development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-11-05 20:49:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

some more cleanup

Browse source
This commit is contained in:
Brendan Forster 2016-12-01 16:08:23 +11:00
parent 35d8090e79
commit 372bd9d9b0
1 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/src/ui/diff/index.tsx
View file

@ -205,13 +205,11 @@ export class Diff extends React.Component<IDiffProps, void> {
private onMouseEnter = (index: number, isHunkSelection: boolean) => {
if (isHunkSelection) {
const hunk = this.props.diff.diffHunkForIndex(index)
if (!hunk) {
console.error('unable to find hunk for given line in diff')
return
}
this.highlightHunk(hunk, true)
} else {
this.highlightLine(index, true)
@ -220,13 +218,11 @@ export class Diff extends React.Component<IDiffProps, void> {
private onMouseLeave = (index: number, isHunkSelection: boolean) => {
if (isHunkSelection) {
const hunk = this.props.diff.diffHunkForIndex(index)
if (!hunk) {
console.error('unable to find hunk for given line in diff')
return
}
this.highlightHunk(hunk, false)
} else {
this.highlightLine(index, false)
@ -234,10 +230,6 @@ export class Diff extends React.Component<IDiffProps, void> {
}
private onMouseDown = (index: number, isHunkSelection: boolean) => {
if (this.props.readOnly) {
return
}
if (!(this.props.file instanceof WorkingDirectoryFileChange)) {
fatalError('must not start selection when selected file is not a WorkingDirectoryFileChange')
return
@ -265,16 +257,13 @@ export class Diff extends React.Component<IDiffProps, void> {
}
private onMouseMove = (index: number, isHunkSelection: boolean) => {
const hunk = this.props.diff.diffHunkForIndex(index)
if (!hunk) {
return
}
if (!this.selection) {
// selection is not active, perform highlighting based on mouse position
if (isHunkSelection) {
this.highlightHunk(hunk, true)
} else {