development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-12 21:01:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix violations

Browse source
This commit is contained in:
Markus Olsson 2016-12-01 14:19:35 +01:00
parent a1d5641787
commit 11d61e6f99
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/ui/diff/code-mirror-host.tsx
View file

@ -68,7 +68,7 @@ export class CodeMirrorHost extends React.Component<ICodeMirrorHostProps, void>
}
}
public shouldComponentUpdate(nextProps: ICodeMirrorHostProps, nextState: void) {
public shouldComponentUpdate(nextProps: ICodeMirrorHostProps) {
// NB This is the only time we actually have to re-render.
// Updating of values is done in componentWillReceiveProps,
// all event handlers are marshalled through private non-changing

2
app/src/ui/history/commit-list-item.tsx
View file

@ -29,7 +29,7 @@ export class CommitListItem extends React.Component<ICommitProps, void> {
)
}
public shouldComponentUpdate(nextProps: ICommitProps, nextState: void): boolean {
public shouldComponentUpdate(nextProps: ICommitProps): boolean {
return (
this.props.commit.sha !== nextProps.commit.sha ||
this.props.avatarURL !== nextProps.avatarURL

2
app/src/ui/octicons/octicon.tsx
View file

@ -40,7 +40,7 @@ export class Octicon extends React.Component<IOcticonProps, void> {
symbol: OcticonSymbol.markGithub,
}
public shouldComponentUpdate(nextProps: IOcticonProps, nextState: void) {
public shouldComponentUpdate(nextProps: IOcticonProps) {
if (nextProps.symbol.w !== this.props.symbol.w ||
nextProps.symbol.h !== this.props.symbol.h ||

2
app/src/ui/repositories-list/repository-list-item.tsx
View file

@ -27,7 +27,7 @@ export class RepositoryListItem extends React.Component<IRepositoryListItemProps
)
}
public shouldComponentUpdate(nextProps: IRepositoryListItemProps, nextState: void): boolean {
public shouldComponentUpdate(nextProps: IRepositoryListItemProps): boolean {
if (nextProps.repository instanceof Repository && this.props.repository instanceof Repository) {
return nextProps.repository.id !== this.props.repository.id
} else {