development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-08-24 02:21:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
41329 commits 765 branches 969 tags 1.3 GiB
Commit graph

41329 commits

This branch
This branch
All branches
Author SHA1 Message Date
flutter-pub-roller-bot 9efe11c6cb
Roll pub packages (#150712) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2024-06-24 22:15:13 +00:00
Parker Lougheed d7af9314b3
Update flutter.dev links from framework to more permanent destinations (#150531) 
The final framework PR contributing to https://github.com/flutter/website/issues/10363.
 2024-06-24 21:36:23 +00:00
Jason Simmons a27d013850
Manual engine roll to be7db94196fe (#150714) 
Includes updates to Gradle lockfiles required by https://github.com/flutter/engine/pull/53280
 2024-06-24 20:19:08 +00:00
Reid Baker 1eb7cd2c73
allow adb to set canfail then use canFail=true for clearing logs (#150517) 
Fixes https://github.com/flutter/flutter/issues/150093

New tests added to cover that we at least pass the arguments we expect to adb. 

The test for #150093  is not ideal in that it does not verify the behavior of a failed process but instead ensures we set the parameter that contains the behavior we want. 

devicelab code and tests are not setup to enable fake process or fake output from stdin/stderr and hang if adb or no hardware are present.
 2024-06-24 19:13:24 +00:00
Reid Baker 7292c94bac
Update android_device.dart to have clearLogs not print to standard error (#150197) 
Even though this does not fix the below issue lets land this anyway as not logging to stderr when clearing logs makes sense to me. 
related https://github.com/flutter/flutter/issues/150093 

The test added is bad. It does not verify the behavior changed. 
To verify the behavior changed correctly I would need to modify the generic device class to have clearLogs be an async function like many of the other calls. That would mean modifying every other device type and their implementations and their tests. Then I would need to update android_device to expose its logger. That is more than I have time for to validate a 2% flake error. 

Feel free to disagree in the comments on this pr.
 2024-06-24 18:38:27 +00:00
Michael Goderbauer fd3f769ec5
Update issue link in analysis_options.yaml (#150395) 2024-06-24 18:31:55 +00:00
Sam Rawlins b9a6ede8ff
Fix a number of broken doc comment references (#150540) 
Work towards https://github.com/flutter/flutter/issues/150562
 2024-06-24 18:26:54 +00:00
Kate Lovett acf1fb644f
Fix flaky sliver tree test (#150707) 
The set of nodes being used in the tree test was not being consistently
reset at the beginning of every test. The tree is currently broken
because today's random seed for test ordering exposed this leak of state
from one test to another.

Fixes https://github.com/flutter/flutter/issues/150706

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-06-24 11:00:53 -07:00
auto-submit[bot] 70e9b4185e
Reverts "Add tests for form_text_field.1.dart (#150481)" (#150696) 
Reverts: flutter/flutter#150481
Initiated by: cbracken
Reason for reverting: Surprisingly, the following test seems to be consistently failing on Windows after the addition of this test:
```
flutter/packages/flutter/test/widgets/sliver_tree_test.dart: .toggleNodeWith, onNodeToggle
```
Original PR Author: ValentinVignal

Reviewed By: {TahaTesser, bleroux}

This change reverts the following previous change:
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/text_form_field/text_form_field.1.dart`
 2024-06-24 12:35:26 +00:00
Valentin Vignal 27b961673a
Add tests for form_text_field.1.dart (#150481) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/text_form_field/text_form_field.1.dart`
 2024-06-24 06:16:13 +00:00
Matt Carroll 1cb003b8fb
Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves #148291) (#150661) 
Unsets a global `client` variable that was missed.
 2024-06-22 16:41:39 -07:00
Tong Mu 88e6f62974
[CupertinoActionSheet] Fix the layout (part 1) (#149636) 
This PR fixes the general layout of `CupertinoActionSheet` to match the native behavior.

This PR adjusts the height of buttons, the height of the content section, the gap between the cancel button and the main sheet, and most importantly, the maximum height of the action sheet.

The maximum height is the trickiest part. I tried to figure out a rule, and found that the top padding only depends the type of the device - notch-less, notch, capsule - but there isn't a clear rule that can unify the 3 padding numbers. This PR uses linear interpolation as a heuristic algorithm. See the in-code comment for details. 
* What about iPad? Well, action sheets look completely different on iPad, more similar to a drop down menu. This might be fixed in the future.

### Tests

Among all the test changes, there are a few tests that have been converted to using `AnimationSheetRecorder` to verify the animation changes. Before the PR they were checking the height at each from, which is hard to reason whether a change makes sense, and hard to modify if anything needs changing.

### Result demo

The following images compares native(left) with Flutter after PR (right) by stacking them closely, and show that their layout really match almost pixel perfect.

<img width="455" alt="image" src="https://github.com/flutter/flutter/assets/1596656/f8be35bd-0da5-4908-92f7-7a1f4e999229">

_No notch (iPhone 13)_

<img width="405" alt="image" src="https://github.com/flutter/flutter/assets/1596656/54a37c2f-cd99-4e3b-86f0-045b1dfdbbb8">

_Notch (iPhone 13)_

<img width="385" alt="image" src="https://github.com/flutter/flutter/assets/1596656/546ab529-0b62-4e3d-9019-ef900d3552e5">

_Capsule (iPhone 15 Plus)_

<img width="1142" alt="image" src="https://github.com/flutter/flutter/assets/1596656/e06b6dac-dbcd-48f7-9dee-83700ae680e0">

_iPhone 13 landscape_

<img width="999" alt="image" src="https://github.com/flutter/flutter/assets/1596656/698cf530-51fc-4906-90a5-7a3ab626f489">

_All "capsule" devices share the same top padding in logical pixels (iPhone 15 Pro Max, iPhone 15 Pro, iPhone 15 Plus)_
 2024-06-22 17:24:39 +00:00
Gray Mackall 4a84fb0fea
Remove discontinued device_info and connectivity plugins from flutter_gallery, roll pub packages (#150585) 
Removes these two discontinued plugins from `dev/integration_tests/flutter_gallery`

[`device_info`](https://pub.dev/packages/device_info):
Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README.

[`connectivity`](https://pub.dev/packages/connectivity):
This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin.

Unblocks the re-land of https://github.com/flutter/engine/pull/53462 (itself a reland 🙂), because of https://github.com/flutter/flutter/pull/150465#issuecomment-2181403712.
 2024-06-21 23:10:24 +00:00
hangyu d4cffa2540
[a11y] Update semantics in bottom_navigation_bar.dart (#150576) 
issue: https://github.com/flutter/flutter/issues/117997

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-06-21 14:48:41 -07:00
engine-flutter-autoroll 9988510e34
Roll Flutter Engine from dda82d905f37 to 33415c6ee7c2 (7 revisions) (#150637) 
dda82d905f...33415c6ee7

2024-06-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 4483d67ba725 to fc1e5912fc94 (1 revision) (flutter/engine#53503)
2024-06-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix focus management for text fields (#51009)" (flutter/engine#53502)
2024-06-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 19d3e659f49a to 4483d67ba725 (2 revisions) (flutter/engine#53501)
2024-06-20 mdebbar@google.com [web] Add 'flt-semantics-identifier' attribute to semantics nodes (flutter/engine#53278)
2024-06-20 mdebbar@google.com [web] Don't add `href="#"` to semantics links (flutter/engine#53395)
2024-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from be6b533e07e7 to 19d3e659f49a (1 revision) (flutter/engine#53495)
2024-06-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tD5pof7jVnbXPwP7l... to iU-B6rJxy0wUYSmmp... (flutter/engine#53493)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from tD5pof7jVnbX to iU-B6rJxy0wU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-21 20:53:08 +00:00
Tong Mu 123e33b87c
Reland 4: [CupertinoActionSheet] Match colors to native (#150442) 
Relands https://github.com/flutter/flutter/pull/149568 (first attempt) or https://github.com/flutter/flutter/pull/150386 (latest attempt), which was reverted in https://github.com/flutter/flutter/pull/150413 due to a one-pixel difference on the debug banner (in the tilted border of the rotated text).

This attempt removed the debug banner from tests (see 31cbcb1dc6).

<img width="949" alt="image" src="https://github.com/flutter/flutter/assets/1596656/78f26f72-b69f-41ee-9134-2e2a9e8e1bdd">
 2024-06-21 20:41:10 +00:00
Renzo Olivares 20459dda0d
Enable SelectionArea double tap/triple tap gesture support for mobile platforms (#149295) 
This change enables double tap / triple tap support in SelectionArea for mobile platforms:
Android / Fuchsia: 
- On native, these platforms allow for double tap / double tap + drag to select word-by-word.
- On web using touch, these platforms only support double tap to select word.
- On web and native using a mouse, these platforms support double click / double click + drag to select word-by-word, and triple click / triple click + drag to select paragraph-by-paragraph.

iOS:
- On native, these platforms allow for double tap / double tap + drag to select word-by-word.
- On web using touch, these platforms do not support double tap/triple tap gestures.
- On web using touch, these platforms allow support double tap + drag gestures.
- On web and native using a mouse, these platforms support double click / double click + drag to select word-by-word, and triple click / triple click + drag to select paragraph-by-paragraph.

Part of: https://github.com/flutter/flutter/issues/129583
 2024-06-21 18:47:20 +00:00
Limane Gaya 9056c0b192
made SelectionArea alignment consistent between web and other platform (#150037) 
Currently, when text is placed inside a SelectionArea widget that's nested within a Column widget, it results in misalignment, causing the text to appear centered instead of aligned as intended.

This was originally #149552 but had issues with my branch.

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Fixes #148934 
Fixes #121053 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
 2024-06-21 16:41:14 +00:00
Moritz a3f6a2bdc7
Fix link hook typo (#150194) 
Fixes a typo in the link hook implementation.

cc @dcharkes
 2024-06-21 14:25:56 +00:00
Sigurd Meldgaard 16e7adedd4
Stop looking for .packages when analyzing (#150349) 
Not sure exactly what this was supposed to do, but pub no longer writes
".packages" and has not done since:
https://github.com/dart-lang/pub/pull/3413. So this check would never
find a '.packages'.

Not sure if this code was doing anything useful - but it does not seem
to have been missed for a couple of years.

This is a warm-up for: https://github.com/flutter/flutter/issues/150196

It was added in https://github.com/flutter/flutter/pull/6093 seemingly
without tests of this functionality.
 2024-06-21 10:29:27 +02:00
Parker Lougheed c63339866d
Update flutter.dev links from misc packages to more permanent destinations (#150532) 
Contributes to https://github.com/flutter/website/issues/10363
 2024-06-20 23:09:08 +00:00
engine-flutter-autoroll b0953649c9
Roll Flutter Engine from dd37cefd4a94 to dda82d905f37 (9 revisions) (#150582) 
dd37cefd4a...dda82d905f

2024-06-20 tarrinneal@gmail.com Update StandardMessageCodec.readValue to be @Nullable (flutter/engine#53473)
2024-06-20 bruno.leroux@gmail.com [Web] Fix extra new line when inputAction is not newline for a multil… (flutter/engine#53453)
2024-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 366eb1b4b308 to be6b533e07e7 (1 revision) (flutter/engine#53492)
2024-06-20 tugorez@users.noreply.github.com Fix focus management for text fields (flutter/engine#51009)
2024-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from cbd933e707e7 to 366eb1b4b308 (1 revision) (flutter/engine#53487)
2024-06-20 skia-flutter-autoroll@skia.org Roll Skia from 17626ca22729 to 4471ee07e223 (1 revision) (flutter/engine#53486)
2024-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from e403519a4436 to cbd933e707e7 (1 revision) (flutter/engine#53485)
2024-06-20 skia-flutter-autoroll@skia.org Roll Skia from 4acebac47ea5 to 17626ca22729 (1 revision) (flutter/engine#53484)
2024-06-20 skia-flutter-autoroll@skia.org Roll Skia from 199e1a49b091 to 4acebac47ea5 (1 revision) (flutter/engine#53482)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-20 22:04:24 +00:00
Qun Cheng 0f827d7450
Update Material token to the latest 4.1.0 (#150382) 
This PR is to update material tokens to the latest version 4.1.0, which:
* deprecates two tokens in `Slider`
* doesn't impact the material widgets' defaults
 2024-06-20 20:39:58 +00:00
Gray Mackall 0e2f3d7226
Let the lockfile script generate lockfiles for kotlin gradle files as well (#150471) 
Fixes https://github.com/flutter/flutter/issues/150468.
 2024-06-20 20:22:18 +00:00
Bruno Leroux 4b0c8414fc
Make popup menu hardcoded padding configurable (#150506) 
## Description

This PR exposed `PopupMenuButton.menuPadding` parameter to override the hardcoded value.

Credits to @Moluram for the original PR https://github.com/flutter/flutter/pull/81996.
And to @arafaysaleem for the update in https://github.com/flutter/flutter/pull/96657.

https://github.com/flutter/flutter/pull/96657 was reverted due to a Google testing failure. `PopupMenuButton` implementation has evolved since that time so maybe we will not hit this Google testing failure. And if we do, we will try to figure out what is going on.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/143512.
Fixes https://github.com/flutter/flutter/issues/57110

## Tests

Adds 2 tests, updates several tests.
 2024-06-20 19:18:21 +00:00
Christopher Fujino 80a65bd781
[flutter_tools] un-hide the --dds flag (#150280) 
Fixes https://github.com/flutter/flutter/issues/94548
 2024-06-20 18:25:10 +00:00
davidhicks980 c2c183387e
[material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (#149586) 
`_MenuAnchorState` now removes itself from its parent regardless of whether `_MenuAnchorState._isOpen` is true.

Before, _MenuAnchorState would only detach itself when `_MenuAnchorState._isOpen == true`. This led to _MenuAnchorState being retained until an anchor's parent was disposed.

Before:

https://github.com/flutter/flutter/assets/59215665/48f1617a-a3d0-49ab-a767-f41e3a30ea41

After:

https://github.com/flutter/flutter/assets/59215665/31312bb6-49ec-4083-b8de-e9ae2a42a8b3

Fixes https://github.com/flutter/flutter/issues/149584

I was a bit unsure what the best way of testing this change would be, and wanted feedback from the Flutter team. Is there a way for us to view at the instance count of `_MenuAnchorState`, or expose `_MenuAnchorState._anchorChildren.length` for testing?

- [] I added new tests to check the change I am making, or this PR is [test-exempt].
 2024-06-20 18:10:05 +00:00
Valentin Vignal b3dc24ccc6
Add test for inherited_notifier.0.dart (#150344) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/widgets/inherited_notifier/inherited_notifier.0.dart`
 2024-06-20 17:55:07 +00:00
Andrew Kolos 8e4f704abc
[CLI tool] in flutter test, consider --flavor when validating the cached asset bundle (#150461) 
Fixes https://github.com/flutter/flutter/issues/150296

**Context.** `flutter test` has its own code path for writing flutter app [assets](https://docs.flutter.dev/ui/assets/assets-and-images). https://github.com/flutter/flutter/pull/132985 introduced [flavor-conditional asset bundling ](https://docs.flutter.dev/deployment/flavors#conditionally-bundling-assets-based-on-flavor), which lets users control which assets get bundled based on `--flavor`. `--flavor` is supported in `flutter test`.

**Bug and fix.** `--flavor` isn't considered when deciding whether we need to rebuild this asset bundle:

5e448f4ce5/packages/flutter_tools/lib/src/commands/test.dart (L709)

This PR address this by writing the value of `--flavor` to a file in the build directory and checking that when validating the cached asset bundle.
 2024-06-20 17:45:09 +00:00
derdilla 0674f46e9f
Test InputDecoration API examples (#148560) 
Add tests for `InputDecoration` API example as part of #130459. Updates examples that use the deprecated MaterialState to use WidgetState. Tests files: `input_decoration.0.dart`, `input_decoration.1.dart`, `input_decoration.2.dart`, `input_decoration.3.dart`, `input_decoration.widget_state.0.dart`, `input_decoration.widget_state.1.dart`, `input_decoration.prefix_icon_constraints.0.dart`, `input_decoration.suffix_icon_constraints.0.dart`, and `input_decoration.label.0.dart`
 2024-06-20 16:02:07 +00:00
Polina Cherkasova bfdcb51643
Clean leaky tests. (#150335) 2024-06-20 06:44:11 -07:00
engine-flutter-autoroll 64dd1ca9bc
Roll Flutter Engine from f9c497f178d3 to dd37cefd4a94 (2 revisions) (#150537) 
f9c497f178...dd37cefd4a

2024-06-20 skia-flutter-autoroll@skia.org Roll Skia from 79a7acc34939 to 199e1a49b091 (1 revision) (flutter/engine#53481)
2024-06-19 jonahwilliams@google.com [Impeller] Compute correct-ish binding order for Vulkan. (flutter/engine#53463)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-20 04:51:26 +00:00
engine-flutter-autoroll c631d0855b
Roll Flutter Engine from a31279381b40 to f9c497f178d3 (9 revisions) (#150528) 
a31279381b...f9c497f178

2024-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from u8WOst9tlXsVQ02eJ... to tD5pof7jVnbXPwP7l... (flutter/engine#53480)
2024-06-19 skia-flutter-autoroll@skia.org Roll Skia from 8de98f3939d1 to 79a7acc34939 (1 revision) (flutter/engine#53478)
2024-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 604f590c5308 to e403519a4436 (2 revisions) (flutter/engine#53477)
2024-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from cf0d430bc6a5 to 604f590c5308 (1 revision) (flutter/engine#53475)
2024-06-19 skia-flutter-autoroll@skia.org Roll Skia from a732ecc66691 to 8de98f3939d1 (1 revision) (flutter/engine#53474)
2024-06-19 skia-flutter-autoroll@skia.org Roll Skia from 0a35f4531a56 to a732ecc66691 (1 revision) (flutter/engine#53472)
2024-06-19 skia-flutter-autoroll@skia.org Roll Skia from ad94fabf7400 to 0a35f4531a56 (1 revision) (flutter/engine#53471)
2024-06-19 skia-flutter-autoroll@skia.org Roll Skia from 24a4123fc949 to ad94fabf7400 (1 revision) (flutter/engine#53470)
2024-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1f97ab20d078 to cf0d430bc6a5 (1 revision) (flutter/engine#53469)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from u8WOst9tlXsV to tD5pof7jVnbX

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-20 00:29:41 +00:00
Valentin Vignal 71ac7f55b3
Add tests for about_list_tile.0.dart (#150181) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/about/about_list_tile.0.dart`
 2024-06-19 07:40:31 +00:00
engine-flutter-autoroll f11d3689ef
Roll Flutter Engine from 0ad18fe4c0b5 to a31279381b40 (7 revisions) (#150473) 
0ad18fe4c0...a31279381b

2024-06-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "Upgrade all[most] androidx dependencies to latest" (#53462)" (flutter/engine#53468)
2024-06-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f1642cd8bed to 1f97ab20d078 (1 revision) (flutter/engine#53465)
2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from f0bab26f6818 to 24a4123fc949 (2 revisions) (flutter/engine#53464)
2024-06-18 34871572+gmackall@users.noreply.github.com Reland "Upgrade all[most] androidx dependencies to latest" (flutter/engine#53462)
2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from 1675eeabb289 to f0bab26f6818 (2 revisions) (flutter/engine#53459)
2024-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TwoeJy5Tn0ARHF5O4... to u8WOst9tlXsVQ02eJ... (flutter/engine#53461)
2024-06-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7245875f5191 to 7f1642cd8bed (1 revision) (flutter/engine#53460)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TwoeJy5Tn0AR to u8WOst9tlXsV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-19 03:26:23 +00:00
hangyu 835ff2045c
Revert "[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items" (#150445) 
Reverts flutter/flutter#149375
Because it failed a g3 integration testing. b/347867286
 2024-06-18 15:58:10 -07:00
dependabot[bot] 5a5f6e7666
Bump peter-evans/create-pull-request from 6.0.5 to 6.1.0 (#150456) 
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.0.5 to 6.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v6.1.0</h2>
<p>✨ Adds <code>pull-request-branch</code> as an action output.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump undici from 6.14.1 to 6.15.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2873">peter-evans/create-pull-request#2873</a></li>
<li>Update distribution by <a href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2878">peter-evans/create-pull-request#2878</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.31 to 18.19.32 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2884">peter-evans/create-pull-request#2884</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.32 to 18.19.33 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2890">peter-evans/create-pull-request#2890</a></li>
<li>build(deps-dev): bump ts-jest from 29.1.2 to 29.1.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2892">peter-evans/create-pull-request#2892</a></li>
<li>build(deps): bump undici from 6.15.0 to 6.18.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2891">peter-evans/create-pull-request#2891</a></li>
<li>Update distribution by <a href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2907">peter-evans/create-pull-request#2907</a></li>
<li>build(deps): bump undici from 6.18.0 to 6.18.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2913">peter-evans/create-pull-request#2913</a></li>
<li>build(deps-dev): bump ts-jest from 29.1.3 to 29.1.4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2914">peter-evans/create-pull-request#2914</a></li>
<li>Update distribution by <a href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2921">peter-evans/create-pull-request#2921</a></li>
<li>build(deps): bump undici from 6.18.1 to 6.18.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2934">peter-evans/create-pull-request#2934</a></li>
<li>build(deps-dev): bump prettier from 3.2.5 to 3.3.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2936">peter-evans/create-pull-request#2936</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.33 to 18.19.34 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2935">peter-evans/create-pull-request#2935</a></li>
<li>Update distribution by <a href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2947">peter-evans/create-pull-request#2947</a></li>
<li>build(deps-dev): bump prettier from 3.3.0 to 3.3.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2959">peter-evans/create-pull-request#2959</a></li>
<li>build(deps-dev): bump braces from 3.0.2 to 3.0.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2962">peter-evans/create-pull-request#2962</a></li>
<li>build(deps-dev): bump ws from 8.11.0 to 8.17.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2970">peter-evans/create-pull-request#2970</a></li>
<li>build(deps-dev): bump ts-jest from 29.1.4 to 29.1.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2975">peter-evans/create-pull-request#2975</a></li>
<li>build(deps-dev): bump <code>@​types/node</code> from 18.19.34 to 18.19.36 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2976">peter-evans/create-pull-request#2976</a></li>
<li>build(deps): bump undici from 6.18.2 to 6.19.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2977">peter-evans/create-pull-request#2977</a></li>
<li>Update distribution by <a href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2990">peter-evans/create-pull-request#2990</a></li>
<li>feat: add branch name output by <a href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2995">peter-evans/create-pull-request#2995</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v6.0.5...v6.1.0">https://github.com/peter-evans/create-pull-request/compare/v6.0.5...v6.1.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c5a7806660"><code>c5a7806</code></a> feat: add branch name output (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2995">#2995</a>)</li>
<li><a href="4383ba9ef0"><code>4383ba9</code></a> build: update distribution (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2990">#2990</a>)</li>
<li><a href="36f7648874"><code>36f7648</code></a> build(deps): bump undici from 6.18.2 to 6.19.2 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2977">#2977</a>)</li>
<li><a href="5f7c1586fd"><code>5f7c158</code></a> build(deps-dev): bump <code>@​types/node</code> from 18.19.34 to 18.19.36 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2976">#2976</a>)</li>
<li><a href="db1713da3a"><code>db1713d</code></a> build(deps-dev): bump ts-jest from 29.1.4 to 29.1.5 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2975">#2975</a>)</li>
<li><a href="ca98a71ccc"><code>ca98a71</code></a> build(deps-dev): bump ws from 8.11.0 to 8.17.1 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2970">#2970</a>)</li>
<li><a href="ce008085c8"><code>ce00808</code></a> build(deps-dev): bump braces from 3.0.2 to 3.0.3 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2962">#2962</a>)</li>
<li><a href="7318c0b7b6"><code>7318c0b</code></a> build(deps-dev): bump prettier from 3.3.0 to 3.3.2 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2959">#2959</a>)</li>
<li><a href="e30bbbb3c9"><code>e30bbbb</code></a> build: update distribution (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2947">#2947</a>)</li>
<li><a href="bad19b8e0b"><code>bad19b8</code></a> build(deps-dev): bump <code>@​types/node</code> from 18.19.33 to 18.19.34 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2935">#2935</a>)</li>
<li>Additional commits viewable in <a href="6d6857d369...c5a7806660">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=6.0.5&new-version=6.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-06-18 22:17:09 +00:00
Jacob MacDonald 9bfac23825
Remove duplicate testOutputsDirectory definition from integration_test package (#150224) 
I noticed a getter by this name with the same implementation already exists in flutter_driver, with the same implementation as the initializer for this variable. This deletes the variable and instead exports the getter.

Note that technically this could be breaking, because this version is a mutable variable instead of just a getter. But, I think this was just a mistake.
 2024-06-18 22:11:05 +00:00
Gray Mackall b98d48549c
Make flutter tool enforce >= kotlin 1.7.0, Gradle 7.0.2, and AGP 7.0.0, and Fix test failures blocking androidx upgrade (#149204) 
PR to pave the way for https://github.com/flutter/engine/pull/53001 to re-land

Summary: 
- Enforces use of Kotlin >= `1.7.0` (please see below note)
- Fixes ci failures that prevented the above PR from landing.

Details:

Because it landed initially, we are able to fake the roll in this PR to fix all the tests ([see my comment](https://github.com/flutter/flutter/pull/149204#discussion_r1617924772)).

Fixes all the tests that failed:
1. `module_test` failing on multiple platforms (3/9 of the failures). 
Failure is 
```
> Android resource linking failed
   ERROR:/b/s/w/ir/x/t/flutter_module_test.KECMXW/hello/.android/plugins_build_output/device_info/intermediates/merged_res/release/values/values.xml:194: AAPT: error: resource android:attr/lStar not found.
```

This is a rather unhelpful error message but some [folks online suggest](https://stackoverflow.com/a/69050529) that upgrading your `compileSdk` version fixes this.
These resolve when I remove the dependency on the long discontinued [package_info](https://pub.dev/packages/package_info) and [device_info](https://pub.dev/packages/device_info) packages, perhaps because they are transitively pulling in low `compileSdk` versions? This is unclear to me.

2. `module_custom_host_app_name_test` was failing for the same reason (another 3/9, or cumulative 6/9).
3. `tool_integration_tests_3_4` was a flake 🙂 (7/9)
4. `framework_tests_slow` needed a newer version of the Kotlin Gradle plugin (the flutter tool tells us this, so I just upgraded as suggested) and it resolved (8/9)
5.`android_preview_tool_integration_tests` needed newer AGP and KGP versions. I also refactored the tests, and bumped our error versions, fixing https://github.com/flutter/flutter/issues/142653.

**Note that the bump to KGP is not in line with our policy** - we didn't warn for `1.5.0-1.6.x` for a release (or at all) before dropping support. But I think it might still be justified:
- The bump to our androidx libraries unblocks ongoing Scribe work, and also includes a fix for a [memory leak](https://github.com/flutter/flutter/issues/129307#issuecomment-1601636959) and a [crash on folding phones](https://github.com/flutter/flutter/issues/114868#issuecomment-2133226962), among many other bug fixes.
- Gradle [doesn't test on half of that range](https://docs.gradle.org/current/userguide/compatibility.html#kotlin), and so we implicitly can't claim to support it either. More generally, our Java and Kotlin support ranges should probably strictly fall within what Gradle tests.
 2024-06-18 20:24:09 +00:00
engine-flutter-autoroll 948d8122be
Roll Flutter Engine from 74f42ca3544c to 0ad18fe4c0b5 (2 revisions) (#150447) 
74f42ca354...0ad18fe4c0

2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from 6d541b4dddd0 to 1675eeabb289 (4 revisions) (flutter/engine#53455)
2024-06-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 863f4d04575c to 7245875f5191 (3 revisions) (flutter/engine#53454)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-18 19:10:12 +00:00
Hasan M. Hallak f54dfcd27d
add forceErrorText to FormField & TextFormField. (#132903) 
Introducing the `forceErrorText` property to both `FormField` and `TextFormField`. With this addition, we gain the capability to trigger an error state and provide an error message without invoking the `validator` method.

While the idea of making the `Validator` method work asynchronously may be appealing, it could introduce significant complexity to our current form field implementation. Additionally, this approach might not be suitable for all developers, as discussed by @justinmc  in this [comment](https://github.com/flutter/flutter/issues/56414#issuecomment-624960263).

This PR try to address this issue by adding `forceErrorText` property allowing us to force the error to the `FormField` or `TextFormField` at our own base making it possible to preform some async operations without the need for any hacks while keep the ability to check for errors if we call `formKey.currentState!.validate()`.

Here is an example:

<details> <summary>Code Example</summary>  

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(
    const MaterialApp(home: MyHomePage()),
  );
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({
    super.key,
  });

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final key = GlobalKey<FormState>();
  String? forcedErrorText;

  Future<void> handleValidation() async {
    // simulate some async work..
    await Future.delayed(const Duration(seconds: 3));

    setState(() {
      forcedErrorText = 'this username is not available.';
    });

    // wait for build to run and then check.
    //
    // this is not required though, as the error would already be showing.
    WidgetsBinding.instance.addPostFrameCallback((_) {
      print(key.currentState!.validate());
    });
  }

  @override
  Widget build(BuildContext context) {
    print('build');
    return Scaffold(
      floatingActionButton: FloatingActionButton(onPressed: handleValidation),
      body: Form(
        key: key,
        child: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: [
              Padding(
                padding: const EdgeInsets.symmetric(horizontal: 30),
                child: TextFormField(
                  forceErrorText: forcedErrorText,
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}
```
</details>

Related to #9688 & #56414.

Happy to hear your thoughts on this.
 2024-06-18 17:52:21 +00:00
Jenn Magder 6c06abbb55
Add test for engine artifact framework permissions (#148786) 
Framework test to validate the iOS and macOS framework engine artifacts (Flutter.framework and FlutterMacOS.framework) have read and executable permissions.

~~Will fail until https://github.com/flutter/engine/pull/52961 rolls.~~ <-- it rolled https://github.com/flutter/flutter/pull/148819
 2024-06-18 17:07:21 +00:00
Valentin Vignal f2c48afbb1
Add test for icon_button.3.dart (#149988) 
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/icon_button/icon_button.3.dart`
 2024-06-18 15:03:59 +00:00
engine-flutter-autoroll b44c67e2e8
Roll Flutter Engine from 78fdd06af541 to 74f42ca3544c (6 revisions) (#150421) 
78fdd06af5...74f42ca354

2024-06-18 flar@google.com [DisplayList] delete obsolete PathEffect sources (flutter/engine#53441)
2024-06-18 dacoharkes@google.com Setup `NativeAssetsApi` during isolate group creation (flutter/engine#53329)
2024-06-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 (flutter/engine#53445)
2024-06-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.8 to 3.25.10 (flutter/engine#53446)
2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from f18547e60ed8 to 6d541b4dddd0 (1 revision) (flutter/engine#53444)
2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from 2db8813a349d to f18547e60ed8 (1 revision) (flutter/engine#53442)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-18 12:56:38 +00:00
Taha Tesser 33599006e7
Fix transparent dividerColor breaks TabBar.tabAlignment (#150350) 
fixes [`TabBar.tabAlignment` property does't work when `dividerColor` is transparent](https://github.com/flutter/flutter/issues/150316)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: DefaultTabController(
        length: 2,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('TabBar'),
            bottom: const TabBar(
              dividerColor: Colors.transparent,
              tabAlignment: TabAlignment.start,
              isScrollable: true,
              tabs: <Widget>[
                Tab(text: 'TAB 1'),
                Tab(text: 'TAB 2'),
              ],
            ),
          ),
          body: const TabBarView(
            children: <Widget>[
              SizedBox.expand(),
              SizedBox.expand(),
            ],
          ),
          floatingActionButton: FloatingActionButton(
            onPressed: () {},
            child: const Icon(Icons.add),
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before (`dividerColor: Colors.transparent`, `tabAlignment: TabAlignment.start`)

![Screenshot 2024-06-17 at 15 44 33](https://github.com/flutter/flutter/assets/48603081/a60e88c7-fd99-4444-b7e5-1bceacc22f4c)

### After (`dividerColor: Colors.transparent`, `tabAlignment: TabAlignment.start`)

![Screenshot 2024-06-17 at 15 44 55](https://github.com/flutter/flutter/assets/48603081/aa003d65-107f-4618-be29-095ab2660374)
 2024-06-18 12:05:05 +00:00
Taha Tesser a9f554ac39
Fix scrollable TabBar jittering (#150041) 
fixes [TabBar with isScrollable set to true is broken](https://github.com/flutter/flutter/issues/150000)

This regressed due to a tiny mistake in https://github.com/flutter/flutter/pull/146293

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'dart:ui';

import 'package:flutter/material.dart';

/// Flutter code sample for [TabBar].

void main() => runApp(const TabBarApp());

class TabBarApp extends StatelessWidget {
  const TabBarApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: TabBarExample(),
    );
  }
}

class TabBarExample extends StatelessWidget {
  const TabBarExample({super.key});

  @override
  Widget build(BuildContext context) {
    final List<Tab> tabs =
        List<Tab>.generate(20, (int index) => Tab(text: 'Tab $index'));

    return ScrollConfiguration(
      behavior: ScrollConfiguration.of(context)
          .copyWith(dragDevices: <PointerDeviceKind>{
        PointerDeviceKind.touch,
        PointerDeviceKind.mouse,
      }),
      child: DefaultTabController(
        length: tabs.length,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('TabBar Sample'),
            bottom: TabBar(
              isScrollable: true,
              tabs: tabs,
              tabAlignment: TabAlignment.start,
            ),
          ),
          body: TabBarView(
            children: <Widget>[
              for (int i = 0; i < tabs.length; i++)
                Center(
                  child: Text('Page $i'),
                ),
            ],
          ),
        ),
      ),
    );
  }
}

```

</details>

### Before

https://github.com/flutter/flutter/assets/48603081/b7aa98a2-a6a5-431e-8327-859a11efa129

### After

https://github.com/flutter/flutter/assets/48603081/0435719f-03d4-4d76-8b5a-532894fcf4a3
 2024-06-18 08:30:21 +00:00
auto-submit[bot] 639910720c
Reverts "Reland 3: [CupertinoActionSheet] Match colors to native (#150386)" (#150413) 
Reverts: flutter/flutter#150386
Initiated by: andrewkolos
Reason for reverting: the Mac framework_tests_impeller check has been failing (due to golden test failures) since this PR (though it occasionally passes after retry). Taking a brief look at this PR, it looks like there's been some troubles with goldens in the past (though the recent failures appear very different to past ones). Regardless, I'm taking a shot at getting the tree green again by reverting this. Apologies i
Original PR Author: dkwingsmt

Reviewed By: {chunhtai}

This change reverts the following previous change:
Relands https://github.com/flutter/flutter/pull/149568 (first attempt) or https://github.com/flutter/flutter/pull/150129 (latest attempt), which was reverted in https://github.com/flutter/flutter/pull/150142 due to unverified golden tests post-commit from recent infra issues.

No code is changed from https://github.com/flutter/flutter/pull/150129.

The relevant golden files have been resubmitted in https://github.com/flutter/flutter/pull/150219. I expect these files to appear in the golden file checker in this PR (which will hint that this PR is safe.) Fingers crossed.
 2024-06-18 07:22:18 +00:00
Jason Simmons 6ef91167f0
Extend the Windows web_tool_tests_1_2 shard timeout to 45 minutes (#150393) 
This suite typically takes almost 30 minutes on CI, and some recent
engine->framework rolls failed because the tests exceeded the current 30
minute timeout.
 2024-06-17 23:44:01 -07:00
engine-flutter-autoroll 6a8f70f11e
Roll Flutter Engine from 1c4e5e230ecb to 78fdd06af541 (3 revisions) (#150403) 
1c4e5e230e...78fdd06af5

2024-06-18 chinmaygarde@google.com [Impeller] Update iOS CPU profiling instructions. (flutter/engine#53440)
2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from 2b9bc16df969 to 2db8813a349d (4 revisions) (flutter/engine#53438)
2024-06-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 51bbba0da7d3 to 863f4d04575c (1 revision) (flutter/engine#53436)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-18 04:12:10 +00:00
engine-flutter-autoroll fb067b9948
Roll Flutter Engine from a4f266f7eb1a to 1c4e5e230ecb (8 revisions) (#150399) 
a4f266f7eb...1c4e5e230e

2024-06-17 flar@google.com [DisplayList] Create DrawDashedLine for paragraph code (flutter/engine#53411)
2024-06-17 chinmaygarde@google.com [Impeller] Update Android CPU profiling instructions. (flutter/engine#53437)
2024-06-17 jonahwilliams@google.com [Impeller] move draw vertices to dl unittests. (flutter/engine#53400)
2024-06-17 chinmaygarde@google.com [Impeller] Link CPU profiling docs from the main README. (flutter/engine#53435)
2024-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 1ce6b4d54247 to 51bbba0da7d3 (1 revision) (flutter/engine#53432)
2024-06-17 jonahwilliams@google.com [Impeller] Move drawAtlas golden tests to display list. (flutter/engine#53398)
2024-06-17 fmil@google.com [flatland] Handle fence overflow in flatland_connection.cc (flutter/engine#53366)
2024-06-17 skia-flutter-autoroll@skia.org Roll Skia from 0dda1054f543 to 2b9bc16df969 (1 revision) (flutter/engine#53431)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-18 01:41:41 +00:00