development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-06-30 23:54:38 +00:00
Code Issues Projects Releases Wiki Activity

Remove duplicate testOutputsDirectory definition from integration_test package (#150224)

Browse Source 
I noticed a getter by this name with the same implementation already exists in flutter_driver, with the same implementation as the initializer for this variable. This deletes the variable and instead exports the getter.

Note that technically this could be breaking, because this version is a mutable variable instead of just a getter. But, I think this was just a mistake.
This commit is contained in:
Jacob MacDonald 2024-06-18 15:11:05 -07:00 committed by GitHub
parent b98d48549c
commit 9bfac23825
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/integration_test/lib/integration_test_driver.dart
View File

@ -14,13 +14,7 @@ import 'package:path/path.dart' as path;
import 'common.dart';
/// Flutter Driver test output directory.
///
/// Tests should write any output files to this directory. Defaults to the path
/// set in the FLUTTER_TEST_OUTPUTS_DIR environment variable, or `build` if
/// unset.
String testOutputsDirectory =
Platform.environment['FLUTTER_TEST_OUTPUTS_DIR'] ?? 'build';
export 'package:flutter_driver/flutter_driver.dart' show testOutputsDirectory;
/// The callback type to handle [Response.data] after the test
/// succeeds.

8
packages/integration_test/lib/integration_test_driver_extended.dart
View File

@ -14,13 +14,7 @@ import 'package:path/path.dart' as path;
import 'common.dart';
/// Flutter Driver test output directory.
///
/// Tests should write any output files to this directory. Defaults to the path
/// set in the FLUTTER_TEST_OUTPUTS_DIR environment variable, or `build` if
/// unset.
String testOutputsDirectory =
Platform.environment['FLUTTER_TEST_OUTPUTS_DIR'] ?? 'build';
export 'package:flutter_driver/flutter_driver.dart' show testOutputsDirectory;
/// The callback type to handle [Response.data] after the test
/// succeeds.