Commit graph

2687 commits

Author SHA1 Message Date
Katarina Behrens 20b34d00c9 Make clang-tidy happier 2020-12-13 21:31:14 +00:00
Thorsten Behrens 62a4c63fd3 Conditionalize code to Poppler signing feature flag 2020-12-13 21:31:14 +00:00
Thorsten Behrens f37de4feb4 Set some signature reason - might want some UI later 2020-12-13 21:31:14 +00:00
Thorsten Behrens 71795917de Add configurable CertDB path 2020-12-13 21:31:14 +00:00
Thorsten Behrens 3eedb21a83 Consistenly use CERT nick to refer to signing key 2020-12-13 21:31:14 +00:00
Thorsten Behrens 981c597376 Fix overwriting pdf after signing
- make explicit we're using static QFile func here
- QFile::rename doesn't work across filesystems, so instead
  create it alongside. Might fail if dir is not writeable
- can't use QSaveFile, since poppler sign() func wants a filename
2020-12-13 21:31:14 +00:00
Thorsten Behrens f7d6045b92 Add poppler NSS support
Move certificate config down into generator code
Read available signing certificates from poppler NSS
2020-12-13 21:31:14 +00:00
Thorsten Behrens b96dac6df3 Add certificate store for access to NSS keys
WIP - add interfaces and methods to get access to NSS-via-poppler
sign certificates, and provide them for signing documents.
2020-12-13 21:31:14 +00:00
Thorsten Behrens e031822744 Adapt to poppler sign api change
Now poppler offers signing via PDFConverter class. Add some error
handling, and store signature in temp file. Document gets reloaded
after replacing original file.
2020-12-13 21:31:14 +00:00
Thorsten Behrens e3e582ee5c Add feature flag for poppler signing API
Test and conditionally-compile pdf signing feature, depending
on poppler new-ness.
2020-12-13 21:31:14 +00:00
Katarina Behrens 5db7421851 Get certificate CN and password and pass it to poppler 2020-12-13 21:31:14 +00:00
Katarina Behrens cc908b9f92 Pass pointer to widget annotation just added down the chain 2020-12-13 21:31:14 +00:00
Katarina Behrens d320fa17ad Stub some iface for signing the document 2020-12-13 21:31:14 +00:00
Albert Astals Cid 35590a273d Fix CI
Laurent please use MR like everyone else does, otherwise you break the
build for the rest of us.

CCMAIL: montel@kde.org
2020-12-13 21:59:08 +01:00
Laurent Montel dd1938755e Don't include QtTest as it includes all QtCore includes 2020-12-13 17:51:28 +01:00
Albert Astals Cid 8176613076 Merge remote-tracking branch 'origin/release/20.12' 2020-12-10 00:01:29 +01:00
Albert Astals Cid bc85160d7f clang-tidy: Disable performance-no-automatic-move
It's just too aggressive with Qt classes that are refcounted and fine to
copy
2020-12-09 21:37:32 +01:00
Albert Astals Cid 39846f8c16 Merge remote-tracking branch 'origin/release/20.12' 2020-12-09 21:15:36 +01:00
Albert Astals Cid d1c2eed1b6 Make the CI pass with new clang-tidy
Disable bugprone-suspicious-include since it's triggered by the moc
includes

Disable bugprone-reserved-identifier since it's triggered by all our
_OKULAR defines, and yes even if the spec says that underscore is
reserved, are we going to be that unlucky that the library decides to
start using _OKULAR ? not probably

Add two TODOs for the future to make NormalizedRect/Point faster

Silence a warning about a quick moving QString if we make it non const

Silence a uchar vs char warning that is in decades old code so
experience seems to suggest it's ok.
2020-12-09 19:53:50 +01:00
Albert Astals Cid e200d90de2 cmake: Modern way to link to tiff 2020-12-02 19:01:32 +01:00
Albert Astals Cid 43ae701345 cmake: Modern way to link to freetype 2020-12-02 19:00:18 +01:00
Albert Astals Cid 3cc7bdd1d7 cmake: Modern way to link to zlib 2020-12-02 18:57:49 +01:00
Albert Astals Cid 3129b642f9 cmake: Modern way to link to jpeg 2020-12-02 18:55:59 +01:00
Marat Radchenko 2aa9f18fe7 initial tables support for FictionBook 2020-11-29 23:12:37 +03:00
Marat Radchenko 29ed5d1dd7 handle <subtitle> inside <cite> in FictionBook documents
(cherry picked from commit 2e3faa0052)
2020-11-28 02:20:30 +01:00
Marat Radchenko 2e3faa0052 handle <subtitle> inside <cite> in FictionBook documents 2020-11-27 10:25:34 +03:00
Marat Radchenko 9f7b45271f add support for <subtitle> tag in FictionBook
(cherry picked from commit bcdd5a996c)
2020-11-27 00:30:19 +01:00
l10n daemon script a61977aa8a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-11-26 10:02:48 +01:00
Marat Radchenko bcdd5a996c add support for <subtitle> tag in FictionBook 2020-11-25 11:16:50 +03:00
l10n daemon script 33483a10fa GIT_SILENT made messages (after extraction) 2020-11-25 08:38:49 +01:00
l10n daemon script c9440a9160 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-11-25 06:34:22 +01:00
l10n daemon script a752711872 GIT_SILENT made messages (after extraction) 2020-11-25 02:20:39 +01:00
David Hurka a83261db92 Merge branch 'release/20.12' into master 2020-11-18 20:35:53 +01:00
David Hurka 19d5dd8ec7 New part/ directory for okularpart sources from /, ui/, conf/
Source files are no longer separated by UI and non-UI and similar,
but only by their build target.

* ui/ -> part/
* Move all source files from conf/ to part/
* Keep config skeleton definitions in conf/, needed for the mobile target too
* Move editdrawingtooldialogtest.h from conf/autotests/ to autotests/
* ui/data/icons/ -> icons/
* Move /part.cpp, /part.rc and similar files to part/
* Adapt include paths in source files
* Adapt CMakeLists.txt files (in / and in subdirectories)
* Adapt /Messages.sh
2020-11-18 19:32:56 +00:00
Alexander Lohnau 3c1fa441d9 Remove dead code
A lot of this code has been commented out for over
a decade and adds no value to the project.
It is only annoying when you look over it ;).

Same for the KNS2 support which was commented out.

Also some of the debug statements didn't even build
anymore, because the properties got removed/refactored.
2020-11-14 10:52:00 +01:00
Albert Astals Cid 6bd6714ab0 poppler: Use actual function calls instead of xml to create poppler annotations 2020-11-11 00:43:54 +00:00
Albert Astals Cid becdc7c483 Revert the two last commits
f9841b0f8a and e0f45add55

They break the windows build, which shows there's something defenitely
fishy going on with the current code, but oh well, someone with more
time needs to figure out a proper solution
2020-11-11 01:31:47 +01:00
Albert Astals Cid e0f45add55 Enable -Wweak-vtables in clang
Read https://stackoverflow.com/a/23749273/11956287 for a full
explanation, but basically this is important for headers like the
interfaces/ and kdocumentviewer.h that are supposed to be used by third
partyies where it may happen that wrong things happen because the whole
class is inline in a header

For the classes that are defined in the .cpp or are not installed
headers this would not be necessary but it's not so hard to add a few
default defined destructors, so do that :)
2020-11-08 21:21:06 +00:00
David Hurka 055d5709c1 Merge branch 'release/20.08' into master 2020-11-08 02:05:10 +01:00
Christoph Feck 02c3bd691a GIT_SILENT Update Appstream for new release 2020-10-31 18:08:36 +01:00
Albert Astals Cid b9c40d709d Fix formatting after Laurent's commit
Please Laurent try to use MR when you do changes that may break our CI
like this one

CCMAIL: montel@kde.org
2020-10-23 22:48:44 +02:00
Laurent Montel 486e05b270 If include is define in .h remove it if it's defined in .cpp too (scripted) 2020-10-23 07:32:28 +02:00
l10n daemon script dc74ffa68c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-10-17 06:04:22 +02:00
l10n daemon script 6abe9fcdfd GIT_SILENT made messages (after extraction) 2020-10-17 02:16:46 +02:00
Albert Astals Cid 62d7a6938a Remove the ooo plugin
As mentioned on the Akademy meeting, just use the calligra okular plugins if you want to open an odt/odp in Okular
2020-10-07 22:01:22 +00:00
Christoph Feck 6a31bfc7e3 GIT_SILENT Update Appstream for new release
(cherry picked from commit 0abdab924d)
2020-10-03 14:20:24 +02:00
Christoph Feck 0abdab924d GIT_SILENT Update Appstream for new release 2020-10-03 14:20:23 +02:00
Albert Astals Cid 45702f2291 Port deprecated QFontMetrics::width -> horizontalAdvance 2020-09-30 16:09:57 +00:00
Albert Astals Cid 78d983eeed drawRoundRect -> drawRoundedRect 2020-09-30 16:09:57 +00:00
Albert Astals Cid 8ab379e178 Part away from deprecated QProcess::finished(int) 2020-09-30 16:09:56 +00:00
l10n daemon script 601e96037c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-25 09:54:54 +02:00
l10n daemon script 21647201c2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-25 06:16:02 +02:00
Albert Astals Cid ceb8cf629d poppler: Convert Stamp annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:52 +00:00
Albert Astals Cid d13b18af32 poppler: Convert Caret annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:52 +00:00
Albert Astals Cid bfdd033bfb poppler: Convert Ink annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:52 +00:00
Albert Astals Cid a39708e71d Remove setTextIcon call that we already do at createAnnotationFromPopplerAnnotation 2020-09-24 07:42:52 +00:00
Albert Astals Cid eed89aaef6 poppler: Convert Highlight annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:52 +00:00
Albert Astals Cid f533788637 poppler: Convert Geom annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-09-24 07:42:51 +00:00
Albert Astals Cid 7ccb475df8 Fix crash on files that have the same signature in more than 1 page
It happens with some official documents where they use the same
signature in all pages to make it clear all pages are signed/official

BUGS: 426467
2020-09-17 01:27:42 +02:00
Albert Astals Cid 9bf171a108 Fix crash on files that have the same signature in more than 1 page
It happens with some official documents where they use the same
signature in all pages to make it clear all pages are signed/official

BUGS: 426467
2020-09-16 21:42:23 +00:00
Friedrich W. H. Kossebau 1784c1d0cb Use more nullptr instead of 0 2020-09-13 11:20:09 +02:00
Albert Astals Cid 4085181512 UDSEntry::insert -> UDSEntry::fastInsert
we're clearing the UDSEntry just before the inserts so it's safe to
assume we're not inserting something that was there already
2020-09-13 01:25:54 +02:00
Albert Astals Cid 8a1bef81f8 Remove poppler 0.80 ifdefs since we require 0.86 now 2020-09-13 01:21:11 +02:00
Albert Astals Cid 6b08af754f Remove poppler 0.79 ifdefs since we require 0.86 now 2020-09-13 01:20:14 +02:00
Albert Astals Cid 4d12c257b2 Remove poppler 0.74 ifdefs since we require 0.86 now 2020-09-13 01:18:34 +02:00
Albert Astals Cid 9264723002 Remove poppler 0.73 ifdefs since we require 0.86 now
This actually fixes a mistake in SignatureFormTest::testSignatureForm
2020-09-13 01:16:27 +02:00
Albert Astals Cid e283da994b Remove poppler 0.69 ifdefs since we require 0.86 now 2020-09-13 01:12:53 +02:00
Albert Astals Cid eacb5eed8b Remove poppler 0.68 ifdefs since we require 0.86 now 2020-09-13 01:12:05 +02:00
Albert Astals Cid 7dce3389cb Remove poppler 0.65 ifdefs since we require 0.86 now 2020-09-13 01:11:08 +02:00
Albert Astals Cid c019a7e76c Remove poppler 0.64 ifdefs since we require 0.86 now 2020-09-13 01:10:10 +02:00
Albert Astals Cid bcd36d6374 Remove poppler 0.63 ifdefs since we require 0.86 now 2020-09-13 01:07:38 +02:00
Albert Astals Cid e989200dcf Increase minimum supported versions to those provided by Ubuntu 20.04 2020-09-13 01:03:53 +02:00
Albert Astals Cid 2697105462 Revert cbddcd3273
KJS and KWallet are indeed optional, that's what the ${optionalComponents} variable does
2020-09-09 14:13:09 +02:00
Albert Astals Cid cbddcd3273 kwallet and kjs are mandatory in cmake anyway, remove ifdefs 2020-09-05 23:50:45 +00:00
Albert Astals Cid a05df764bc Move IsDigitallySigned code to part.cpp
It isn't really pdf generator specific
2020-09-05 19:33:47 +00:00
Christoph Feck b3101774cf GIT_SILENT Update Appstream for new release
(cherry picked from commit 4b9e50a1ed)
2020-08-31 21:02:07 +02:00
Christoph Feck 4b9e50a1ed GIT_SILENT Update Appstream for new release 2020-08-31 21:02:06 +02:00
Albert Astals Cid 8966b715b6 poppler: Convert Line annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-08-22 23:38:53 +00:00
Albert Astals Cid 884704f6cb poppler: Convert Text annotations via C++
Instead of via the magic XML cycle of Poppler::AnnotationUtils::storeAnnotation + Okular::AnnotationUtils::createAnnotation
2020-08-22 23:38:53 +00:00
Markus Brenneis 89cf21b222 Add support for image sizes in markdowns
The discount markdown parser supports parsing explicit image sizes in markdown, but we ignore them and replace them with the actual image dimensions. With this patch, any specified image sizes are respected.
2020-08-22 23:32:27 +00:00
Christoph Feck f6ce4a57d8 GIT_SILENT Update Appstream for new release 2020-08-05 09:52:57 +02:00
Christoph Feck d0b9d83946 GIT_SILENT Update Appstream for new release
(cherry picked from commit f6ce4a57d8)
2020-08-05 09:52:57 +02:00
l10n daemon script 36a6010c4f SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-30 09:32:05 +02:00
l10n daemon script 8f81af09e2 GIT_SILENT made messages (after extraction) 2020-07-30 07:58:09 +02:00
l10n daemon script 8563aa45cb SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-30 05:49:55 +02:00
l10n daemon script 685ae66b45 GIT_SILENT made messages (after extraction) 2020-07-30 02:13:37 +02:00
l10n daemon script 3ef3de28c8 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-07-25 05:29:31 +02:00
Albert Astals Cid 1eb724b5be Convert the poppler revisions to Okular revisions
It's not really like it matters since we're not using the okular
revision information anywhere, but well, at least from the poppler
plugin we're doing the right thing
2020-07-23 08:44:53 +00:00
Albert Astals Cid 2c8dd71931 Convert the poppler annotation popup to Okular annotation window
Not having this is not as bad as it sounds since for most of the
annotations where the style makes sense this is currently already being
converted by AnnotationPrivate::setAnnotationProperties but the plan is
to stop passing xml between poppler annotations and okular annotations
because that's just plain bad
2020-07-23 08:44:53 +00:00
Albert Astals Cid 2b639579f7 Convert the poppler annotation style to Okular annotation the style
Not having this is not as bad as it sounds since for most of the
annotations where the style makes sense this is currently already being
converted by AnnotationPrivate::setAnnotationProperties but the plan is
to stop passing xml between poppler annotations and okular annotations
because that's just plain bad
2020-07-23 08:44:53 +00:00
Albert Astals Cid 5ce3593e8f createAnnotationFromPopplerAnnotation: Renames to make the code easier to read
It's not clear ann was a popplerAnnotation but annotation was an
okularAnnotation
2020-07-23 08:44:53 +00:00
Albert Astals Cid 4e89757af1 Poppler: Use non xml API for toc if possible
The xml api will be removed in Qt6 so better to move away from it as
soon as possible
2020-07-23 07:49:38 +00:00
Albert Astals Cid 19d98d6a74 Run clang-format
find . \( -name "*.cpp" -or -name "*.h"  -or -name "*.c"  -or -name "*.cc" \) -exec clang-format -i {} \;

If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
2020-07-11 09:17:33 +02:00
Albert Astals Cid 751a7074d1 Need two clang-format off markers to not trigger clazy-connect-not-normalized 2020-07-11 09:15:45 +02:00
Albert Astals Cid 2ed253a540 Include fixes 2020-07-11 00:12:08 +02:00
Albert Astals Cid ae0bdd1fe9 Add qAsConst to code that is not CI'ed so clazy didn't complain [yet]
It's not CI'ed because CI doesn't have a poppler new enough
2020-07-09 21:37:43 +02:00
Laurent Montel 516fb89d94 Use camelcase include. (scripted) 2020-07-08 13:54:37 +02:00
Christoph Feck 182e2791d7 GIT_SILENT Update Appstream for new release
(cherry picked from commit 13dc58655a)
2020-07-03 23:03:22 +02:00
l10n daemon script 90502b2961 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-18 05:35:59 +02:00
l10n daemon script f046034c69 GIT_SILENT made messages (after extraction) 2020-06-18 02:14:44 +02:00
l10n daemon script 2857dc241f SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-17 14:03:40 +02:00
l10n daemon script 6cd2e32e64 GIT_SILENT made messages (after extraction) 2020-06-17 11:28:48 +02:00
l10n daemon script ef53790eba SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-10 05:21:36 +02:00
Nate Graham 4ee6b5066d Merge branch 'release/20.04' 2020-06-09 13:16:33 -06:00
l10n daemon script cc452498e5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-09 09:16:32 +02:00
Christoph Feck 6bb75da566 GIT_SILENT Update Appstream for new release
(cherry picked from commit 884b082aea)
2020-06-08 19:53:17 +02:00
Christoph Feck 884b082aea GIT_SILENT Update Appstream for new release 2020-06-08 19:53:16 +02:00
Albert Astals Cid 7a51799484 Merge remote-tracking branch 'origin/release/20.04' 2020-06-08 00:32:10 +02:00
Christoph Cullmann 3ad9fc7028 allow unicode filenames to work on Windows, too
BUG: 422500
2020-06-07 13:52:07 +02:00
l10n daemon script 0ff05b0e39 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-06-05 05:01:57 +02:00
Albert Astals Cid 8bd51cd97d Merge remote-tracking branch 'origin/release/20.04' 2020-06-03 09:04:30 +02:00
Albert Astals Cid 8460d34f34 pdf: fix memory leak when listing fonts 2020-06-02 22:55:45 +02:00
Albert Astals Cid 8d2fe2231d Merge remote-tracking branch 'origin/release/20.04' 2020-05-23 12:12:27 +02:00
Albert Astals Cid bb8de23468 CHM: Fix memory leak every time we open a file 2020-05-20 00:12:34 +02:00
Albert Astals Cid 4954395d08 PDF: Only enable the signatures without page feature with poppler 0.89
poppler 0.88 is crashy when using the signatures() method.

Use poppler's own version defines to check for 0.89 (since there's no
new api added in 0.89 we can't check it like the others)
2020-05-16 12:46:19 +02:00
Albert Astals Cid 4b1d85f81b Show signatures that don't belong to any page in the signature panel
Needs poppler 0.88, we "pretend" the belong to page 0 since in Okular
core there's no concept of having a signature that doesn't belong to any
page

BUGS: 415199
2020-05-13 21:21:52 +00:00
Albert Astals Cid b1c02b7e79 Markdown: Support internal links
When processing the <a> elements, store in two maps those that contain
an href="#Something" and those with name="Something" then once we've
processed them all, go over the first map trying to find itself in the
second

BUGS: 421163
2020-05-12 22:21:15 +00:00
Christoph Feck 3d148bd570 GIT_SILENT Update Appstream for new release 2020-05-11 23:14:44 +02:00
Christoph Feck 5e1f2c9a47 GIT_SILENT Update Appstream for new release
(cherry picked from commit 3d148bd570)
2020-05-11 23:14:44 +02:00
l10n daemon script ee0c3c0f17 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-05-11 06:20:55 +02:00
l10n daemon script 67b36f1cc2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-05-10 10:48:45 +02:00
l10n daemon script 3b57e3a731 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-05-05 10:22:59 +02:00
l10n daemon script 0fe02f2e18 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-05-05 06:13:17 +02:00
l10n daemon script f353ed2a9b SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-20 09:50:10 +02:00
l10n daemon script 5410a798c9 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-20 05:45:41 +02:00
Albert Astals Cid a4e044e6d6 tweak spacing to make clang-10 happier
The whole file is a mess, but in particular this was making a warning so
let's fix it
2020-04-19 17:29:35 +02:00
Albert Astals Cid 5abcbea617 Make clazy happy
Otherwise when CI gets a new enough poppler it'll start failing
2020-04-18 23:48:51 +02:00
Albert Astals Cid d8e4796830 Merge remote-tracking branch 'origin/release/20.04' 2020-04-16 00:06:40 +02:00
Albert Astals Cid 903cdec02b GIT_SILENT fix version
need to figure out a way to make this work :/
2020-04-16 00:06:00 +02:00
Christoph Feck 8fd53e5674 GIT_SILENT Update Appstream for new release
(cherry picked from commit c8dcf1fdea)
2020-04-15 11:06:58 +02:00
Christoph Feck c8dcf1fdea GIT_SILENT Update Appstream for new release 2020-04-15 11:06:58 +02:00
Albert Astals Cid cf42f391cc Merge remote-tracking branch 'origin/release/20.04' 2020-04-12 19:46:24 +02:00
Albert Astals Cid da24829ee2 djvu: Fix garbage on empty pages at "high" zoom levels
BUGS: 419962
2020-04-12 17:37:16 +02:00
Albert Astals Cid 25b6775468 Use ${KF5_REQUIRED_VERSION} also for ECM 2020-04-08 21:56:29 +02:00
l10n daemon script 1cea26861a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-04 10:55:58 +02:00
l10n daemon script 3d69157736 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-04 06:34:17 +02:00
l10n daemon script b7c4f253bb SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-02 10:24:59 +02:00
l10n daemon script 1e3b058254 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-04-02 06:14:37 +02:00
Nicolas Fella 7d24a51e6a Launch okularkirigami directly instead of via kpackagelauncherqml 2020-03-29 12:39:19 +00:00
Albert Astals Cid f69e2114e7 Use poppler choicesWithExportValues if available 2020-03-28 23:12:08 +00:00
Albert Astals Cid 4019ec56e5 comicbook: Obey autotransform of images
BUGS: 410778
2020-03-04 19:07:03 +00:00
Albert Astals Cid 4964e7e42d Merge remote-tracking branch 'origin/release/19.12' 2020-03-02 22:22:06 +01:00
Christoph Feck a7876ca013 GIT_SILENT Update Appstream for new release 2020-03-01 10:37:27 +01:00
Albert Astals Cid af35ef4fbf Merge remote-tracking branch 'origin/release/19.12' 2020-02-23 22:33:56 +01:00
Albert Astals Cid 3720833be4 Enable clazy qstring-allocations 2020-02-21 17:45:03 +01:00
Albert Astals Cid 9a32bd354d Enable clazy raw-environment-function 2020-02-21 17:09:46 +01:00
Albert Astals Cid dcf8f79481 Enable clazy isempty-vs-count and qhash-with-char-pointer-key 2020-02-21 17:09:46 +01:00
Albert Astals Cid 46d1ba0e20 Enable clazy missing-qobject-macro 2020-02-21 17:09:46 +01:00
Albert Astals Cid 6d0d61c2ad Enable clazy copyable-polymorphic 2020-02-21 17:09:43 +01:00
Albert Astals Cid 93540ac16d Enable most of clazy level2 2020-02-21 14:57:48 +01:00
Albert Astals Cid 968e9d6073 Enable clazy old-style-connect 2020-02-20 15:48:08 +01:00
Albert Astals Cid 91bce4a0a3 Enable clazy const-signal-or-slot 2020-02-20 12:42:23 +01:00
Albert Astals Cid 3ca05fc1f8 Enable clazy qstring-insensitive-allocation 2020-02-20 11:15:15 +01:00
Albert Astals Cid beb195c9e6 Enable clazy qcolor-from-literal 2020-02-20 11:12:00 +01:00
Albert Astals Cid 0a60ab54c4 Enable clazy qstring-ref 2020-02-20 11:01:58 +01:00
Albert Astals Cid e2a1705703 CI: Enable clazy connect-not-normalized 2020-02-19 23:44:41 +01:00
Albert Astals Cid a23709b097 CI: Enable clazy range-loop 2020-02-19 23:44:41 +01:00
Albert Astals Cid 82d5810493 CI: Enable clazy detaching-temporary 2020-02-19 23:44:41 +01:00
Albert Astals Cid 1a05112be1 CI: enable clazy incorrect-emit 2020-02-19 23:44:41 +01:00
Albert Astals Cid 96f00a4d29 CI: Enable clazy qstring-arg check 2020-02-19 23:44:37 +01:00
Albert Astals Cid 5ecbb51f77 Enable modernize-use-nullptr 2020-02-19 18:10:05 +01:00
l10n daemon script 2d95594a4a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-02-14 09:55:09 +01:00
l10n daemon script f2274e8992 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-02-14 05:55:12 +01:00
l10n daemon script a26dd5118a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-02-04 10:04:28 +01:00
l10n daemon script 0d5bd0bc43 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-02-04 06:09:17 +01:00
Christoph Feck a18c013932 GIT_SILENT Update Appstream for new release 2020-02-04 00:16:27 +01:00
l10n daemon script 5dfbee0a00 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-02-01 05:46:42 +01:00
Albert Astals Cid b82682037e Merge remote-tracking branch 'origin/release/19.12' 2020-01-31 10:22:59 +01:00
l10n daemon script 134c16efdc SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-01-31 09:40:26 +01:00
l10n daemon script f6ee1a3b24 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-01-31 05:46:31 +01:00
l10n daemon script aae406bd80 GIT_SILENT made messages (after extraction) 2020-01-29 02:58:10 +01:00
l10n daemon script 79de5d3958 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-01-28 05:42:48 +01:00
l10n daemon script a5eda6348f GIT_SILENT made messages (after extraction) 2020-01-28 03:10:03 +01:00
Ahmad Samir 4a4456abd7 Port QRegExp to QRegularExpression in a couple of locations
Some instances of QRegExp are still left:
generators/mobipocket and generators/epub
2020-01-26 11:40:33 +00:00
Albert Astals Cid 2da1cd736a CI: Enable clang-tidy modernize-loop-convert 2020-01-24 17:23:39 +01:00
Laurent Montel cea7d0fa28 Don't use endl at the end of qDebug as it already adds end line 2020-01-17 21:04:27 +01:00
l10n daemon script 7e40267790 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-01-17 10:22:33 +01:00
l10n daemon script 204653e2c3 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-01-09 09:37:27 +01:00
l10n daemon script 64e90432d0 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-01-09 05:45:18 +01:00
Albert Astals Cid be8e5710d4 Require poppler >= 0.62
It's the one that comes with our "minimum" requirement Ubuntu 16.04

Cleans up the code a bit
2020-01-09 00:01:43 +00:00
Albert Astals Cid 88e5775f34 Merge remote-tracking branch 'origin/release/19.12' 2020-01-07 23:28:40 +01:00
Christoph Feck 475652a990 Update Appstream for new release 2020-01-06 14:55:05 +01:00
l10n daemon script 2fc22344e3 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-01-03 09:44:10 +01:00
l10n daemon script 4c46aabe2e SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-01-03 05:59:22 +01:00
Albert Astals Cid 2e46cf22f5 CI: enable clang tidy performance checks 2020-01-02 14:27:11 +01:00
Albert Astals Cid b001ea2019 CI: Enable a bunch of bugprone- clang-tidy warnings 2019-12-24 10:18:16 +00:00
Albert Astals Cid 8d6109de65 Merge remote-tracking branch 'origin/release/19.12' 2019-12-24 11:13:36 +01:00
Albert Astals Cid da2e03ec5a Make clang-tidy happy
We know we will never have more than t_dir pages but since QList::count
can be an int, make the index variable also be int and let clang-tidy be
happy
2019-12-23 13:15:57 +01:00
Albert Astals Cid 5f42e08e25 Don't have a for with variable i inside a for with variable i 2019-12-23 13:15:57 +01:00
Albert Astals Cid c81392a71c Remove wrong forward declarations
They are not needed and clang-tidy says they are on the wrong namespace
anyway
2019-12-23 13:15:57 +01:00
Albert Astals Cid 0a2287be19 CI: Enable two readability clang-tidy checks
Use jq to filter compile_commands.json to not include the compilation of
autogenerated files, we don't want to check those

Also filter out the synctex folder, since that is imported code
2019-12-23 12:06:49 +01:00
Ahmad Samir 54494cc3d4 [generators/*] Replace deprecated foreach with range-for 2019-12-23 06:06:25 +00:00
Albert Astals Cid 78cf6bd910 CI: enable more modernize checks
Since unfortunately some of the autogenerated includes don't pass the
checks we do a trick of building out of source and then specifying the
.*/okular/.* path as the only includes we care about
2019-12-18 12:51:13 +01:00
Albert Astals Cid a2ac42b9c7 CI: Enable modernize-use-bool-literals 2019-12-18 11:32:46 +01:00
Albert Astals Cid 6b80bc9fcd Enable a CI with clang-tidy and modernize-redundant-void-arg 2019-12-18 09:01:01 +00:00
Albert Astals Cid f7f2b3105f Increase version here too 2019-12-05 23:50:27 +01:00
Christoph Feck 7974aa1d36 Update Appstream for new release 2019-12-05 22:05:15 +01:00
Oliver Sander 3b7bfb2e17 Use std::unique_ptr for several FormField objects 2019-12-04 09:19:46 +00:00
Oliver Sander 30e5a492ed Use more 'nullptr' instead of '0' 2019-12-04 09:19:46 +00:00
l10n daemon script d40d89a029 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-25 05:24:21 +01:00
l10n daemon script 1f0048c125 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-24 09:11:36 +01:00
l10n daemon script 1850e8d1ec GIT_SILENT made messages (after extraction) 2019-11-24 07:54:36 +01:00
l10n daemon script cf07a44f27 GIT_SILENT made messages (after extraction) 2019-11-24 03:07:30 +01:00
Yuri Chornoivan b510bb8f20 Update links to the dependencies 2019-11-21 17:54:42 +02:00
l10n daemon script 9e4c6cfb68 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-11 09:47:25 +01:00
l10n daemon script 35b7d057a2 GIT_SILENT made messages (after extraction) 2019-11-11 08:18:44 +01:00
l10n daemon script 6aecd5d5db SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-10 05:25:56 +01:00
l10n daemon script 8d1dbe5041 GIT_SILENT made messages (after extraction) 2019-11-10 03:06:52 +01:00
l10n daemon script 2d90b6210c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-03 05:15:02 +01:00
l10n daemon script ff7c93a600 GIT_SILENT made messages (after extraction) 2019-11-03 03:01:10 +01:00
Harald Sitter 235164b264 don't crahs on nullptr pdfOptionsPage
same as in fbeff5ae7c there may not be
a pdfOptionsPage when using print preview.

this fixes an exciting crash on our windows build when tryint to print
preview
2019-10-21 11:08:25 +02:00
l10n daemon script 9c1227a3bc SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-20 05:15:31 +02:00
l10n daemon script b77bcd3078 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-14 05:05:17 +02:00
l10n daemon script 527737711f SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-10 05:29:24 +02:00
l10n daemon script a90bf7fe02 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-09 05:35:12 +02:00
l10n daemon script 1943667775 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-08 05:22:18 +02:00
l10n daemon script af085affe4 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-07 05:05:01 +02:00
l10n daemon script c5e9de8931 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-06 05:23:07 +02:00
Albert Astals Cid da21543a50 Small performance improvements 2019-10-05 22:16:43 +02:00
l10n daemon script 92232d81ba SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-05 05:16:24 +02:00
Christoph Cullmann 34476a6301 merge 19.08 fixes to master 2019-10-04 20:22:30 +02:00
l10n daemon script cd26e23a33 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-29 08:45:21 +02:00
l10n daemon script 26c0a606d7 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-28 05:20:46 +02:00
l10n daemon script a9e0e49f43 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-25 08:58:56 +02:00
l10n daemon script 59f13d9bcf SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-25 05:23:48 +02:00
l10n daemon script 91e0ad9a9d SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-22 09:03:32 +02:00
Aleix Pol 40d32ae9a4 Fix compilation against a karchive that doesn't have lzma
Fixes one of the problems with building for Android.
Note LZMA is an optional dependency for KArchive.
2019-09-21 00:59:50 +02:00
Laurent Montel 8beef33c05 Port some deprecated methods 2019-09-18 13:41:19 +02:00
Laurent Montel db0f477119 Port deprecated QLayout::setMargin 2019-09-18 13:35:04 +02:00
l10n daemon script 86fba9df67 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-09 08:45:37 +02:00
l10n daemon script 7f97880667 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-09 05:09:03 +02:00
l10n daemon script 26c5d9c8de SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-07 09:12:13 +02:00
l10n daemon script e27209f430 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-06 09:19:00 +02:00
l10n daemon script 2dcf717c95 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-05 09:08:26 +02:00
l10n daemon script d647ff3b67 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-03 08:55:46 +02:00
l10n daemon script 10f9f30bf1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-02 08:48:01 +02:00
l10n daemon script abfa0c7ed9 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-09-01 08:27:16 +02:00
l10n daemon script 674afc0250 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-31 08:50:23 +02:00
l10n daemon script 49e414444a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-30 09:23:56 +02:00
l10n daemon script 774bcbc4ef SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-30 05:20:53 +02:00
l10n daemon script 2a3820aba1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-26 05:02:04 +02:00
l10n daemon script 87f80c3418 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-18 05:05:25 +02:00
l10n daemon script 241e807bca SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-17 05:10:33 +02:00
l10n daemon script c2479a733b SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-16 05:11:44 +02:00
l10n daemon script df7a8d67e7 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-14 05:09:46 +02:00
l10n daemon script 0fbe40dfb4 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-13 05:25:02 +02:00
l10n daemon script b16dcf41aa SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-12 08:33:06 +02:00
l10n daemon script bf7a53d62b SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-12 05:10:27 +02:00
João Netto b66df68452 Implemented support for setAppearanceText defined on Poppler 2019-08-11 14:55:21 +00:00
João Netto b7249ce8c1 Implemented support for keystroke actions 2019-08-11 14:55:21 +00:00
l10n daemon script 96b9fa1ef4 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-08-11 04:52:16 +02:00
Natsumi Higa 5a8d21d597 Add support for cb7 comic book archives
Test Plan: Open a cb7 file (e.g. [[ https://bugs.kde.org/attachment.cgi?id=122002 | Attachment 122002 ]] from [[ https://bugs.kde.org/show_bug.cgi?id=410696 | Bug 410696 ]]) using Okular and see if it works.

Reviewers: #okular, aacid

Subscribers: broulik, pino, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D23037
2019-08-10 11:45:13 +02:00
Jan Grulich a738c98c20 Add information about substituting font into properties dialog
Reviewers: aacid

Subscribers: pino, ngraham, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D23027
2019-08-10 02:00:57 +02:00
João Netto bb6bee53fe Added support for the full name of fields, which is used in the JavaScript 2019-08-07 22:40:50 +00:00
João Netto 60ff2f414e Fixed indentation, bad algebra and moved display enum to KJSDisplay 2019-07-20 12:06:42 +02:00
João Netto ad858267d1 Implemented display support and updated dependencies to Poppler > 0.79
Moved executeScript to document private and support to display options for JavaScript
2019-07-20 12:06:12 +02:00
João Netto 552e4a3917 Added support for buttonSetIcon and buttonGetIcon.
Added support for the setIcon/getIcon defined in Poppler > 0_78
2019-07-20 12:05:37 +02:00
Yuri Chornoivan e7ead0d3f5 Fix EBN issues 2019-07-14 10:15:45 +03:00
Albert Astals Cid 2e4212ad80 Partially revert "Fix two easy deprecation warnings"
QFontMetrincs::horizontalAdvance is only available in Qt 5.11

This reverts commit 69ec17554a.
2019-07-04 00:31:15 +02:00
Albert Astals Cid ec51b2f02f Remove QFontDatabase::supportsThreadedFontRendering checks
We require Qt 5.8 and there (and up) it returns true unconditionally and
it's now marked as deprecated
2019-07-04 00:09:04 +02:00
Albert Astals Cid 69ec17554a Fix two easy deprecation warnings
width -> horizontalAdvance

background -> window
2019-07-04 00:06:19 +02:00
Albert Astals Cid 073f50cab8 Merge remote-tracking branch 'origin/Applications/19.04' 2019-06-22 12:40:20 +02:00
Albert Astals Cid 3c5b9b6f81 Fix compile with older poppler 2019-06-22 12:39:42 +02:00
Albert Astals Cid ea2a7b264f PDF: Finish support for Optional Content state change links
I implemented this 3 years ago, but for some reason forgot to commit this part ^_^

CCBUGS: 408849
2019-06-22 12:36:33 +02:00
Laurent Montel 9f90e14dd1 Fix forward declaration 2019-06-03 08:48:32 +02:00
Laurent Montel cb691f70dc Fix some clazy warning
Summary: fix clazy warning

Reviewers: aacid

Reviewed By: aacid

Subscribers: nicolasfella, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D20832
2019-05-27 08:02:57 +02:00
Albert Astals Cid 2083e763d0 Merge remote-tracking branch 'origin/Applications/19.04' 2019-05-23 00:29:12 +02:00
Stefan Brüns eb41001e0e [EPubGenerator] Avoid pointless scans of the whole document
Summary:
The "<video></video>" tag is a placeholder, and should only be processed
when it has been inserted for this toc item, i.e. when movieAnnots is
non-empty. Also place the search cursor at the last inserted block,
otherwise the expression will search from the beginning of the document.

Do likewise for audio/soundActions.

This makes loading large documents much fasters, and even fixes crashing
on huge documents, e.g. from project Gutenberg "The Complete Works of
William Shakespeare" (3200 pages) or the "King James Bible" (1400 pages).

Test Plan: open a large EPub file (see above)

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D20948
2019-05-23 00:28:56 +02:00
Albert Astals Cid 91333fdf7c Merge remote-tracking branch 'origin/Applications/19.04' 2019-05-23 00:25:30 +02:00
Stefan Brüns 9f98c01069 [EPubGenerator] Avoid crashes due to bogus wrapping of content in table
Summary:
QTextDocument chokes badly when a some documents are wrapped inside
a table, returning e.g. a pagecount of -41292 afterwards.

On the downside, this removes any padding from the page. On the upside,
it removes any padding from the page.

BUG: 406738
BUG: 407140
CCBUG: 406116

Reviewers: #okular

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D20949
2019-05-23 00:24:46 +02:00
Stefan Brüns eb1e796449 [EPubGenerator] Use proper UserResource enum value for custom resource
Summary:
QTextDocument::ResourceType uses values 0 through 3, and provides
UserResource = 100 for custom types. Avoid possible future clashes.

Reviewers: #okular

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D20950
2019-05-22 23:54:01 +02:00
Albert Astals Cid b74aa28f3f Merge remote-tracking branch 'origin/Applications/19.04' 2019-05-22 22:57:22 +02:00
Albert Astals Cid d121461b57 Revert "Fix build with poppler < 0.51"
This reverts commit 32786e6b3d.
2019-05-22 22:56:39 +02:00
Alexander Volkov f29f6727a2 Merge remote-tracking branch 'origin/Applications/19.04' 2019-05-22 15:37:30 +03:00
Alexander Volkov 32786e6b3d Fix build with poppler < 0.51
Reviewers: #okular, sander

Reviewed By: sander

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D21320
2019-05-22 15:31:17 +03:00
l10n daemon script a7742d4604 GIT_SILENT made messages (after extraction) 2019-05-22 03:10:30 +02:00
Stefan Brüns 43cf8c8aef [EPubGenerator] Fetch the application palette just once
Summary:
There is no reason to fetch the palette once per loop,
just do it once

Reviewers: #okular, ngraham

Reviewed By: ngraham

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D20947
2019-05-02 20:29:26 +02:00
Stefan Brüns f7fbbf769b [EPubGenerator] Reduce nesting level in loop
Summary:
The loop body is skipped when `epub_it_get_curr(it)` is invalid.
Make it more obvious there is no more code executed in this case.

Test Plan: no functional changes

Reviewers: #okular, ngraham

Reviewed By: ngraham

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D20946
2019-05-02 20:28:57 +02:00
Michael Weghorn 748884b4c7 PDF: Implement scaling options for non-rasterized printing
Summary:
This adds another 'FilePrinter::printFile' method that
accepts an additional parameter to specify whether or not to
do scaling and passes the 'fit-to-page' to CUPS dependent
on what is specified.

If FilePrinter is used, The PDF generator now passes this
option depending on the scaling mode that was selected in the
custom print options widget, which is therefore now enabled
for non-rasterized printing as well.

Test Plan:
1) open a PDF document in Okular and open the print dialog
2) go to the "PDF Options" tab
3) verify that "Force rasterisation" is disabled, but the
  "Scale mode" combobox is active.
4) test all the three options available in the "Scale mode"
   combobox do what they say
5) Make sure the three options still work as expected for
   the "Force rasterisation" case.

Reviewers: #okular, ngraham, sander

Reviewed By: ngraham

Subscribers: aacid, fvogt, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D18179
2019-04-14 21:11:36 -06:00
Albert Astals Cid aa3813abf6 Merge remote-tracking branch 'origin/Applications/19.04' 2019-04-13 00:06:12 +02:00
Heiko Becker e01329eb47 Fix build with poppler <0.58
Summary:
- Poppler::FormFieldSignature::signatureType
- Poppler::SignatureValidationInfo::hashAlgorithm
- Poppler::SignatureValidationInfo::signature
- Poppler::SignatureValidationInfo::signedRangeBounds
- Poppler::SignatureValidationInfo::signerSubjectDN
- Poppler::SignatureValidationInfo::signsTotalDocument

were all introduced with poppler 0.58.

Test Plan:
Builds fine with poppler 0.57 and 0.75, looked at
http://tecxoft.com/samples/pdf_digital_signature_timestamp.pdf

Reviewers: aacid

Reviewed By: aacid

Subscribers: aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D20488
2019-04-13 00:00:46 +02:00
Albert Astals Cid d9515bb625 mArchiveDir can be const, so we save a nasty const_cast 2019-04-12 09:51:32 +02:00
Michael Weghorn 8bf1a91175 Add option to ignore print margins for non-PDF generators
Summary:
This adds a combobox in the print dialog of the non-PDF
generators to allow selecting whether or not to take
print margins into account.

For the PDF case and rasterized printing, new print otions have
been implemented in commit 2e97d58750
already, which adds an additional option to do no scaling at all.

For consistency reasons, the same terms also used for the PDF
case are used in the combobox (i.e. the two of the three that
apply).

This adds a new abstract class 'PrintOptionsWidget' with a
'ignorePrintMargins()' method to indicate whether print margins
should be ignored or not, and a default implementation.
The existing widget for the PDF generator now derives from this
class.

In order to avoid an ABI breakage, the return value of
'Document::printConfigurationWidget' is left as a 'QWidget *'
and a dynamic_cast is done on use.

FilePrinter is adapted to take into account the value set by
'QPrinter::setFullPage()' and the margin options
are now passed accordingly (either the values set in the dialog or '0').

A big thanks to Albert Astals Cid <aacid@kde.org> for showing how
to extend the initial implementation to cover more generators.

Test Plan:
1) Open a PostScript file in Okular (using a document size that matches
  a paper size available on the printer used later makes it easier
  to see things behave as expected)

2) open print dialog, go to "Print options" and notice that there is a new
  "Scale mode" combobox whose value is set to "Fit to printable area"
   by default.

3) don't change any options, print to a printer that has hardware margins

Expected result: the document is scaled to the printable area (e.g.
scaled down so that the printer's hardware margins remain empty) as it
has been without this change.

4) Set the value of the "Print Options" -> "Scale mode" combobox to
   "Fit to full page" and print again

Expected result: The document is scaled to the full page size, i.e. ignoring
the printer's hardware margins.

5) Try steps 1-4 with other document formats supported by Okular and
   observe that they behave the same (except for the PDF case, where
   there's a combobox with three options that has been implemented
   independent of this change).

Reviewers: #okular, ngraham

Reviewed By: ngraham

Subscribers: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham

Tags: #okular

Differential Revision: https://phabricator.kde.org/D10974
2019-04-03 08:00:35 -06:00
Yuri Chornoivan 6722052380 Remove extra include 2019-04-01 13:13:01 +03:00
Albert Astals Cid fe0c8ad7c9 MarkDown: Enable option to disable smartypants formatting
BUGS: 404616

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D19405
2019-03-30 23:51:00 +01:00
Albert Astals Cid 0520d58246 Fix delete/delete[] mismatch
bits is only allocated in one place

characterBitmaps[ch]->bits = new char[size != 0 ? size : 1];
2019-03-21 20:10:15 +01:00
Albert Astals Cid 8a1553bf56 Merge remote-tracking branch 'origin/Applications/18.12' 2019-03-16 12:07:53 +01:00
Laurent Montel d120f2b655 Remove more deprecated method 2019-03-12 13:21:07 +01:00
Laurent Montel 549c32e4be Port qStableSort 2019-03-12 13:15:34 +01:00
Laurent Montel 5a3a49c310 Port qSort to std::sort 2019-03-12 13:13:53 +01:00
Laurent Montel c3db297225 Remove deprecated method 2019-02-27 07:50:47 +01:00
l10n daemon script aaa176041d GIT_SILENT made messages (after extraction) 2019-02-16 03:14:15 +01:00
l10n daemon script 5e01eff352 GIT_SILENT made messages (after extraction) 2019-02-15 07:43:11 +01:00
Joao Netto 716b234100 Implemented find function from console
Summary:
Implemented feature request to find from console.

BUG: 362038

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: ngraham, aacid, yurchor, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D18144
2019-02-13 23:59:52 +01:00
l10n daemon script 241bc6525a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-10 05:27:14 +01:00
Shubham Jangra b03bfa1163 Fix unused parameter warnings 2019-02-04 23:36:40 +05:30
Shubham Jangra 251e352563 Handle OCGState and fix warning 2019-02-04 23:30:49 +05:30
Alexander Volkov 0d958be290 Fix MimeType in org.kde.mobile.okular_comicbook.desktop 2019-01-16 17:44:07 +03:00
Yuri Chornoivan 614f580b79 Fix minor typos 2019-01-11 09:09:34 +02:00
Chinmoy Ranjan Pradhan a234a902dc Implement digital signature support for PDF
This is a squash of the original branch

It also contains fixes/rework from Albert Astals Cid

If you're interested in its history have a look at the
gsoc2018_digitalsignature branch

The poppler dependency situation is:
 * With 0.51 you get most signature information
 * With 0.68 you also get signature location/reason information
 * With 0.73 you also get signature certificate information
2019-01-10 23:13:54 +01:00
Albert Astals Cid 47d7d04b5e delete copy constructor and assignment operator of some internal classes
they are unused(except the PageViewItem one), but if anyone would use
them things would go wrong, so protect us from it

Actually fixes a bug in PageView::slotFitWindowToPage in which we were
copying constructing PageViewItem and that's bad
2019-01-10 00:28:49 +01:00
l10n daemon script c575d0ac29 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-01-06 08:41:17 +01:00
l10n daemon script d6775c6462 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-01-06 05:35:56 +01:00
l10n daemon script 6bcf22da75 GIT_SILENT made messages (after extraction) 2019-01-05 07:21:16 +01:00
l10n daemon script 802e8814aa GIT_SILENT made messages (after extraction) 2019-01-05 03:17:40 +01:00
Oliver Sander a4735e428a Use more std::unique_ptr 2018-12-30 16:52:47 +01:00
Albert Astals Cid cbae44467a Merge remote-tracking branch 'origin/Applications/18.12' 2018-12-26 12:03:38 +01:00
Albert Astals Cid 58038fed18 Do not crash in files without title-info
BUGS: 402558
2018-12-26 12:02:31 +01:00
Oliver Sander 2e97d58750 Implement several new print scaling options
This patch introduces the choice between three scaling
options for printing:

* Fit to printable area
* Fit to full page
* No scaling

The new options only work with the QPrinter backend.  Therefore
they are only enabled if 'force rasterization' is selected.

Differential Revision: https://phabricator.kde.org/D7962
2018-12-23 02:25:08 +01:00
Albert Astals Cid 004120917d Fix build ^_^ 2018-12-19 00:58:11 +01:00
Albert Astals Cid c950ea92f5 PDF: Add a "Using Poppler $VERSION" string
It is sometimes useful to know which version of the poppler you're using
and to which you where built

Needs feature introduced in poppler just now
2018-12-19 00:41:37 +01:00
Albert Astals Cid c4cf125e85 Merge remote-tracking branch 'origin/Applications/18.12' 2018-11-28 23:11:47 +01:00
Alexander Kandaurov b04a2daa6b Fix DjVu links pointing to pages with different dimensions
Summary:
Currently the coordinates of a link rectangle in a DjVu document are computed with respect to the size of the page the link is pointing to. Because of that, links only appear in correct places if the dimensions of a target page are the same as of the page containing the link.

The attached file demonstrating the issue contains two pages, one in portrait orientation and one in landscape, the first pointing to the second. The active zone for the link is different from where it is in other viewers.
{F6443987}

Reviewers: #okular

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D17194
2018-11-28 23:11:00 +01:00
Yuri Chornoivan 5478b2ec92 Fix minor typos 2018-11-14 21:12:15 +02:00
Fabio Bolz 4e353aabee Add unarchiver support for cbr files
Summary:
FEATURE: 339370
When no unrar installed, Okular now utilizes the program unar for extracting the archive and lsar for listing the content in the archive.
lsar is related and comes with a unar installation.

Subscribers: aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D15691
2018-11-07 23:30:22 +01:00
Laurent Montel 6f9913802c Remove qt prefix 2018-11-06 13:27:12 +01:00
Albert Astals Cid ec692e459b Remove unused variables 2018-11-02 18:03:26 +01:00
l10n daemon script 33a5f67eb2 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-24 05:59:57 +02:00
Yuri Chornoivan 69c7b834d1 Fix minor API docs EBN issues 2018-10-19 09:00:06 +03:00
Yuri Chornoivan 2f014ccd20 Fix minor EBN issues 2018-10-18 22:04:49 +03:00
l10n daemon script 4e9bbfddb0 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-10-10 06:37:12 +02:00
l10n daemon script 96f4f27ba6 GIT_SILENT made messages (after extraction) 2018-10-10 04:08:48 +02:00
Dileep Sankhla e44ff38706 Support setting text color for typewriter annotations
Summary:
Changing typewriter text color can be done in the typewriter properties dialog, or programmatically via new okular API methods TextAnnotation::textColor and TextAnnotation::setTextColor.

poppler >= 0.69 is required to store text color natively inside PDF documents. For other document types, text color is stored as metadata inside the document archive.

This work was done during GSoC 2018. See https://community.kde.org/GSoC/2018/StatusReports/DileepSankhla for details.

Test Plan:
- properties dialog of typewriter annotation has "Font Color" picker
- saving to PDF results in <r> <g> <b> rg operation in /DA
- saving to archive results in fontColor="rrggbb" attribute in metadata.xml

Reviewers: sander

Reviewed By: sander

Subscribers: kde-doc-english, sander, okular-devel

Tags: #okular, #documentation

Differential Revision: https://phabricator.kde.org/D15205
2018-10-04 20:02:55 +02:00
Yuri Chornoivan 39b6e8147d Fix minor EBN issues 2018-09-01 11:25:57 +03:00
Yuri Chornoivan c04ca1fa96 Fix minor EBN issues 2018-08-31 12:23:45 +03:00
Albert Astals Cid 6a37055351 Merge remote-tracking branch 'origin/Applications/18.08' 2018-08-27 01:09:44 +02:00
Albert Astals Cid 0a8d2f7f85 Fix links being "lost" on save
Summary:
We need to regenerate the links when switching the file
since we won't re-render the pages since we already have
them and link generation is on page render

BUG: 397373

Reviewers: tobiasdeiminger

Reviewed By: tobiasdeiminger

Subscribers: tobiasdeiminger, sander, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D14752
2018-08-27 01:09:11 +02:00
Yuri Chornoivan c7722c4078 Fix minor EBN issues 2018-08-17 21:05:01 +03:00
Gilbert Assaf fcf148b75b Fixes url whitespaces in epub documents
Summary:
libepub can't handle whitespace url encodings. This is why epub documents containing whitespaces urls aren't
displayed correctly. Since libepub doesn't seem to be maintained anymore, it might be better to fix this issue here.

BUG: 334711

Test Plan: Example epubs are in the ticket.

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: ngraham, aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D14310
2018-08-15 19:14:39 +02:00
Oliver Sander 59b8770545 Remove unused file
BUGS: 397429
2018-08-14 10:18:39 +02:00
l10n daemon script d85fe1df64 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-08-04 07:49:58 +02:00
l10n daemon script bae0e13719 GIT_SILENT made messages (after extraction) 2018-08-04 06:27:24 +02:00
l10n daemon script f1d3c68115 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-08-04 05:43:46 +02:00
l10n daemon script 5f93a0b90e GIT_SILENT made messages (after extraction) 2018-08-04 03:45:00 +02:00
l10n daemon script 55c1cd433e SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-08-01 07:46:16 +02:00
l10n daemon script f670a18bd9 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-08-01 05:52:53 +02:00
Gilbert Assaf 57be655c15 Improve picture scaling issues in epub generator
CCBUG: 391625

Test Plan: I tested the file mentioned in the bug report. Pictures look less blurry

Reviewers: #okular

Subscribers: ngraham, aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D13766
2018-07-28 23:13:53 +02:00
l10n daemon script c4570f7e40 GIT_SILENT made messages (after extraction) 2018-07-16 03:26:51 +02:00
l10n daemon script 860dc697ef GIT_SILENT made messages (after extraction) 2018-07-14 03:29:12 +02:00
l10n daemon script 879a46ac55 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-07-07 05:17:35 +02:00
Andre Heinecke 18d404c3ee Support additional widget actions in PDF Forms
Summary:
This adds support for actions associated with form fields
through corresponding annotation widgets.

Test Plan:
Still needs a unit test, only tested manually with
the document attached in the task.

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: okular-devel, aacid

Tags: #okular

Maniphest Tasks: T8627

Differential Revision: https://phabricator.kde.org/D12665
2018-05-30 10:04:21 +02:00
Sune Vuorela aa800c01bc Merge branch 'Applications/18.04' 2018-05-08 21:46:20 +02:00
Sune Vuorela 3e48663fb7 Use a target in FindDiscount (modern cmake) rather than variables
Test Plan: Things still builds

Reviewers: kde-buildsystem, apol

Reviewed By: apol

Subscribers: apol, aacid, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D12672
2018-05-08 21:39:06 +02:00
l10n daemon script ee57925c57 GIT_SILENT made messages (after extraction) 2018-05-06 06:09:02 +02:00
l10n daemon script 26c40ab7bd GIT_SILENT made messages (after extraction) 2018-05-06 03:31:04 +02:00
Sune Vuorela 13bdb97084 Don't crash if fopen fails
Summary:
If we have a qrc url, all checks so far fails, and this one returns null.

It might also be possible to get here in some race condition.

Reviewers: aacid

Reviewed By: aacid

Subscribers: #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D12643
2018-05-01 22:24:24 +02:00
Andre Heinecke 1de0f5465b Add support for chained / next actions
Summary:
This adds support for multiple actions following each
other through the "Next" value of Action dictionaries.

Test Plan: Activates the corresponding part of the visibilitytest.

Reviewers: #okular

Subscribers: sander, aacid

Tags: #okular

Maniphest Tasks: T8278

Differential Revision: https://phabricator.kde.org/D11609
2018-04-30 14:02:49 +02:00
Andre Heinecke bf90867c13 Add support for dynamic visibility
Summary:
This adds the hidden property to JavaScript fields and
uses it to implement support for HideAction.

Test Plan: Unit test in the next commit.

Reviewers: #okular

Subscribers: aacid

Tags: #okular

Maniphest Tasks: T8274

Differential Revision: https://phabricator.kde.org/D11596
2018-04-23 23:55:01 +02:00
Aleix Pol c325b342f3 Make some frameworks optional so okular can be built on Android
Summary:
Disables KWallet integration if there's no KWallet, KJS if there's no
KJS and KDocTools.
Here's a list of frameworks that don't work on Android:
https://cgit.kde.org/sysadmin/ci-tooling.git/tree/local-metadata/project-ignore-rules.yaml

Test Plan: Still works locally, ran Okular and Okular Mobile on Android.

Reviewers: #okular, aacid

Subscribers: aacid

Tags: #okular

Differential Revision: https://phabricator.kde.org/D12177
2018-04-16 22:41:19 +02:00
Aleix Pol 52b62306f8 Also don't use KPty code for Android
Changed the defines to something more explicit of what's going on.
2018-04-13 17:44:50 +02:00