office/okular
office/okular
1
0
Fork 0
mirror of https://invent.kde.org/graphics/okular synced 2024-10-02 14:14:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix minor EBN issues

Browse source
This commit is contained in:
Yuri Chornoivan 2018-09-01 11:25:57 +03:00
parent c04ca1fa96
commit 39b6e8147d
45 changed files with 76 additions and 67 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
conf/editannottooldialog.cpp
View file

@ -1,3 +1,12 @@
/***************************************************************************
* Copyright (C) 2012 by Fabio D'Urso <fabiodurso@hotmail.it> *
* Copyright (C) 2015 by Laurent Montel <montel@kde.org> *
* *
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
***************************************************************************/
#include "editannottooldialog.h"

2
conf/editannottooldialog.h
View file

@ -43,7 +43,7 @@ class EditAnnotToolDialog : public QDialog
ToolStamp
};
EditAnnotToolDialog( QWidget *parent = nullptr, const QDomElement &initialState = QDomElement() );
explicit EditAnnotToolDialog( QWidget *parent = nullptr, const QDomElement &initialState = QDomElement() );
~EditAnnotToolDialog();
QString name() const;
QDomDocument toolXml() const;

2
conf/widgetannottools.cpp
View file

@ -14,7 +14,7 @@
#include <klocalizedstring.h>
#include <QtWidgets/QApplication>
#include <QApplication>
#include <QHBoxLayout>
#include <QListWidget>
#include <QListWidgetItem>

6
core/action.h
View file

@ -237,7 +237,7 @@ class OKULARCORE_EXPORT ExecuteAction : public Action
/**
* The Browse action browses an url by opening a web browser or
* email client, depedning on the url protocol (e.g. http, mailto, etc.).
* email client, depending on the url protocol (e.g. http, mailto, etc.).
*/
class OKULARCORE_EXPORT BrowseAction : public Action
{
@ -247,7 +247,7 @@ class OKULARCORE_EXPORT BrowseAction : public Action
*
* @param url The url to browse.
*/
BrowseAction( const QUrl &url );
explicit BrowseAction( const QUrl &url );
/**
* Destroys the browse action.
@ -461,7 +461,7 @@ class OKULARCORE_EXPORT MovieAction : public Action
/**
* Creates a new movie action.
*/
MovieAction( OperationType operation );
explicit MovieAction( OperationType operation );
/**
* Destroys the movie action.

16
core/annotations.h
View file

@ -781,7 +781,7 @@ class OKULARCORE_EXPORT TextAnnotation : public Annotation
/**
* Creates a new text annotation from the xml @p description
*/
TextAnnotation( const QDomNode &description );
explicit TextAnnotation( const QDomNode &description );
/**
* Destroys the text annotation.
@ -1054,7 +1054,7 @@ class OKULARCORE_EXPORT GeomAnnotation : public Annotation
/**
* Creates a new geometrical annotation from the xml @p description
*/
GeomAnnotation( const QDomNode &description );
explicit GeomAnnotation( const QDomNode &description );
/**
* Destroys the geometrical annotation.
@ -1296,7 +1296,7 @@ class OKULARCORE_EXPORT InkAnnotation : public Annotation
/**
* Creates a new ink annotation from the xml @p description
*/
InkAnnotation( const QDomNode &description );
explicit InkAnnotation( const QDomNode &description );
/**
* Destroys the ink annotation.
@ -1458,7 +1458,7 @@ class OKULARCORE_EXPORT SoundAnnotation : public Annotation
/**
* Creates a new sound annotation from the xml @p description
*/
SoundAnnotation( const QDomNode &description );
explicit SoundAnnotation( const QDomNode &description );
/**
* Destroys the sound annotation.
*/
@ -1518,7 +1518,7 @@ class OKULARCORE_EXPORT MovieAnnotation : public Annotation
/**
* Creates a new movie annotation from the xml @p description
*/
MovieAnnotation( const QDomNode &description );
explicit MovieAnnotation( const QDomNode &description );
/**
* Destroys the movie annotation.
*/
@ -1565,7 +1565,7 @@ class OKULARCORE_EXPORT ScreenAnnotation : public Annotation
/**
* Creates a new screen annotation from the xml @p description
*/
ScreenAnnotation( const QDomNode &description );
explicit ScreenAnnotation( const QDomNode &description );
/**
* Destroys the screen annotation.
@ -1634,7 +1634,7 @@ class OKULARCORE_EXPORT WidgetAnnotation : public Annotation
/**
* Creates a new widget annotation from the xml @p description
*/
WidgetAnnotation( const QDomNode &description );
explicit WidgetAnnotation( const QDomNode &description );
/**
* Destroys the widget annotation.
@ -1689,7 +1689,7 @@ class OKULARCORE_EXPORT RichMediaAnnotation : public Annotation
/**
* Creates a new rich media annotation from the xml @p description
*/
RichMediaAnnotation( const QDomNode &description );
explicit RichMediaAnnotation( const QDomNode &description );
/**
* Destroys the rich media annotation.

4
core/area.h
View file

@ -448,7 +448,7 @@ class OKULARCORE_EXPORT AnnotationObjectRect : public ObjectRect
* Creates a new annotation object rectangle with the
* given @p annotation.
*/
AnnotationObjectRect( Annotation *annotation );
explicit AnnotationObjectRect( Annotation *annotation );
/**
* Destroys the annotation object rectangle.
@ -871,7 +871,7 @@ class HighlightAreaRect : public RegularAreaRect
* Creates a new highlight area rect with the coordinates of
* the given @p area.
*/
HighlightAreaRect( const RegularAreaRect *area = nullptr );
explicit HighlightAreaRect( const RegularAreaRect *area = nullptr );
/**
* The search ID of the highlight owner.

2
core/audioplayer_p.h
View file

@ -26,7 +26,7 @@ class AudioPlayer;
class AudioPlayerPrivate
{
public:
AudioPlayerPrivate( AudioPlayer * qq );
explicit AudioPlayerPrivate( AudioPlayer * qq );
~AudioPlayerPrivate();

2
core/document_p.h
View file

@ -86,7 +86,7 @@ Q_DECLARE_FLAGS(LoadDocumentInfoFlags, LoadDocumentInfoFlag)
class DocumentPrivate
{
public:
DocumentPrivate( Document *parent )
explicit DocumentPrivate( Document *parent )
: m_parent( parent ),
m_tempFile( nullptr ),
m_docSize( -1 ),

2
core/form_p.h
View file

@ -22,7 +22,7 @@ class FormField;
class FormFieldPrivate
{
public:
FormFieldPrivate( FormField::FieldType type );
explicit FormFieldPrivate( FormField::FieldType type );
virtual ~FormFieldPrivate();
void setDefault();

4
core/generator.h
View file

@ -221,7 +221,7 @@ class OKULARCORE_EXPORT Generator : public QObject
/**
* Creates a new generator.
*/
Generator(QObject* parent = nullptr, const QVariantList& args = QVariantList());
explicit Generator(QObject* parent = nullptr, const QVariantList& args = QVariantList());
/**
* Destroys the generator.
@ -781,7 +781,7 @@ class OKULARCORE_EXPORT TextRequest
/**
* Creates a new text request.
*/
TextRequest( Page *page );
explicit TextRequest( Page *page );
TextRequest();

4
core/generator_p.h
View file

@ -114,7 +114,7 @@ class PixmapGenerationThread : public QThread
Q_OBJECT
public:
PixmapGenerationThread( Generator *generator );
explicit PixmapGenerationThread( Generator *generator );
void startGeneration( PixmapRequest *request, bool calcBoundingRect );
@ -142,7 +142,7 @@ class TextPageGenerationThread : public QThread
Q_OBJECT
public:
TextPageGenerationThread( Generator *generator );
explicit TextPageGenerationThread( Generator *generator );
void endGeneration();

2
core/script/event_p.h
View file

@ -70,7 +70,7 @@ class Event
PageClose, /// < Not implemented.
};
Event(EventType type);
explicit Event(EventType type);
/** One of the defined EventTypes */
EventType eventType() const;

2
core/script/executor_kjs_p.h
View file

@ -21,7 +21,7 @@ class Event;
class ExecutorKJS
{
public:
ExecutorKJS( DocumentPrivate *doc );
explicit ExecutorKJS( DocumentPrivate *doc );
~ExecutorKJS();
void execute( const QString &script, Event *event );

2
core/textdocumentgenerator_p.h
View file

@ -115,7 +115,7 @@ class TextDocumentGeneratorPrivate : public GeneratorPrivate
friend class TextDocumentConverter;
public:
TextDocumentGeneratorPrivate( TextDocumentConverter *converter )
explicit TextDocumentGeneratorPrivate( TextDocumentConverter *converter )
: mConverter( converter ), mDocument( nullptr ), mGeneralSettings( nullptr )
{
}

2
core/textdocumentsettings.h
View file

@ -84,7 +84,7 @@ class OKULARCORE_EXPORT TextDocumentSettingsWidget : public QWidget
Q_OBJECT
public:
TextDocumentSettingsWidget( QWidget *parent = nullptr );
explicit TextDocumentSettingsWidget( QWidget *parent = nullptr );
virtual ~TextDocumentSettingsWidget();
void addRow( const QString& labelText, QWidget *widget );

4
core/textdocumentsettings_p.h
View file

@ -23,7 +23,7 @@ class TextDocumentSettingsWidgetPrivate
* @note the private class won't take ownership of the ui, so you
* must delete it yourself
*/
TextDocumentSettingsWidgetPrivate(Ui_TextDocumentSettings *ui)
explicit TextDocumentSettingsWidgetPrivate(Ui_TextDocumentSettings *ui)
: mUi(ui)
{}
@ -36,7 +36,7 @@ class TextDocumentSettingsPrivate : public QObject
Q_OBJECT
public:
TextDocumentSettingsPrivate(QObject *parent)
explicit TextDocumentSettingsPrivate(QObject *parent)
: QObject(parent)
{}

4
extensions.h
View file

@ -24,7 +24,7 @@ class BrowserExtension : public KParts::BrowserExtension
Q_OBJECT
public:
BrowserExtension(Part*);
explicit BrowserExtension(Part*);
public Q_SLOTS:
// Automatically detected by the host.
@ -39,7 +39,7 @@ class OkularLiveConnectExtension : public KParts::LiveConnectExtension
Q_OBJECT
public:
OkularLiveConnectExtension( Part *parent );
explicit OkularLiveConnectExtension( Part *parent );
// from LiveConnectExtension
bool get( const unsigned long objid, const QString &field, Type &type,

4
generators/djvu/kdjvu.h
View file

@ -157,7 +157,7 @@ class KDjVu
bool inlineText() const;
private:
TextAnnotation( miniexp_t anno );
explicit TextAnnotation( miniexp_t anno );
QSize m_size;
bool m_inlineText;
};
@ -179,7 +179,7 @@ class KDjVu
void setWidth( int width );
private:
LineAnnotation( miniexp_t anno );
explicit LineAnnotation( miniexp_t anno );
QPoint m_point2;
bool m_isArrow;
miniexp_t m_width;

2
generators/epub/epubdocument.h
View file

@ -24,7 +24,7 @@ namespace Epub {
Q_OBJECT
public:
EpubDocument(const QString &fileName);
explicit EpubDocument(const QString &fileName);
bool isValid();
~EpubDocument();
struct epub *getEpub();

2
generators/fictionbook/document.h
View file

@ -20,7 +20,7 @@ namespace FictionBook {
class Document
{
public:
Document( const QString &fileName );
explicit Document( const QString &fileName );
bool open();

2
generators/mobipocket/mobidocument.h
View file

@ -24,7 +24,7 @@ namespace Mobi {
class MobiDocument : public QTextDocument {
public:
MobiDocument(const QString &fileName);
explicit MobiDocument(const QString &fileName);
~MobiDocument();
Mobipocket::Document* mobi() const { return doc; }

2
generators/ooo/document.h
View file

@ -21,7 +21,7 @@ namespace OOO {
class Document
{
public:
Document( const QString &fileName );
explicit Document( const QString &fileName );
~Document();
bool open( const QString &password );

6
generators/ooo/formatproperty.h
View file

@ -76,7 +76,7 @@ class TextFormatProperty
{
public:
TextFormatProperty();
TextFormatProperty( const StyleInformation *information );
explicit TextFormatProperty( const StyleInformation *information );
void apply( QTextCharFormat *format ) const;
@ -155,7 +155,7 @@ class ListFormatProperty
};
ListFormatProperty();
ListFormatProperty( Type type );
explicit ListFormatProperty( Type type );
void apply( QTextListFormat *format, int level ) const;
@ -202,7 +202,7 @@ class StyleFormatProperty
{
public:
StyleFormatProperty();
StyleFormatProperty( const StyleInformation *information );
explicit StyleFormatProperty( const StyleInformation *information );
void applyBlock( QTextBlockFormat *format ) const;
void applyText( QTextCharFormat *format ) const;

2
generators/ooo/manifest.h
View file

@ -45,7 +45,7 @@ class ManifestEntry
/**
Create a new manifest entry
*/
ManifestEntry( const QString &fileName );
explicit ManifestEntry( const QString &fileName );
/**
Set the mimetype of the file.

6
generators/poppler/formfields.h
View file

@ -16,7 +16,7 @@
class PopplerFormFieldButton : public Okular::FormFieldButton
{
public:
PopplerFormFieldButton( Poppler::FormFieldButton * field );
explicit PopplerFormFieldButton( Poppler::FormFieldButton * field );
virtual ~PopplerFormFieldButton();
// inherited from Okular::FormField
@ -46,7 +46,7 @@ class PopplerFormFieldButton : public Okular::FormFieldButton
class PopplerFormFieldText : public Okular::FormFieldText
{
public:
PopplerFormFieldText( Poppler::FormFieldText * field );
explicit PopplerFormFieldText( Poppler::FormFieldText * field );
virtual ~PopplerFormFieldText();
// inherited from Okular::FormField
@ -79,7 +79,7 @@ class PopplerFormFieldText : public Okular::FormFieldText
class PopplerFormFieldChoice : public Okular::FormFieldChoice
{
public:
PopplerFormFieldChoice( Poppler::FormFieldChoice * field );
explicit PopplerFormFieldChoice( Poppler::FormFieldChoice * field );
virtual ~PopplerFormFieldChoice();
// inherited from Okular::FormField

2
generators/txt/document.h
View file

@ -19,7 +19,7 @@ namespace Txt
Q_OBJECT
public:
Document( const QString &fileName );
explicit Document( const QString &fileName );
~Document();
private:

2
generators/xps/generator_xps.h
View file

@ -110,7 +110,7 @@ class XpsFile;
class XpsHandler: public QXmlDefaultHandler
{
public:
XpsHandler( XpsPage *page );
explicit XpsHandler( XpsPage *page );
~XpsHandler();
bool startElement( const QString & nameSpace,

2
mobile/components/documentitem.cpp
View file

@ -19,7 +19,7 @@
#include "documentitem.h"
#include <QtQml>
#include <QtQml> // krazy:exclude=includes
#include <QMimeDatabase>
#include <core/document_p.h>

2
mobile/components/documentitem.h
View file

@ -169,7 +169,7 @@ class Observer : public QObject, public Okular::DocumentObserver
Q_OBJECT
public:
Observer(DocumentItem *parent);
explicit Observer(DocumentItem *parent);
~Observer();
// inherited from DocumentObserver

2
part.h
View file

@ -23,7 +23,7 @@
#include <QList>
#include <QPointer>
#include <QProcess>
#include <QtDBus>
#include <QtDBus> // krazy:exclude=includes
#include <QUrl>
#include <KCompressionDevice>

4
shell/shell.h
View file

@ -20,9 +20,9 @@
#include <kparts/readwritepart.h>
#include <QMimeType>
#include <QMimeDatabase>
#include <qaction.h>
#include <QAction>
#include <QtDBus>
#include <QtDBus> // krazy:exclude=includes
class KRecentFilesAction;
class KToggleAction;

4
ui/annotationtools.h
View file

@ -32,7 +32,7 @@ class Page;
class AnnotatorEngine
{
public:
AnnotatorEngine( const QDomElement & engineElement );
explicit AnnotatorEngine( const QDomElement & engineElement );
virtual ~AnnotatorEngine();
// enum definitions
@ -87,7 +87,7 @@ class SmoothPathEngine
: public AnnotatorEngine
{
public:
SmoothPathEngine( const QDomElement & engineElement );
explicit SmoothPathEngine( const QDomElement & engineElement );
QRect event( EventType type, Button button, double nX, double nY, double xScale, double yScale, const Okular::Page * /*page*/ ) override;

2
ui/annotationwidgets.h
View file

@ -72,7 +72,7 @@ class AnnotationWidget
Q_OBJECT
public:
AnnotationWidget( Okular::Annotation * ann );
explicit AnnotationWidget( Okular::Annotation * ann );
virtual ~AnnotationWidget();
virtual Okular::Annotation::SubType annotationType() const;

2
ui/embeddedfilesdialog.cpp
View file

@ -183,7 +183,7 @@ void EmbeddedFilesDialog::viewFile( Okular::EmbeddedFile* ef )
+ QDir::separator()
+ fileInfo.baseName()
+ ".XXXXXX"
+ (fileInfo.completeSuffix().isEmpty() ? QString("") : "." + fileInfo.completeSuffix())
+ (fileInfo.completeSuffix().isEmpty() ? QString("") : "." + fileInfo.completeSuffix()) // krazy:exclude=doublequote_chars
);
GuiUtils::writeEmbeddedFile( ef, this, *tmpFile );

2
ui/formwidgets.h
View file

@ -54,7 +54,7 @@ class FormWidgetsController : public QObject
Q_OBJECT
public:
FormWidgetsController( Okular::Document *doc );
explicit FormWidgetsController( Okular::Document *doc );
virtual ~FormWidgetsController();
void signalAction( Okular::Action *action );

2
ui/magnifierview.h
View file

@ -29,7 +29,7 @@ class MagnifierView : public QWidget, public Okular::DocumentObserver
Q_OBJECT
public:
MagnifierView( Okular::Document *document, QWidget *parent = nullptr );
explicit MagnifierView( Okular::Document *document, QWidget *parent = nullptr );
~MagnifierView();
void notifySetup( const QVector< Okular::Page * > & pages, int setupFlags ) override;

6
ui/minibar.h
View file

@ -32,7 +32,7 @@ class PagesEdit : public KLineEdit
Q_OBJECT
public:
PagesEdit( MiniBar * parent );
explicit PagesEdit( MiniBar * parent );
void setText( const QString & ) override;
protected:
@ -54,7 +54,7 @@ class PageNumberEdit : public PagesEdit
Q_OBJECT
public:
PageNumberEdit( MiniBar * parent );
explicit PageNumberEdit( MiniBar * parent );
void setPagesNumber( int pages );
private:
@ -65,7 +65,7 @@ class PageLabelEdit : public PagesEdit
{
Q_OBJECT
public:
PageLabelEdit( MiniBar * parent );
explicit PageLabelEdit( MiniBar * parent );
void setText( const QString & newText ) override;
void setPageLabels( const QVector< Okular::Page * > & pageVector );

2
ui/pageitemdelegate.h
View file

@ -17,7 +17,7 @@ class PageItemDelegate : public QItemDelegate
Q_OBJECT
public:
PageItemDelegate( QObject * parent = nullptr );
explicit PageItemDelegate( QObject * parent = nullptr );
virtual ~PageItemDelegate();
static const int PageRole = 0x000f0001;

2
ui/pageviewutils.h
View file

@ -107,7 +107,7 @@ class PageViewMessage : public QWidget
Q_OBJECT
public:
PageViewMessage( QWidget * parent );
explicit PageViewMessage( QWidget * parent );
enum Icon { None, Info, Warning, Error, Find, Annotation };
void display( const QString & message, const QString & details = QString(), Icon icon = Info, int durationMs = 4000 );

2
ui/propertiesdialog.h
View file

@ -56,7 +56,7 @@ class FontsListModel
Q_OBJECT
public:
FontsListModel( QObject * parent = nullptr );
explicit FontsListModel( QObject * parent = nullptr );
virtual ~FontsListModel();
// reimplementations from QAbstractTableModel

2
ui/sidebar.h
View file

@ -20,7 +20,7 @@ class OKULARPART_EXPORT Sidebar : public QWidget
{
Q_OBJECT
public:
Sidebar( QWidget *parent = nullptr );
explicit Sidebar( QWidget *parent = nullptr );
~Sidebar();
int addItem( QWidget *widget, const QIcon &icon, const QString &text );

2
ui/snapshottaker.h
View file

@ -21,7 +21,7 @@ class SnapshotTaker : public QObject
Q_OBJECT
public:
SnapshotTaker( const QUrl &url, QObject *parent = nullptr );
explicit SnapshotTaker( const QUrl &url, QObject *parent = nullptr );
~SnapshotTaker();
Q_SIGNALS:

2
ui/thumbnaillist.h
View file

@ -80,7 +80,7 @@ class ThumbnailsBox : public QWidget
Q_OBJECT
public:
ThumbnailsBox( QWidget * parent ) : QWidget( parent ) { QVBoxLayout *vbox = new QVBoxLayout(this); vbox->setMargin(0); vbox->setSpacing(0);}
explicit ThumbnailsBox( QWidget * parent ) : QWidget( parent ) { QVBoxLayout *vbox = new QVBoxLayout(this); vbox->setMargin(0); vbox->setSpacing(0);}
QSize sizeHint() const override { return QSize(); }
};

2
ui/toolaction.h
View file

@ -22,7 +22,7 @@ class ToolAction : public KSelectAction
Q_OBJECT
public:
ToolAction( QObject *parent = nullptr );
explicit ToolAction( QObject *parent = nullptr );
virtual ~ToolAction();
void addAction( QAction *action );

2
ui/tts.h
View file

@ -17,7 +17,7 @@ class OkularTTS : public QObject
{
Q_OBJECT
public:
OkularTTS( QObject *parent = nullptr );
explicit OkularTTS( QObject *parent = nullptr );
~OkularTTS();
void say( const QString &text );