3670836588
As discovered by @blaugold on GitHub, Instructions::Equals can give a false negative on the JIT if the GC flags in the object header are set differently. This CL changes Instructions::Equals to only compare the Instructions-specific portion of the object, namely the size_and_flags_ field and the content bytes. If those match, then the important parts of the object header match: the cid is always kInstructionsCid, as the Equals method assumes non-null instances, and the size in the object header is calculated using the content size from size_and_flags_. TEST=Manually ran failing tests after cherry picking CL 221360 on top. Bug: https://github.com/dart-lang/sdk/issues/39843 Change-Id: I25c25bbe6b1bf615d4cd923bfe871da7e929822a Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-linux-product-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221467 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com> |
||
|---|---|---|
| .dart_tool | ||
| .github | ||
| benchmarks | ||
| build | ||
| client | ||
| docs | ||
| pkg | ||
| runtime | ||
| samples | ||
| samples-dev/swarm | ||
| samples_2 | ||
| sdk | ||
| tests | ||
| third_party | ||
| tools | ||
| utils | ||
| .clang-format | ||
| .gitattributes | ||
| .gitconfig | ||
| .gitignore | ||
| .gn | ||
| .mailmap | ||
| .packages | ||
| .style.yapf | ||
| .vpython | ||
| AUTHORS | ||
| BUILD.gn | ||
| CHANGELOG.md | ||
| codereview.settings | ||
| CONTRIBUTING.md | ||
| DEPS | ||
| LICENSE | ||
| PATENT_GRANT | ||
| PRESUBMIT.py | ||
| README.dart-sdk | ||
| README.md | ||
| sdk_args.gni | ||
| SECURITY.md | ||
| WATCHLISTS | ||
Dart
A client-optimized language for fast apps on any platform
Dart is:
-
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
-
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
-
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
-
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
-
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
License & patents
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Using Dart
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
Building Dart
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
Contributing to Dart
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.