languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-08 12:06:26 +00:00
Code Issues Projects Releases Wiki Activity

[build] Fix dart2js_compile action dependencies

Browse Source 
Add dependency on unsound platform files.

This should fix the following flaky CQ failure:

    FAILED: dev_compiler/build/web/dart_stack_trace_mapper.js
    Error: Input file not found: dart2js_platform_unsound.dill.
    ...

Compilation action tries to read the unsound version of the platform,
but the GN template only specifies the dependency on the sound platform
making build non-hermetic.

Change-Id: If13431b1682e35a419cb6865c38e2b69348751f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221084
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
This commit is contained in:
Vyacheslav Egorov 2021-11-24 13:10:11 +00:00 committed by commit-bot@chromium.org
parent 71c9c2cd83
commit a860e69f57
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
utils/dartdevc/BUILD.gn
View File

@ -49,11 +49,16 @@ template("dart2js_compile") {
abs_output = rebase_path(out)
prebuilt_dart_action(target_name) {
deps = invoker.deps + [ "../compiler:compile_dart2js_platform" ]
deps = invoker.deps + [
"../compiler:compile_dart2js_platform",
"../compiler:compile_dart2js_platform_unsound",
]
inputs = [
"$root_out_dir/dart2js_platform.dill",
"$root_out_dir/dart2js_platform_unsound.dill",
"$root_out_dir/dart2js_outline.dill",
"$root_out_dir/dart2js_outline_unsound.dill",
]
outputs = [ out ]