languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-03 00:45:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove references to dartfmt in various comments and docs.

Browse source 
Change-Id: I02112ce2920d71f84ce4808c13a62e1a1765d83f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215181
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This commit is contained in:
Robert Nystrom 2021-10-01 00:56:14 +00:00 committed by commit-bot@chromium.org
parent 8e6f639a7e
commit 0ea8347576
13 changed files with 21 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
PRESUBMIT.py
View file

@ -127,8 +127,8 @@ def _CheckDartFormat(input_api, output_api):
def HasFormatErrors(filename: str = None, contents: str = None):
# Don't look for formatting errors in multitests. Since those are very
# sensitive to whitespace, many cannot be formatted with dartfmt without
# breaking them.
# sensitive to whitespace, many cannot be reformatted without breaking
# them.
if filename and filename.endswith('_test.dart'):
with open(filename) as f:
contents = f.read()
@ -179,7 +179,7 @@ def _CheckDartFormat(input_api, output_api):
lineSep = " ^\n"
return [
output_api.PresubmitError(
'File output does not match dartfmt.\n'
'File output does not match dart format.\n'
'Fix these issues with:\n'
'%s format %s%s' %
(dart, lineSep, lineSep.join(unformatted_files)))

4
tests/corelib/symbol_arbitrary_string_test.dart
View file

@ -2,9 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// Note that this library violates the formatting provided by `dartfmt` in
// Note that this library violates the formatting provided by `dart format` in
// a few locations, to verify that `"""...""""z"` can be parsed as two
// consecutive strings, `dartfmt` will insert whitespace before `"z"`.
// consecutive strings, `dart format` will insert whitespace before `"z"`.
import 'package:expect/expect.dart';

2
tests/language/async_star/yield_statement_context_test.dart
View file

@ -51,7 +51,7 @@ void main() {
test('two labels on same line', () {
f() async* {
// DO NOT RUN dartfmt on this file. The labels should be on the same.
// DO NOT RUN dart format on this file. The labels should be on the same.
// line. Originally VM issue #2238.
label1: label2: yield 0;
}

6
tests/language/redirecting/factory_bounds_test.dart
View file

@ -11,7 +11,7 @@ class Baz<T> {}
class Foobar<T> implements Foo<T> {}
class Bar<
T // A comment to prevent dartfmt from joining the lines.
T // A comment to prevent dart format from joining the lines.
extends Foo<T> //# 00: ok
extends Baz<Foo<T>> //# 01: compile-time error
extends Foobar<T> //# 02: compile-time error
@ -21,7 +21,7 @@ class Bar<
}
class Qux<
T // A comment to prevent dartfmt from joining the lines.
T // A comment to prevent dart format from joining the lines.
extends Foo<T> //# 00: continued
extends Foo<T> //# 01: continued
extends Foo<T> //# 02: continued
@ -33,7 +33,7 @@ class Qux<
class A<T extends int> {
factory A() = B<
T // A comment to prevent dartfmt from joining the lines.
T // A comment to prevent dart format from joining the lines.
, int //# 03: compile-time error
, String //# 04: ok
>;

2
tests/language_2/async_star/yield_statement_context_test.dart
View file

@ -53,7 +53,7 @@ void main() {
test('two labels on same line', () {
f() async* {
// DO NOT RUN dartfmt on this file. The labels should be on the same.
// DO NOT RUN dart format on this file. The labels should be on the same.
// line. Originally VM issue #2238.
label1: label2: yield 0;
}

6
tests/language_2/redirecting/factory_bounds_test.dart
View file

@ -13,7 +13,7 @@ class Baz<T> {}
class Foobar<T> implements Foo<T> {}
class Bar<
T // A comment to prevent dartfmt from joining the lines.
T // A comment to prevent dart format from joining the lines.
extends Foo<T> //# 00: ok
extends Baz<Foo<T>> //# 01: compile-time error
extends Foobar<T> //# 02: compile-time error
@ -23,7 +23,7 @@ class Bar<
}
class Qux<
T // A comment to prevent dartfmt from joining the lines.
T // A comment to prevent dart format from joining the lines.
extends Foo<T> //# 00: continued
extends Foo<T> //# 01: continued
extends Foo<T> //# 02: continued
@ -35,7 +35,7 @@ class Qux<
class A<T extends int> {
factory A() = B<
T // A comment to prevent dartfmt from joining the lines.
T // A comment to prevent dart format from joining the lines.
, int //# 03: compile-time error
, String //# 04: ok
>;

2
tests/standalone/dwarf_stack_trace_invisible_functions_test.dart
View file

@ -20,7 +20,7 @@ const int LINE_E = 56;
@pragma("vm:prefer-inline")
bar() {
// Keep the 'throw' and its argument on separate lines.
throw // force linebreak with dartfmt // LINE_A
throw // force linebreak with dart format // LINE_A
"Hello, Dwarf!";
}

2
tests/standalone/dwarf_stack_trace_obfuscate_test.dart
View file

@ -14,7 +14,7 @@ import 'dwarf_stack_trace_test.dart' as base;
@pragma("vm:prefer-inline")
bar() {
// Keep the 'throw' and its argument on separate lines.
throw // force linebreak with dartfmt
throw // force linebreak with dart format
"Hello, Dwarf!";
}

2
tests/standalone/dwarf_stack_trace_test.dart
View file

@ -14,7 +14,7 @@ import 'package:expect/expect.dart';
@pragma("vm:prefer-inline")
bar() {
// Keep the 'throw' and its argument on separate lines.
throw // force linebreak with dartfmt
throw // force linebreak with dart format
"Hello, Dwarf!";
}

2
tests/standalone_2/dwarf_stack_trace_invisible_functions_test.dart
View file

@ -22,7 +22,7 @@ const int LINE_E = 58;
@pragma("vm:prefer-inline")
bar() {
// Keep the 'throw' and its argument on separate lines.
throw // force linebreak with dartfmt // LINE_A
throw // force linebreak with dart format // LINE_A
"Hello, Dwarf!";
}

2
tests/standalone_2/dwarf_stack_trace_obfuscate_test.dart
View file

@ -16,7 +16,7 @@ import 'dwarf_stack_trace_test.dart' as base;
@pragma("vm:prefer-inline")
bar() {
// Keep the 'throw' and its argument on separate lines.
throw // force linebreak with dartfmt
throw // force linebreak with dart format
"Hello, Dwarf!";
}

2
tests/standalone_2/dwarf_stack_trace_test.dart
View file

@ -16,7 +16,7 @@ import 'package:expect/expect.dart';
@pragma("vm:prefer-inline")
bar() {
// Keep the 'throw' and its argument on separate lines.
throw // force linebreak with dartfmt
throw // force linebreak with dart format
"Hello, Dwarf!";
}

4
tools/sdks/README
View file

@ -7,6 +7,6 @@ We use the x64 build as the default on Linux, Mac and Windows. Builds for Linux
on ARM and ARM64 are also provided.
To upload new versions of these CIPD packages, run "./update.sh" in this
directory. Because these SDKs are used for the presubmit dartfmt check on
changed files, they may need to be updated often when dartfmt is changing
directory. Because these SDKs are used for the presubmit dart format check on
changed files, they may need to be updated often when dart format is changing
rapidly. Access to the project-dart-admins Luci auth group is required to do so.