languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
39404 commits 11 branches 6005 tags 1.4 GiB
Commit graph

39404 commits

This branch
This branch
All branches
Author SHA1 Message Date
Florian Loitsch eaeb260244 Better error-message when bind fails. 
See #26790.

R=sgjesse@google.com

Committed: 34aed6a08b

Reverted: a1005bad7e

Committed: 8c4954492f

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: 5ebcd3cda0
 2016-08-03 22:44:28 +02:00
Ryan Macnak ecbf3f7b31 Disable canonical verifier for precompiled. 
Issue #27003

TBR=asiva@google.com

Review URL: https://codereview.chromium.org/2201163004 .
 2016-08-03 13:43:06 -07:00
Konstantin Shcheglov 6cceb72ea7 Don't report removed sources as changed in CacheConsistencyValidatorImpl. 
Also I believe we don't need this check anymore.
context.getLibrariesContaining(source).isEmpty &&
context.getLibrariesDependingOn(source).isEmpty)

1. It was not used in applyChanges(), which could probably cause losing
some dependencies.

2. Since https://codereview.chromium.org/2172143003 we record that
there are dependencies on the removed, so not existing, source. So,
when the source is added again, _sourceAvailable() will invalidate
its CONTENT and the whole transitive closure of its users.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2209493003 .
 2016-08-03 13:30:09 -07:00
Brian Wilkerson 9169baca21 Attempt to fix failures under Windows 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2209873002 .
 2016-08-03 13:26:40 -07:00
Zachary Anderson 0e6f087942 Clear the error bit after reading the default trusted certs 
fixes #26954

R=whesse@google.com

Review URL: https://codereview.chromium.org/2211453002 .
 2016-08-03 12:24:35 -07:00
Stan Manilov 3237d789d1 Disallow assigning null to non-nullable variables 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2200263004 .
 2016-08-03 11:47:10 -07:00
John McCutchan 133c087cdb Become the old E.values into the new E.values 
Fixes https://github.com/dart-lang/sdk/issues/26988

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2199173002 .
 2016-08-03 10:46:40 -07:00
Brian Wilkerson 90267bbfe4 Guard against NPE 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2200223002 .
 2016-08-03 10:38:13 -07:00
Brian Wilkerson e2f74fc0a3 SDK implementations based on file_system rather than java_io 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2207953002 .
 2016-08-03 10:25:20 -07:00
Konstantin Shcheglov 30b2401907 Issue 25666. Add test for shadowing of a superclass member from other library. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25666

Review URL: https://codereview.chromium.org/2204263002 .
 2016-08-03 10:16:36 -07:00
Ryan Macnak 5ebcd3cda0 Revert "Better error-message when bind fails." 
This reverts commit 8c4954492f.

This change broke the Android build.

Review URL: https://codereview.chromium.org/2201183004 .
 2016-08-03 09:54:57 -07:00
Ryan Macnak 8c87121afe Revert "Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a function." 
This reverts commit 908309fe6d.

Review URL: https://codereview.chromium.org/2199263004 .
 2016-08-03 09:34:10 -07:00
Konstantin Shcheglov 6f37f85215 Stress test for comparing analysis performed in two AnalysisContext instances with different options. 
It takes a Git repository, a folder in this repository and creates two
AnalysisContext instances - with experimental and with stable
analysis options. Then for each Git revision it applies the changes
to Dart files in the folder to both contexts, analyzes and compares
analysis cache results.

The current implementation sets "finerGrainedInvalidation" to true for the experimental context.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2206783002 .
 2016-08-03 09:06:59 -07:00
John Messerly 4c07f7224c fixes #26993, constant evaluation gets wrong type 
like the todo suggested, we need to update staticElement too

R=leafp@google.com

Review URL: https://codereview.chromium.org/2207473004 .
 2016-08-03 08:50:58 -07:00
John McCutchan af46b9dc55 Fix typo in status file 
BUG=

Review URL: https://codereview.chromium.org/2203163003 .
 2016-08-03 08:34:11 -07:00
John Messerly 0fe54a637a fix #26990, incorrect substitution of upper bound 
We were handling the "extends" clause too early, when we did not have enough information to correctly substitute it. So we tried to substitute later on, but this breaks cases where we (correctly) inferred using the argument types.

The fix is to move the "extends" clause handling to a place where we have the inferred types for our preceding type variables available.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2205993002 .
 2016-08-03 08:31:14 -07:00
Sigmund Cherem 9aee504527 Remove unnecessary imports to tree.dart 
R=het@google.com

Review URL: https://codereview.chromium.org/2203013003 .
 2016-08-03 08:27:50 -07:00
John McCutchan 6a23dda952 Mark double_pow_test as failing with a runtime error for reload 
BUG=

Review URL: https://codereview.chromium.org/2209683003 .
 2016-08-03 08:03:16 -07:00
Florian Loitsch 8c4954492f Better error-message when bind fails. 
See #26790.

R=sgjesse@google.com

Committed: 34aed6a08b

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: a1005bad7e
 2016-08-03 16:27:48 +02:00
Florian Loitsch a1005bad7e Revert "Better error-message when bind fails." 
This reverts commit 34aed6a08b.

Review URL: https://codereview.chromium.org/2210523002 .
 2016-08-03 15:47:15 +02:00
Florian Loitsch 873c6e4688 Don't close stdio/stderr when shutting down. 
Fixes #26872.

BUG= http://dartbug.com/26872
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2204953002 .
 2016-08-03 15:30:30 +02:00
Florian Loitsch 34aed6a08b Better error-message when bind fails. 
See #26790.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2205913003 .
 2016-08-03 15:29:41 +02:00
William Hesse 17536f15f7 Update changelog with stable patch 1.18.1 
BUG=
R=mit@google.com

Review URL: https://codereview.chromium.org/2202923004 .
 2016-08-03 13:33:41 +02:00
Konstantin Shcheglov 77590f5ab1 Use unitMember/classMember/parameter names instead of offsets in index. 
This fixes index for cases when element offset might change without
causing resolution of its users, e.g. incremental changes (like
inserting a whitespace) and incremental invalidation.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2203173002 .
 2016-08-02 23:18:29 -07:00
John McCutchan a547fd531c Propagate UnhandledExceptionErrors returned by the tag handler in Reload 
TBR=rmacnak

Review URL: https://codereview.chromium.org/2205573005 .
 2016-08-02 19:08:45 -07:00
John McCutchan 35146c688e Fix reload handling of unwind / stackoverflow errors 
BUG=

Review URL: https://codereview.chromium.org/2201283002 .
 2016-08-02 18:27:35 -07:00
John McCutchan b8500cdd2d More reload status and bug fixes 
TBR=rmacnak

Review URL: https://codereview.chromium.org/2209513003 .
 2016-08-02 17:26:13 -07:00
Jacob Richman eb2b2bcda9 DEPS AutoUpdate: dev_compiler 
commit 5fc554825310aecff61898172e2451e8cec26f77
Author: Brenna Milligan <bmilligan@google.com>

    Updated sdk
 2016-08-02 17:19:41 -07:00
Jacob Richman 8230749e11 DEPS AutoUpdate: dev_compiler 
commit db950878eded7ab400c71f4a7b0c9cfd66b06fd3
Author: Brenna Milligan <bmilligan@google.com>

    Get rid of library proto information for debugger libraries
 2016-08-02 17:09:20 -07:00
Ryan Macnak 908309fe6d Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a function. 
Allows dropping const constructors never used as non-const constructors nor roots.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2203843003 .
 2016-08-02 16:30:57 -07:00
John McCutchan 24b6264c13 Silence service isolate startup error unless --trace-service is enabled 
Fixes https://github.com/flutter/flutter/issues/5186

Review URL: https://codereview.chromium.org/2205953003 .
 2016-08-02 16:19:24 -07:00
John McCutchan a6114c23cd Simplify reload error reporting 
- [x] Rationalize the load failure code path.
- [x] Remove support for reload to be aborted via a callback.
- [x] If a reload fails due to an unwind error, ignore it as the isolate is dead anyway.
- [x] Move more allocations into the zone.

Review URL: https://codereview.chromium.org/2208553002 .
 2016-08-02 16:11:30 -07:00
Ryan Macnak cdae2f2783 Revert "Also attempt to symbolize dart frames in Profiler::DumpStackTrace." 
This reverts commit d215693513.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2201953003 .
 2016-08-02 15:14:43 -07:00
Jacob Richman 375e5dd94f DEPS AutoUpdate: dev_compiler 
commit 930e1bd50d27e5156b137cbf263fec509812e3ee
Author: Vijay Menon <vsm@google.com>

    Fix wrt analyzer tip

commit 2699745b635dcb626ba81eb0f412092ab1143584
Author: Vijay Menon <vsm@google.com>

    Test against dev version of analyzer on travis
 2016-08-02 14:45:17 -07:00
Matthias Hausner 478e0db389 Eliminate remaining case of ambiguous context level info 
When generating the scopes in an await-for loop, make sure the scope
of the loop block is a proper sub-range of the block surrounding
the loop.

This eliminates the last case where the compiler generated context
info of the same range, but with contradicting context level info.

BUG=26941
R=regis@google.com

Review URL: https://codereview.chromium.org/2201203002 .
 2016-08-02 14:44:29 -07:00
Carlo Bernaschina bd79732101 Converted Observatory error-ref element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2202943002 .
 2016-08-02 13:51:22 -07:00
Jacob Richman cdb317d88b DEPS AutoUpdate: dev_compiler 
commit 1a946b210f9275a1dda1a79969f5dabdc8b7784b
Author: Vijay Menon <vsm@google.com>

    Remove source file check
 2016-08-02 13:43:27 -07:00
Stan Manilov 6cafcbb87a Add non-null types list to StrongModeOptions 
There two tests for the list: if it's empty the behaviour should be as
before; if it's not then there should be an analyzer error. The latter
test is marked as failing, as the list is not used internally yet.

Based on 9e124ba8d4 .

BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2205743002 .
 2016-08-02 13:38:10 -07:00
Zachary Anderson e476e00ca6 Fuchsia: Use low-level prng call, add test, update test runner. 
There is now a syscall for getting cryptographically secure random bytes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2204523002 .
 2016-08-02 13:18:37 -07:00
Zachary Anderson 081718c198 Fuchsia Fix FindCodeObject test. 
It can't handle having the large array on the stack.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2202023007 .
 2016-08-02 13:10:45 -07:00
Konstantin Shcheglov a708585164 Don't report DeltaResult.KEEP_CONTINUE results as invalidated. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2204623004 .
 2016-08-02 12:59:49 -07:00
John McCutchan 757b7d094c Revert "Fix NativeMessageHandler leak" 
This reverts commit 425efb9808.

BUG=

Review URL: https://codereview.chromium.org/2207663002 .
 2016-08-02 11:33:12 -07:00
John McCutchan 425efb9808 Fix NativeMessageHandler leak 
Fixes #27002

R=zra@google.com

Review URL: https://codereview.chromium.org/2200903002 .
 2016-08-02 11:08:18 -07:00
John McCutchan 268082769b Initial status file updates for $hot_reload_rollback 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2207653002 .
 2016-08-02 11:03:44 -07:00
John McCutchan ade4a6b111 Fix top level parse error reload test 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2200233002 .
 2016-08-02 10:58:16 -07:00
Ryan Macnak d2f91a5229 Fix clang builds. 
Review URL: https://codereview.chromium.org/2203733004 .
 2016-08-02 10:27:29 -07:00
Ryan Macnak 25759da7bf Narrow the scope of writable code to the forwarding phase of become instead of the whole isolate reload scope. 
Other operations during an isolate reload scope may create new protected code or re-protect old code.

Also, only make code writable on IA32.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2207643002 .
 2016-08-02 10:19:35 -07:00
Jacob Richman 27e59484ea DEPS AutoUpdate: dev_compiler 
commit c6f1ea6e6ab0f17afe335f4b59ed9719235ee14a
Author: Brenna Milligan <bmilligan@google.com>

    Deprecation of ClassMetadata wrapper for Class formatters so a stand-alone class is recognizable.
 2016-08-02 09:46:40 -07:00
John McCutchan 059470cf85 Make all reload zone allocations use the same zone 
- [x] Use a single outer zone for all zone allocations done during a reload. This fixes an issue where we were allocating  objects in different zones that were destroyed before we expected them to be.
- [x] Rename some methods.
- [x] Made most methods on IsolateReloadContext private.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2201093002 .
 2016-08-02 09:36:46 -07:00
Jacob Richman a10977d400 Script to automate keeping ddc dep in sync. 
BUG=
R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2200973002 .
 2016-08-02 09:25:17 -07:00