Commit graph

39404 commits

Author SHA1 Message Date
Lars Bak a4a314251b Added use of from_.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2183703003 .
2016-07-26 11:22:40 -07:00
Lars Bak 293c6116e9 Implemented schema change for the isolate reload operation.
I'll add more tests to isolate_reload_test.cc while waiting for the first round of comments.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2179983002 .
2016-07-26 11:13:28 -07:00
pq 9f424fa9d5 Remove duplicated import.
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2181423002 .
2016-07-26 10:56:22 -07:00
Konstantin Shcheglov f4b1d502f3 Issue 26747. Report HintCode.UNDEFINED_SHOWN_NAME, but not HintCode.UNUSED_SHOWN_NAME for unresolved shown names.
R=pquitslund@google.com, brianwilkerson@google.com, srawlins@google.com
BUG= https://github.com/dart-lang/sdk/issues/26747

Review URL: https://codereview.chromium.org/2182593004 .
2016-07-26 10:36:29 -07:00
Ryan Macnak 708334c614 DBC: Fix reading locals out of a deopt frame.
R=zra@google.com

Review URL: https://codereview.chromium.org/2176413003 .
2016-07-26 10:36:07 -07:00
Konstantin Shcheglov 4211fb7525 Remove unused code from limited invalidation.
We now perform the whole cache visits to gather changed elements,
so there is no need in the limited in-the-same-unit updates.

R=pquitslund@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2185713002 .
2016-07-26 10:28:01 -07:00
Jacob Richman a711a35021 Fix missing line for js_util in dart_server.platform
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2181403002 .
2016-07-26 10:26:29 -07:00
pq 065238943a Associate excludes with context data.
A step towards centralizing file exclusion handling (which is currently duplicated by all analyzer clients).

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2183003003 .
2016-07-26 10:24:39 -07:00
Stephen Adams 94df5a0c24 dart2js: Avoid empty else clauses in generators.
R=sigurdm@google.com

Committed: a02c5798a4

Review URL: https://codereview.chromium.org/1916863002 .

Reverted: 803826256d
2016-07-26 09:58:34 -07:00
Zachary Anderson 9eca0e5714 DBC: Fix 32-bit build
Review URL: https://codereview.chromium.org/2178413002 .
2016-07-26 07:50:54 -07:00
Zachary Anderson e14263a09a Remove duplicate entries from a .gypi file
+cbernaschina@google.com FYI

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2179843003 .
2016-07-26 07:37:23 -07:00
John McCutchan 50c141d298 Mark closure identity test as pass, fail for reload bots
BUG=

Review URL: https://codereview.chromium.org/2181233003 .
2016-07-26 06:38:06 -07:00
Konstantin Shcheglov cc290c1dc0 Fix for false positive in field (not-)overriding.
Fields can also override setters.

R=pquitslund@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2174423005 .
2016-07-25 22:49:01 -07:00
Jacob Richman 31f1f9caf3 TBR. Shouldn't have referenced JSObject in dart2js. Accidentally left it in porting code from dartium.
BUG=

Review URL: https://codereview.chromium.org/2186433002 .
2016-07-25 18:55:31 -07:00
Stephen Adams 803826256d Revert "dart2js: Avoid empty else clauses in generators."
BUG=

Review URL: https://codereview.chromium.org/2177403003 .
2016-07-25 18:53:32 -07:00
Stephen Adams a02c5798a4 dart2js: Avoid empty else clauses in generators.
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1916863002 .
2016-07-25 18:43:16 -07:00
Jacob Richman 9648db46be TBR. Add back line that should not have been removed.
BUG=

Review URL: https://codereview.chromium.org/2179253002 .
2016-07-25 17:53:27 -07:00
Konstantin Shcheglov 7808f167ec Issue 26787. Report HintCode.OVERRIDE_ON_NON_OVERRIDING_GETTER for non-overriding fields.
R=pquitslund@google.com, brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26787

Review URL: https://codereview.chromium.org/2182773002 .
2016-07-25 15:02:27 -07:00
Konstantin Shcheglov f8c32c5ea1 Issue 26860. Report CompileTimeErrorCode.FIELD_INITIALIZER_OUTSIDE_CONSTRUCTOR for parameters of function typed constructor parameters.
R=pquitslund@google.com, brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26860

Review URL: https://codereview.chromium.org/2178123003 .
2016-07-25 14:56:47 -07:00
Jacob Richman bacd980554 Fix sdk version constraint for pkg:js 0.6.1
BUG=
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/2175423004 .
2016-07-25 14:49:13 -07:00
Carlo Bernaschina a3f7f85a6e Using TargetMock during vm-connect-target tests
TBR=johnmccutchan@google.com,rmacnak@google.com

Review URL: https://codereview.chromium.org/2179993002 .
2016-07-25 14:42:45 -07:00
Siva Annamalai bd1895017b Add a verification step which iterates over the heap and verifies that all canonical objects are consistent (i.e canonicalizing the object returns the object).
Review URL: https://codereview.chromium.org/2160953002 .
2016-07-25 14:35:13 -07:00
Zachary Anderson d279392430 DBC: More Load/Store Indexed variants, A few more math instructions.
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2181713002 .
2016-07-25 13:40:37 -07:00
John McCutchan d0ebc78d68 Peturb the reload points on the reload bot
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2183533002 .
2016-07-25 13:34:04 -07:00
Paul Berry f02a7aa3f6 Roll dev_compiler to version 108f2a2a03b1926e640013f3244df625b42ec380.
This brings in the fix for
https://github.com/dart-lang/dev_compiler/issues/606, which allows the
extension for summaries to be specified using the "--summary-extension"
option.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2180633002 .
2016-07-25 13:22:26 -07:00
Jacob Richman 410cde6023 Fix analyzer warnings in js_util_test, skip js_util_test in csp mode and baseline expectations for analyze_library.status
Update pkg/js CHANGELOG.md to address comment from previous CL.

BUG=

Review URL: https://codereview.chromium.org/2179153002 .
2016-07-25 13:20:25 -07:00
Paul Berry eb7f2d6fcc Issue a strong mode warning for type inference that is unsafe with AST-based summaries.
See #26947 for details.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2176693003 .
2016-07-25 13:18:15 -07:00
Carlo Bernaschina 53c315a095 Removed onPopState event test from vm_connect_target tests
TBR=johnmccutchan@google.com,rmacnak@google.com

Review URL: https://codereview.chromium.org/2177843005 .
2016-07-25 13:12:18 -07:00
Konstantin Shcheglov dd18f93154 Issue 26926. Don't search hierarchy for static class members.
R=pquitslund@google.com
BUG= https://github.com/dart-lang/sdk/issues/26926

Review URL: https://codereview.chromium.org/2176173004 .
2016-07-25 11:36:52 -07:00
Devon Carew e0e96ad99a Fix some markdown issues in library docs (related to https://github.com/dart-lang/dartdoc/issues/968).
BUG=
R=keertip@google.com

Review URL: https://codereview.chromium.org/2175293004 .
2016-07-25 11:01:27 -07:00
Carlo Bernaschina a2b7cf9067 Removed Dead Code
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2176103002 .
2016-07-25 10:08:59 -07:00
Carlo Bernaschina c6d346d692 Converted Observatory isolate-ref element
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2178643002 .
2016-07-25 10:00:09 -07:00
Jacob Richman 96ca5db7e5 Add JSNative utility class with static methods methods to efficiently manipulate typed JSInterop objects in cases where the member name is not known statically. These methods would be extension methods on JSObject if Dart supported extension methods. Update package js to export these methods. Implement in Dart2JS. Implement JS$ in dart2js.
BUG=
R=alanknight@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2150313003 .
2016-07-25 09:59:01 -07:00
Carlo Bernaschina f5e157f7d0 Converted Observatory library-nav-menu element
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2164903003 .
2016-07-25 09:36:17 -07:00
Ryan Macnak 2c7983a1d1 vm-service: Include pauseEvent even when running without debugger support.
Pausing the isolate at event boundries, such as --pause-isolates-on-start, doesn't require debugger support.

Fix crash in getStack RPC when running the JIT with --support-debugger=false.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2180613002 .
2016-07-25 09:24:30 -07:00
Johnni Winther 6549cd24af Split serialization tests further
+ add helpers to compute the split for reuse between tests.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2162053005 .
2016-07-25 10:36:37 +02:00
Carlo Bernaschina 4dccbcaa0f Revert "Use Timer and not AnimationFrame during Observatory UI tests"
This reverts commit ebbeff3d2c.

TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2173373002 .
2016-07-24 16:11:32 -07:00
Carlo Bernaschina ebbeff3d2c Use Timer and not AnimationFrame during Observatory UI tests
TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2176093002 .
2016-07-24 15:11:14 -07:00
Carlo Bernaschina 61e34b244b Converted Observatory nav-notify element
Still writing tests.

R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2167053002 .
2016-07-24 12:54:04 -07:00
Stephen Adams 5923966da3 Feature-detect browser for assignment to __proto__.
Assigning to __proto__ is a fast way to stitch together a number of
object literals into a prototype chain without copying all the
properties.

Unfortunately this leads to very slow execution on Firefox (and
jsshell).  So now we feature-detect Chrome (and d8) since that is the
only browser we know currently can use the 'fast' startup path without
penalizing subsequent performance.

This speeds up some jsshell benchmarks by 30%.

R=het@google.com

Review URL: https://codereview.chromium.org/2180533002 .
2016-07-23 11:42:24 -07:00
Konstantin Shcheglov 7e54c880df Fix incremental element builder for added enums.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2175093002 .
2016-07-23 09:43:54 -07:00
Konstantin Shcheglov 091b605e89 Fix for recording dependency when the user is recorder before the provider.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2172143003 .
2016-07-23 09:40:48 -07:00
Carlo Bernaschina a66cee26bd Converted Observatory class-nav-menu element
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2165913004 .
2016-07-22 17:22:50 -07:00
Carlo Bernaschina d2a5586289 Converted Observatory vm-connect-target element
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2169313002 .
2016-07-22 17:04:43 -07:00
Carlo Bernaschina b730ee7161 Fixed automatic Merge error with vm-nav-menu branch
TBR=rmacnak@google.com

Review URL: https://codereview.chromium.org/2177643003 .
2016-07-22 16:30:28 -07:00
Florian Schneider 8cd73fd94c Revert "Add new atomic operations and use them in two places."
This reverts commit 27863288db.

Cross ARM and Windows build failing.

TBR=rmacnak@google.com,

Review URL: https://codereview.chromium.org/2178693002 .
2016-07-22 15:54:24 -07:00
Florian Schneider 27863288db Add new atomic operations and use them in two places.
1. Setting the IC data array.  This may have caused corrupt IC data seen by the
 background compiler when cloning IC data.

2. Reading the thread_interrupt_disabled_ flag. This was reported as a race with TSAN.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2176803003 .
2016-07-22 15:40:54 -07:00
Carlo Bernaschina e71c000ce4 Converted Observatory vm-nav-menu element
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2170723002 .
2016-07-22 15:08:05 -07:00
Carlo Bernaschina 3ccc1f337f Converted Observatory isolate-nav-menu element
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2168463004 .
2016-07-22 14:27:34 -07:00
Zachary Anderson b0503ad81c Fix build
Review URL: https://codereview.chromium.org/2173223002 .
2016-07-22 14:07:07 -07:00