UPDATE (1/3): blocked on a new analyzer roll (details: https://github.com/dart-lang/linter/issues/1927)
UPDATE (1/8): updated to 0.1.108
Change-Id: I4fc825c5019fee05b4d9e1ec38bd50f9044f42dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130081
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
- Remove the define DART_NO_SNAPSHOT in all the build configs
- Remove all conditional code under DART_NO_SNAPSHOT
Change-Id: Ia01d09de7c4b1813a5e172a630950e637e476713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130566
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Display progress when loading a snapshot from a file.
Change-Id: I6802998308c0b6c552ffea76439fe18edd34c99c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130460
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Two renames, to make the implementation more closely match
https://github.com/dart-lang/language/pull/763:
- typesOfInterest -> tested
- promotion chain -> promoted types
Change-Id: If2c0d72c81bee45ef94fc4fb04000f5c9ed84f26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130570
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This addresses a nuisance warning when publishing the package.
See https://github.com/dart-lang/sdk/issues/40007.
Change-Id: I7ba813a827af08033c7884153533cb19aa8e3211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130624
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Previously, parameter TypeCheck was applied to the joined value of a
parameter variable which may include assignments in the method body.
After this change, parameter TypeCheck is only applied to the incoming
value. This also removes duplicate management of variables and variable
joins.
Change-Id: I9a8205a778aced7b0ea8c51c83e48ae485315221
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130561
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
_fe_analyzer_shared is published on pub so it isn't appropriate for it
to use package:expect (which isn't published at all). All we were
using it for was a few string equality checks; simply using operator==
and throwing an exception is an adequate replacement.
If, in the future, we decide that we really need the additional
functionality provided by package:expect, we can always convert the
test to use package:test, and then make use of the `expect` method
provided by package:test.
Partially addresses https://github.com/dart-lang/sdk/issues/40007.
Change-Id: Ib7827db0cdb480feacc454a3aa660ea4c6e7cfd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130623
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Object -> Object? in the NNBD fork.
Change-Id: Id17827327f77d61266f1a478abb735348dbc7312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130564
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Change-Id: I0dc03d6dd58c672c843936dc78fd958608ddef35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130701
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This supports skipping tests per configuration, for instance to add
nnbd-only tests and skip these in non-nnbd configurations.
Change-Id: I7eaebaa16d67129ce60cffa3594c766ff5e5bc66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130376
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
This reverts commit 4b5d757bea.
Reason for revert: This intentionally failing test should have been reverted immediately, after verifying that it was detected by the CI.
Original change's description:
> Reland "Reland "[infra] Add failing test to test CI systems and approvals workflow""
>
> This reverts commit 84a4bbcabc.
>
> Reason for revert: Another try to land, to get more logging data.
>
> Original change's description:
> > Revert "Reland "[infra] Add failing test to test CI systems and approvals workflow""
> >
> > This reverts commit c716068538.
> >
> > Reason for revert: Trying again to diagnose failure to copy approvals.
> >
> > Original change's description:
> > > Reland "[infra] Add failing test to test CI systems and approvals workflow"
> > >
> > > This reverts commit 25def20f5d.
> > >
> > > Reason for revert: Retrying, now that we are copying CQ approvals for all commits in the blamelist of a builder.
> > >
> > > Original change's description:
> > > > Revert "[infra] Add failing test to test CI systems and approvals workflow"
> > > >
> > > > This reverts commit e578eeb235.
> > > >
> > > > Reason for revert: The reverted commit is a test of the new approvals UI for tryjobs and the CI. It includes an intentionally failing test, that we now remove again.
> > > >
> > > > Original change's description:
> > > > > [infra] Add failing test to test CI systems and approvals workflow
> > > > >
> > > > > The failing test lib_2/collection/failing_list_test.dart is added,
> > > > > which imports dart:io. So it will be a compile-time failure on
> > > > > some dart2js platforms, and a run-time failure on dart:io.
> > > > >
> > > > > This commit is just to test the UI and backend for test failure
> > > > > approvals on tryjobs and on CI results. It will be reverted after
> > > > > the CI builders have run on it.
> > > > >
> > > > > Change-Id: Icc3d11e72511cb0dbd9a62cb4fa80e754c203c8c
> > > > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127883
> > > > > Reviewed-by: Jonas Termansen <sortie@google.com>
> > > >
> > > > TBR=whesse@google.com,sortie@google.com
> > > >
> > > > Change-Id: I32b900e25dc562ac88f5cb496cdbca726fc70445
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127885
> > > > Reviewed-by: William Hesse <whesse@google.com>
> > >
> > > TBR=whesse@google.com,sortie@google.com
> > >
> > > Change-Id: I64e528131c779c8d20c007ff715b57b599cd3f07
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127886
> > > Reviewed-by: William Hesse <whesse@google.com>
> > > Reviewed-by: Jonas Termansen <sortie@google.com>
> >
> > TBR=whesse@google.com,sortie@google.com,athom@google.com
> >
> > Change-Id: Icf68fd813d5f8f98d5ebf40c34e35811e8fffaf5
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127892
> > Reviewed-by: William Hesse <whesse@google.com>
>
> TBR=whesse@google.com,sortie@google.com,athom@google.com
>
> Change-Id: Ic63f74bf660e71e5e1853a391013368ce640bbc1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127895
> Reviewed-by: William Hesse <whesse@google.com>
> Reviewed-by: Jonas Termansen <sortie@google.com>
TBR=whesse@google.com,sortie@google.com,athom@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Ib82dadb2c82f2329164b29e60997320b775c104d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130378
Reviewed-by: William Hesse <whesse@google.com>
Turns out the flow analysis bug was actually an issue with calling
toString() on an enum. This happened to throw the same type of exception
as caused by the shared part file, so it blended in. Flow analysis was
not itself broken.
Tested the other methods on enum too, but no others seemed to have this
problem.
Change-Id: I5e9e1be3f02adf0177c276c63d0c4f4fa2cb94db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130622
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Change-Id: I7acce67a51d74c1a7ab043443169f8a62f33e1d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130568
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Fixes#39830
The instrumentation_output_test.dart was very old; used dead LibraryInfo class.
Moved this test, renamed to unit_renderer_test.dart.
Change-Id: I8a7538ab3d152944fd93ee6dcab39202344b613b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
We are establishing a convention that nullability wrappers will be emitted at the
call sites of 'is', 'as', and '_check' calls (when necessary). Additional wrappers
will be emitted when forward-declaring generic types at the top level - but only
around the generic parameters themselves.
For example, declaring List<int>, List<int?>, List<int>?, and List<int?>? results
in two top-level classes: ListOfInt(int) and ListOfInt$(dart.nullable(int)).
Change-Id: I2d91e170d8e1e911ad9eb70d6b4d67f1cc4cdbc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129921
Commit-Queue: Mark Zhou <markzipan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
This reverts commit 24a0601d5b.
Reason for revert: This breaks the flutter build because flutter has
a build target producing the same "gen/frontend_server.dart.snapshot" file and is therefore conflicting.
See e.g. head-head-head bot failure:
https://ci.chromium.org/p/dart/builders/ci.sandbox/flutter-engine-linux/9747
Original change's description:
> Create the frontend_server snapshot as a part of the sdk
>
> This will allow us to use it from webdev, as it now supports DDC output.
>
> Change-Id: I4b82d1c45d2c058abb062dddd2a2c41cc6318c45
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130134
> Reviewed-by: Keerti Parthasarathy <keertip@google.com>
> Reviewed-by: Jonah Williams <jonahwilliams@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>
> Commit-Queue: Jake Macdonald <jakemac@google.com>
TBR=keertip@google.com,jakemac@google.com,vsm@google.com,jonahwilliams@google.com
Change-Id: Ib2d782560cc005416ece429f9506dca055bffd9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130377
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This CL changes test.dart to
- improve errors reporting with multiple configurations and builders
by tracking the builders for each configuration separately
- improve output of which configurations and which builders are
tested
- fix a missing check for the case that at least one invalid and
one valid configuration was used
- remove a class and some type annotations
Change-Id: If91e3033c3892c39243327101d3017a5f8e710c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130369
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
The incremental compiler doesn't initialize from dill when it finds that
something in that dill has changed path (because of a change in package
version for instance).
Before this CL, though, it still initialized the incremental serializer
from the data, leading to weird and wrong results: If a package still in
use had been changed it could output the old serialization for that
package because invalidations didn't come into effect (as the incremental
compiler was starting from scratch and there thus was no libraries that
it didn't reuse (which are the ones that are "invalidated" in the
serialization world)).
This CL fixes the issue by only initializing the incremental serializer
when the incremental compiler has sucessfully initialized from the dill.
This should fix the problem that caused #39851.
Fixes#39851.
Change-Id: Ia62c4b7d96878174e0950a0dbbcdcbc4187615c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130371
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
