languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 08:44:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

[infra] Handle missing boolean fields in get_builder_status

Browse source 
Change-Id: I0dc03d6dd58c672c843936dc78fd958608ddef35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130701
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This commit is contained in:
William Hesse 2020-01-08 15:18:18 +00:00 committed by commit-bot@chromium.org
parent 3dd8a3b2f3
commit 13fd15d2f0
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tools/bots/get_builder_status.dart
View file

@ -17,6 +17,12 @@ import 'package:http/http.dart' as http;
const numAttempts = 20;
bool booleanFieldOrFalse(Map<String, dynamic> document, String field) {
Map<String, dynamic> fieldObject = document['fields'][field];
if (fieldObject == null) return false;
return fieldObject['booleanValue'] ?? false;
}
void usage(ArgParser parser) {
print('''
Usage: get_builder_status.dart [OPTIONS]
@ -93,13 +99,9 @@ main(List<String> args) async {
final documents = jsonDecode(response.body);
final document = documents.first['document'];
if (document != null) {
bool success =
(document['fields']['success'] ?? const {})['booleanValue'];
bool completed =
(document['fields']['completed'] ?? const {})['booleanValue'];
bool activeFailures =
(document['fields']['active_failures'] ?? const {})['booleanValue'];
bool success = booleanFieldOrFalse(document, 'success');
bool completed = booleanFieldOrFalse(document, 'completed');
bool activeFailures = booleanFieldOrFalse(document, 'active_failures');
if (completed) {
if (success) {
print('No unapproved new failures');