Commit graph

42928 commits

Author SHA1 Message Date
Dan Rubel 74d713ece9 remove support for analyzer configuration in pubspec
This removes support for having directives like this in your pubspec:

analyzer:
  configuration: test_pack/config

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2511963002 .
2016-11-20 20:44:04 -05:00
Florian Schneider 5399d8acf6 Fix Flutter profile_unopt and release_unopt builds
Fixes #27862.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2516033002 .
2016-11-20 12:17:50 -08:00
Devon Carew c4bcfb5a02 Regen the analysis server spec to include the diagnostic domain.
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2521433002 .
2016-11-20 10:27:58 -08:00
Devon Carew f16a0a2a4d Use an import prefix in the analysis server tests; this fixes some issues conflicting with the
'equals' symbol in the 1.4.0 version of package:path.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2518873002 .
2016-11-20 10:26:27 -08:00
Devon Carew f7334bef35 Add a gitignore file for the analysis_server package.
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2519763002 .
2016-11-20 10:05:11 -08:00
Devon Carew 5c9f09e657 Bring in version 3.0.3 of http_parser; it addresses an issue in the pubspec file of
one of it's dependencies.

BUG=
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/2515123002 .
2016-11-20 00:13:03 -08:00
Konstantin Shcheglov 6039890b99 Compute and flush sets of transitively referenced files in File[System]State.
This allows us to flush transitively referenced file sets only for
affected files.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2516003003 .
2016-11-19 08:35:51 -08:00
Emily Fortuna 3db16e52eb Don't call stringify if we can prove that the type is a string.
BUG=https://github.com/dart-lang/sdk/issues/27394
R=het@google.com

Review URL: https://codereview.chromium.org/2512303002 .
2016-11-18 17:07:20 -08:00
Siva Annamalai 66cb033ac1 Revert "Fix tsan failure"
This reverts commit 159a5ab366.

This reverts commit aa76de9a8f.

BUG=

Review URL: https://codereview.chromium.org/2510093005 .
2016-11-18 16:44:32 -08:00
Siva Annamalai 1df3535771 Fix status files to skip failing complex_reload_test on windows.
BUG=

Review URL: https://codereview.chromium.org/2508323005 .
2016-11-18 16:37:13 -08:00
Siva Annamalai aa76de9a8f Attempt to fix win64 test failures.
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2513173002 .
2016-11-18 16:10:35 -08:00
Konstantin Shcheglov 4f1fa54e34 Fix for Import/ExportDirective annotations while applying resynthesized element model.
This takea care of the Pub analysis crash you saw.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2508223004 .
2016-11-18 15:05:59 -08:00
Siva Annamalai 159a5ab366 Fix tsan failure
We have a racy read of the object header in the stack frame walker
called from the profiler (in this case the gc marker is running at
the same time).

It is appropriate to avoid this even though we think the access is
safe as the objects are in old space and never forwarded and only
the mark bits are manipulated while marking
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2517473002 .
2016-11-18 14:09:02 -08:00
John McCutchan f0f0d4abd7 Fix Windows paths in complex_reload_test
BUG=

Review URL: https://codereview.chromium.org/2519553002 .
2016-11-18 13:26:18 -08:00
John McCutchan 8a7f7715f1 Add a complex reload test that rebases the root script path three times.
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org/2518643002 .
2016-11-18 12:24:01 -08:00
Emily Fortuna 80e227a840 Fix dart2js/analyze_unused_dart2js_test.
(I thought I reran the test when I added currentImplicitInstantiations stack, but clearly not)

TBR=sigmund@google.com

BUG=

Review URL: https://codereview.chromium.org/2514833003 .
2016-11-18 12:00:42 -08:00
Konstantin Shcheglov 4d003da5c8 Enable SDK summaries with --enable-new-analysis-driver flag.
...even if the IDEA does not use 'as-is' mode, it should not be a
problem in fishfooding. Hopefully a new IDEA will be released before
we would want to turn it on for our users.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2514053002 .
2016-11-18 11:32:01 -08:00
Konstantin Shcheglov f52b5973c5 Compute names referenced in a unit.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2519443003 .
2016-11-18 11:19:02 -08:00
Emily Fortuna 4b93090c09 Add types for map literal construction with kernel code.
Possible this could be further simplified?

.... http://i1.kym-cdn.com/photos/images/facebook/000/234/739/fa5.jpg

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sigmund@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2512023002 .
2016-11-18 10:41:29 -08:00
Stephen Adams 7b12dbc665 Bit width analysis for avoiding conversion of bitops to unsigned.
R=sigmund@google.com

Committed: a5443a8b0d

Review URL: https://codereview.chromium.org/2507883002 .

Reverted:  08854375b3
2016-11-18 10:26:07 -08:00
Mohamed Hayibor 5595b9698d Fix typos 'overriden' to 'overridden' and '@mustCall super' to '@mustCallSuper' (#27853)
* fix overriden typos to overridden
* Fix @mustCall super to @mustCallSuper
2016-11-18 09:36:25 -08:00
Martin Kustermann 13f7e93c7e Add wrapper shell script to invoke dartk with checked-in binary
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2516433004 .
2016-11-18 17:35:35 +01:00
Vyacheslav Egorov 30e01bcd67 VM: [Kernel] Relax assertion in Script::GetTokenLocation().
Kernel binaries do not carry token streams.

Introduce a dummy URI to identify dummy Script objects created for Kernel entities.

R=rmacnak@google.com
BUG=

Review URL: https://codereview.chromium.org/2511883002 .
2016-11-18 15:58:16 +01:00
Erik Ernst cf4cff3812 Revert "Enable syntax-only support for generic functions by default."
This reverts commit 70fa0defe9.

(There were too many tests previously failing and now passing on
browsers to fix it right now, will sort it out on Monday.)

Review URL: https://codereview.chromium.org/2514693003 .
2016-11-18 15:54:32 +01:00
Vyacheslav Egorov e924dc4b83 VM: [Kernel] Clone Field objects if building IL during background compilation.
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2506993004 .
2016-11-18 15:48:27 +01:00
Vyacheslav Egorov 35c828c2d2 VM: Fix Flutter build.
libdart_vm_nosnapshot should not include dart_maybe_precompiled_runtime_config.

DART_NOSNAPSHOT and DART_PRECOMPILED_RUNTIME are mutually exclusive configurations
add a meaningful check in the globals.h to catch this instead of cryptic compile
time errors.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2515663002 .
2016-11-18 15:48:01 +01:00
Johnni Winther 39697dc5cf Enhance precision of recorded instantiation info in ResolutionWorldBuilder
+ use this to enhance closed_world_test.

R=het@google.com

Review URL: https://codereview.chromium.org/2506393002 .
2016-11-18 10:57:35 +01:00
Johnni Winther e83fb1bc9d Mark sourcemaps/stacktrace_test as slow
Review URL: https://codereview.chromium.org/2510043003 .
2016-11-18 10:52:07 +01:00
Erik Ernst 70fa0defe9 Enable syntax-only support for generic functions by default.
This CL removes the 'DartOptions=--generic-method-syntax' directives in
test cases concerned with generic functions and enables that feature by
default. The option '--generic-method-syntax' is still allowed, but the
feature is always enabled so the option makes no difference.

R=johnniwinther@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2476423005 .
2016-11-18 09:56:17 +01:00
Johnni Winther d0e057903e Provide source map info for simple async methods.
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2510073002 .
2016-11-18 09:28:40 +01:00
Adam Barth 7125282478 Move fuchsia tests to new mx_object_get_info style
BUG=
R=abarth@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2511983002 .
2016-11-17 20:38:30 -08:00
Konstantin Shcheglov d37acd8e4a Tests for File[System]State.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2510003003 .
2016-11-17 15:40:45 -08:00
Jennifer Messerly 37029a22de fix #27336, ddc with recursive generic class type args
R=vsm@google.com

Review URL: https://codereview.chromium.org/2516483002 .
2016-11-17 15:38:33 -08:00
Paul Berry f670a464d8 Rename UnlinkedConst -> UnlinkedExpr
This is purely a nomenclature change to avoid confusion, since these
data structures are used for all expressions that appear in summaries,
regardless of whether they are const.

R=scheglov@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2508343002 .
2016-11-17 15:27:47 -08:00
John McCutchan 985d03db2a Revert "Fix flutter build"
This reverts commit f45d5ad70e.

BUG=

Review URL: https://codereview.chromium.org/2508273003 .
2016-11-17 15:20:12 -08:00
John McCutchan f45d5ad70e Fix flutter build
BUG=

Review URL: https://codereview.chromium.org/2511653003 .
2016-11-17 15:15:24 -08:00
Ryan Macnak edb9c4205e Adjust ARM feature detection to note the Xiaomi MI5 also fails to support integer division in A32 code.
flutter/flutter#6901

R=zra@google.com

Review URL: https://codereview.chromium.org/2507113004 .
2016-11-17 14:42:17 -08:00
Vijay Menon 3b4854ac7d Allow canary to fail for DDC tests
This has been pretty flaky recently.  Almost all intermittent failures are this config.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2509363002 .
2016-11-17 12:57:21 -08:00
Dan Rubel 9ec7547323 update ContextManager to support analysis option include directive
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2514533002 .
2016-11-17 15:36:33 -05:00
Brian Wilkerson 138cebfa2d Un-deprecate some deprecated code and fix a couple of hints
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2508973005 .
2016-11-17 12:34:46 -08:00
Kevin Moore 4d75bf77a5 Fix a couple of links in runtime/observatory
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2513703002 .
2016-11-17 12:31:00 -08:00
Florian Schneider 2e4101fc6c VM: Remove too strict assertion in rethrow.
With custom zones and async code we may end up invoking rethrow
with an error object where the stacktrace is not initialized.

In that case we can just use the stacktrace passed into rethrow
explicitly.

Fixes #27839.

R=kustermann@google.com

Review URL: https://codereview.chromium.org/2511573003 .
2016-11-17 12:11:33 -08:00
Dan Rubel 0d15f1d892 report errors in included options files
Example error messages include:
/analysis_options.yaml(10..27): The include file other_options.yaml in /analysis_options.yaml cannot be found.
/analysis_options.yaml(10..27): Bad options file format (expected String scope key, got YamlScalar) in /other_options.yaml(0..0)
/analysis_options.yaml(10..27): Warning in the included options file /other_options.yaml(47..49): The option 'ftw' isn't supported by 'errors'.

Since the included options file may not be part of the project,
the error is reported on the initial include statement
and includes the needed location information for the user to track down the problem.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2502233004 .
2016-11-17 14:43:05 -05:00
John McCutchan f43b48e34d Support reloading from source on top of a script snapshot.
- [x] Add arguments `rootLibUri` and `packagesUri` to the reload service rpc. These allow the uri of the root library and the .packages files to be overridden.
- [x] When pairing libraries during reload, support the base url changing.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2512483002 .
2016-11-17 11:29:12 -08:00
Konstantin Shcheglov 3215a1b2be Send CacheCleanUpRequest instead of a List.
R=paulberry@google.com, rmacnak@google.com
BUG=

Review URL: https://codereview.chromium.org/2504193004 .
2016-11-17 11:16:37 -08:00
Vyacheslav Egorov ce25ab3aa0 VM: Fix sticky matching for anchored regexps on interpreter.
It was fixed in CompileIR but not ported to CompileBytecode.

TBR=rmacnak@google.com
BUG=

Review URL: https://codereview.chromium.org/2508253002 .
2016-11-17 20:04:13 +01:00
Ryan Macnak f4baefeb25 Don't crash trying to use --snapshot-kind=app-aot from 'dart' rather than 'dart_bootstrap'.
R=asiva@google.com

Review URL: https://codereview.chromium.org/2510143002 .
2016-11-17 10:34:51 -08:00
Florian Schneider dc6aaadba9 DBC: Add missing PC descriptors in static initializers.
InitStatic can call, and may throw. Therefore we need to mark it as a call.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2491713002 .
2016-11-17 10:30:06 -08:00
Konstantin Shcheglov 225b062be8 Fix crash while inferencing instance field type.
The type does not look correct, should it be '(dynamic) → dynamic'?
But at least it does not crash anymore.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2511753002 .
2016-11-17 10:23:53 -08:00
Vyacheslav Egorov f82cd6bb5d VM: Fix RegExp_ExecuteMatchSticky fingerprint.
TBR=rmacnak@google.com

Review URL: https://codereview.chromium.org/2508133003 .
2016-11-17 19:03:40 +01:00