Enable SDK summaries with --enable-new-analysis-driver flag.

...even if the IDEA does not use 'as-is' mode, it should not be a
problem in fishfooding. Hopefully a new IDEA will be released before
we would want to turn it on for our users.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2514053002 .
This commit is contained in:
Konstantin Shcheglov 2016-11-18 11:32:01 -08:00
parent f52b5973c5
commit 4d003da5c8

View file

@ -389,7 +389,7 @@ class Driver implements ServerStarter {
analysisServerOptions.enableIncrementalResolutionValidation =
results[INCREMENTAL_RESOLUTION_VALIDATION];
analysisServerOptions.enableNewAnalysisDriver =
results[ENABLE_NEW_ANALYSIS_DRIVER];
results[ENABLE_NEW_ANALYSIS_DRIVER];
analysisServerOptions.enablePubSummaryManager =
results[ENABLE_PUB_SUMMARY_MANAGER];
analysisServerOptions.finerGrainedInvalidation =
@ -428,7 +428,8 @@ class Driver implements ServerStarter {
.defaultSdkDirectory(PhysicalResourceProvider.INSTANCE)
.path;
}
bool useSummaries = analysisServerOptions.fileReadMode == 'as-is';
bool useSummaries = analysisServerOptions.fileReadMode == 'as-is' ||
analysisServerOptions.enableNewAnalysisDriver;
// TODO(brianwilkerson) It would be nice to avoid creating an SDK that
// cannot be re-used, but the SDK is needed to create a package map provider
// in the case where we need to run `pub` in order to get the package map.