languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 15:01:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Adjust ARM feature detection to note the Xiaomi MI5 also fails to support integer division in A32 code.

Browse source 
flutter/flutter#6901

R=zra@google.com

Review URL: https://codereview.chromium.org/2507113004 .
This commit is contained in:
Ryan Macnak 2016-11-17 14:42:17 -08:00
parent 3b4854ac7d
commit edb9c4205e
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
runtime/vm/cpu_arm.cc
View file

@ -207,14 +207,15 @@ void HostCPUFeatures::InitOnce() {
// - Qualcomm Krait CPUs (QCT APQ8064) in Nexus 4 and 7 incorrectly report
// that they lack integer division.
// - Marvell Armada 370/XP incorrectly reports that it has integer division.
// - The Pixel lacks integer division even though ARMv8 requires it in A32.
// - Qualcomm Snapdragon 820/821 CPUs (MSM 8996 and MSM8996pro) in Xiaomi MI5
// and Pixel lack integer division even though ARMv8 requires it in A32.
bool is_krait = CpuInfo::FieldContains(kCpuInfoHardware, "QCT APQ8064");
bool is_armada_370xp =
CpuInfo::FieldContains(kCpuInfoHardware, "Marvell Armada 370/XP");
bool is_pixel = CpuInfo::FieldContains(kCpuInfoHardware, "MSM8996pro");
bool is_snapdragon = CpuInfo::FieldContains(kCpuInfoHardware, "MSM8996");
if (is_krait) {
integer_division_supported_ = FLAG_use_integer_division;
} else if (is_armada_370xp || is_pixel) {
} else if (is_armada_370xp || is_snapdragon) {
integer_division_supported_ = false;
} else {
integer_division_supported_ =