Josh Soref
f7a2ea5e06
Spelling
...
Closes https://github.com/dart-lang/sdk/pull/50922
GitOrigin-RevId: 58fd7cfd5ef470a65a52ea28e0407244d853c917
Change-Id: I2e5a5ed991cb05270170a18b8f0169daa9eabdb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278537
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-01-24 18:00:25 +00:00
Alexander Thomas
b9b6511ca6
Spelling sdk
...
Closes https://github.com/dart-lang/sdk/pull/50918
Co-authored-by: Josh Soref <jsoref@gmail.com>
GitOrigin-RevId: 1fd275051c561b63d374fb47e76a22424c4a12a9
Change-Id: I97790d9c79ff659f2c1fa2d2d46d041fe67957cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278530
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
2023-01-20 12:37:49 +00:00
Josh Soref
9e4dc755cb
Spelling pkg
...
Closes https://github.com/dart-lang/sdk/pull/50921
GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23
Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-01-19 10:06:29 +00:00
Paul Berry
8b2d39471e
Update CHANGELOG to reflect removal of dart migrate
...
Bug: https://github.com/dart-lang/sdk/issues/50319
Change-Id: Ic9ff1aa3432f3ec37feaecaf3f35b43363b76003
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278539
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
2023-01-09 18:06:16 +00:00
Lasse R.H. Nielsen
8a891ba869
Deprecate HasNextIterator
.
...
Bug: https://dartbug.com/50883
Change-Id: I983e07072052a0538e4c04cc66e7fd2ad2bc1242
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278121
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2023-01-09 12:14:33 +00:00
Kevin Chisholm
68358bceee
update changelog to reflect Metrics API deprecation
...
Change-Id: I92138c3a1dbf6be150f9b695d759034d2058d365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278531
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2023-01-06 15:56:58 +00:00
Nicholas Shahan
8e1f57666e
[3.0 alpha][ddc] Remove unused command line args
...
The `-k`, `--kernel`, and `--dart-sdk` arguments have been
ignored since v2.8.1.
Change-Id: I28e793f3e2023cc09c279ca65d08295b1ed11028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276771
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2023-01-03 20:14:12 +00:00
Lasse R.H. Nielsen
81b137d8fe
[3.0 alpha] Remove deprecated BidirectionalIterator
.
...
Requires releasing `package:quiver` 3.2.0 so Flutter can upgrade to that.
Change-Id: Ibd9acc5fa11a67ca50d06172dfe0f9175b240522
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276741
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2023-01-02 16:14:08 +00:00
Brian Quinlan
9b2b9df09e
[io] Remove incorrect docs that listSupport is not available on Android.
...
Bug:https://github.com/dart-lang/sdk/issues/47894
Change-Id: Id79a37f5ba6a8118a30d2297c95cff5a7ca1a03f
TEST=unit
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276660
Commit-Queue: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2022-12-21 00:23:02 +00:00
Vyacheslav Egorov
13978f85fd
[lib] Update SendPort.send documentation
...
Try to make it more clear that you can only send default
implementations of List, Map, Set, etc.
Add CHANGELOG.md entry that documents a8fe399c79
Related to https://github.com/dart-lang/sdk/issues/50594
Change-Id: Ib0cf9d389b91cc5ab72b8bab5461ee91037baf25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273185
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
2022-12-19 16:03:46 +00:00
Michael Thomsen
6bbe71fbbb
Add missing API removal changelog changes
...
Change-Id: I444f94b9ef712de6e2203b67965e792eb33c5893
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276101
Reviewed-by: Lasse Nielsen <lrn@google.com>
Auto-Submit: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
2022-12-19 09:51:38 +00:00
Michael Thomsen
cebaa403c1
Update changelog with a few missing API removals
...
Change-Id: Ic519e646fde654da8ab64ec0971436a751f67dd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276084
Reviewed-by: Lasse Nielsen <lrn@google.com>
2022-12-19 08:29:29 +00:00
Riley Porter
b6388f2ea0
[JS interop] Expose more JavaScript operators in js_util
...
Exposes helper functions in js_util to access the JavaScript operators
`delete`, `||`, `&&`, `!`, `!!`, and `typeof`.
Change-Id: I0676b143aa004c7b4ed1c6b695b8d1e78a60778d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276028
Commit-Queue: Riley Porter <rileyporter@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
2022-12-17 00:31:27 +00:00
Sam Rawlins
94f20d7731
Revert "Remove all support for all strong-mode analysis options"
...
This reverts ea120b5d44
Change-Id: I97a1bf6ced06bf8bcab50a2fdb41732f13182a84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276026
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-12-16 00:47:49 +00:00
pq
ea1473e6cd
linter 1.32.0
...
See: https://github.com/dart-lang/linter/issues/3848
Change-Id: I73469ce43d52c1755875a39067b267f216ebd490
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-12-15 22:51:28 +00:00
Nate Bosch
ca03588d2b
Run extension handlers in the registering zone
...
Towards https://github.com/flutter/flutter/issues/93676
Flutter uses an extension for hot reloads, and the app ends up running
in the root zone after a hot reload because that is the zone that the
handler gets called in.
Always run extension handler callbacks in the zone from which they were
registered for more predictable behavior.
Change-Id: Ia921489a6ada802c8e53a0ccc650a8bce218ba01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275842
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2022-12-15 15:05:17 +00:00
Michael Thomsen
bcbf24ec3d
[3.0 alpha] Remove deprecated CastError
and FallThroughError
dart:core
errors
...
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/49529
Change-Id: I52495d3e5319f0555714f4f8247149afc06128a1
Cq-Include-Trybots: luci.dart.try:vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,dart-sdk-mac-arm64-try,dart-sdk-mac-try,vm-kernel-nnbd-mac-debug-arm64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,dart-sdk-linux-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259041
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2022-12-15 13:38:47 +00:00
Sam Rawlins
ea120b5d44
Remove all support for all 'strong-mode' analysis options
...
Fixes https://github.com/dart-lang/sdk/issues/50679
Change-Id: I3572faf51276f5c7551d35b7725c799567189413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-12-13 21:32:24 +00:00
Michael Thomsen
2a0bcaf155
[3.0 alpha] Add onError removal to changelog.
...
Followup to https://dart-review.googlesource.com/c/sdk/+/259042
Change-Id: I9f21a58fe7baf9e0dc0a9b8b13900c72a07e0805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275001
Reviewed-by: Lasse Nielsen <lrn@google.com>
2022-12-12 11:51:35 +00:00
Lasse R.H. Nielsen
767049139a
[3.0 alpha] Remove deprecated dart:core apis
...
- Remove `proxy` and `Provisional` annotations.
- Remove `Deprecated.expires` getter.
Change-Id: I4521b48bb92e5f8420c778686f4efa9c6426cebb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258004
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2022-12-12 11:46:58 +00:00
Michael Thomsen
ef286f6039
[3.0 alpha] Remove dart:developer's deprecated MAX_USER_TAGS
...
Change-Id: I967974b4295548278400c14fcca7540dfa95fb66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268340
Reviewed-by: Siva Annamalai <asiva@google.com>
2022-12-12 10:49:58 +00:00
Michael Thomsen
4028b9b0fe
[3.0 alpha] Remove deprecated NoSuchMessageError API
...
Contributes to https://github.com/dart-lang/sdk/issues/49529
Change-Id: I2cef41b991c59869f606235929347449e17022cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271082
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
2022-12-12 09:48:05 +00:00
Michael Thomsen
d6b40b0926
[3.0 alpha] Remove deprecated dart:async APIs
...
Contributes to https://github.com/dart-lang/sdk/issues/49529
Change-Id: Ib70efd0f388f50686e1745ca5237d06a4538a870
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268460
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
2022-12-12 09:35:29 +00:00
Sigmund Cherem
c91b73eaf7
[3.0 alpha] Remove dart:html's deprecated document.registerElement & registerElement2 APIs
...
Change-Id: I07fc124c55d1aeb678f39a4d72d3b4f581025a10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273541
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2022-12-09 16:02:02 +00:00
Kevin Moore
1b79875bb7
changelog: sort and front-load new lints in 2.19 and 2.18 sections
...
Some other whitespace tweaks
Dropped a bunch of gratuitous `[]` bits next to links
Change-Id: I32b46138d3ff7df68b8a4dab80b346de20fee73f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274088
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
2022-12-07 20:39:10 +00:00
Kevin Chisholm
3e968e5fc4
update changelog on main to include dart 2.18.5 hotfix notes.
...
Change-Id: Ic3cfe61db296d2ed1500fc0756ee3f6f29832f07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272880
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2022-12-01 13:54:43 +00:00
Erik Ernst
1d7ec85d9c
Add CHANGELOG entry for 50383
...
Issue 50383 is the breaking change whereby all cyclic dependencies are
reported as an error during top-level inference.
Change-Id: I669276c2e356aeed261287a0b295971d11357950
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272781
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
2022-11-30 09:40:40 +00:00
Brian Quinlan
8df8bbf0de
Add PathExistsException and PathAccessException FileSystemException subclasses.
...
Bug:https://github.com/dart-lang/sdk/issues/50436
Change-Id: Ie2954f162c01189cd0d817f58606529acdc13416
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269240
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-11-30 04:54:52 +00:00
pq
636eec185b
linter 1.31.0
...
Cherry-picks update of `prefer_equal_for_default_values` to be a no-op in SDKs `>=2.19`.
See: https://github.com/dart-lang/linter/pull/3865
Change-Id: I2669f0279a0913bc8b3c5b0501a9869608883a14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-11-30 02:11:07 +00:00
Sam Rawlins
c37fc761f5
Update changelog for analyzer
...
Change-Id: I2283636efd0b6c63ac047ccf703effb35e0388b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272489
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-11-29 22:47:58 +00:00
Srujan Gaddam
ed0ac1936a
Reland "[pkg:js] Disallow using @staticInterop synthetic constructors"
...
This reverts commit aa252e907e
.
Reason for revert: Flutter engine is migrated to not use synthetic constructors.
Original change's description:
> Revert "[pkg:js] Disallow using @staticInterop synthetic constructors"
>
> This reverts commit aab6ab8b84
.
>
> Reason for revert: Broke Flutter roll https://github.com/flutter/engine/pull/37838
>
> Original change's description:
> > [pkg:js] Disallow using @staticInterop synthetic constructors
> >
> > Change-Id: I5c74369ee8ae97fcc21032464fcb8fea987022d9
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268107
> > Reviewed-by: Joshua Litt <joshualitt@google.com>
> > Reviewed-by: Riley Porter <rileyporter@google.com>
> > Reviewed-by: Sigmund Cherem <sigmund@google.com>
>
> TBR=sigmund@google.com ,joshualitt@google.com,rileyporter@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com,srujzs@google.com
>
> Change-Id: I6caf4b776191e8eed9877c43f900ae6300f1f5c2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271440
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Commit-Queue: Srujan Gaddam <srujzs@google.com>
> Reviewed-by: Srujan Gaddam <srujzs@google.com>
# Not skipping CQ checks because this is a reland.
Change-Id: Iaa538bb5f309a46c320bf1781c3d1a7148ec7be7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271500
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
2022-11-28 23:41:02 +00:00
Daco Harkes
827d166ea0
[vm/ffi] Stop reifying type argument in Pointer
...
All `Pointer`s will now have the `Never` type argument at runtime.
TEST=tests/ffi(_2)/*
Bug: https://github.com/dart-lang/sdk/issues/49935
Change-Id: I83c8bba9461c2cab22992ba2e3cf42b7b5f43c36
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-win-debug-x64-try,vm-kernel-precomp-win-debug-x64c-try,vm-kernel-mac-debug-x64-try,dart-sdk-mac-arm64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64c-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272201
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
2022-11-28 09:45:45 +00:00
Sigurd Meldgaard
28be06f6d5
Bump pub to 6fdcd and webdev to 637b4
...
Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53
Changes:
```
> git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4
https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667 )
https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196 )
https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666 )
https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665 )
https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656 )
https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to
override stdout.hasTerminal for output animations (#3658 )
https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663 )
https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571 )
https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637 )
https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660 )
https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650 )
https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652 )
https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648 )
```
Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/
Bump webdev to 637b406f325669507b5c1048c19a7c0083c1bd6e
Changes:
```
> git log --format="%C(auto) %h %s" 3ec168f..637b406
https://dart.googlesource.com/webdev.git/+/637b406 Support `--native-assets` in `FrontendServerClient` (#1797 )
https://dart.googlesource.com/webdev.git/+/a19d563 Save debug information in `chrome.storage` after a Dart app loads (#1791 )
https://dart.googlesource.com/webdev.git/+/9cc10d4 Connect to a `chrome.runtime` port to keep the service worker alive (#1789 )
```
Diff: https://dart.googlesource.com/webdev.git/+/3ec168f6815af9d5f11278111d147bc82c0755c3~..637b406f325669507b5c1048c19a7c0083c1bd6e/
Update CHANGELOG
Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53
Changes:
```
> git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4
https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667 )
https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196 )
https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666 )
https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665 )
https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656 )
https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to override stdout.hasTerminal for output animations (#3658 )
https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663 )
https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571 )
https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637 )
https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660 )
https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650 )
https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652 )
https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648 )
```
Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/
Change-Id: I65b928479b44f08305853078b0f34a6b66602709
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271709
Auto-Submit: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
2022-11-25 11:13:03 +00:00
Lasse R.H. Nielsen
b7b45eb421
Deprecate NullThrownError and CyclicInitializetionError.
...
Both exceptions are used only in pre-null-safe code.
They can safely be removed when all code has been
migrated to null safety, and non-null-safe code is
no longer supported.
Change-Id: I13624d0da369c2241b8f6d66da01ea91bc0b45f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271920
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
Auto-Submit: Lasse Nielsen <lrn@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
2022-11-24 15:05:13 +00:00
Srujan Gaddam
aa252e907e
Revert "[pkg:js] Disallow using @staticInterop synthetic constructors"
...
This reverts commit aab6ab8b84
.
Reason for revert: Broke Flutter roll https://github.com/flutter/engine/pull/37838
Original change's description:
> [pkg:js] Disallow using @staticInterop synthetic constructors
>
> Change-Id: I5c74369ee8ae97fcc21032464fcb8fea987022d9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268107
> Reviewed-by: Joshua Litt <joshualitt@google.com>
> Reviewed-by: Riley Porter <rileyporter@google.com>
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
TBR=sigmund@google.com ,joshualitt@google.com,rileyporter@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com,srujzs@google.com
Change-Id: I6caf4b776191e8eed9877c43f900ae6300f1f5c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271440
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
2022-11-22 17:28:28 +00:00
Srujan Gaddam
7d8e63b0b5
[pkg:js] Disallow non-@staticInterop
classes from inheriting @staticInterop
...
Adds checks that if the derived class does not have a `@staticInterop`
annotation, none of the classes it implements or immediately extends can
have it either. Also cleans up some redundant abstract class tests for
readability.
Change-Id: I2e8528b0fb02d9ce39003d00ee0b3da88ce75d44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268109
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2022-11-21 20:19:06 +00:00
Srujan Gaddam
4c34e780cf
[pkg:js] Require users to use @JS when using @staticInterop
...
Change-Id: Iea0a54ff03b32bc910ef2c6eb633bffd09cf0671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268108
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Riley Porter <rileyporter@google.com>
2022-11-21 20:19:06 +00:00
Srujan Gaddam
aab6ab8b84
[pkg:js] Disallow using @staticInterop synthetic constructors
...
Change-Id: I5c74369ee8ae97fcc21032464fcb8fea987022d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268107
Reviewed-by: Joshua Litt <joshualitt@google.com>
Reviewed-by: Riley Porter <rileyporter@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2022-11-21 20:19:06 +00:00
Marya
7f1ae73fdb
Add link to issue #1073
...
Closes https://github.com/dart-lang/sdk/pull/50500
GitOrigin-RevId: 13916c1f944e04dc61fcba9c78efbcbf33684ab5
Change-Id: I6f2a502621afb98063591871af5fb3bac0c2bb65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270481
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2022-11-17 21:59:28 +00:00
Kevin Moore
bdd37d0c56
drop unneeded changelog entry
...
Change-Id: I950e6650553ac3c6f3c1feafaf875bfcc0c9fc71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269145
Commit-Queue: Kallen Tu <kallentu@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kallen Tu <kallentu@google.com>
2022-11-11 00:33:31 +00:00
Kallen Tu
5adeb03c2f
Add ServerSocketBase to remove dynamic invocations of secure sockets in _HttpServer.
...
Change-Id: If8379fe73eeabd3aef99fcb85b4a5fd8414f8a18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260980
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2022-11-10 22:28:48 +00:00
pq
35699ad901
linter 1.30.0
...
Change-Id: I46981ffb71006aff9e7d8d68a323ae243f9c2542
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268800
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-11-09 23:25:29 +00:00
Brian Quinlan
b75f8aaaf5
[io/file] - add FileSystemNotFoundException
...
Thrown by when an operation fails because a file is not found.
TEST=updated unit tests
Issue: https://github.com/dart-lang/sdk/issues/12461
Change-Id: I2e6e3986f92d5bf9f3922f4e2c6bbba67cc102bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267280
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-11-08 19:26:19 +00:00
Kallen Tu
63b49dfc8e
Deprecate checkValidIndex and avoid using it in the core library.
...
TEST=No new behaviour, existing tests pass.
Change-Id: Ia7a8e58543bd5e1d8dd14bd46c5083759333845b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259104
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2022-11-08 19:02:35 +00:00
pq
ca52c30092
linter 1.29.0
...
Downstream fixes:
* https://github.com/flutter/flutter/pull/113794
* https://github.com/flutter/plugins/pull/6669
* https://github.com/flutter/engine/pull/37321
* https://github.com/dart-lang/linter/pull/3775
* https://github.com/dart-lang/linter/pull/3776
* cl/482614222
* cl/482654980
* cl/482744309
* cl/485129394
* cl/485139323
* ...
Upstream:
* https://github.com/dart-lang/sdk/issues/50263
Change-Id: I259cb0c28464b1e513d9a1931b7c680a2a04a0a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264961
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-11-07 22:02:42 +00:00
William Hesse
8f9f6f99ad
[release] Add release notes for 2.18.4
...
Change-Id: If8ee0291c6baacf8d8c69f73f90ab4602fa58ab1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266940
Reviewed-by: Michael Thomsen <mit@google.com>
2022-11-01 12:51:00 +00:00
Michael Thomsen
ec39de1aba
Link to CVE
...
Change-Id: I6cc5843715ce3a575b584b89e51426f1798740d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266000
Reviewed-by: Lasse Nielsen <lrn@google.com>
2022-10-27 15:10:25 +00:00
Kevin Moore
027b0269d8
CHANGELOG: consolidate dart:core
for 1.19 and fix link
...
Change-Id: Ieacc901aea121418782e938133670eef2d8732fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265901
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
2022-10-26 21:13:05 +00:00
Kevin Moore
e36316ebb7
changelog: move ResourceHandle note to correct section - near dart:io
...
follow-up to fa53fb66d0
Change-Id: I4ee2bcdef4b6d04318da7e3f5400c4fb73e8a691
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265621
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2022-10-26 20:41:31 +00:00
Sam Rawlins
9896f1c647
Enable the unnamed-libraries experiment by default in 2.19.0
...
TEST=tests/language/library/unnamed_library_test.dart
Bug: https://github.com/dart-lang/language/issues/1073
Change-Id: I1c7fa7b4ee4450e344a7613525765e4ab590cc8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265381
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-10-25 21:10:57 +00:00
Sam Rawlins
13529cac21
Add a few items to analyzer's 2.19 CHANGELOG entry
...
Change-Id: I71dadebcffed30331027ad9c4ba250d3103dcc62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-10-25 20:04:28 +00:00
Lasse R.H. Nielsen
c13676f2b7
Deprecate FallThroughError
.
...
The error has not been thrown since Dart 2.0,
where being able to reach the end of a switch case
became a compile-time error.
TEST=Removes tests depending on discontinued behavior.
Change-Id: I76292e7c73f2b3aaf071bbb290e97db493b75477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261860
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
Auto-Submit: Lasse Nielsen <lrn@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
2022-10-25 12:25:35 +00:00
Lukas Klingsbo
6e4e12922a
DateTime copyWith extension
...
This change has been discussed for 8+ years and it would of course be preferred
to be added as an instance method, but since that is a breaking change I added it as an extension as discussed here:
https://github.com/dart-lang/sdk/issues/24644#issuecomment-1241695835
Change-Id: Iebb9f300e449920ae8891abac88f30b271321661
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258541
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
2022-10-20 10:50:25 +00:00
Srujan Gaddam
521cbcdd47
[pkg:js] Disallow external extension members with type parameters
...
Bug: https://github.com/dart-lang/sdk/issues/49350
Checks to see that external extension members on `@staticInterop` types
do not declare or use a type parameter.
Change-Id: Id8646b599094b748c5490810b64d872065676014
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254103
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
2022-10-18 17:47:29 +00:00
Srujan Gaddam
b6526beeab
[pkg:js] Disallow staticInterop generative constructors
...
Fixes https://github.com/dart-lang/sdk/issues/48730
Change-Id: I4c7f687ec8d2724de0e031aa5ebe887f93843761
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254101
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2022-10-18 17:47:29 +00:00
Sigurd Meldgaard
4768317f2b
Bump pub to b9afe9270c24d040b8ae465b4b37ba4f7f4b4cc5
...
Changes:
```
> git log --format="%C(auto) %h %s" 817e61d..b9afe92
https://dart.googlesource.com/pub.git/+/b9afe927 Completely switch from pub.dartlang.org to pub.dev (#3611 )
https://dart.googlesource.com/pub.git/+/7b65fa73 update docs for running 'pub token' (#3602 )
https://dart.googlesource.com/pub.git/+/4c9ebd0e Content hashing of archives (#3482 )
```
Diff: https://dart.googlesource.com/pub.git/+/817e61d9eb174f77dfd2cb1d1de45826f66ac6bf~..b9afe9270c24d040b8ae465b4b37ba4f7f4b4cc5/
Change-Id: I6d827dd64f822e0194e0e17e95a47f02b744b561
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264701
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2022-10-18 14:42:34 +00:00
Sigurd Meldgaard
250db68e25
Bump pub to 817e61d9eb174f77dfd2cb1d1de45826f66ac6bf
...
Changes:
```
> git log --format="%C(auto) %h %s" 28a2503..817e61d
https://dart.googlesource.com/pub.git/+/817e61d9 Fix publishing (#3610 )
https://dart.googlesource.com/pub.git/+/97f638d0 PubToplevel.directory is never null. (#3587 )
https://dart.googlesource.com/pub.git/+/a3ee2099 Make binstubs offset invariant (#3586 )
https://dart.googlesource.com/pub.git/+/67e44b4b Make >=2.12 <3.0.0 compatible with dart 3 (#3572 )
https://dart.googlesource.com/pub.git/+/c287c110 Warn on `pub publish` if `dart analyze` has messages (#3568 )
https://dart.googlesource.com/pub.git/+/29d7d868 Cleaner pubspec.lock parsing (#3487 )
```
Diff: https://dart.googlesource.com/pub.git/+/28a2503d7f4806e6854e3ed0d783f065abfd1b5f~..817e61d9eb174f77dfd2cb1d1de45826f66ac6bf/
Change-Id: I203963479a2bb78db80d8e645066a227febeef46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264680
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2022-10-18 12:17:31 +00:00
Alexander Thomas
843cd8e43f
[release] Add release notes for 2.18.3
...
Change-Id: I291c49c56480786aa7ae4dff2b889e70157f62a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264420
Reviewed-by: Slava Egorov <vegorov@google.com>
2022-10-17 13:08:05 +00:00
Sigurd Meldgaard
4f4f446e22
Bump pub to 28a2503d7f4806e6854e3ed0d783f065abfd1b5f
...
Changes:
```
> git log --format="%C(auto) %h %s" ec35d46..28a2503
https://dart.googlesource.com/pub.git/+/28a2503d Bump analyzer from 4.7.0 to 5.1.0 (#3582 )
https://dart.googlesource.com/pub.git/+/8dba9574 Crc32c checksum validation and retry of archive downloads (#3546 )
https://dart.googlesource.com/pub.git/+/27da43ec Allow `dart pub add` with existing package, update constraint instead of adding (#3570 )
https://dart.googlesource.com/pub.git/+/2e9338e5 Do resolution before publishing. (#3565 )
https://dart.googlesource.com/pub.git/+/0a487534 Migrate removed command `pub` to `dart pub` in docs & messages (#3506 )
https://dart.googlesource.com/pub.git/+/e2720c27 Fail gracefully when run inside the pub-cache (#3471 )
https://dart.googlesource.com/pub.git/+/a76c1933 Upgrade `package:tar` to 0.5.6 (#3540 )
https://dart.googlesource.com/pub.git/+/c065e559 Remove unnecessary nullability (#3547 )
https://dart.googlesource.com/pub.git/+/8e306f33 Use pub.dev in writing (#3528 )
https://dart.googlesource.com/pub.git/+/08d71024 Use unicode (if available) when drawing file-lists (#3541 )
https://dart.googlesource.com/pub.git/+/a0ca4226 Don't be conservative in upgrade --major-versions without specific pa… (#3539 )
https://dart.googlesource.com/pub.git/+/a59d890e Show file size (#3509 )
https://dart.googlesource.com/pub.git/+/b0ba5cc6 Avoid packageGraph (and therefore getExecutableForCommand) depending on the lock-file (#3533 )
```
Diff: https://dart.googlesource.com/pub.git/+/ec35d46261b610e558dfd0d8525ca3fc8387b4b7~..28a2503d7f4806e6854e3ed0d783f065abfd1b5f/
Change-Id: Ia366f75da16982fb9588a0d7aa18e109daea8f8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262346
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2022-10-04 10:11:57 +00:00
Paul Berry
54906759b9
Don't delegate foreign private names to noSuchMethod
.
...
If a concrete class implements an interface containing a name that's
private to a different library, any attempt to invoke that name will
result in an exception getting thrown. Previously, such attempts
would result in the call being diverted to noSuchMethod.
This change closes a loophole in Dart's privacy system, and paves the way for
a future implementation of promotion for private final fields (see
https://github.com/dart-lang/language/issues/2020 ).
Bug: https://github.com/dart-lang/sdk/issues/49687
Change-Id: Ie55805e0fc77dc39713761a80a42c28bd0504722
Tested: language tests
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255640
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
2022-09-27 21:20:35 +00:00
William Hesse
28263235b6
[release] Update changelog for 2.18.2
...
Bug: https://github.com/dart-lang/sdk/issues/50052
Change-Id: I1d9aedac81b2fdb05f04a0246d1088ffa66192ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261300
Reviewed-by: Alexander Thomas <athom@google.com>
2022-09-27 11:07:48 +00:00
Alexander Thomas
d8cf2a5cbf
[release] Add changelog for 2.18.2
...
Change-Id: I47ae13f80780c57419e252431c429fbb040db599
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260104
Reviewed-by: Michael Thomsen <mit@google.com>
2022-09-26 10:06:44 +00:00
Marya
871f36a4e9
Add link to breaking change
...
Closes https://github.com/dart-lang/sdk/pull/49979
GitOrigin-RevId: bc350b0cdf003d5765803213be3cf393009bd992
Change-Id: I09375c48824098d37402720de967f7c71666f044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259507
Reviewed-by: Alexander Thomas <athom@google.com>
2022-09-21 09:49:30 +00:00
Brian Quinlan
fa53fb66d0
Throw an error if an attempt is made to create more than one resource from a ResourceHandle
...
Change-Id: I629d2b9cfddd8e5f7fe8ae65a03362c7bcce5e2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257000
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-09-14 18:17:33 +00:00
Lasse R.H. Nielsen
e4ae0cf2ce
Make Uri
treat \
as /
in path and authority.
...
When using `Uri.parse` or `Uri(path:..)`, a `\` is treated as, and converted to, a `/`.
This avoids a particular problematic difference in behavior between Dart and the browser's `URL` functionality. There are still examples where the two differ in interpretation of the same code, but in those cases, the Dart `Uri` will most likely end up without a host name, which should be easily detected.
Change-Id: I798df6c3c27c6d64fb9fc8dc30d90b06ba5a9004
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258120
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2022-09-13 11:48:19 +00:00
Alexander Thomas
14da46cfaa
[release] Add changelog for 2.18.1
...
Change-Id: I754a5ae6a52e3be01dd90491f11dd642f77a5ec9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258923
Reviewed-by: Michael Thomsen <mit@google.com>
2022-09-13 07:58:49 +00:00
Paul Berry
7eab5ef808
Document and test additional breaking change.
...
Breaking change https://github.com/dart-lang/sdk/issues/49635 had a
slightly larger effect than I previously understood. This change
documents the additional effect and adds a test that would have caught
it.
Bug: https://github.com/dart-lang/sdk/issues/49635
Change-Id: I40e9434a7fb87ff00d71b454239e4cadf197a285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256880
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2022-09-08 16:05:05 +00:00
Jonas Termansen
ff212e8540
Fix old CHANGELOG entry at wrong header lever.
...
Change-Id: If6ccea08ccd27d0ed001892e2d170ca042b40f47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257062
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2022-09-07 09:46:57 +00:00
pq
3f346ef418
linter 1.28.0
...
Change-Id: I5f8e7dd1e581e37b456ba2be4c41904dbdfd7977
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257125
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-09-02 15:46:23 +00:00
Kevin Moore
e11c172432
Fix library entries for 2.18 and 2.19
...
Correct ordering
Fixed header level
Change-Id: I117ff01793c36e389ecf8ff101f2f82ff0ef5bc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256801
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2022-08-30 19:16:28 +00:00
Sam Rawlins
36affd7014
Analyzer changelog entries for 2.17, 2.18, 2.19
...
Diagnostic codes which are not in a link do not have a diagnostics page.
Change-Id: Ifedf15e8c956e91a9c498c2496ab9fa3e65844a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256782
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-08-30 14:14:18 +00:00
Alexander Aprelev
1583517b35
[changelog] Add CHANGELOG entry for landed File.create signature change.
...
Follow-up to 33846f3678
Change-Id: I6ed61ad407fe4b613809140052a800255b003b1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256431
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2022-08-26 20:43:13 +00:00
Sigurd Meldgaard
c02c9753c3
Reland "Bump pub to ec35d46261b610e558dfd0d8525ca3fc8387b4b7"
...
This is a reland of commit 78636aaea9
Original change's description:
> Bump pub to ec35d46261b610e558dfd0d8525ca3fc8387b4b7
>
> Changes:
> ```
> > git log --format="%C(auto) %h %s" ac7db6c..ec35d46
> https://dart.googlesource.com/pub.git/+/ec35d462 Fix null-safety warning in dart.dart (#3514 )
> https://dart.googlesource.com/pub.git/+/7d30cf0b Allow pubspec key 'funding' (#3529 )
> https://dart.googlesource.com/pub.git/+/8ff63a8e Fix remaining usages of path.prettyUri on git uris (#3524 )
> https://dart.googlesource.com/pub.git/+/bc32a30e Fix typo "exitcode" (#3511 )
>
> ```
>
> Diff: https://dart.googlesource.com/pub.git/+/ac7db6c07318efa4a8712110275eaf70f96a6d00~..ec35d46261b610e558dfd0d8525ca3fc8387b4b7/
> Change-Id: I535f4fab8940ee8400ef75369d35fb4c1ee3adab
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255990
> Reviewed-by: Sarah Zakarias <zarah@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Change-Id: I9c50c7b5ea01fc24cc97b328766ad7d2b9c4b36e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256280
Reviewed-by: Sarah Zakarias <zarah@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2022-08-25 11:16:32 +00:00
Sigurd Meldgaard
2559aba219
Revert "Bump pub to ec35d46261b610e558dfd0d8525ca3fc8387b4b7"
...
This reverts commit 78636aaea9
.
Reason for revert: This breaks the google3 roll. We need to roll frontend_server_client first.
Original change's description:
> Bump pub to ec35d46261b610e558dfd0d8525ca3fc8387b4b7
>
> Changes:
> ```
> > git log --format="%C(auto) %h %s" ac7db6c..ec35d46
> https://dart.googlesource.com/pub.git/+/ec35d462 Fix null-safety warning in dart.dart (#3514 )
> https://dart.googlesource.com/pub.git/+/7d30cf0b Allow pubspec key 'funding' (#3529 )
> https://dart.googlesource.com/pub.git/+/8ff63a8e Fix remaining usages of path.prettyUri on git uris (#3524 )
> https://dart.googlesource.com/pub.git/+/bc32a30e Fix typo "exitcode" (#3511 )
>
> ```
>
> Diff: https://dart.googlesource.com/pub.git/+/ac7db6c07318efa4a8712110275eaf70f96a6d00~..ec35d46261b610e558dfd0d8525ca3fc8387b4b7/
> Change-Id: I535f4fab8940ee8400ef75369d35fb4c1ee3adab
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255990
> Reviewed-by: Sarah Zakarias <zarah@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
TBR=sigurdm@google.com ,zarah@google.com
Change-Id: I9f46b5a63f8c3f0b11a9fe1d348696b1f988e5ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256080
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2022-08-23 09:58:30 +00:00
Sigurd Meldgaard
78636aaea9
Bump pub to ec35d46261b610e558dfd0d8525ca3fc8387b4b7
...
Changes:
```
> git log --format="%C(auto) %h %s" ac7db6c..ec35d46
https://dart.googlesource.com/pub.git/+/ec35d462 Fix null-safety warning in dart.dart (#3514 )
https://dart.googlesource.com/pub.git/+/7d30cf0b Allow pubspec key 'funding' (#3529 )
https://dart.googlesource.com/pub.git/+/8ff63a8e Fix remaining usages of path.prettyUri on git uris (#3524 )
https://dart.googlesource.com/pub.git/+/bc32a30e Fix typo "exitcode" (#3511 )
```
Diff: https://dart.googlesource.com/pub.git/+/ac7db6c07318efa4a8712110275eaf70f96a6d00~..ec35d46261b610e558dfd0d8525ca3fc8387b4b7/
Change-Id: I535f4fab8940ee8400ef75369d35fb4c1ee3adab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255990
Reviewed-by: Sarah Zakarias <zarah@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2022-08-23 08:44:09 +00:00
Paul Berry
b7567b1799
Flag additional code as unreachable due to types Null
and Never
.
...
Several unusual constructs that lead to unreachable code are now
recognized by flow analysis:
- Control flow after an expression of the form `e ?? other` or `e ??=
other`, where `e` has static type `Null` and `other` has static type
`Never`, is considered unreachable.
- Control flow predicated on an expression of the form `e is Never`
evaluating to `true` is considered unreachable.
- Control flow predicated on an expression of the form `e is! Never`
evaluating to `false` is considered unreachable.
- Control flow on the RHS of a null-aware access such as
`e?.property...`, `e?.property = ...` or `e?.method(...)`, where `e`
has static type `Null`, is considered unreachable (Note: this can
arise in the presence of extension methods).
Previously, these behaviors only took effect if `e` was a reference to
a local variable.
Note: the change to `regress/issue_31180` is because I’ve corrected
the behavior of implicit temporary variables to not undergo a type
change from `Null` to `dynamic`, so the dead code part of `null?[1]`
is now erroneous. (I had to make this change in order for the last
bullet above to work properly; without it, the type change to
`dynamic` prevents flow analysis from recognizing that the code to the
right of `?.` is unreachable.) There's no behavioral change to
correct code, but I've captured the behavioral change to incorrect
code in
`tests/language_2/null_aware/null_aware_index_on_null_error_test.dart`.
Bug: https://github.com/dart-lang/sdk/issues/49635
Change-Id: I8b24b3b040a34f897c0b61dcb9bd105be6d0af6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251280
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2022-08-22 16:50:19 +00:00
William Hesse
321c4970ed
Update CHANGELOG.md for 2.17.7 patch release
...
This is a patch release that:
- Fixes a crash in the debugger (issue [#49430 ][]).
[#49430 ]: https://github.com/dart-lang/sdk/issues/49430
Bug: https://github.com/dart-lang/sdk/issues/49430
Change-Id: I9b1e4f7422be502a08ab7f199effed3e799311ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255985
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2022-08-22 08:36:37 +00:00
Lasse R.H. Nielsen
a5f25ee3ba
Add Isolate.run
.
...
Adds static method on `Isolate` to run an asynchronous function
in a separate isolate.
Change-Id: I673373fa02524f1d0b88099027cfaf1b796eb344
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254960
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2022-08-18 10:42:55 +00:00
Sigmund Cherem
fead8b897e
[dart2js] remove support for reading sources from http (tech-debt)
...
Long ago the compiler had logic for reading sources via an http
connection. This is not a supported use case and there is no need to
keep this around anymore.
Change-Id: Ic59c154def264a52d9310133f76b153c9972899c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251701
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2022-08-16 00:01:26 +00:00
Michael Thomsen
c34b72482e
Remove deprecated APIs from dart:convert
...
Contributes to bug: https://github.com/dart-lang/sdk/issues/34233
Change-Id: I443fa14342680b61bf7357d40347427200fea29b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247741
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
2022-08-09 10:21:22 +00:00
pq
11e2bf94e3
linter 1.27.0
...
Flutter engine fixes: https://github.com/flutter/engine/pull/35100
Flutter tools fixes: https://github.com/flutter/flutter/pull/108836
Flutter plugins test fixes: https://github.com/flutter/plugins/pull/6173
Flutter plugins script fixes: https://github.com/flutter/plugins/pull/6175
Flutter plugins testing/scenario_app: https://github.com/flutter/engine/pull/35165
(Internal) linter test execution fixes: cl/464897186
Change-Id: Ica7cbcba7599d1367fc67e088ff634398a160df7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253501
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-08-08 21:40:30 +00:00
Sigurd Meldgaard
29e56e9d09
Bump pub to ac7db6c07318efa4a8712110275eaf70f96a6d00
...
Changes:
```
> git log --format="%C(auto) %h %s" 9bf4289..ac7db6c
https://dart.googlesource.com/pub.git/+/ac7db6c0 Fix string shortening (#3512 )
https://dart.googlesource.com/pub.git/+/4ed0d5cd Add pubspec_overrides.yaml to basicIgnoreRules (#3503 )
https://dart.googlesource.com/pub.git/+/d8f4c549 Remove all support for legacy .packages file (#3507 )
https://dart.googlesource.com/pub.git/+/1722b6a8 Update 2-BUG.md (#3495 )
https://dart.googlesource.com/pub.git/+/e60ef647 Add lint avoid_print (#3475 )
```
Diff: https://dart.googlesource.com/pub.git/+/9bf4289d6fd5d6872a8929d6312bbd7098f3ea9c~..ac7db6c07318efa4a8712110275eaf70f96a6d00/
Change-Id: I730a048dbf10992270f74ddde47824cc071a3994
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253663
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2022-08-04 13:38:46 +00:00
Srujan Gaddam
409b426cfc
[dart:html] Add SharedArrayBuffer constructor and slice
...
Fixes https://github.com/dart-lang/sdk/issues/35344
Change-Id: I5742adddf1fe01bfe40860a734a4c930091d8472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253563
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2022-08-03 01:04:25 +00:00
Sigmund Cherem
b62e612dc8
[dart:html] Deprecate custom element registration APIs.
...
The `registerElement` APIs in `dart:html` are legacy APIs based on a
deprecated Web Components v0.5 specification. These methods don't work
on modern browsers and can only be used with a polyfill.
The latest Web Components specification is supported indirectly via
JSInterop and doesn't have an explicit API in the `dart:html` library.
This change marks these APIs as deprecated. We intend to remove them in
the future (see https://github.com/dart-lang/sdk/issues/49536 )
Fixes https://github.com/dart-lang/sdk/issues/48973
Change-Id: I2e96d36e95c9971b59cde80bc4da49b63d12b17c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252840
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
2022-07-28 16:07:30 +00:00
Michael Thomsen
e84412af45
Remove unsupported APIs in dart:mirrors
...
Contributes to bug: https://github.com/dart-lang/sdk/issues/34233
Fixes https://github.com/dart-lang/sdk/issues/32507
Change-Id: Iee72e9f91fc1fc49761e6f5e6e9dba412493c8ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248003
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2022-07-20 18:28:35 +00:00
Michael Thomsen
04ae05beae
Changelog entry for .packages breaking change
...
Change-Id: I40d03b47a9f0e4ebe4d3c95d8ab8101a2fd0f7b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251765
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2022-07-19 08:03:54 +00:00
Michael Thomsen
f667180626
Fix dart:developer changelog.
...
This content was added in the wrong place in https://dart-review.googlesource.com/c/sdk/+/251767 .
Change-Id: Ifce9d9258e7f3f420c9d8081f76648c5891985c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251943
Reviewed-by: William Hesse <whesse@google.com>
2022-07-19 07:58:08 +00:00
Michael Thomsen
e15d639827
Remove deprecated APIs from dart:developer
...
Contributes to bug: https://github.com/dart-lang/sdk/issues/34233
Change-Id: I18f12b8c8da2ec444911128b96111e93df6c0496
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251767
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2022-07-19 07:10:03 +00:00
Brian Quinlan
981bcf61c9
Disallow invalid content-length.
...
Change-Id: I502c80f6d5914683622272cca37b5ba324f9262f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248840
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-07-19 00:44:33 +00:00
Alexander Thomas
f2bd1e9641
[release] Move CHANGELOG entries to 2.18
...
Change-Id: I35d887541c8de985b55daed7c732c0d8302d278a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251542
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
2022-07-14 14:13:28 +00:00
Ben Konyi
4c263d3754
[ dart:developer ] Add deprecation message to MAX_USER_TAGS
...
Follow up to https://dart-review.googlesource.com/c/sdk/+/251120/
Change-Id: Ib7fa8d1ece6d3301489f70d58793b65e0c1cfe0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251240
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2022-07-12 15:40:12 +00:00
William Hesse
3224487a07
Update CHANGELOG.md for 2.17.6 patch release
...
This is a patch release that fixes:
- Improve code completion for Flutter (issue [#49054 ][]).
- Fix crash on ARM (issue [#106510 ][]).
- Fix compiler crash with Finalizable parameters (issue [#49402 ][]).
[#49054 ]: https://github.com/dart-lang/sdk/issues/49054
[#106510 ]: https://github.com/flutter/flutter/issues/106510
[#49402 ]: https://github.com/dart-lang/sdk/issues/49402
Change-Id: I9a814603d9793b75b764fd0f384e89017e773c50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251109
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2022-07-12 10:06:12 +00:00
pq
3efd79b4b5
linter 1.26.0
...
Change-Id: I0a20fd9f26933908f6c40cb1019fca45b9a88299
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250949
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-07-11 20:00:21 +00:00
Alexander Markov
5a067e91bb
Describe new async/async*/sync* implementation in CHANGELOG.
...
Issue: https://github.com/dart-lang/sdk/issues/48378
Change-Id: I0cfff561a06c402603ad4f2b977821b572cb6e21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250408
Reviewed-by: Slava Egorov <vegorov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2022-07-06 15:17:50 +00:00
Janice Collins
822cd1cbd5
Remove dartanalyzer from built SDK.
...
Bug: https://github.com/dart-lang/sdk/issues/48457
Change-Id: Ic0d038299712989b8445859590ff870ce3bdc13a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249662
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-07-01 17:43:20 +00:00
William Hesse
ff03ff9f77
[release] Add changelog for 2.17.5
...
Because of a problem releasing 2.17.4, a new stable release 2.17.5
is being created with no additional changes. Since 2.17.4 will not
be published, the changelog entry is changed to refer to 2.17.5.
Change-Id: Ibf4c83268790ccca54eb375a3a958dd56ce538d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249189
Reviewed-by: Michael Thomsen <mit@google.com>
2022-06-27 08:35:29 +00:00
Lasse R.H. Nielsen
a08a5c5d6c
Deprecate BidirectionalIterator
.
...
There is only one use of it in the SDK, `RuneIterator`,
one use of it outside, `TreeSet` from `package:quiver`,
and one known use in Google internal code.
There are other bi-directional iteration interfaces,
like `CharacterRange` from `package:characters`,
which can move a cursor in two directions,
but which didn't loke the `movePrevious` name and therefore
are not `BidirectionalIterator`s.
(There is also a Google internal class which mentions explicitly
why they're not `BidirectionalIterator`.)
There is no real need for this "shared" interface.
It doesn't carry its own weight.
We have no abstractions which work on the *interface*,
only code that works on one specific concrete implementation.
I'd recommend:
* `quiver` introduce a `TreeSetIterator` for their use-case
(the actual class has more public members than `BidirectionalIterator`,
which cannot be accessed through the declared type.)
* the Google internal code introduces its own interface
(which is just `Iterable` + `movePrevious`.
* The SDK will just make `RuneIterator` not implement
`BidirectionalIterator` at some (breaking) point.
Maybe just when we remove the type.
FLUTTER: Needs to land https://github.com/flutter/flutter/pull/106471 before merging this CL into Flutter.
Change-Id: Iaaa6b0c428d30eb3b68898c077d265ac0a622805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249486
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2022-06-24 14:21:29 +00:00
William Hesse
2118a4b813
[release] Add 2.17.4 release notes
...
This is a patch release that fixes:
- Improve analysis of enums and switch (issue [#49188 ]).
- Fix compiler crash when initializing Finalizable objects (issue [#49075 ]).
[#49188 ]: https://github.com/dart-lang/sdk/issues/49188
[#49075 ]: https://github.com/dart-lang/sdk/issues/49075
Change-Id: If2059474ce2acbadf7f3c6e407f0087d262e2842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249161
Reviewed-by: Michael Thomsen <mit@google.com>
2022-06-20 14:36:33 +00:00
Lasse R.H. Nielsen
330759efc0
Refactor to implement Stream.fromIterator
more directly.
...
The current implementation uses a specialized version of the
pending-event queue used by stream subscriptions to remember
pending events.
That makes the queue polymorphic, and slightly more complicated than
necessary, and that again makes further refactorings of the
Stream implementation harder.
This change moves the logic from the specialized pending-queue
into a simple function instead, so you only pay for it if you
actually use `Stream.fromIterable`.
Also allows `Stream.fromIterable` to be listened to more than once.
(It uses `Stream.multi` for the general async+sync controller API,
and it would cost extra code to make it only work once.)
Change-Id: I44b2010225cd3d32c2bcdb8a315c94881331bdae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248146
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2022-06-16 11:39:30 +00:00
Ahmed Ashour
85700570f6
Fix typos
...
Fixes #49241
TEST=ci
Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-06-15 11:08:28 +00:00
Sigmund Cherem
69249df50b
[web] remove top-level scripts for dartdevc and dart2js.
...
This completes the breaking change that was previously announced in
https://github.com/dart-lang/sdk/issues/46100
Change-Id: Ie81665e7932fe00a8c1fee9f67ee8294cd4c89e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248342
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
2022-06-14 18:29:17 +00:00
Johnni Winther
7900e9071a
[cfe] Remove support for old super-mixins feature
...
This CL remove the support for mixing in classes that don't extend
Object. An error has been report by the analyzer for some time and
now also by the CFE.
This puts the breaking change https://github.com/dart-lang/sdk/issues/48167 into effect.
TEST=pkg/front_end/testcases/general/issue48167.dart
Change-Id: Ia7715a27dc1aa18a7c85b24ed86d19a91b6924d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247551
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2022-06-13 15:30:57 +00:00
Sigurd Meldgaard
2aa637afce
Bump pub to c4e9ddc888c3aa89ef4462f0c4298929191e32b9
...
Changes:
```
> git log --format="%C(auto) %h %s" 51435ef..c4e9ddc
https://dart.googlesource.com/pub.git/+/c4e9ddc8 Extend retries for file-ops on windows (#3451 )
https://dart.googlesource.com/pub.git/+/6aeb1795 Upgrade package:lints to 2.0.0 (#3445 )
https://dart.googlesource.com/pub.git/+/73ea9a98 Roll tar to 0.5.5+1 (#3447 )
https://dart.googlesource.com/pub.git/+/2dc887fe Add env var for writing golden files (#3222 )
https://dart.googlesource.com/pub.git/+/764500b8 List all files in pub publish (#3440 )
https://dart.googlesource.com/pub.git/+/0b52e6a8 Remove debug print (#3441 )
https://dart.googlesource.com/pub.git/+/ea070238 Merge pull request #3443 from jonasfj/master
https://dart.googlesource.com/pub.git/+/bffd1267 Merge branch 'cherry-pick-for-2.17.2'
https://dart.googlesource.com/pub.git/+/c66381c5 Make `name` field of `_UserInfo` nullable. Fix #3424 (#3442 )
https://dart.googlesource.com/pub.git/+/cecc8e3c Handle broken response from userinfo_endpoint (#3427 )
https://dart.googlesource.com/pub.git/+/6c635040 Make `name` field of `_UserInfo` nullable. Fix #3424 (#3442 )
https://dart.googlesource.com/pub.git/+/6f20a94b Handle missing pubspec.lock in dependency_services list (#3439 )
https://dart.googlesource.com/pub.git/+/0ad17e84 Handle broken response from userinfo_endpoint (#3427 )
https://dart.googlesource.com/pub.git/+/153ef061 `pub add` create top-level attribute in block-style if possible. (#3423 )
https://dart.googlesource.com/pub.git/+/3b96f910 Handle error code 183 on windows (#3426 )
https://dart.googlesource.com/pub.git/+/9eb6428c Ignore `pubspec_overrides.yaml` for `publish` command (#3419 )
```
Diff: https://dart.googlesource.com/pub.git/+/51435efcd574b7bc18d47a5dd620cb9759dea8f8~..c4e9ddc888c3aa89ef4462f0c4298929191e32b9/
Change-Id: I6dacb3e95c6399d3fb5cf340b5d0e5cded270684
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247962
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2022-06-13 08:39:56 +00:00
Brian Quinlan
d32a274c90
Add a breaking change note for #49045
...
Bug: https://github.com/dart-lang/sdk/issues/49045
Change-Id: I9ac976545c0505a20a90f12333a424d0ed8cf96f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247820
Commit-Queue: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2022-06-09 19:28:25 +00:00
Michael Thomsen
da050a2b16
Reland "Remove SCREAMING dart:io networking APIs"
...
This is a reland of commit abfdc3d50f
Original change's description:
> Remove SCREAMING dart:io networking APIs
>
> Bug: https://github.com/dart-lang/sdk/issues/49140
> Change-Id: I50c6cca26597ee4d469b776fcec412ddfed760e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246962
> Reviewed-by: Paul Berry <paulberry@google.com>
> Commit-Queue: Michael Thomsen <mit@google.com>
Bug: https://github.com/dart-lang/sdk/issues/49140
Change-Id: I64a4bdb69909dd864e84efae7dc423fc435e40ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247543
Reviewed-by: Oleh Prypin <oprypin@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
2022-06-08 16:57:32 +00:00
Oleh Prypin
159887ff78
Revert "Remove SCREAMING dart:io networking APIs"
...
This reverts commit abfdc3d50f
.
Reason for revert: breaks on internal roll - b/235267735 and others can be fixed in advance of landing this
Original change's description:
> Remove SCREAMING dart:io networking APIs
>
> Bug: https://github.com/dart-lang/sdk/issues/49140
> Change-Id: I50c6cca26597ee4d469b776fcec412ddfed760e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246962
> Reviewed-by: Paul Berry <paulberry@google.com>
> Commit-Queue: Michael Thomsen <mit@google.com>
TBR=mit@google.com ,paulberry@google.com
Change-Id: I55a43cc1bd7435fe7824f7ca8098575232fdcf2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/49140
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247389
Commit-Queue: Oleh Prypin <oprypin@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Oleh Prypin <oprypin@google.com>
2022-06-08 07:22:31 +00:00
pq
a362115c60
bump to linter 1.25.0
...
Change-Id: Ie709139029d1f58cef4807708ff054acb0fba6cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247363
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2022-06-07 17:59:29 +00:00
Michael Thomsen
abfdc3d50f
Remove SCREAMING dart:io networking APIs
...
Bug: https://github.com/dart-lang/sdk/issues/49140
Change-Id: I50c6cca26597ee4d469b776fcec412ddfed760e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246962
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
2022-06-07 16:00:17 +00:00
Nate Bosch
75ed6c01fb
Make path argument optional for Uri.http(s)
...
Closes #49165
The empty string argument can be confusing to read since it is not clear
what it means. Allow omitting the argument entirely to default to an
empty path.
R=lrn@google.com
Change-Id: I05ca432a679a0df751a16d1beb241b14f80d4681
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246988
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
2022-06-03 18:07:27 +00:00
William Hesse
11d63e3fa0
[release] Add 2.17.3 release notes
...
Change-Id: I92ba9f098153a52797c2e294e36cb197d7b69f48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246640
Reviewed-by: Alexander Thomas <athom@google.com>
2022-06-01 08:38:51 +00:00
Jonas Termansen
83850ac5fa
[io] Don't restore terminal state on exit.
...
This is breaking change #45630 .
The Dart VM has until now restored the terminal settings upon exit to
their initial values for stdin, stdout, and stderr. This change removes
that automatic behavior in favor of having the program do the
restoration. Previously the intention was that dart programs can
enable/disable echoing and line buffering and not worry about restoring
the original settings.
However, the VM doing so unconditionally leads to undesirable behavior
e.g. when the program does not care about terminal settings and is
sharing a process group with a program that does care. E.g. if dart's
output is piped into less(1), then there is a race condition where dart
might see the raw terminal settings set by less(1), and if the dart VM
exits after less(1) has exited, then it will restore the raw terminal
settings, leaving the user with a seemingly defective shell with echo
disabled. This race condition can be reproduced using:
cat > yes.dart << EOF
main() {
for (int i = 0; i < 1000000; i++) {
print("yes");
}
}
EOF
stty; (sleep 1 && dart yes.dart) | less; stty; stty sane
The user will end up with a shell with echo behavior disabled. The stty
command shows the current terminal settings, where the difference can be
seen, and 'stty sane' fixes the settings before returning to the shell
prompt. The 'stty sane' call can be omitted to see the defective shell
prompt.
This change removes the terminal restoring behavior (added in Dart
2.0.0) and instead asks applications to do the restoration themselves.
The new design matches how programs in other programming languages
implement interactive input that changes terminal settings.
Furthermore the `echoMode` setting now only controls the `echo` local
mode and no longer sets the `echonl` local mode on POSIX systems (which
controls whether newline are echoed even if the regular echo mode is
disabled). The `echonl` local mode is usually turned off in common shell
environments. Programs that wish to control the `echonl` local mode can
use the new `echoNewlineMode` setting. This change is required to
prevent the reoccurence of #30318 when programs manually restore
`echoMode`.
Windows has further considerations: It also saves the console code pages
and restore them if they were not UTF-8. This behavior is retained as it
is useful and needed for Dart's output to function properly. ANSI output
sequences are also turned on via ENABLE_VIRTUAL_TERMINAL_PROCESSING,
which is slightly changed in this change to only rsetore that setting if
it wasn't already on for consistency.
Closes https://github.com/dart-lang/sdk/issues/36453
Closes https://github.com/dart-lang/sdk/issues/45630
TEST=Reproduced with less as above
Change-Id: I2991f9c7f47b97fe475c1ad6edeb769024f8d0db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190484
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2022-05-31 15:36:33 +00:00
William Hesse
c326007193
[release] Add 2.17.2 release notes
...
Change-Id: I18e92d65698804073de8c9920d7aca08283dfb60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246441
Reviewed-by: Alexander Thomas <athom@google.com>
2022-05-30 14:50:39 +00:00
Paul Berry
0a92b0c3aa
Turn on the experimental feature inference-update-1
.
...
Fixes https://github.com/dart-lang/language/issues/731 .
Change-Id: I5fee1470efe7b891b79dcfecd33bc3670590efb3
Tested: trybots, and global presubmit in the internal mono repo
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243530
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
2022-05-24 13:54:23 +00:00
pq
5ee3a6f07a
bump to linter 1.24.0
...
(I did a `find_violations` run internally against cl/449544481 and all clear 🟢 .)
Change-Id: I2375a42244902ee2da515417cb463f74d9949387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245224
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-05-19 00:20:30 +00:00
Alexander Thomas
9fb27f9842
[release] Add 2.17.1 release notes
...
Change-Id: I9c3489f75745be85437c4e5927ab15b4c8edd68c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245022
Reviewed-by: Michael Thomsen <mit@google.com>
2022-05-17 17:10:33 +00:00
Joshua Litt
c6d5cd043b
[js_util] Add dartify
and some helpers.
...
Change-Id: I40822d87a7fef9e4de563ccb73046eee78f34b21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243846
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
2022-05-16 21:31:47 +00:00
Sigurd Meldgaard
8188d2824a
Bump pub to 51435efcd574b7bc18d47a5dd620cb9759dea8f8
...
Changes:
```
> git log --format="%C(auto) %h %s" 1e3c17e..51435ef
https://dart.googlesource.com/pub.git/+/51435efc Reland "Add flag controlling creation of `.packages` file." (#3413 )
```
Diff: https://dart.googlesource.com/pub.git/+/1e3c17ea871e6a80c720aa998f37cbd3913bc287~..51435efcd574b7bc18d47a5dd620cb9759dea8f8/
Change-Id: Ic6e28328827cf9aada1272decf4d95fc6a649c90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244623
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2022-05-12 13:37:36 +00:00
Sigurd Meldgaard
28e8202c14
Bump pub to 1e3c17ea871e6a80c720aa998f37cbd3913bc287
...
Changes:
```
> git log --format="%C(auto) %h %s" 6068f47..1e3c17e
https://dart.googlesource.com/pub.git/+/1e3c17ea dependency_services: use revisions as versions for git deps. (#3383 )
https://dart.googlesource.com/pub.git/+/9ecdd6b1 show discontinued in pub outdated (#3399 )
https://dart.googlesource.com/pub.git/+/c8fdf231 Bump analyzer from 3.4.1 to 4.0.0 (#3412 )
```
Diff: https://dart.googlesource.com/pub.git/+/6068f47c264ef790e16411b31b2c94ad6beb1ab6~..1e3c17ea871e6a80c720aa998f37cbd3913bc287/
Change-Id: Idb9484e36d03001039e9f7e5447c659b85bd093f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244621
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2022-05-12 12:06:45 +00:00
Parker Lougheed
ba05fc9f1d
Moves linter 1.23.0 changelog entry to 2.18
...
Change-Id: I686fd2c6a35be1205cc2c5161dd8f8fcc4b1bb7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244305
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2022-05-11 18:46:44 +00:00
pq
226fceaef2
bump to linter 1.23.0
...
Tested internally w/ `blaze run //ads/acx/devcycle/lints/find_violations -- 446742744`. Should be a clean roll.
Change-Id: I5ebd2fab7b79e108a82e2790fcb754e74767e435
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242391
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-05-06 16:08:50 +00:00
Robert Nystrom
65e751c5c3
Add 2.17 language features to CHANGELOG.
...
Change-Id: I64716576bf387d85f2e42e7ef439e3e9cff36392
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243400
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2022-05-03 01:24:46 +00:00
Srujan Gaddam
560579b584
Move connectionState/onConnectionStateChange to 2.18 in CHANGELOG
...
Change-Id: I272191c7b0adf1420d87f8264f6d2ef55b7b687d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240482
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2022-04-06 23:26:47 +00:00
Chris Terefinko
ecbf11b8d8
[dart2js] Add missing connectionState and onConnectionStateChange to RTCPeerConnection.
...
Closes https://github.com/dart-lang/sdk/issues/48735
Change-Id: I04f263afa4dee1b868ad254cb54ad7c398435e03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240240
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2022-04-06 22:34:07 +00:00
Daco Harkes
d2e2c95cb6
[vm/ffi] Update dart:ffi
entries in changelog
...
Standardize the `dart:ffi` changelog entries header on:
```
### Core Libraries
#### `dart:ffi`
```
Add entries for new additions in last couple of versions. (So far we
mostly only documented breaking changes.)
Bug: https://github.com/dart-lang/sdk/issues/48711
Change-Id: I095c966ad2a1d7123e6543fd19de7af57a573d36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240047
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2022-04-05 14:57:53 +00:00
Lasse R.H. Nielsen
d063ac3233
Revert Isolate.run
.
...
The current VM closure serialization makes this function a foot-gun.
Revert until the supporting features are improved, so as to not give
users a bad experience.
Change-Id: I83b6b453ce5ab00d49ffbf36a5763119a6435352
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237940
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2022-03-31 09:42:34 +00:00
Brian Quinlan
c286b76c2d
Allow sockets to enable TLS renegotiation.
...
TESTED=unit + manually tested user issue.
Bug: https://github.com/dart-lang/sdk/issues/47841
Change-Id: Iad13899135fd34f15abba3a499132d88e7f597dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234821
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-03-31 06:40:51 +00:00
Sigurd Meldgaard
c78ef90124
Bump pub to a3a102a549388a6dbfecc9252fabb618f9a2f5f7
...
Changes:
```
> git log --format="%C(auto) %h %s" 8f5ab7b..a3a102a
https://dart.googlesource.com/pub.git/+/a3a102a5 Fix equality and hashcode for the sdk descriptors (#3367 )
https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212 )
https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346 )
https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361 )
https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305 )
https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358 )
https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215 )
https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356 )
https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757 )" (#3357 )
https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359 )
https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354 )
https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352 )
https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349 )
https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347 )
https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341 )
https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340 )
https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335 )
https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332 )
https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331 )
https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330 )
https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313 )
https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320 )
https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311 )
https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304 )
https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297 )
https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295 )
https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757 )
```
Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..a3a102a549388a6dbfecc9252fabb618f9a2f5f7/
Change-Id: I8d0ea375039ea450d397871d9fac35d590ea8869
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239315
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2022-03-30 09:34:50 +00:00
Sam Rawlins
248b27c37f
Bump dartdoc to ~5.1.0
...
Change-Id: Iee217a3cab8653828b7437cf89c68d31c41dd284
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239241
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-03-29 17:10:49 +00:00
Sigurd Meldgaard
afe5e06381
Revert "Bump pub to 94ae66a660cc187cc46ceaf1ab96bdcf8d48a313"
...
This reverts commit 6e00bb17b8
.
Reason for revert: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-engine-linux/16089/overview
Original change's description:
> Bump pub to 94ae66a660cc187cc46ceaf1ab96bdcf8d48a313
>
> Changes:
> ```
> > git log --format="%C(auto) %h %s" 8f5ab7b..94ae66a
> https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212 )
> https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346 )
> https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361 )
> https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305 )
> https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358 )
> https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215 )
> https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356 )
> https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757 )" (#3357 )
> https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359 )
> https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354 )
> https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352 )
> https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349 )
> https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347 )
> https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341 )
> https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340 )
> https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335 )
> https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332 )
> https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331 )
> https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330 )
> https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313 )
> https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320 )
> https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311 )
> https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304 )
> https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297 )
> https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295 )
> https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757 )
>
> ```
>
> Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..94ae66a660cc187cc46ceaf1ab96bdcf8d48a313/
> Change-Id: I121fa281ad77991ef10938a3c228ce1d62e748db
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238901
> Reviewed-by: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
TBR=sigurdm@google.com ,jonasfj@google.com
Change-Id: I2402e8647ad79a613d8be55a85a7f05f511a4081
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239301
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2022-03-29 13:12:47 +00:00
Sigurd Meldgaard
6e00bb17b8
Bump pub to 94ae66a660cc187cc46ceaf1ab96bdcf8d48a313
...
Changes:
```
> git log --format="%C(auto) %h %s" 8f5ab7b..94ae66a
https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212 )
https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346 )
https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361 )
https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305 )
https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358 )
https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215 )
https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356 )
https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757 )" (#3357 )
https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359 )
https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354 )
https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352 )
https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349 )
https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347 )
https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341 )
https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340 )
https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335 )
https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332 )
https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331 )
https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330 )
https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313 )
https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320 )
https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311 )
https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304 )
https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297 )
https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295 )
https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757 )
```
Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..94ae66a660cc187cc46ceaf1ab96bdcf8d48a313/
Change-Id: I121fa281ad77991ef10938a3c228ce1d62e748db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238901
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2022-03-29 09:14:45 +00:00
pq
7d94674a90
bump to linter 1.22.0
...
Change-Id: I523e7ffbc8d17e84d46b3f203327de628bac6986
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-03-28 20:18:30 +00:00
Srujan Gaddam
3f1c69dd1d
[dart:html] Fix Performance.mark typing to work with Firefox
...
Closes https://github.com/dart-lang/sdk/issues/48630
'mark' can return undefined in Firefox, and therefore needs to
return a nullable. Similarly, the different syntaxes of 'measure'
don't work in Firefox or Safari, so the incompatible ones are
removed from tests.
Change-Id: Ia137fe0d72ddbaad03ae8cf58c43736b128b3f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237930
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2022-03-22 19:37:00 +00:00
Alexander Thomas
a999d2182c
[release] Add 2.16.2 release notes
...
Change-Id: I099b090401af4280f13b42eea21fc0ca13379495
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238044
Reviewed-by: Michael Thomsen <mit@google.com>
2022-03-22 08:54:56 +00:00
Srujan Gaddam
2444bcca59
Fix Performance.mark and measure
...
Closes https://github.com/dart-lang/sdk/issues/48430
Adds overloads for both methods to accept additional/different options.
Also changes return types:
- mark returns a PerformanceEntry
- measure returns a PerformanceMeasure, but this may be undefined, so it's
marked as nullable
Change-Id: I189c4613b19e214a1f5bcc5bbd780d9dc447d9e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235286
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2022-03-21 18:58:38 +00:00
pq
ccd9a027c1
linter 1.21.2
...
Change-Id: I877cbfdcf7302ed830ad8a84f87c4cae62a34fbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237922
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-03-21 18:27:37 +00:00
pq
ccb4157309
bump to linter 1.21.1
...
Fixes: https://github.com/flutter/flutter/issues/100297
Change-Id: I240d8bfd77f48830b91ed80329dc6a2352e1cb8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-03-18 19:56:21 +00:00
Paul Berry
fd02fec0fc
Remove deprecated "SCREAMING CAPS" constants from dart:io.
...
Fixes #34218 .
Bug: https://github.com/dart-lang/sdk/issues/34218
Change-Id: Ibe936dc6ed8951b2a0c53997b7d33bb8c7afe8cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236840
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2022-03-17 23:00:57 +00:00
pq
c305b6b6f0
bump linter to 1.20.0
...
Change-Id: I44ca585b3cf3649983955a2202c8fb093677329a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237184
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-03-15 17:09:22 +00:00
pq
3778e79365
fix misplaced linter change entries for 2.17
...
See: 75e03d7875 (commitcomment-68437878)
Change-Id: I37e17fec16c7b76df390421f61ba16a8ea24cdc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-03-14 15:56:38 +00:00
pq
75e03d7875
linter 1.19.2
...
Change-Id: Ied72b70663dee8cb91ebc18204464baa2a9644b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2022-03-08 23:34:54 +00:00
Sigurd Meldgaard
4cd91b983b
Reland "Reland "Remove the pub top-level""
...
This is a reland of 7bb6841815
Original change's description:
> Reland "Remove the pub top-level"
>
> This is a reland of 872ffa85c2
>
> Original change's description:
> > Remove the pub top-level
> >
> > The old pub toplevel interface is still reachable via
> >
> > ```
> > $ dart __deprecated_pub
> > ```
> >
> > That is what `flutter pub` is using.
> >
> > Part of https://github.com/dart-lang/sdk/issues/46100
> >
> > Bug: https://github.com/dart-lang/pub/issues/3292
> > Change-Id: I97a14f2458d0f67c7bf98a90664d504cfaba0e98
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229541
> > Reviewed-by: Jonas Jensen <jonasfj@google.com>
> > Reviewed-by: Michael Thomsen <mit@google.com>
> > Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
>
> Bug: https://github.com/dart-lang/pub/issues/3292
> Change-Id: I45b5bf93f30c8abad4558cb15b61289c6c786f65
> Cq-Include-Trybots: luci.dart.try:flutter-engine-linux-try,flutter-engine-linux-web_tests-try,flutter-frontend-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231943
> Reviewed-by: Jonas Jensen <jonasfj@google.com>
> Reviewed-by: Michael Thomsen <mit@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Bug: https://github.com/dart-lang/pub/issues/3292
Change-Id: I132e965a7097cf438dd90e04012a782eb5489798
Cq-Include-Trybots: luci.dart.try:flutter-engine-linux-try,flutter-engine-linux-web_tests-try,flutter-frontend-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234283
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2022-03-07 12:16:28 +00:00
Lasse R.H. Nielsen
05322f23dd
Add Isolate.run
.
...
Change-Id: I049f6b1bf684ed28b6f14d380adfadf9f4e97fcb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217008
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2022-03-03 11:43:10 +00:00
Brian Quinlan
cdcc221d60
Remove renegotiate.
...
TESTED=deprecation does not break unit tests.
Bug: https://github.com/dart-lang/sdk/issues/42771
Change-Id: I5c661ef91285a117c881cb15d26ab40cfd185a70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234880
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-03-02 19:50:50 +00:00
Michael Thomsen
f8ef1b7f42
Update CHANGELOG.md wrt template names
...
Related to https://dart-review.googlesource.com/c/sdk/+/232800
Closes https://github.com/dart-lang/sdk/pull/48482
https://github.com/dart-lang/sdk/pull/48482
GitOrigin-RevId: b553c853521e035bf4df431284fc28af72aa64a0
Change-Id: Ic49d669c5e665cd0f03a05b720b7cb4b62239b96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234561
Reviewed-by: Devon Carew <devoncarew@google.com>
2022-02-28 16:02:54 +00:00
Lasse R.H. Nielsen
a3e39fadd6
Make UriData
more case-insensitive.
...
Add `isMimeType` method to `UriData` class, to allow case-insensitive
checking of the MIME type.
Add `isCharset` and `isEncoding` methods to `UriData` class,
to allow case-insensitive and alternative-encoding-name aware checking
of the MIME type "charset" parameter.
Make `UriData.fromString` and `UriData.fromBytes` recognize and omit
a "text/plain" `mimeType` even if it is not all lower-case.
Be case-insensitive in a few cases where we weren't before
(like the `charset` getter not recognizing `CHARSET=utf-8`.)
Fixes #28592
TEST=corelib/data_uri_test.dart updated
BUG= http://dartbug.com/28592
Change-Id: Ia885af69d271856af7fadfe93851e07eff6ddca2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217366
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2022-02-22 10:47:41 +00:00
Brian Quinlan
917ae52f70
Add the ability to log TLS keys.
...
TEST=unit tests
Bug: https://github.com/dart-lang/sdk/issues/47838
Change-Id: I8a64e8623022215cae261eadb25b22deb9f3d910
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231330
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-02-17 21:39:31 +00:00
Brian Quinlan
f056a4515d
Reland "Add the ability to customize socket creation."
...
Will only submit this after the cbuild is green.
Bug: https://github.com/dart-lang/sdk/issues/42716
Change-Id: I228050594ce9897e388b4d5e446d3e4b94d08f12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232320
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-02-16 19:23:50 +00:00
Alexander Aprelev
d6a4edaf04
Revert "Add the ability to customize socket creation."
...
This reverts commit a0aeed9faa
.
Reason for revert: flutter and g3 buildbot regressions.
Original change's description:
> Add the ability to customize socket creation.
>
> Bug: https://github.com/dart-lang/sdk/issues/42716
> Change-Id: I9e854007f15ed54cc2d85a372bc145e1b90f5967
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231530
> Reviewed-by: Alexander Aprelev <aam@google.com>
> Commit-Queue: Brian Quinlan <bquinlan@google.com>
TBR=aam@google.com ,bquinlan@google.com
Change-Id: I55eede1b26e02b215c21339dacaf2a52857bdebd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/42716
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232280
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2022-02-09 21:48:34 +00:00
Brian Quinlan
a0aeed9faa
Add the ability to customize socket creation.
...
Bug: https://github.com/dart-lang/sdk/issues/42716
Change-Id: I9e854007f15ed54cc2d85a372bc145e1b90f5967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231530
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
2022-02-09 19:42:46 +00:00
Michael Thomsen
9a4b994232
Add older security advisories to changelog
...
Change-Id: I79a6d2065b7b2043401ee648a7238b8563729aff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232084
Reviewed-by: Alexander Thomas <athom@google.com>
2022-02-09 13:41:52 +00:00