Remove deprecated APIs from dart:convert

Contributes to bug: https://github.com/dart-lang/sdk/issues/34233

Change-Id: I443fa14342680b61bf7357d40347427200fea29b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247741
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>

CHANGELOG.md

@@ -4,7 +4,13 @@
 
 ### Libraries
 
-#### `dart:developer`
+#### `dart:convert`
+
+- **Breaking change** [#34233][]: The previously deprecated API
+  [`DEFAULT_BUFFER_SIZE`][] in [`JsonUtf8Encoder`] has been removed.
+
+[#34233]: https://github.com/dart-lang/sdk/issues/34233
+[`DEFAULT_BUFFER_SIZE`]: https://api.dart.dev/stable/2.17.6/dart-convert/JsonUtf8Encoder/DEFAULT_BUFFER_SIZE-constant.html
 
 #### `dart:developer`
 
@@ -15,7 +21,7 @@
   and `extensionErrorMin`.
 
 [#34233]: https://github.com/dart-lang/sdk/issues/34233
-[`ServiceExtensionResponse`]: https://api.dart.dev/stable/dart-developer/ServiceExtensionResponse-class.html#constants
+[`ServiceExtensionResponse`]: https://api.dart.dev/stable/2.17.6/dart-developer/ServiceExtensionResponse-class.html#constants
 
 - Deprecated `UserTag.MAX_USER_TAGS` in favor of `UserTag.maxUserTags`.
 

runtime/tests/vm/dart/regress38654_test.dart

@@ -154,7 +154,7 @@ Set<int> foo1(int par1, bool par2) {
                     Map.from({6: var9[var1], 28: foo0(), 36: '8+'})));
             var9[((-93 * loc1[loc2]) +
                 (((!((!(par2)))) || (!(par2)))
-                    ? (var4 ~/ JsonUtf8Encoder.DEFAULT_BUFFER_SIZE)
+                    ? (var4 ~/ 42)
                     : -9223372032559775745))] ??= var6;
           }
           var3 = ((!((loc1[loc0] != (false ? (--var4) : var1)))) ||

runtime/tests/vm/dart_2/regress38654_test.dart

@@ -156,7 +156,7 @@ Set<int> foo1(int par1, bool par2) {
                     Map.from({6: var9[var1], 28: foo0(), 36: '8+'})));
             var9[((-93 * loc1[loc2]) +
                 (((!((!(par2)))) || (!(par2)))
-                    ? (var4 ~/ JsonUtf8Encoder.DEFAULT_BUFFER_SIZE)
+                    ? (var4 ~/ 42)
                     : -9223372032559775745))] ??= var6;
           }
           var3 = ((!((loc1[loc0] != (false ? (--var4) : var1)))) ||

runtime/tools/dartfuzz/dartfuzz.dart

@@ -14,7 +14,7 @@ import 'dartfuzz_type_table.dart';
 // Version of DartFuzz. Increase this each time changes are made
 // to preserve the property that a given version of DartFuzz yields
 // the same fuzzed program for a deterministic random seed.
-const String version = '1.93';
+const String version = '1.94';
 
 // Restriction on statements and expressions.
 const int stmtDepth = 1;

runtime/tools/dartfuzz/dartfuzz_api_table.dart

@@ -973,8 +973,6 @@ class DartLib {
     DartLib('Int8List.bytesPerElement', [DartType.VOID, DartType.VOID], false),
     DartLib('Isolate.beforeNextEvent', [DartType.VOID, DartType.VOID], false),
     DartLib('Isolate.immediate', [DartType.VOID, DartType.VOID], false),
-    DartLib('JsonUtf8Encoder.DEFAULT_BUFFER_SIZE',
-        [DartType.VOID, DartType.VOID], false),
     DartLib('OSError.noErrorCode', [DartType.VOID, DartType.VOID], false),
     DartLib(
         'RangeError.checkNotNegative',
@@ -1785,8 +1783,6 @@ class DartLib {
     DartLib('Int8List.bytesPerElement', [DartType.VOID, DartType.VOID], false),
     DartLib('Isolate.beforeNextEvent', [DartType.VOID, DartType.VOID], false),
     DartLib('Isolate.immediate', [DartType.VOID, DartType.VOID], false),
-    DartLib('JsonUtf8Encoder.DEFAULT_BUFFER_SIZE',
-        [DartType.VOID, DartType.VOID], false),
     DartLib('OSError.noErrorCode', [DartType.VOID, DartType.VOID], false),
     DartLib(
         'RangeError.checkNotNegative',

sdk/lib/convert/json.dart

@@ -386,8 +386,6 @@ class JsonEncoder extends Converter<Object?, String> {
 class JsonUtf8Encoder extends Converter<Object?, List<int>> {
   /// Default buffer size used by the JSON-to-UTF-8 encoder.
   static const int _defaultBufferSize = 256;
-  @deprecated
-  static const int DEFAULT_BUFFER_SIZE = _defaultBufferSize;
 
   /// Indentation used in pretty-print mode, `null` if not pretty.
   final List<int>? _indent;