mirror of
https://github.com/dart-lang/sdk
synced 2024-10-01 16:44:02 +00:00
Spelling pkg
Closes https://github.com/dart-lang/sdk/pull/50921 GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23 Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
This commit is contained in:
Josh Soref
Commit Queue
parent
e6b89b2a8d
commit
9e4dc755cb
|
|
@ -1058,7 +1058,7 @@ them, you must set the lower bound on the SDK constraint for your package to
|
|||
removed (they were previously deprecated). Please use the corresponding
|
||||
`lowerCamelCase` constants instead.
|
||||
- **Breaking Change** [#48513](https://github.com/dart-lang/sdk/issues/48513):
|
||||
Add a new `allowLegacyUnsafeRenegotiation` poperty to `SecurityContext`,
|
||||
Add a new `allowLegacyUnsafeRenegotiation` property to `SecurityContext`,
|
||||
which allows TLS renegotiation for client secure sockets.
|
||||
- Add a optional `keyLog` parameter to `SecureSocket.connect` and
|
||||
`SecureSocket.startConnect`.
|
||||
|
|
|
|||
|
|
@ -62,7 +62,7 @@ class Monomorphic extends Base {
|
|||
: data1 = Uint8List(n)..setToOnes(),
|
||||
super('TypedDataPoly.mono.array', n);
|
||||
|
||||
/// An identical [sum] method appears in each benchmark so the the compiler
|
||||
/// An identical [sum] method appears in each benchmark so the compiler
|
||||
/// can specialize the method according to different sets of input
|
||||
/// implementation types.
|
||||
@pragma('vm:never-inline')
|
||||
|
|
@ -94,7 +94,7 @@ class Monomorphic extends Base {
|
|||
}
|
||||
|
||||
/// [Baseline] is modelled after [Monomorphic], but does almost no work in
|
||||
/// `sum`. This measures the the cost of benchmark code outside of `sum`.
|
||||
/// `sum`. This measures the cost of benchmark code outside of `sum`.
|
||||
class Baseline extends Base {
|
||||
final Uint8List data1;
|
||||
Baseline(int n)
|
||||
|
|
|
|||
|
|
@ -199,7 +199,7 @@ name: test
|
|||
return false;
|
||||
}
|
||||
// Library URIs are not available in protocol v1 so skip the check to
|
||||
// allow the the same test to verify for v2.
|
||||
// allow the same test to verify for v2.
|
||||
if (!isProtocolVersion1 &&
|
||||
libraryUri != null &&
|
||||
s.libraryUri != libraryUri) {
|
||||
|
|
|
|||
|
|
@ -120,7 +120,7 @@ class LiteralType extends TypeBase with LiteralValueMixin {
|
|||
/// A special class of Union types where the values are all literals of the same
|
||||
/// type.
|
||||
///
|
||||
/// This allows the Dart field for this type to be the the common base type
|
||||
/// This allows the Dart field for this type to be the common base type
|
||||
/// rather than an EitherX<>.
|
||||
class LiteralUnionType extends UnionType {
|
||||
final List<LiteralType> literalTypes;
|
||||
|
|
|
|||
|
|
@ -73,7 +73,7 @@ caller can create more opportunities for optimization, for example, it becomes
|
|||
possible to recognize and remove repeated operations.
|
||||
|
||||
The compiler automatically makes a decision whether or not to inline a function
|
||||
or method based on heuristics. One heuristic is to inline if the the inlined
|
||||
or method based on heuristics. One heuristic is to inline if the inlined
|
||||
code is likely to be smaller that the call, as this results in a smaller _and_
|
||||
faster program. Another heuristic is to inline even if the code is likely to be
|
||||
slightly larger when the call is in a loop, as loops here is a chance that some
|
||||
|
|
|
|||
|
|
@ -107,7 +107,7 @@ class EntityDataInfoBuilder {
|
|||
|
||||
/// Collects all direct dependencies of [element].
|
||||
///
|
||||
/// The collected dependent elements and constants are are added to
|
||||
/// The collected dependent elements and constants are added to
|
||||
/// [elements] and [constants] respectively.
|
||||
void addDirectMemberDependencies(MemberEntity element) {
|
||||
// TODO(sigurdm): We want to be more specific about this - need a better
|
||||
|
|
|
|||
|
|
@ -229,7 +229,7 @@ class MinifyNamer extends Namer
|
|||
// Try other n-character names based on the hash. We try one to three
|
||||
// character identifiers. For each length we try around 10 different names
|
||||
// in a predictable order determined by the proposed name. This is in order
|
||||
// to make the renamer stable: small changes in the input should nornally
|
||||
// to make the renamer stable: small changes in the input should normally
|
||||
// result in relatively small changes in the output.
|
||||
for (int n = 1; n <= 3; n++) {
|
||||
int h = hash;
|
||||
|
|
|
|||
|
|
@ -470,7 +470,7 @@ class InstanceMethod extends DartMethod {
|
|||
/// `true` if the tear-off needs to access methods directly rather than rely
|
||||
/// on JavaScript prototype lookup. This happens when a tear-off getter is
|
||||
/// called via `super.method` and there is a shadowing definition of `method`
|
||||
/// in some sublcass.
|
||||
/// in some subclass.
|
||||
// TODO(sra): Consider instead having an alias per stub, creating tear-off
|
||||
// trampolines that target the stubs.
|
||||
final bool tearOffNeedsDirectAccess;
|
||||
|
|
|
|||
|
|
@ -1523,7 +1523,7 @@ class SsaInstructionSimplifier extends HBaseVisitor<HInstruction>
|
|||
// We don't expect a non-integer first input to the fixed-size allocation,
|
||||
// but checking the input is an integer ensures we do not replace a
|
||||
// HGetlength with a reference to something with a type that will confuse
|
||||
// bounds check eliminiation.
|
||||
// bounds check elimination.
|
||||
if (lengthInput.isInteger(_abstractValueDomain).isDefinitelyTrue) {
|
||||
// TODO(sra). HGetLength may have a better type than [lengthInput] as
|
||||
// the allocation may throw on an out-of-range input. Typically the
|
||||
|
|
|
|||
|
|
@ -69,7 +69,7 @@ main() {
|
|||
});
|
||||
}
|
||||
|
||||
/// Generate a component for a modular complation unit.
|
||||
/// Generate a component for a modular compilation unit.
|
||||
Future<List<int>> compileUnit(List<String> inputs, Map<String, dynamic> sources,
|
||||
{List<String> deps = const []}) async {
|
||||
var fs = MemoryFileSystem(_defaultDir);
|
||||
|
|
|
|||
|
|
@ -112,7 +112,7 @@ String createCompileJitJson({
|
|||
);
|
||||
}
|
||||
|
||||
/// Used to create compile requesets for AOT compilations
|
||||
/// Used to create compile requests for AOT compilations
|
||||
String createCompileAotJson({
|
||||
required String executable,
|
||||
required String outputDill,
|
||||
|
|
|
|||
|
|
@ -1521,7 +1521,7 @@ abstract class DartDebugAdapter<TL extends LaunchRequestArguments,
|
|||
: frames.length;
|
||||
|
||||
// Find the first async marker, because some functionality only works
|
||||
// up until the first async bounday (e.g. rewind) since we're showing
|
||||
// up until the first async boundary (e.g. rewind) since we're showing
|
||||
// the user async frames which are out-of-sync with the real frames
|
||||
// past that point.
|
||||
final firstAsyncMarkerIndex = frames.indexWhere(
|
||||
|
|
|
|||
|
|
@ -928,7 +928,7 @@ class ThreadInfo {
|
|||
// Don't rethrow here, because it will cause these completers futures
|
||||
// to not have error handlers attached which can cause their errors to
|
||||
// go unhandled. Instead, these completers futures will be returned
|
||||
// below and awaited by the caller (which will propogate the errors).
|
||||
// below and awaited by the caller (which will propagate the errors).
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -46,7 +46,7 @@ class IOPipeline extends Pipeline<IOModularStep> {
|
|||
|
||||
/// A unique number to denote the current modular test configuration.
|
||||
///
|
||||
/// When using [cacheSharedModules], a test can resuse the output of a
|
||||
/// When using [cacheSharedModules], a test can reuse the output of a
|
||||
/// previous run of this pipeline if that output was generated with the same
|
||||
/// configuration.
|
||||
int? _currentConfiguration;
|
||||
|
|
|
|||
|
|
@ -8,7 +8,7 @@ contents.
|
|||
Each folder contains a file named `expectation.txt` which shows a plain text
|
||||
summary of what we expect to extract or report from the test:
|
||||
|
||||
* for invalid inputs it shows the error mesage produced by the modular\_test
|
||||
* for invalid inputs it shows the error message produced by the modular\_test
|
||||
loader logic
|
||||
|
||||
* for valid inputs it shows the test layout, highlighting what each module
|
||||
|
|
|
|||
|
|
@ -1011,7 +1011,7 @@ class NodeChangeForMethodName extends NodeChange<SimpleIdentifier> {
|
|||
}
|
||||
|
||||
/// Common infrastructure used by [NodeChange] objects that operate on AST nodes
|
||||
/// with that can be null-aware (method invocations and propety accesses).
|
||||
/// with that can be null-aware (method invocations and property accesses).
|
||||
mixin NodeChangeForNullAware<N extends Expression> on NodeChange<N> {
|
||||
/// Indicates how null-awareness should be handled.
|
||||
NullAwarenessRemovalType nullAwarenessRemoval = NullAwarenessRemovalType.none;
|
||||
|
|
|
|||
|
|
@ -551,7 +551,7 @@ class InfoBuilder {
|
|||
/// into [declarationList], or `null` if none is possible.
|
||||
int? _offsetForPossibleLateModifier(VariableDeclarationList declarationList) {
|
||||
if (declarationList.isLate || declarationList.isConst) {
|
||||
// Don't offer an ofset.
|
||||
// Don't offer an offset.
|
||||
return null;
|
||||
}
|
||||
var keyword = declarationList.keyword;
|
||||
|
|
|
|||
|
|
@ -44,7 +44,7 @@ class EditDetail {
|
|||
/// with information about the rest of the libraries represented in the
|
||||
/// instrumentation output.
|
||||
class MigrationInfo {
|
||||
/// The information about the compilation units that are are migrated.
|
||||
/// The information about the compilation units that are migrated.
|
||||
final Set<UnitInfo>? units;
|
||||
|
||||
/// A map from file paths to the unit infos created for those files. The units
|
||||
|
|
|
|||
|
|
@ -753,7 +753,7 @@ LayoutTests/fast/text/font-fallback-synthetic-italics_t01: Pass, RuntimeError #
|
|||
LayoutTests/fast/text/glyph-reordering_t01: Pass, RuntimeError # Issue 747, This is a false pass. The font gets sanitized, so whether it works or not probably depends on default sizes.
|
||||
LayoutTests/fast/text/international/rtl-text-wrapping_t01: Pass # Issue 747, This is a false pass. All the content gets sanitized, so there's nothing to assert fail on. If the code did anything it would fail.
|
||||
LayoutTests/fast/text/line-break-after-empty-inline-hebrew_t01: Pass, RuntimeError # Issue 747
|
||||
LayoutTests/fast/text/regional-indicator-symobls_t01: Pass, Fail # Issue 747
|
||||
LayoutTests/fast/text/regional-indicator-symbols_t01: Pass, Fail # Issue 747
|
||||
LayoutTests/fast/text/font-fallback-synthetic-italics_t01: RuntimeError # Issue 747
|
||||
LayoutTests/fast/text/font-ligatures-linebreak_t01: Skip # Issue 747
|
||||
LayoutTests/fast/text/font-ligatures-linebreak-word_t01: Skip # Issue 747
|
||||
|
|
@ -1814,7 +1814,7 @@ LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-
|
|||
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-rounded-boxes_t02: RuntimeError # Please triage this failure
|
||||
LayoutTests/fast/text/international/combining-marks-position_t01: RuntimeError # Please triage this failure
|
||||
LayoutTests/fast/text/line-break-after-question-mark_t01: RuntimeError # Please triage this failure
|
||||
LayoutTests/fast/text/regional-indicator-symobls_t01: RuntimeError # Please triage this failure
|
||||
LayoutTests/fast/text/regional-indicator-symbols_t01: RuntimeError # Please triage this failure
|
||||
LayoutTests/fast/text/text-combine-shrink-to-fit_t01: RuntimeError # Please triage this failure
|
||||
LibTest/math/log_A01_t01: RuntimeError # Please triage this failure
|
||||
LayoutTests/fast/canvas/webgl/index-validation-verifies-too-many-indices_t01: RuntimeError, Pass # Please triage this flake
|
||||
|
|
|
|||
|
|
@ -17,7 +17,7 @@ cc/Fail0: Fail # These tests are expected to crash on all platforms.
|
|||
cc/Fail1: Fail # These tests are expected to crash on all platforms.
|
||||
cc/Fail2: Fail # These tests are expected to crash on all platforms.
|
||||
|
||||
cc/Profiler_InliningIntervalBoundry: Skip # Differences in ia32, debug, release
|
||||
cc/Profiler_InliningIntervalBoundary: Skip # Differences in ia32, debug, release
|
||||
|
||||
cc/Sleep: Skip # Flaky # Flaky on buildbot. Issue 5133 and 10409.
|
||||
|
||||
|
|
@ -47,7 +47,7 @@ cc/CorelibIsolateStartup: Skip # OOM crash can bring down the OS.
|
|||
dart/data_uri_spawn_test: Skip # TODO(zra): package:unittest is not in the image.
|
||||
cc/Read: Fail # TODO(zra): Investigate, ../../dart/runtime/bin/file_test.cc: 34: error: expected: !file->WriteByte(1)
|
||||
|
||||
# On the simluator stack traces produced by the Profiler do not match
|
||||
# On the simulator stack traces produced by the Profiler do not match
|
||||
# up with the real Dart stack trace and hence we don't get correct
|
||||
# symbol names.
|
||||
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simriscv32 || $arch == simriscv64]
|
||||
|
|
@ -64,7 +64,7 @@ cc/Profiler_CodeTicks: Skip
|
|||
cc/Profiler_ContextAllocation: Skip
|
||||
cc/Profiler_FunctionInline: Skip
|
||||
cc/Profiler_FunctionTicks: Skip
|
||||
cc/Profiler_InliningIntervalBoundry: Skip
|
||||
cc/Profiler_InliningIntervalBoundary: Skip
|
||||
cc/Profiler_IntrinsicAllocation: Skip
|
||||
cc/Profiler_SampleBufferIterateTest: Skip
|
||||
cc/Profiler_SampleBufferWrapTest: Skip
|
||||
|
|
|
|||
|
|
@ -134,7 +134,7 @@ class _FfiDefinitionTransformer extends FfiTransformer {
|
|||
return _compoundAnnotatedDependencies(fieldTypes);
|
||||
}
|
||||
|
||||
// Non-tranformed classes.
|
||||
// Non-transformed classes.
|
||||
final dependencies = <Class>{};
|
||||
final membersWithAnnotations =
|
||||
_compoundFieldMembers(node, includeSetters: false);
|
||||
|
|
|
|||
|
|
@ -549,8 +549,8 @@ mixin _FfiUseSiteTransformer on FfiTransformer {
|
|||
return ConstructorInvocation(constructor, Arguments([pointer]));
|
||||
}
|
||||
|
||||
/// Replaces a `.ref=` or `[]=` on a compound pointer extension with a memcopy
|
||||
/// call.
|
||||
/// Replaces a `.ref=` or `[]=` on a compound pointer extension with a mem
|
||||
/// copy call.
|
||||
Expression _replaceSetRef(StaticInvocation node) {
|
||||
final target = node.arguments.positional[0]; // Receiver of extension
|
||||
|
||||
|
|
|
|||
|
|
@ -1141,7 +1141,7 @@ class RuntimeType extends Type {
|
|||
int _computeHashCode() {
|
||||
int hash = _type.hashCode ^ 0x1234 & kHashMask;
|
||||
// Only hash by the type arguments of the class. The type arguments of
|
||||
// supertypes are are implied by them.
|
||||
// supertypes are implied by them.
|
||||
for (int i = 0; i < numImmediateTypeArgs; ++i) {
|
||||
hash = (((hash * 31) & kHashMask) + typeArgs![i].hashCode) & kHashMask;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -426,13 +426,13 @@ bool mayHaveOrSeeSideEffects(Expression node) {
|
|||
return false;
|
||||
}
|
||||
|
||||
// Dedicated fileUri for artifical nodes created during type flow analysis.
|
||||
// Dedicated fileUri for artificial nodes created during type flow analysis.
|
||||
final Uri artificialNodeUri = Uri(scheme: 'tfa-artificial-node');
|
||||
|
||||
// Returns true if [node] was artificially created during type flow analysis.
|
||||
bool isArtificialNode(TreeNode node) =>
|
||||
node is FileUriNode && identical(node.fileUri, artificialNodeUri);
|
||||
|
||||
// Returns [node] or null, if node is artifical.
|
||||
// Returns [node] or null, if node is artificial.
|
||||
T? filterArtificialNode<T extends TreeNode>(T? node) =>
|
||||
(node == null || isArtificialNode(node)) ? null : node;
|
||||
|
|
|
|||
|
|
@ -12,7 +12,7 @@ class StringVertex extends Vertex<StringVertex> {
|
|||
}
|
||||
|
||||
main() {
|
||||
// small example from [Lenguaer & Tarjan 1979]
|
||||
// small example from [Lengauer & Tarjan 1979]
|
||||
var R = new StringVertex("R");
|
||||
var A = new StringVertex("A");
|
||||
var B = new StringVertex("B");
|
||||
|
|
|
|||
|
|
@ -233,7 +233,7 @@
|
|||
|
||||
## 4.0.0
|
||||
- **breaking**: RPCs which can return a `Sentinel` will now throw a `SentinelException`
|
||||
if a `Sential` is received as a response.
|
||||
if a `Sentinel` is received as a response.
|
||||
- **breaking**: RPCs which can return multiple values now return
|
||||
`Future<Response>` rather than `Future<dynamic>`.
|
||||
- `RPCError` now implements `Exception`.
|
||||
|
|
|
|||
|
|
@ -711,7 +711,7 @@ abstract class VmServiceInterface {
|
|||
/// The `offset` and `count` parameters are used to request subranges of
|
||||
/// Instance objects with the kinds: String, List, Map, Set, Uint8ClampedList,
|
||||
/// Uint8List, Uint16List, Uint32List, Uint64List, Int8List, Int16List,
|
||||
/// Int32List, Int64List, Flooat32List, Float64List, Inst32x3List,
|
||||
/// Int32List, Int64List, Float32List, Float64List, Inst32x3List,
|
||||
/// Float32x4List, and Float64x2List. These parameters are otherwise ignored.
|
||||
///
|
||||
/// This method will throw a [SentinelException] in the case a [Sentinel] is
|
||||
|
|
@ -7074,7 +7074,7 @@ class ProcessMemoryItem {
|
|||
/// size. That is, it includes the size of children.
|
||||
int? size;
|
||||
|
||||
/// Subdivisons of this bucket of memory.
|
||||
/// Subdivisions of this bucket of memory.
|
||||
List<ProcessMemoryItem>? children;
|
||||
|
||||
ProcessMemoryItem({
|
||||
|
|
|
|||
|
|
@ -12,7 +12,7 @@ import 'package:vm_service/vm_service.dart';
|
|||
import 'common/service_test_common.dart';
|
||||
import 'common/test_helper.dart';
|
||||
|
||||
Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
||||
Future<ServiceExtensionResponse> Handler(String method, Map parameters) {
|
||||
print('Invoked extension: $method');
|
||||
switch (method) {
|
||||
case 'ext..delay':
|
||||
|
|
@ -21,7 +21,7 @@ Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
|||
c.complete(ServiceExtensionResponse.result(jsonEncode({
|
||||
'type': '_delayedType',
|
||||
'method': method,
|
||||
'parameters': paremeters,
|
||||
'parameters': parameters,
|
||||
})));
|
||||
});
|
||||
return c.future;
|
||||
|
|
@ -36,7 +36,7 @@ Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
|||
ServiceExtensionResponse.result(jsonEncode({
|
||||
'type': '_extensionType',
|
||||
'method': method,
|
||||
'parameters': paremeters,
|
||||
'parameters': parameters,
|
||||
})));
|
||||
}
|
||||
throw "Unknown extension: $method";
|
||||
|
|
|
|||
|
|
@ -29,7 +29,7 @@ DART_EXPORT intptr_t Dart_InitializeApiDL(void* data);
|
|||
// DART_API_DL_MAJOR_VERSION and DART_API_DL_MINOR_VERSION.
|
||||
//
|
||||
// Verbatim copy of `dart_native_api.h` and `dart_api.h` symbol names and types
|
||||
// to trigger compile-time errors if the sybols in those files are updated
|
||||
// to trigger compile-time errors if the symbols in those files are updated
|
||||
// without updating these.
|
||||
//
|
||||
// Function return and argument types, and typedefs are carbon copied. Structs
|
||||
|
|
|
|||
|
|
@ -1157,7 +1157,7 @@ DEFINE_NATIVE_ENTRY(Isolate_sendOOB, 0, 2) {
|
|||
GET_NON_NULL_NATIVE_ARGUMENT(SendPort, port, arguments->NativeArgAt(0));
|
||||
GET_NON_NULL_NATIVE_ARGUMENT(Array, msg, arguments->NativeArgAt(1));
|
||||
|
||||
// Make sure to route this request to the isolate library OOB mesage handler.
|
||||
// Make sure to route this request to the isolate library OOB message handler.
|
||||
msg.SetAt(0, Smi::Handle(Smi::New(Message::kIsolateLibOOBMsg)));
|
||||
|
||||
// Ensure message writer (and it's resources, e.g. forwarding tables) are
|
||||
|
|
|
|||
|
|
@ -12,7 +12,7 @@ import 'package:test/test.dart';
|
|||
import 'service_test_common.dart';
|
||||
import 'test_helper.dart';
|
||||
|
||||
Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
||||
Future<ServiceExtensionResponse> Handler(String method, Map parameters) {
|
||||
print('Invoked extension: $method');
|
||||
switch (method) {
|
||||
case 'ext..delay':
|
||||
|
|
@ -21,7 +21,7 @@ Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
|||
c.complete(new ServiceExtensionResponse.result(jsonEncode({
|
||||
'type': '_delayedType',
|
||||
'method': method,
|
||||
'parameters': paremeters,
|
||||
'parameters': parameters,
|
||||
})));
|
||||
});
|
||||
return c.future;
|
||||
|
|
@ -36,7 +36,7 @@ Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
|||
new ServiceExtensionResponse.result(jsonEncode({
|
||||
'type': '_extensionType',
|
||||
'method': method,
|
||||
'parameters': paremeters,
|
||||
'parameters': parameters,
|
||||
})));
|
||||
}
|
||||
throw "Unknown extension: $method";
|
||||
|
|
|
|||
|
|
@ -10,7 +10,7 @@ import 'package:observatory/service_io.dart';
|
|||
import 'package:test/test.dart';
|
||||
import 'test_helper.dart';
|
||||
|
||||
// small example from [Lenguaer & Tarjan 1979]
|
||||
// small example from [Lengauer & Tarjan 1979]
|
||||
class R {
|
||||
// All fields are marked with @pragma("vm:entry-point")
|
||||
// in order to make sure they are not removed by the tree shaker
|
||||
|
|
|
|||
|
|
@ -19,7 +19,7 @@ double getDoubleWithHeapObjectTag() {
|
|||
return v;
|
||||
}
|
||||
|
||||
// small example from [Lenguaer & Tarjan 1979]
|
||||
// small example from [Lengauer & Tarjan 1979]
|
||||
class R {
|
||||
final double fld = getDoubleWithHeapObjectTag();
|
||||
// Fields are marked with @pragma("vm:entry-point")
|
||||
|
|
|
|||
|
|
@ -12,7 +12,7 @@ import 'package:test/test.dart';
|
|||
import 'service_test_common.dart';
|
||||
import 'test_helper.dart';
|
||||
|
||||
Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
||||
Future<ServiceExtensionResponse> Handler(String method, Map parameters) {
|
||||
print('Invoked extension: $method');
|
||||
switch (method) {
|
||||
case 'ext..delay':
|
||||
|
|
@ -21,7 +21,7 @@ Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
|||
c.complete(new ServiceExtensionResponse.result(jsonEncode({
|
||||
'type': '_delayedType',
|
||||
'method': method,
|
||||
'parameters': paremeters,
|
||||
'parameters': parameters,
|
||||
})));
|
||||
});
|
||||
return c.future;
|
||||
|
|
@ -36,7 +36,7 @@ Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
|
|||
new ServiceExtensionResponse.result(jsonEncode({
|
||||
'type': '_extensionType',
|
||||
'method': method,
|
||||
'parameters': paremeters,
|
||||
'parameters': parameters,
|
||||
})));
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -10,7 +10,7 @@ import 'package:observatory_2/service_io.dart';
|
|||
import 'package:test/test.dart';
|
||||
import 'test_helper.dart';
|
||||
|
||||
// small example from [Lenguaer & Tarjan 1979]
|
||||
// small example from [Lengauer & Tarjan 1979]
|
||||
class R {
|
||||
// All fields are marked with @pragma("vm:entry-point")
|
||||
// in order to make sure they are not removed by the tree shaker
|
||||
|
|
|
|||
|
|
@ -19,7 +19,7 @@ double getDoubleWithHeapObjectTag() {
|
|||
return v;
|
||||
}
|
||||
|
||||
// small example from [Lenguaer & Tarjan 1979]
|
||||
// small example from [Lengauer & Tarjan 1979]
|
||||
class R {
|
||||
final double fld = getDoubleWithHeapObjectTag();
|
||||
// Fields are marked with @pragma("vm:entry-point")
|
||||
|
|
|
|||
|
|
@ -349,7 +349,7 @@ cc/CodeExecutability: SkipByDesign # --dual-map-code not supported on non-Linux/
|
|||
dart/v8_snapshot_profile_writer_test: SkipByDesign # Only relevant for AOT. Doesn't work in cross-compilation (has to run on the host). On Linux/simarm64 and Linux/simarm this test requires buildtools/clang which is not always available on testing shards.
|
||||
dart_2/v8_snapshot_profile_writer_test: SkipByDesign # Only relevant for AOT. Doesn't work in cross-compilation (has to run on the host). On Linux/simarm64 and Linux/simarm this test requires buildtools/clang which is not always available on testing shards.
|
||||
|
||||
# On the simluator stack traces produced by the Profiler do not match
|
||||
# On the simulator stack traces produced by the Profiler do not match
|
||||
# up with the real Dart stack trace and hence we don't get correct
|
||||
# symbol names.
|
||||
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simriscv32 || $arch == simriscv64 ]
|
||||
|
|
@ -372,7 +372,7 @@ cc/Profiler_ContextAllocation: SkipByDesign
|
|||
cc/Profiler_FunctionInline: SkipByDesign
|
||||
cc/Profiler_FunctionTicks: SkipByDesign
|
||||
cc/Profiler_GetSourceReport: SkipByDesign
|
||||
cc/Profiler_InliningIntervalBoundry: SkipByDesign
|
||||
cc/Profiler_InliningIntervalBoundary: SkipByDesign
|
||||
cc/Profiler_IntrinsicAllocation: SkipByDesign
|
||||
cc/Profiler_SampleBufferIterateTest: SkipByDesign
|
||||
cc/Profiler_SampleBufferWrapTest: SkipByDesign
|
||||
|
|
|
|||
|
|
@ -6257,7 +6257,7 @@ class VMSerializationRoots : public SerializationRoots {
|
|||
}
|
||||
|
||||
if (!should_write_symbols_ && s->profile_writer() != nullptr) {
|
||||
// If writing V8 snapshot profile create an artifical node representing
|
||||
// If writing V8 snapshot profile create an artificial node representing
|
||||
// VM isolate symbol table.
|
||||
ASSERT(!s->IsReachable(symbols_.ptr()));
|
||||
s->AssignArtificialRef(symbols_.ptr());
|
||||
|
|
@ -8027,7 +8027,7 @@ ZoneGrowableArray<Object*>* Serializer::Serialize(SerializationRoots* roots) {
|
|||
// targets in reachable WSRs if writing a v8 snapshot profile, since they
|
||||
// will be used in AttributeReference().
|
||||
//
|
||||
// Unreachable WSRs may also need artifical nodes, as they may be members
|
||||
// Unreachable WSRs may also need artificial nodes, as they may be members
|
||||
// of other unreachable objects that have artificial nodes in the profile,
|
||||
// but they are instead lazily handled in CreateArtificialNodeIfNeeded().
|
||||
wsr_cluster->CreateArtificialTargetNodesIfNeeded(this);
|
||||
|
|
@ -8082,7 +8082,7 @@ void Serializer::WriteDispatchTable(const Array& entries) {
|
|||
#if defined(DART_PRECOMPILER)
|
||||
if (kind() != Snapshot::kFullAOT) return;
|
||||
|
||||
// Create an artifical node to which the bytes should be attributed. We
|
||||
// Create an artificial node to which the bytes should be attributed. We
|
||||
// don't attribute them to entries.ptr(), as we don't want to attribute the
|
||||
// bytes for printing out a length of 0 to Object::null() when the dispatch
|
||||
// table is empty.
|
||||
|
|
|
|||
|
|
@ -1152,7 +1152,7 @@ void ClassFinalizer::RegisterClassInHierarchy(Zone* zone, const Class& cls) {
|
|||
other_cls.AddDirectImplementor(cls, /* is_mixin = */ i == mixin_index);
|
||||
}
|
||||
|
||||
// Propogate known concrete implementors to interfaces.
|
||||
// Propagate known concrete implementors to interfaces.
|
||||
if (!cls.is_abstract()) {
|
||||
GrowableArray<const Class*> worklist;
|
||||
worklist.Add(&cls);
|
||||
|
|
|
|||
|
|
@ -564,7 +564,7 @@ void DispatchTableGenerator::SetupSelectorRows() {
|
|||
obj = classes_->At(cid);
|
||||
if (obj.IsClass()) {
|
||||
klass = Class::RawCast(obj.ptr());
|
||||
GrowableArray<Interval>& subclasss_cid_ranges = cid_subclass_ranges[cid];
|
||||
GrowableArray<Interval>& subclass_cid_ranges = cid_subclass_ranges[cid];
|
||||
|
||||
functions = klass.current_functions();
|
||||
if (!functions.IsNull()) {
|
||||
|
|
@ -579,8 +579,8 @@ void DispatchTableGenerator::SetupSelectorRows() {
|
|||
// A function handle that survives until the table is built.
|
||||
auto& function_handle = Function::ZoneHandle(Z, function.ptr());
|
||||
|
||||
for (intptr_t i = 0; i < subclasss_cid_ranges.length(); i++) {
|
||||
Interval& subclass_cid_range = subclasss_cid_ranges[i];
|
||||
for (intptr_t i = 0; i < subclass_cid_ranges.length(); i++) {
|
||||
Interval& subclass_cid_range = subclass_cid_ranges[i];
|
||||
selector_rows[sid].DefineSelectorImplementationForInterval(
|
||||
cid, depth, subclass_cid_range, &function_handle);
|
||||
}
|
||||
|
|
|
|||
|
|
@ -2,7 +2,7 @@
|
|||
// for details. All rights reserved. Use of this source code is governed by a
|
||||
// BSD-style license that can be found in the LICENSE file.
|
||||
//
|
||||
// Unit tests specific to BCE (bounds check eliminaton),
|
||||
// Unit tests specific to BCE (bounds check elimination),
|
||||
// which runs as part of range analysis optimizations.
|
||||
|
||||
#include "vm/compiler/backend/range_analysis.h"
|
||||
|
|
|
|||
|
|
@ -375,7 +375,7 @@ bool HierarchyInfo::CanUseGenericSubtypeRangeCheckFor(
|
|||
TypeArguments::Handle(zone, Type::Cast(type).arguments());
|
||||
ASSERT(ta.Length() == num_type_arguments);
|
||||
|
||||
// The last [num_type_pararameters] entries in the [TypeArguments] vector [ta]
|
||||
// The last [num_type_parameters] entries in the [TypeArguments] vector [ta]
|
||||
// are the values we have to check against. Ensure we can handle all of them
|
||||
// via [CidRange]-based checks or that it is a type parameter.
|
||||
AbstractType& type_arg = AbstractType::Handle(zone);
|
||||
|
|
|
|||
|
|
@ -2599,7 +2599,7 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
|
|||
}
|
||||
__ b(fail, NE);
|
||||
} else if (value_cid == field_cid) {
|
||||
// This would normaly be caught by Canonicalize, but RemoveRedefinitions
|
||||
// This would normally be caught by Canonicalize, but RemoveRedefinitions
|
||||
// may sometimes produce the situation after the last Canonicalize pass.
|
||||
} else {
|
||||
// Both value's and field's class id is known.
|
||||
|
|
|
|||
|
|
@ -2404,7 +2404,7 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
|
|||
|
||||
__ b(fail, NE);
|
||||
} else if (value_cid == field_cid) {
|
||||
// This would normaly be caught by Canonicalize, but RemoveRedefinitions
|
||||
// This would normally be caught by Canonicalize, but RemoveRedefinitions
|
||||
// may sometimes produce the situation after the last Canonicalize pass.
|
||||
} else {
|
||||
// Both value's and field's class id is known.
|
||||
|
|
|
|||
|
|
@ -2042,7 +2042,7 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
|
|||
}
|
||||
__ j(NOT_EQUAL, fail);
|
||||
} else if (value_cid == field_cid) {
|
||||
// This would normaly be caught by Canonicalize, but RemoveRedefinitions
|
||||
// This would normally be caught by Canonicalize, but RemoveRedefinitions
|
||||
// may sometimes produce the situation after the last Canonicalize pass.
|
||||
} else {
|
||||
// Both value's and field's class id is known.
|
||||
|
|
|
|||
|
|
@ -2755,7 +2755,7 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
|
|||
|
||||
__ BranchIf(NE, fail);
|
||||
} else if (value_cid == field_cid) {
|
||||
// This would normaly be caught by Canonicalize, but RemoveRedefinitions
|
||||
// This would normally be caught by Canonicalize, but RemoveRedefinitions
|
||||
// may sometimes produce the situation after the last Canonicalize pass.
|
||||
} else {
|
||||
// Both value's and field's class id is known.
|
||||
|
|
|
|||
|
|
@ -2346,7 +2346,7 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
|
|||
|
||||
__ j(NOT_EQUAL, fail);
|
||||
} else if (value_cid == field_cid) {
|
||||
// This would normaly be caught by Canonicalize, but RemoveRedefinitions
|
||||
// This would normally be caught by Canonicalize, but RemoveRedefinitions
|
||||
// may sometimes produce the situation after the last Canonicalize pass.
|
||||
} else {
|
||||
// Both value's and field's class id is known.
|
||||
|
|
|
|||
|
|
@ -603,7 +603,7 @@ InductionVar* InductionVarAnalysis::SolveConstraint(LoopInfo* loop,
|
|||
InductionVar* init) {
|
||||
InductionVar* c = LookupCycle(def->InputAt(0)->definition());
|
||||
if (c == init) {
|
||||
// Record a non-artifical bound constraint on a phi.
|
||||
// Record a non-artificial bound constraint on a phi.
|
||||
ConstraintInstr* constraint = def->AsConstraint();
|
||||
if (constraint->target() != nullptr) {
|
||||
loop->limit_ = constraint;
|
||||
|
|
|
|||
|
|
@ -3724,7 +3724,7 @@ FlowGraph* FlowGraphBuilder::BuildGraphOfImplicitClosureFunction(
|
|||
// Instantiate a flattened type arguments vector which
|
||||
// includes type arguments corresponding to superclasses.
|
||||
// TranslateInstantiatedTypeArguments is smart enough to
|
||||
// avoid instantiation and resuse passed function type arguments
|
||||
// avoid instantiation and reuse passed function type arguments
|
||||
// if there are no extra type arguments in the flattened vector.
|
||||
const auto& instantiated_type_arguments =
|
||||
TypeArguments::ZoneHandle(Z, result_type.arguments());
|
||||
|
|
|
|||
|
|
@ -292,7 +292,7 @@ bool Compiler::CanOptimizeFunction(Thread* thread, const Function& function) {
|
|||
}
|
||||
|
||||
bool Compiler::IsBackgroundCompilation() {
|
||||
// For now: compilation in non mutator thread is the background compoilation.
|
||||
// For now: compilation in non mutator thread is the background compilation.
|
||||
return !Thread::Current()->IsMutatorThread();
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -1819,27 +1819,27 @@ static void GenerateAllocateObjectHelper(Assembler* assembler,
|
|||
Label not_parameterized_case;
|
||||
|
||||
const Register kClsIdReg = R2;
|
||||
const Register kTypeOffestReg = R9;
|
||||
const Register kTypeOffsetReg = R9;
|
||||
|
||||
__ ExtractClassIdFromTags(kClsIdReg, kTagsReg);
|
||||
|
||||
// Load class' type_arguments_field offset in words.
|
||||
__ LoadClassById(kTypeOffestReg, kClsIdReg);
|
||||
__ LoadClassById(kTypeOffsetReg, kClsIdReg);
|
||||
__ ldr(
|
||||
kTypeOffestReg,
|
||||
FieldAddress(kTypeOffestReg,
|
||||
kTypeOffsetReg,
|
||||
FieldAddress(kTypeOffsetReg,
|
||||
target::Class::
|
||||
host_type_arguments_field_offset_in_words_offset()));
|
||||
|
||||
// Set the type arguments in the new object.
|
||||
__ StoreIntoObjectNoBarrier(
|
||||
AllocateObjectABI::kResultReg,
|
||||
Address(AllocateObjectABI::kResultReg, kTypeOffestReg, LSL,
|
||||
Address(AllocateObjectABI::kResultReg, kTypeOffsetReg, LSL,
|
||||
target::kWordSizeLog2),
|
||||
AllocateObjectABI::kTypeArgumentsReg);
|
||||
|
||||
__ Bind(¬_parameterized_case);
|
||||
} // kClsIdReg = R1, kTypeOffestReg = R9
|
||||
} // kClsIdReg = R1, kTypeOffsetReg = R9
|
||||
|
||||
__ AddImmediate(AllocateObjectABI::kResultReg,
|
||||
AllocateObjectABI::kResultReg, kHeapObjectTag);
|
||||
|
|
|
|||
|
|
@ -466,7 +466,7 @@ void StubCodeCompiler::GenerateJITCallbackTrampolines(
|
|||
// we only emit a 32-bit callback ID.
|
||||
__ uxtw(R9, R9);
|
||||
|
||||
// Save THR (callee-saved) and LR on real real C stack (CSP). Keeps it
|
||||
// Save THR (callee-saved) and LR on the real C stack (CSP). Keeps it
|
||||
// aligned.
|
||||
COMPILE_ASSERT(StubCodeCompiler::kNativeCallbackTrampolineStackDelta == 2);
|
||||
SPILLS_LR_TO_FRAME(__ stp(
|
||||
|
|
@ -2147,7 +2147,7 @@ static void GenerateAllocateObjectHelper(Assembler* assembler,
|
|||
AllocateObjectABI::kTypeArgumentsReg);
|
||||
|
||||
__ Bind(¬_parameterized_case);
|
||||
} // kClsIdReg = R4, kTypeOffestReg = R5
|
||||
} // kClsIdReg = R4, kTypeOffsetReg = R5
|
||||
|
||||
__ AddImmediate(AllocateObjectABI::kResultReg,
|
||||
AllocateObjectABI::kResultReg, kHeapObjectTag);
|
||||
|
|
|
|||
|
|
@ -1950,7 +1950,7 @@ static void GenerateAllocateObjectHelper(Assembler* assembler,
|
|||
__ sx(AllocateObjectABI::kTypeArgumentsReg, Address(kTypeOffsetReg, 0));
|
||||
|
||||
__ Bind(¬_parameterized_case);
|
||||
} // kClsIdReg = R4, kTypeOffestReg = R5
|
||||
} // kClsIdReg = R4, kTypeOffsetReg = R5
|
||||
|
||||
__ AddImmediate(AllocateObjectABI::kResultReg,
|
||||
AllocateObjectABI::kResultReg, kHeapObjectTag);
|
||||
|
|
|
|||
|
|
@ -73,7 +73,7 @@ DART_EXPORT Dart_Handle Dart_GetLibraryDebuggable(intptr_t library_id,
|
|||
bool* is_debuggable);
|
||||
|
||||
/**
|
||||
* Requets that debugging be enabled for the given library.
|
||||
* Requests that debugging be enabled for the given library.
|
||||
*
|
||||
* Requires there to be a current isolate.
|
||||
*
|
||||
|
|
|
|||
|
|
@ -14,7 +14,7 @@ namespace dart {
|
|||
|
||||
class Array;
|
||||
|
||||
// Objects that are a source in a become are tranformed into forwarding
|
||||
// Objects that are a source in a become are transformed into forwarding
|
||||
// corpses pointing to the corresponding target. Forwarding corpses have the
|
||||
// same heap sizes as the source object to ensure the heap remains walkable.
|
||||
// If the heap sizes is small enough to be encoded in the size field of the
|
||||
|
|
|
|||
|
|
@ -215,7 +215,7 @@ void MournFinalized(GCVisitorType* visitor) {
|
|||
// We only run in serial marker or in the finalize step in the marker,
|
||||
// both are in safepoint.
|
||||
// The main scavenger worker is at safepoint, the other scavenger
|
||||
// workers are are not, but they bypass safepoint because the main
|
||||
// workers are not, but they bypass safepoint because the main
|
||||
// worker is at a safepoint already.
|
||||
ASSERT(Thread::Current()->IsAtSafepoint() ||
|
||||
Thread::Current()->BypassSafepoints());
|
||||
|
|
|
|||
|
|
@ -90,7 +90,7 @@ static uword ForwardingHeader(ObjectPtr target) {
|
|||
// here as relaxed so the C++ compiler still has the freedom to reorder them.
|
||||
NO_SANITIZE_THREAD
|
||||
static void objcpy(void* dst, const void* src, size_t size) {
|
||||
// A memcopy specialized for objects. We can assume:
|
||||
// A mem copy specialized for objects. We can assume:
|
||||
// - dst and src do not overlap
|
||||
ASSERT(
|
||||
(reinterpret_cast<uword>(dst) + size <= reinterpret_cast<uword>(src)) ||
|
||||
|
|
|
|||
|
|
@ -2187,7 +2187,7 @@ class UnlinkedCall : public CallSiteData {
|
|||
// compilation. Code may contain only original ICData objects.
|
||||
//
|
||||
// ICData's backing store is an array that logically contains several valid
|
||||
// entries followed by a sentinal entry.
|
||||
// entries followed by a sentinel entry.
|
||||
//
|
||||
// [<entry-0>, <...>, <entry-N>, <sentinel>]
|
||||
//
|
||||
|
|
@ -8360,7 +8360,7 @@ class TypeArguments : public Instance {
|
|||
// If an entry in the given array contains the given instantiator and
|
||||
// function type arguments, returns a KeyLocation with the index of the
|
||||
// entry and true. Otherwise, returns a KeyLocation with the index that
|
||||
// would be used if the instantiation for the the given type arguments is
|
||||
// would be used if the instantiation for the given type arguments is
|
||||
// added and false.
|
||||
static KeyLocation FindKeyOrUnused(const Array& array,
|
||||
const TypeArguments& instantiator_tav,
|
||||
|
|
@ -9214,7 +9214,7 @@ class FunctionType : public AbstractType {
|
|||
Heap::Space space) const;
|
||||
|
||||
// Returns the index in the parameter names array of the corresponding flag
|
||||
// for the given parametere index. Also returns (via flag_mask) the
|
||||
// for the given parameter index. Also returns (via flag_mask) the
|
||||
// corresponding mask within the flag.
|
||||
intptr_t GetRequiredFlagIndex(intptr_t index, intptr_t* flag_mask) const;
|
||||
|
||||
|
|
|
|||
|
|
@ -1487,7 +1487,7 @@ ISOLATE_UNIT_TEST_CASE(Profiler_FunctionInline) {
|
|||
}
|
||||
}
|
||||
|
||||
ISOLATE_UNIT_TEST_CASE(Profiler_InliningIntervalBoundry) {
|
||||
ISOLATE_UNIT_TEST_CASE(Profiler_InliningIntervalBoundary) {
|
||||
// The PC of frames below the top frame is a call's return address,
|
||||
// which can belong to a different inlining interval than the call.
|
||||
// This test checks the profiler service takes this into account; see
|
||||
|
|
|
|||
|
|
@ -964,7 +964,7 @@ collected, then an [Object](#object) will be returned.
|
|||
The _offset_ and _count_ parameters are used to request subranges of
|
||||
Instance objects with the kinds: String, List, Map, Set, Uint8ClampedList,
|
||||
Uint8List, Uint16List, Uint32List, Uint64List, Int8List, Int16List,
|
||||
Int32List, Int64List, Flooat32List, Float64List, Inst32x3List,
|
||||
Int32List, Int64List, Float32List, Float64List, Inst32x3List,
|
||||
Float32x4List, and Float64x2List. These parameters are otherwise
|
||||
ignored.
|
||||
|
||||
|
|
@ -3745,7 +3745,7 @@ class ProcessMemoryItem {
|
|||
// of children.
|
||||
int size;
|
||||
|
||||
// Subdivisons of this bucket of memory.
|
||||
// Subdivisions of this bucket of memory.
|
||||
ProcessMemoryItem[] children;
|
||||
}
|
||||
```
|
||||
|
|
|
|||
Loading…
Reference in a new issue