Switch to importing by SHA rather than tag and sync before publishing.
Change-Id: Ibf563c4fc28f6b4a08b29feee24d4f7cc234ef27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176920
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jacob Richman <jacobr@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Change-Id: Id05944fbe9f2f202d9349e170b3fc760208c6761
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176244
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Fixes a test for compatibility with google3.
Change-Id: Id85c531b6768b6a59f2f63e991de96dd92ab3232
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175446
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
This brings in the null safe migrated args. It also brings in a new
version of dart2js_info with a tiny change to make it compatible with
the new args.
Change-Id: I280d25c9d5d6bea974206996c5a8c232e728e81d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175020
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
This is a reland of 9906fabaa0
Original change's description:
> Roll the latest args package into the SDK repo.
>
> Change-Id: Ie464e5c01f34a101103d16ff108b6b9eb80fbd4b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174485
> Reviewed-by: Nate Bosch <nbosch@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
> Auto-Submit: Bob Nystrom <rnystrom@google.com>
Change-Id: I5b7b041e02857114c257393cf9d560b6b8b03fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174701
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
This reverts commit 9906fabaa0.
Reason for revert: Causes regressions in google3 (likely need internal CL to get new args package in third party), see https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/google/3073/overview
Original change's description:
> Roll the latest args package into the SDK repo.
>
> Change-Id: Ie464e5c01f34a101103d16ff108b6b9eb80fbd4b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174485
> Reviewed-by: Nate Bosch <nbosch@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
> Auto-Submit: Bob Nystrom <rnystrom@google.com>
TBR=rnystrom@google.com,nbosch@google.com
Change-Id: I9d3091d1631a145cd8b37317cc2e381762e5a46a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174646
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Change-Id: I6587b1f543cd838bae02155c34d2f83d474b1846
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173521
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
2020-11-26 sgrekhov@unipro.ru#926. Stdout tests that run process fixed for Windows
2020-11-26 irina.arkhipets@gmail.com Typo in the test corrected.
Cq-Include-Trybots: dart/try:vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I822e64ff5e3ac46ed1c48419d08b0e0cbb413fc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174100
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit ce614d33c4.
Original change's description:
> Revert "update Glob in the sdk, also adds package:file to the sdk"
>
> This reverts commit 18b19db300.
>
> Reason for revert: Breaks Flutter 3H/Golem. Tried making an appropriate patch for 3H that would pull file into its dependencies (see https://dart-review.googlesource.com/c/sdk/+/173960/), but that still failed, so reverting.
>
> Original change's description:
> > update Glob in the sdk, also adds package:file to the sdk
> >
> > Change-Id: Ia8628c28bfaf6343c19eecfef391339968cd57e9
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172063
> > Commit-Queue: Jake Macdonald <jakemac@google.com>
> > Reviewed-by: Nate Bosch <nbosch@google.com>
>
> TBR=jakemac@google.com,nbosch@google.com
>
> Change-Id: I0616e3df7505f348edeefee40cbaf4adc59487cd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173963
> Reviewed-by: Tess Strickland <sstrickl@google.com>
> Commit-Queue: Tess Strickland <sstrickl@google.com>
TBR=jakemac@google.com,nbosch@google.com,sstrickl@google.com
# Not skipping CQ checks because this is a reland.
Change-Id: Ia85fe3b81214ca4ef2bed8e08ecc1b617927a579
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173981
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
2020-11-25 irina.arkhipets@gmail.comFixes#968: missing testing options added back.
2020-11-25 sgrekhov@unipro.ru#969. Line numbers where we expect an error fixed
2020-11-25 sgrekhov@unipro.ru#969. Stdout tests failures on Windows fixed. Don't pass executable arguments to the Process
2020-11-24 irina.arkhipets@gmail.comFixes#968: non-nullable shared option removed.
2020-11-23 sgrekhov@unipro.ru#932. HttpRequest tests fixed to work with cross origin
2020-11-20 sgrekhov@unipro.ru #926.Tryjob failures fixed
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I32eaa75a0fcf4b5b7d8c4855b311a46948afb6f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173964
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit 18b19db300.
Reason for revert: Breaks Flutter 3H/Golem. Tried making an appropriate patch for 3H that would pull file into its dependencies (see https://dart-review.googlesource.com/c/sdk/+/173960/), but that still failed, so reverting.
Original change's description:
> update Glob in the sdk, also adds package:file to the sdk
>
> Change-Id: Ia8628c28bfaf6343c19eecfef391339968cd57e9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172063
> Commit-Queue: Jake Macdonald <jakemac@google.com>
> Reviewed-by: Nate Bosch <nbosch@google.com>
TBR=jakemac@google.com,nbosch@google.com
Change-Id: I0616e3df7505f348edeefee40cbaf4adc59487cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173963
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Change-Id: Idc84c762539e92705f733a50ccc351a4e65211be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173540
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
Change-Id: I0ef9fc42170f7481f513bb1135cbe38836dbb48e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173520
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
There are no formatting changes in this release, so it doesn't need to
be coordinated with a roll of the pre-built SDK.
Change-Id: I2dc263f2f7b824a4161000dbdfe40c0913b39987
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173141
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2020-11-19 sgrekhov@unipro.ru #926.Add Platform.executableArguments to Process.run() command to not to fail on --enable-assert configuration
2020-11-19 sgrekhov@unipro.ru #926.Add Platform.executableArguments to Process.run() command to not to fail on --enable-assert configuration
2020-11-18 sgrekhov@unipro.ruFixes#966. Move certificates to RawSecureServerSocket directory
2020-11-18 sgrekhov@unipro.ru#926. Fixed test that fail on precompiled environment in a strong mode
2020-11-17 sgrekhov@unipro.ruFixes#951. Remove excessive @static-warning
2020-11-17 irina.arkhipets@gmail.comFixes#946: LanguageFeatures/Instantiate-to-bound/nonfunction_typedef tests updated according to the SDK changes, missing tests added.
2020-11-17 sgrekhov@unipro.ru#932. Some HttpRequest tests fixed to work well with cross origin requests
2020-11-16 sgrekhov@unipro.ru Process kill test fixed to work on different platforms
2020-11-16 sgrekhov@unipro.ru External variable test that expects compile time error on dart2js added
2020-11-13 sgrekhov@unipro.ruFixes#926. Remove "--enable-experiment=non-nullable" option from script that runs another process
2020-11-12 sgrekhov@unipro.ru#926. File lock checking tests rewritten to not to fail on precompiled environment. Second part
2020-11-12 irina.arkhipets@gmail.comFixes#602: Missing issue tags added.
2020-11-11 sgrekhov@unipro.ru#926. File lock checking tests rewritten to not to fail on precompiled environment
2020-11-11 sgrekhov@unipro.ru Issue numbers added
2020-11-11 irina.arkhipets@gmail.comFixes#963: test expected result corrected, test template for all generic typedefs updated.
2020-11-10 sgrekhov@unipro.ru#926. ProcessSignal tests rewritten to not to fail on precompiled environment
2020-11-10 sgrekhov@unipro.ru#926. Process tests rewritten to not to fail on precompiled environment
2020-11-10 sgrekhov@unipro.ru#961. Process tests rewritten to not to use process_test tool
2020-11-10 irina.arkhipets@gmail.comFixes#602: Missing Issue tag added.
2020-11-10 sgrekhov@unipro.ruFixes#960. Null safety execution modes renamed and mentions of obsolete checked mode removed
2020-11-10 sgrekhov@unipro.ru Remove wrong error expectations
2020-11-09 sgrekhov@unipro.ruFixes#962. Change CFE error messages expectations
2020-11-08 irina.arkhipets@gmail.comFixes#602: New tests for least and greatest closures added.
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I7aff067ec96f762490de15daa20c40dff2b0ae96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172940
Reviewed-by: William Hesse <whesse@google.com>
Protobuf and bazel_worker are migrated to null safety, dart2js_info
just broadens dependency version range to be compatible with null safe
protobuf.
Also regenerate test protos in vm test cases and update expected ASTs
and add support for conditional expressions to protobuf aware tree shaker.
Change-Id: I019f0fd6c5688302cc5127e1be8368a3ea600439
TEST= Covered by existing tests
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172646
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
Expand the range allowed by the dep from `package:analyzer`.
Switch dependencies to `any` for the packages which are `publish_to:
none`. The actual constraints aren't useful in these packages since they
are always pinned exactly by DEPS and so we can't trust they are kept up
to date.
Change-Id: Ibd937e8646574d49105f4dd0de2529e7ab30862a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172380
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
New in this revision:
> git log --format="%C(auto) %h %s" b10966c6a8ad7d95c2023b7842fa2697001d2fdf..c00d4b4abf5b4ff265a7ce6282b748551f1b5b1f
c00d4b4a Improve message in `pub outdated` when incompatible versions are found (#2746)
2a177623 outdated --mode=null-safety, resolvable constrained to null-safe vers… (#2739)
3ea2b832 Default language version (#2748)
78865460 Don't allow both --json and --transitive (#2742)
Fixes https://github.com/dart-lang/sdk/issues/44013
Change-Id: I0dc876c5e57777a4724d90662408f91910e2517c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171720
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Change-Id: Ief025612b5f3e14079716460eae030d09f6f5e7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170862
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Change-Id: I6db1a2a5dd4501b16fa947a8fa1c337592947ade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170842
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Change-Id: Ie55532aa1471d2c9df1f32ab9444e977f984f7e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170861
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Change-Id: Ie5ba98ac96c05c4890c4b80fbdfe673f2ad64d96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170860
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
There are no functional differences between the previous and the new
commit. Though it brings in a fix for a test which is required for
further dart->g3 rolls.
Issue b/172649154
Change-Id: I923246aa9db1973e213257a086f0065ad862ca4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170881
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2020-11-05 irina.arkhipets@gmail.comFixes#602: New tests for least and greatest closures added.
2020-11-05 sgrekhov@unipro.ru#926. Rewrite io/Process/start_A01_t02 test to work on precompiled environment
2020-11-05 sgrekhov@unipro.ru#932. Rewrite HttpRequestUpload/onLoad_A01_t01 test to send correct HttpRequest
2020-11-04 sgrekhov@unipro.ruFixes#956. Don't expect extension invocation on type dynamic
2020-11-04 karlklose@users.noreply.github.com Convert some multi-tests to static error framework (#958)
2020-11-03 irina.arkhipets@gmail.comFixes#602: dynamic tests for least and greatest closures updated.
2020-11-03 irina.arkhipets@gmail.comFixes#602: tests for least and greatest closures added.
2020-10-28 sgrekhov@unipro.ru#926. Fix two Process tests to use 'process_test' tool
2020-10-28 sgrekhov@unipro.ru#926. Rewrite two Process tests to use 'process_test' tool
2020-10-28 sgrekhov@unipro.ruFixes#955. Expect less specific error for typed_data tests
2020-10-26 sgrekhov@unipro.ruFixes#954. Change the line where we expect an error for CFE
2020-10-20 sgrekhov@unipro.ruFixes#912. Abstract variables syntax tests added
2020-10-19 sgrekhov@unipro.ru#912. More external variables syntax tests added
2020-10-17 sgrekhov@unipro.ru External variables syntax test added
2020-10-16 sgrekhov@unipro.ru#912. More test for static analysis of external variables added
2020-10-15 sgrekhov@unipro.ru#912. Test for static analysis of external variables added
2020-10-14 sgrekhov@unipro.ru#912. Test for static analysis if abstract variables added
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: Id9cde784918faa4e891da8c4cb448d415a7a18aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170680
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This includes the following pub commits:
git log --format="%C(auto) %h %s" 5b4df5a6f931c63622ac349602d6ef0367e8070f..fb72c1f774ca27556225b207185c0b6b6ab1c274
fb72c1f7 Make `run` available (but deprecated) in the embedding (#2698)
63b56ea4 Return the exit-code from commands (#2689)
7fc4e273 Deprecate top level (#2694)
Change-Id: I5842b1ecb15fc7844d628e2ad5fb00e3f627dbff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168347
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
This is the first checked-in SDK with null-safety enabled by default.
Change-Id: I8f6fcdfd8856483f4737eb200ed4623a244cb0cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170085
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This does not affect the formatting of any existing code, so is safe to
roll without updating the pre-built SDK.
Change-Id: I2e7fc20d6933d136dc0390f93f6bc72dc340e9ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170141
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
There are no formatting changes in this release. The only change is the
fix for https://github.com/dart-lang/dart_style/issues/964.
Includes corresponding adaptations of dartdev/dart CLI.
Change-Id: I1c97f0b7009b98ae609b258401522453faa35c64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170083
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Flutter uses CIPD packages that are more reliable.
Change-Id: Ic47b2fd9805709a3175376270df0fe52b82f16ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169341
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Bright in dependency pkg:clock
Also removed pkg:quiver entry in package_config – no longer needed
Change-Id: I98f45c2ad107c7613d300783e77c018edefbaa37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168587
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Change-Id: I857e811dea45a718566d13228a659208821b8556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168982
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Change-Id: I41508e224ee2712580752ebb74b98a2fcf295b6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168840
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
This can safely be done without updating the pre-built SDK. The only
change is a bug fix where the formatter would previously fail and now
successfully formats.
Change-Id: I34e9305bc47621582923635b84906b70118fce88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168580
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Change-Id: I643a4237fb65b04780d7a8d6408adca2e0e8cedd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168740
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Change-Id: I0b64c9a646b9ad0fadbebd6c62d63aa4f04a2665
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168342
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
Change-Id: I44cb1de8fa30ddb748b3ae3cad5e81bb9e2dc8aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168343
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
git log --oneline cf9795f3bb209504c349e20501f0b4b8ae31530c..f0c7771b38155d3829a60d60b5dba2784b100811
f0c7771b Set first version with null safety to 2.12 (#2684)
df1140af Warn from get, when mixed mode (#2590)
765778c0 Simplify test detection (#2682)
afd66ea2 Inline the single test asset. (#2681)
059e4796 Simplify the logic for unicode and colors in output (#2679)
35ddaec2 Dartify test tool (#2680)
62f26401 Example for User-Agent (#2678)
e8b4b114 fixes: #2670 pub global activate commands always exit cmd on windows. (#2671)
93e703b1 Improve stack traces in many tests (#2673)
5b540a39 Fix experiments tests for Dart 2.11 (#2672)
b0ac77d8 Bump dependency on pkg:analyzer (#2662)
73f0906e Removed @alwaysThrows (#2642)
88e0a83c Fixed bug in adding dependency to empty dependencies key (#2640)
135d9fa0 Pub add/remove now remove dependencies key if it makes them empty (#2639)
f4cc9673 Fix "pubpsec" typo (#2641)
4686d74d Adding an existing package is now a dataError (#2638)
1e93f47c Checks pubspec keys for potential typos (#2616)
fa5f51ef Vendor yaml_edit (#2633)
ac6d307f Adding a `pub remove` command (#2620)
9d236e00 Adding the `pub add` command (#2618)
04e237f7 Drop upper bound instead of using "any" while resolving in "pub outdated" (#2623)
93954f33 Use InternetAddress.tryParse over try/catch (#2626)
638c81c9 Refine publishing message (#2624)
Allow github
Embed pub as a library into dartdev
Change-Id: Iadc6acb5c3425dfb8848db89820e6c9c8caf16ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167574
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Adds a new API for creating custom watchers limited to certain paths.
Change-Id: I8033f43c31ef8c112140702dd7ea77f9225a2113
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167143
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Gary Roumanis <grouma@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
This fixes some nuisance analyzer warnings.
Change-Id: Ie2d2843716611c44b5815c91e38ee34b9c32ac07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167141
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-10-12 sgrekhov@unipro.ru#951. Changed error expectation to not to fail on tryjobs
2020-10-12 sgrekhov@unipro.ru#912. Added tests for external variable declaration
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I8e27b4a1605a9503056c3d18e0a8cd4b2d7b3383
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166848
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Change-Id: I186307526c521ef25fb7057d04f21e12f6636ca4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166841
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2020-10-09 irina.arkhipets@gmail.comFixes#946: i-2-b typedef tests updated, missing Issue tags added.
2020-10-09 sgrekhov@unipro.ru Local variable reading tests fixed to not to fail on tryjobs
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try
Change-Id: I5e261e2a3a09087a44e872826eade8208aed5e83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166638
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2020-10-09 irina.arkhipets@gmail.com Fixes 950: typo corrected.
2020-10-09 irina.arkhipets@gmail.com Fixes 950: test adjusted.
2020-10-08 irina.arkhipets@gmail.com Fixes 946: LanguageFeatures/Instantiate-to-bounds/typedef-static/typedef_typedef_* tests updated according to the recent SDK changes.
2020-10-08 irina.arkhipets@gmail.com Fixes 946: LanguageFeatures/Instantiate-to-bounds/typedef/static/typedef_l2_06_* tests updated according to the recent SDK changes.
2020-10-08 irina.arkhipets@gmail.com Issue 946: LanguageFeatures/Instantiate-to-bounds/typedef/static/typedef_l2_t05_* tests updated according to the recent SDK changes.
2020-10-08 irina.arkhipets@gmail.com Fixes 946: LanguageFeatures/Instantiate-to-bounds/typedef/static/typedef_l2_t04_* tests updated according to the recent SDK changes.
2020-10-08 sgrekhov@unipro.ru Fixes 912. Abstract variables tests added
2020-10-08 sgrekhov@unipro.ru Fixes 949. Explicitly cast initializer expression as nullable
2020-10-07 sgrekhov@unipro.ru Fixes 944. Add check for HttpStatus.permanentRedirect
2020-10-07 irina.arkhipets@gmail.com Issue 946: LanguageFeatures/Instantiate-to-bounds/typedef/static/typedef_l2_t03_* tests updated according to the recent SDK changes.
2020-10-07 sgrekhov@unipro.ru 948. Change type of additional required argument to dynamic
2020-10-07 sgrekhov@unipro.ru Fixes 948. Add two positional parameters to Language/Libraries_and_Scripts/Scripts/main_required_parameters_t03 to match the test description
2020-10-06 sgrekhov@unipro.ru 923. More tests for local variable read and definite (un)assignment
2020-10-06 irina.arkhipets@gmail.com Fixes 946: LanguageFeatures/Instantiate-to-bounds/typedef/static/typedef_l2_02_* tests updated according to the recent SDK changes.
2020-10-05 sgrekhov@unipro.ru Fixes 947. It's compile error to declare getter named 'main'
2020-10-05 irina.arkhipets@gmail.com Issue 946: LanguageFeatures/Instantiate-to-bounds/typrdef/static/typedef_l2_* tests updated according to the SDK changes.
2020-10-04 sgrekhov@unipro.ru Fix Process/exitCode_A01_t02 test on Windows. Allow 1 exit code
2020-10-02 sgrekhov@unipro.ru 923. Added tests for local variables assignment and read
Change-Id: Ibdc85b357abfe3c5f8dc0c44b30b354480250d91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166632
Reviewed-by: Karl Klose <karlklose@google.com>
Change-Id: Ieba83cc4d632eb8db3c0054210040fd8ade5d74a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166380
Reviewed-by: Michal Terepeta <michalt@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
This reverts commit f79c6bed7f.
Reason for revert: Causing problems for google3--I'll investigate and handle the reland. b/170193203
Original change's description:
> Update to the latest version of package:tflite_native.
>
> Change-Id: Id9eb5e5a9297a6bbdb83805c6a205663b9220937
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166140
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Devon Carew <devoncarew@google.com>
TBR=devoncarew@google.com,brianwilkerson@google.com
Change-Id: I5b4823e702d15984c37401374dae27f8a6a61f15
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166103
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
This is no longer necessary with the VM only supporting the latest
version and kernel (optionally) including a git-checksum to match up
VM and dills.
Change-Id: Ifccfd0d12333cd99258100cda30e1536cc230bc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166024
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
These nodes are no longer used.
Change-Id: I40c8df7376f0c40a4122c22d934fb3c6f6fd520d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165902
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Removes a cast that was made unnecessary with a fix to flow analysis.
Change-Id: Ia80493fbe64abddd268ca468a7860044954a3928
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165143
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Change-Id: I8baa5a8ceb0e60dc9aad9188441371894b0f7f37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164902
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Avoid using `late final` without initializers on public fields.
Change-Id: I41e36eb7f72b62362b34f4cb3f32a0906c5f362d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164661
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
2020-09-28 sgrekhov@unipro.ru Some 'main()' static analysis tests fixed to not to fail on dart2js
2020-09-28 sgrekhov@unipro.ru Fixes 941. Change flow analysis tests around ==/!== according to the changed spec
2020-09-25 irina.arkhipets@gmail.com More changes for 942: LanguageFeatures/Simple-bounds tests updated.
2020-09-25 sgrekhov@unipro.ru 924. Added tests for the new static analysis of 'main'
2020-09-25 irina.arkhipets@gmail.com One more fix for 942: more Simple-bounds tests corrected.
2020-09-25 irina.arkhipets@gmail.com Fixes 942: LanguageFeature/Simple-bounds tests updated. Common Utils function F<X> toF<X>(X x) improved.
2020-09-23 sgrekhov@unipro.ru Fixes 939. Flow analysis tests changed to not expect promotion
Change-Id: I881d6fb8602f22d0d836a5d42da5dc9f136cadf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164788
Reviewed-by: William Hesse <whesse@google.com>
This is the latest revision that has not been migrated to null safety.
It improves the docs and is worth syncing even though it is not
published.
We cannot bring the null safety migrated version into the SDK yet
because it is not in the allow list for the experiment.
Change-Id: Ie319d81fb4868ed284613424185045f3496e04ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163405
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
This also switches the checked-in SDKs on Windows to x64.
Cq-Include-Trybots: luci.dart.try:vm-kernel-win-release-ia32-try
Change-Id: Ie1c96cefd2ef3d1a06e6ed675e5eb8fe72f3e33d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163343
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2020-09-17 sgrekhov@unipro.ru int-to-double tests fixed. Added expected static warning
2020-09-17 sgrekhov@unipro.ru LibTest/html/Window/postMessage_A01_t01 test fixed to filter test runner messages
2020-09-17 sgrekhov@unipro.ru Fixes 930. Change expectations in flow analysis loops tests according to the changed spec
2020-09-16 sgrekhov@unipro.ru Fixes 935. Change expectations in flow analysis for-in tests according to the changed spec
2020-09-15 irina.arkhipets@gmail.com Fixes 916: LibTest\Spread-collections tests adopted for null safety.
2020-09-15 sgrekhov@unipro.ru Fixes 937. Expect Object? as a default least upper bound
Failures will be triaged on https://github.com/dart-lang/co19/issues/938.
Change-Id: I6c689d48d937f3ec6f43fb6f2135d52f39bdf52a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163064
Reviewed-by: William Hesse <whesse@google.com>
2020-09-14 sgrekhov@unipro.ru iframe.html added to the Window directory
2020-09-14 sgrekhov@unipro.ru Path to iframe.html fixed
2020-09-14 sgrekhov@unipro.ru Assert tests fixed. Use assertStatementsEnabled flag to check if asserts are enabled
2020-09-14 sgrekhov@unipro.ru Fix HTML tests to use OtherResources flag
2020-09-14 sgrekhov@unipro.ru Assert tests uodated to use assertStatementsEnabled check
2020-09-14 sgrekhov@unipro.ru Fixes 934. LanguageFeatures/int-to-double tests migrated to null safety
2020-09-11 sgrekhov@unipro.ru Issue number added
2020-09-11 sgrekhov@unipro.ru Fix for 933. Compile time error fixed
Change-Id: I314c8e76c49d55f5a738f05fd99a0f3ab66e82a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162720
Reviewed-by: William Hesse <whesse@google.com>
Fixes a bug in the null safety migration which throws on a null `size`
argument for a font.
Change-Id: I19e95f38c67c9a9014480d52dab4f10538e88234
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161141
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
The main reason is that this adds better help text when run from
`dart format`. But it includes a couple of other changes and fixes:
* Don't crash when non-ASCII whitespace is trimmed.
* Split all conditional expressions (`?:`) when they are nested.
* Handle `external` and `abstract` fields and variables.
Change-Id: I59326e693bfe538013cd23b58924461f60e8e908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160981
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Change-Id: Ie0adafbd4138b5bec9aa7f3346359d6af31bbd99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161104
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
This is a reland of 2bafc322fd
Original change's description:
> [vm/wasm] Boilerplate for package:wasm
>
> So far this just builds the wasmer library, copies it into the sdk
> directory, loads the library, and allows you to compile WASM modules.
> You can't actually do anything with the modules yet.
>
> Bug: https://github.com/dart-lang/sdk/issues/37882
> Change-Id: I7d7cfe5721bbe38a6afe76f326518e714d236ed4
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158367
> Commit-Queue: Liam Appelbe <liama@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
Bug: https://github.com/dart-lang/sdk/issues/37882
Change-Id: I8056df1e301acde2772ba2273148faa53d03173e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159321
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
Change-Id: I0e1988caa9981e3b958a569f06d307c54d853776
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159082
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
This reverts commit 2bafc322fd.
Reason for revert: Build failures on Flutter HHH CI bots and golem (Dart VM ARMv8, Flutter).
Original change's description:
> [vm/wasm] Boilerplate for package:wasm
>
> So far this just builds the wasmer library, copies it into the sdk
> directory, loads the library, and allows you to compile WASM modules.
> You can't actually do anything with the modules yet.
>
> Bug: https://github.com/dart-lang/sdk/issues/37882
> Change-Id: I7d7cfe5721bbe38a6afe76f326518e714d236ed4
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158367
> Commit-Queue: Liam Appelbe <liama@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
TBR=rmacnak@google.com,asiva@google.com,liama@google.com
Change-Id: I2c5b390987bf45704a3de98e050f4bcf1cb235d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/37882
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159243
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
So far this just builds the wasmer library, copies it into the sdk
directory, loads the library, and allows you to compile WASM modules.
You can't actually do anything with the modules yet.
Bug: https://github.com/dart-lang/sdk/issues/37882
Change-Id: I7d7cfe5721bbe38a6afe76f326518e714d236ed4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158367
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
git log --oneline 0d185a398a1684c15ea16a0facc17f5d170e5d51..cf9795f
cf9795f3 (HEAD -> master, origin/master, origin/HEAD) Refresh binstubs after recompile in global run (#2610)
5c741f6d Avoid O(2^N) complexity when reformating an incompatibility-tree of depth N. (#2615)
10fb3f58 (count_outdated_packages) Differentiate between ansi and unicode support (#2608)
Change-Id: Iaa5f0a37ca3179f24c4114315d7b2a6c349750f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158389
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Use the commit SHA rather than a tagged version.
Change-Id: I2de82f1e4057a45f65b0041246f7bef097b65642
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157479
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Updates the dependency on package charcode to to a version
of the package with language version 2.10. The package_config.json
file gave its language version as 2.10, enabling null safety,
but this was inconsistent with the package spec in charcode,
and would be overwritten by running tools/generate_package_config.
Bug: https://github.com/dart-lang/sdk/issues/43004
Change-Id: If41861485ca99a150152c72e0f0fcccc7c4780cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158008
Auto-Submit: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Adds a member signature origin to member signatures and includes
an additional reference to these in MethodInvocation, PropertyGet,
PropertySet, etc.
This enables the VM to bypass the member signatures when loading the
AST.
Change-Id: I5cae11f4434bc052d0ba0acf0670dd002c6f3df1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157498
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Updates to the latest unpublished version which has been migrated to
null safety.
Change-Id: If999af780b7788da7b78673cb541bfdb3c1e25cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157401
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2020-07-31 sgrekhov@unipro.ru LibTest/core fixed after tryjob run
2020-07-31 sgrekhov@unipro.ru isRedirect_A01_t02 fixed (set followRedirects to false)
2020-07-31 irina.arkhipets@gmail.com Fixes 874: LibTest\typed_data\Float32x4List tests adopted for null safety.
2020-07-30 sgrekhov@unipro.ru Fix for 877. LibTest\io\HttpClientResponse test migrated to null safety
2020-07-30 sgrekhov@unipro.ru Fix for 876. LibTest\io\HttpClientRequest test migrated to null safety
2020-07-30 sgrekhov@unipro.ru Range test fixed to not to fail on JS
Change-Id: Icb1fba88d6803f87435029e83a933285b3c55b3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156683
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2020-07-16 sgrekhov@unipro.ru Fixes 837. It is allowed to import/export libraries with the same name now
2020-07-13 sgrekhov@unipro.ru Fixes 806. Mixin cannot be derived from its superclass
Change-Id: I0dfd9ed29da07f9855c36a784565bb3940ba4fe2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155761
Reviewed-by: Jonas Termansen <sortie@google.com>
git log --oneline 85bdb898aeb2ac7cea76489ba0bf4e52ff7a79bf..master
04b054b6 Find sdk path with cli_util (#2567)
36c195b9 Only alert about new prereleases for prereleases (#2556)
00b36394 Stop using deprecated mapMap from pkg:collection (#2544)
477cbe72 Improved expectations in flutter_plugin_format validator test (#2532)
a8e2442b `pub run` Don't write about precompilation if no terminal is attached (#2531)
d83d36a4 Don't precompile dependencies of global activate from path (#2530)
870f395c Sanitize git cache folder names (#2522)
03b7f9a5 Avoid divisive terms (#2523)
b239ada4 Remove divisive term (#2517)
Change-Id: I55ea52a86121a382dca5c0f85addd4513ada50bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154940
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This support is required for web clients of dwds within google3
Change-Id: Ia1ecbf8f5ba79d53cb340c83a579dc0810ec0065
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150183
Reviewed-by: Gary Roumanis <grouma@google.com>
Change-Id: I29514f0ba94a9d402b3935a0e199180787d0e945
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154342
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2020-07-07 sgrekhov@unipro.ru Fixes 786. LibTest\async\Zone migrated to null safety
2020-07-07 sgrekhov@unipro.ru More leftFutureOr tests added and also generator migrated to null safety
2020-07-06 sgrekhov@unipro.ru Debug output removed and issue number added
2020-07-06 sgrekhov@unipro.ru Language/Statements tests fixed after tryjob run
2020-07-06 sgrekhov@unipro.ru Fixes 784. LibTest\async\Timer migrated to null safety
2020-07-06 sgrekhov@unipro.ru Fixes 783. LibTest\async\StreamTransformer migrated to null safety
2020-07-06 sgrekhov@unipro.ru Fixes 782. LibTest\async\StreamIterator migrated to null safety
2020-07-03 sgrekhov@unipro.ru Fixes 780. StreamConsumer, StreamController and StreamSink tests migrated to null safety
2020-07-03 sgrekhov@unipro.ru Make getter and setter to have the same type
2020-07-02 sgrekhov@unipro.ru Return an expected type from the test
Change-Id: I746333ddb8505f62041da8ec4a80ba223cfe5594
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153353
Reviewed-by: William Hesse <whesse@google.com>
Note: This is a reland of https://dart-review.googlesource.com/c/sdk/+/150343
Adds a new SDK hash to kernels and the VM which is optionally checked
to verify kernels are built for the same SDK as the VM.
This helps catch incompatibilities that are currently causing
subtle bugs and (not so subtle) crashes.
The SDK hash is encoded in kernels as a new field in components.
The hash is derived from the 10 byte git short hash.
This new check can be disabled via:
tools/gn.py ... --no-verify-sdk-hash
This CL bumps the min. (and max.) supported kernel format version,
making the VM backwards incompatible from this point back.
This also bumps the min. and current ABI version.
Bug: https://github.com/dart-lang/sdk/issues/41802
Change-Id: I2f85945045a603eb9dcfd1f2c0d0d024bd84a956
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152802
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: I23f170e78116b66634da74a486d08816c240b983
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152905
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Rename from `_tag` to `_rev` since they are now pinned by SHA.
Change-Id: I1a325be0a48b12624281bc0e8b5b783e92e54585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152984
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
This reverts commit edde575dcd.
Reason for revert: Breaks the Dart to Flutter roll and golem
Original change's description:
> [SDK] Adds an SDK hash to kernels and the VM.
>
> Adds a new SDK hash to kernels and the VM which is optionally checked
> to verify kernels are built for the same SDK as the VM.
> This helps catch incompatibilities that are currently causing
> subtle bugs and (not so subtle) crashes.
>
> The SDK hash is encoded in kernels as a new field in components.
> The hash is derived from the 10 byte git short hash.
>
> This new check can be disabled via:
> tools/gn.py ... --no-verify-sdk-hash
>
> This CL bumps the min. (and max.) supported kernel format version,
> making the VM backwards incompatible from this point back.
>
> Bug: https://github.com/dart-lang/sdk/issues/41802
> Change-Id: I3cbb2d481239ee64dafdaa0e4aac36c80281931b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150343
> Commit-Queue: Clement Skau <cskau@google.com>
> Reviewed-by: Jens Johansen <jensj@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
TBR=kustermann@google.com,jensj@google.com,cskau@google.com
Change-Id: I34cc7d378e2babdaaca4d932d19c19d0f35422fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/41802
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152703
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Adds a new SDK hash to kernels and the VM which is optionally checked
to verify kernels are built for the same SDK as the VM.
This helps catch incompatibilities that are currently causing
subtle bugs and (not so subtle) crashes.
The SDK hash is encoded in kernels as a new field in components.
The hash is derived from the 10 byte git short hash.
This new check can be disabled via:
tools/gn.py ... --no-verify-sdk-hash
This CL bumps the min. (and max.) supported kernel format version,
making the VM backwards incompatible from this point back.
Bug: https://github.com/dart-lang/sdk/issues/41802
Change-Id: I3cbb2d481239ee64dafdaa0e4aac36c80281931b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150343
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
It relies on flutter copy of clang distribution, same one that is used to build flutter/engine.
It addressed several deprecated warnings from clang compiler for functions like strdup, unlink, etc.
It allows few warnings still since they are triggered in third_party sources.
Change-Id: Ieb13792c011438d46dbbc0fa030e1b5e4ea14315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142704
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
The browser used by the test infrastructure are currently pulled in from
the recipes rather than via gclient. This is the first step to remove
that duplicated functionality and will enable all builders to that need
browser to get them.
The browsers aren't downloaded by default and not available on all
platforms. It is not recommend to use these browsers for local testing,
because they may interfere with a user's installation.
https://github.com/dart-lang/sdk/issues/42417
Change-Id: I5df72c3b43f7b49cf90200d47a089714c91b5b3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152340
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit cb1105af48.
Reason for revert: Broke flutter-engine-linux bot https://ci.chromium.org/p/dart/builders/ci.sandbox/flutter-engine-linux/11048?
Original change's description:
> Update fixnum to the migrated version and add it to the allowed experiments file
>
> This package is used in benchmarking and we need a migrated version in order
> to run benchmarks with null safety enabled.
>
> Change-Id: I916331a03006d6b5d3f0d0bb590012376e410c24
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150170
> Commit-Queue: Jake Macdonald <jakemac@google.com>
> Reviewed-by: Stephen Adams <sra@google.com>
TBR=sortie@google.com,jakemac@google.com,sra@google.com
Change-Id: I4536f395a877c245140d53f7a9463f2ed156d012
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151926
Reviewed-by: Jake Macdonald <jakemac@google.com>
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
This package is used in benchmarking and we need a migrated version in order
to run benchmarks with null safety enabled.
Change-Id: I916331a03006d6b5d3f0d0bb590012376e410c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150170
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
This reverts commit 4ce18ab931.
Reason for revert: bad merge, caused build breakages in flutter/engine
Original change's description:
> Add an --os=fuchsia option to build.py:
>
> tools/build.py --os=fuchsia runtime create_sdk
>
> This is analogous to --os=android. It cross compiles from Linux x64 to
> Fuchsia.
>
> A lot of the build rules are just slightly different between the existing
> Fuchsia build rules used by Flutter, and the ones added by GN SDK. For
> example "$fuchsia_sdk_root/pkg:fdio" is now "$fuchsia_sdk_root/pkg/fdio".
> So to support this I had to add a new variable, using_fuchsia_gn_sdk,
> analogous to using_fuchsia_sdk. Flutter will need to set this to false.
>
> Change-Id: Ief275d65f30a42a801607de93cf2d27a1fe825dd
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150689
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>
TBR=rmacnak@google.com,asiva@google.com,liama@google.com,kaushikiska@google.com,matthewcarroll@google.com
Change-Id: If01ee34eba906c55f2d56ba650748a86e81e701c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151321
Auto-Submit: George Wright <wrightgeorge@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
tools/build.py --os=fuchsia runtime create_sdk
This is analogous to --os=android. It cross compiles from Linux x64 to
Fuchsia.
A lot of the build rules are just slightly different between the existing
Fuchsia build rules used by Flutter, and the ones added by GN SDK. For
example "$fuchsia_sdk_root/pkg:fdio" is now "$fuchsia_sdk_root/pkg/fdio".
So to support this I had to add a new variable, using_fuchsia_gn_sdk,
analogous to using_fuchsia_sdk. Flutter will need to set this to false.
Change-Id: Ief275d65f30a42a801607de93cf2d27a1fe825dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150689
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
On x64 desktop in JIT the trampolines with Handles are a bit slower
than trampolines passing integers or Pointers.
FfiCall.Uint64x01(RunTime): 200.8482627033541 us.
FfiCall.PointerUint8x01(RunTime): 261.3910088865656 us.
FfiCall.Handlex01(RunTime): 355.4978670458585 us.
FfiCall.Handlex02(RunTime): 384.86376755820663 us.
FfiCall.Handlex04(RunTime): 492.896007885658 us.
FfiCall.Handlex10(RunTime): 846.1214043993232 us.
FfiCall.Handlex20(RunTime): 1193.412291169451 us.
Issue: https://github.com/dart-lang/sdk/issues/36858
Issue: https://github.com/dart-lang/sdk/issues/41319
New issue for optimizing multiple handles:
https://github.com/dart-lang/sdk/issues/42341
Also cleans up dart2/native which was erroneously left over from the
benchmark duplication for NNBD.
Change-Id: I81223fefc47129d00984492efb9502d5449f0d4a
Cq-Include-Trybots: luci.dart.try:benchmark-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145593
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
This reverts commit ebcc6dc2a2.
Reason for revert: Broke golem. I think there are more implementations of Logger than I realized.
Original change's description:
> Bump cli_util to 0.2.0; implement new methods
>
> This fixes the issue of progress indicators being shown during tests.
>
> Change-Id: I39fd68cfeca70a63d088aceb4325b42c53766afd
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150669
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>
TBR=paulberry@google.com,jcollins@google.com,mfairhurst@google.com,srawlins@google.com
Change-Id: I52ac0f5d96a161534c28cc160c2a2b3b364ad511
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150693
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This fixes the issue of progress indicators being shown during tests.
Change-Id: I39fd68cfeca70a63d088aceb4325b42c53766afd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150669
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
R=nbosch@google.com
Change-Id: I3055efd512701d4b0c66862a473da2b425097f55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144725
Reviewed-by: David Morgan <davidmorgan@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
This includes ParticleSystem benchmark migrated to NNBD.
Change-Id: I95cbc1262a9be9831e37069202473dd6e10ab565
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150461
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Change-Id: If9006620414f7c0a857b4ebeb733f97a63d52e2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150161
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
The shared libraries for the FfiBoringssl benchmark had been moved up a
level but unfortunately the same change wasn't made for the FfiCall
benchmark.
The IsolateJson benchmark had a typo in the path and broke.
Change-Id: Iec2fec1d5508022d9cfbfb040d80c74b078a0640
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150024
Reviewed-by: William Hesse <whesse@google.com>
Change-Id: I8ca3203423a98f8a0b02f0f8b458623025f1ddd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149847
Auto-Submit: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Update in advance of nnbd work on fixnum for accurate attribution of
benchmarking changes.
Change-Id: I69bad3bb21c16bed149e4c30ac82a351bc6db203
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149846
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Stephen Adams <sra@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
