languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 08:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Add browsers to the DEPS

Browse source 
The browser used by the test infrastructure are currently pulled in from
the recipes rather than via gclient. This is the first step to remove
that duplicated functionality and will enable all builders to that need
browser to get them.

The browsers aren't downloaded by default and not available on all
platforms. It is not recommend to use these browsers for local testing,
because they may interfere with a user's installation.

https://github.com/dart-lang/sdk/issues/42417

Change-Id: I5df72c3b43f7b49cf90200d47a089714c91b5b3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152340
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This commit is contained in:
Alexander Thomas 2020-06-24 14:02:40 +00:00 committed by commit-bot@chromium.org
parent 43eb8790f3
commit d8eb844e5d
1 changed files with 28 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
DEPS
View file

@ -164,6 +164,13 @@ vars = {
"minichromium_rev": "8d641e30a8b12088649606b912c2bc4947419ccc",
"googletest_rev": "f854f1d27488996dc8a6db3c9453f80b02585e12",
# Pinned browser versions used by the testing infrastructure. These are not
# meant to be downloaded by users for local testing.
"download_chrome": False,
"chrome_tag": "81",
"download_firefox": False,
"firefox_tag": "67",
# An LLVM backend needs LLVM binaries and headers. To avoid build time
# increases we can use prebuilts. We don't want to download this on every
# CQ/CI bot nor do we want the average Dart developer to incur that cost.
@ -530,7 +537,27 @@ deps = {
],
"condition": "checkout_llvm",
"dep_type": "cipd",
}
},
Var("dart_root") + "/third_party/browsers/chrome": {
"packages": [
{
"package": "dart/browsers/chrome/${{platform}}",
"version": "version:" + Var("chrome_tag"),
},
],
"condition": "download_chrome",
"dep_type": "cipd",
},
Var("dart_root") + "/third_party/browsers/firefox": {
"packages": [
{
"package": "dart/browsers/firefox/${{platform}}",
"version": "version:" + Var("firefox_tag"),
},
],
"condition": "download_firefox",
"dep_type": "cipd",
},
}
deps_os = {