mirror of
https://github.com/dart-lang/sdk
synced 2024-10-04 16:54:55 +00:00
[analyzer] remove the completion language model file
Bug: https://github.com/dart-lang/sdk/issues/42988 Change-Id: I3988f08eb9a7480aacb4a7be79f537595807a3c0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158067 Reviewed-by: Keerti Parthasarathy <keertip@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
This commit is contained in:
parent
d98aa34388
commit
57b192a0fc
10
DEPS
10
DEPS
|
@ -483,16 +483,6 @@ deps = {
|
|||
"dep_type": "cipd",
|
||||
},
|
||||
|
||||
Var("dart_root") + "/pkg/analysis_server/language_model": {
|
||||
"packages": [
|
||||
{
|
||||
"package": "dart/language_model",
|
||||
"version": "lIRt14qoA1Cocb8j3yw_Fx5cfYou2ddam6ArBm4AI6QC",
|
||||
}
|
||||
],
|
||||
"dep_type": "cipd",
|
||||
},
|
||||
|
||||
Var("dart_root") + "/buildtools": {
|
||||
"packages": [
|
||||
{
|
||||
|
|
|
@ -21,7 +21,7 @@ void main() {
|
|||
tokenize('if (list == null) { return; } for (final i = 0; i < list.');
|
||||
final response = await ranking.makePredictRequest(tokens);
|
||||
expect(response['data']['length'], greaterThan(0.9));
|
||||
});
|
||||
}, skip: 'https://github.com/dart-lang/sdk/issues/42988');
|
||||
}
|
||||
|
||||
final directory = path.join(File.fromUri(Platform.script).parent.path, '..',
|
||||
|
|
|
@ -15,60 +15,62 @@ void main() {
|
|||
return;
|
||||
}
|
||||
|
||||
LanguageModel model;
|
||||
group('LanguageModel', () {
|
||||
LanguageModel model;
|
||||
|
||||
setUp(() {
|
||||
model = LanguageModel.load(directory);
|
||||
});
|
||||
setUp(() {
|
||||
model = LanguageModel.load(directory);
|
||||
});
|
||||
|
||||
tearDown(() {
|
||||
model.close();
|
||||
});
|
||||
tearDown(() {
|
||||
model.close();
|
||||
});
|
||||
|
||||
test('calculates lookback', () {
|
||||
expect(model.lookback, expectedLookback);
|
||||
});
|
||||
test('calculates lookback', () {
|
||||
expect(model.lookback, expectedLookback);
|
||||
});
|
||||
|
||||
test('predict with defaults', () {
|
||||
final tokens =
|
||||
tokenize('if (list == null) { return; } for (final i = 0; i < list.');
|
||||
final suggestions = model.predict(tokens);
|
||||
expect(suggestions.first, 'length');
|
||||
});
|
||||
test('predict with defaults', () {
|
||||
final tokens =
|
||||
tokenize('if (list == null) { return; } for (final i = 0; i < list.');
|
||||
final suggestions = model.predict(tokens);
|
||||
expect(suggestions.first, 'length');
|
||||
});
|
||||
|
||||
test('predict with confidence scores', () {
|
||||
final tokens =
|
||||
tokenize('if (list == null) { return; } for (final i = 0; i < list.');
|
||||
final suggestions = model.predictWithScores(tokens);
|
||||
final best = suggestions.entries.first;
|
||||
expect(best.key, 'length');
|
||||
expect(best.value, greaterThan(0.9));
|
||||
});
|
||||
test('predict with confidence scores', () {
|
||||
final tokens =
|
||||
tokenize('if (list == null) { return; } for (final i = 0; i < list.');
|
||||
final suggestions = model.predictWithScores(tokens);
|
||||
final best = suggestions.entries.first;
|
||||
expect(best.key, 'length');
|
||||
expect(best.value, greaterThan(0.9));
|
||||
});
|
||||
|
||||
test('predict when no previous tokens', () {
|
||||
final tokens = <String>[];
|
||||
final suggestions = model.predict(tokens);
|
||||
expect(suggestions.first, isNotEmpty);
|
||||
});
|
||||
test('predict when no previous tokens', () {
|
||||
final tokens = <String>[];
|
||||
final suggestions = model.predict(tokens);
|
||||
expect(suggestions.first, isNotEmpty);
|
||||
});
|
||||
|
||||
test('load fail', () {
|
||||
try {
|
||||
LanguageModel.load('doesnotexist');
|
||||
fail('Failure to load language model should throw an exception');
|
||||
} catch (e) {
|
||||
expect(
|
||||
e.toString(), equals('Invalid argument(s): Unable to create model.'));
|
||||
}
|
||||
});
|
||||
test('load fail', () {
|
||||
try {
|
||||
LanguageModel.load('doesnotexist');
|
||||
fail('Failure to load language model should throw an exception');
|
||||
} catch (e) {
|
||||
expect(e.toString(),
|
||||
equals('Invalid argument(s): Unable to create model.'));
|
||||
}
|
||||
});
|
||||
|
||||
test('isNumber', () {
|
||||
expect(model.isNumber('0xCAb005E'), true);
|
||||
expect(model.isNumber('foo'), false);
|
||||
expect(model.isNumber('3.1415'), true);
|
||||
expect(model.isNumber('1337'), true);
|
||||
expect(model.isNumber('"four score and seven years ago"'), false);
|
||||
expect(model.isNumber('0.0'), true);
|
||||
});
|
||||
test('isNumber', () {
|
||||
expect(model.isNumber('0xCAb005E'), true);
|
||||
expect(model.isNumber('foo'), false);
|
||||
expect(model.isNumber('3.1415'), true);
|
||||
expect(model.isNumber('1337'), true);
|
||||
expect(model.isNumber('"four score and seven years ago"'), false);
|
||||
expect(model.isNumber('0.0'), true);
|
||||
});
|
||||
}, skip: 'https://github.com/dart-lang/sdk/issues/42988');
|
||||
}
|
||||
|
||||
const expectedLookback = 100;
|
||||
|
|
20
sdk/BUILD.gn
20
sdk/BUILD.gn
|
@ -61,11 +61,6 @@ declare_args() {
|
|||
# ...........packages
|
||||
# ..........resources/
|
||||
# ..........templates/
|
||||
# ......model/
|
||||
# ........lexeme/
|
||||
# ..........idx2word.json
|
||||
# ..........model.tflite
|
||||
# ..........word2idx.json
|
||||
# ....include/
|
||||
# ......dart_api.h
|
||||
# ......dart_native_api.h
|
||||
|
@ -323,16 +318,6 @@ if (is_win) {
|
|||
}
|
||||
|
||||
if (target_cpu == "x64") {
|
||||
copy_tree_specs += [
|
||||
{
|
||||
target = "copy_language_model"
|
||||
visibility = [ ":create_common_sdk" ]
|
||||
deps = [ ":copy_libraries" ]
|
||||
source = "../pkg/analysis_server/language_model"
|
||||
dest = "$root_out_dir/dart-sdk/bin/model"
|
||||
ignore_patterns = "{}"
|
||||
},
|
||||
]
|
||||
if (is_linux || is_android || is_fuchsia) {
|
||||
copy_tree_specs += [
|
||||
{
|
||||
|
@ -915,10 +900,7 @@ group("create_common_sdk") {
|
|||
public_deps += [ ":copy_7zip" ]
|
||||
}
|
||||
if (target_cpu == "x64") {
|
||||
public_deps += [
|
||||
":copy_language_model",
|
||||
":copy_libtensorflowlite_c",
|
||||
]
|
||||
public_deps += [ ":copy_libtensorflowlite_c" ]
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue