Commit graph

423 commits

Author SHA1 Message Date
nweiz@google.com
474994a5b7 Add a validator that tests the size of pub packages.
BUG=7045

Review URL: https://codereview.chromium.org//12094093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17961 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 02:09:37 +00:00
nweiz@google.com
f181fdc8a8 Add a Pub validator for READMEs that are invalid utf-8.
BUG=7045

Review URL: https://codereview.chromium.org//12090081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17948 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 22:39:53 +00:00
nweiz@google.com
dd763be6af Add a pub validator for compiled dartdoc output.
BUG=7045

Review URL: https://codereview.chromium.org//12089076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17943 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 21:02:46 +00:00
lrn@google.com
9b23dff467 Reapply "Rename mappedBy to map."
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 15:12:56 +00:00
floitsch@google.com
b1a118d5ce Revert "Rename mappedBy to map."
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 14:02:27 +00:00
lrn@google.com
0dc2f4b1ba Rename mappedBy to map.
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 12:37:13 +00:00
ricow@google.com
b410b64719 Mark pub/oauth2_test as timeout as well as pass,fail
Review URL: https://codereview.chromium.org//12086078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17885 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 07:26:23 +00:00
rnystrom@google.com
b0779d1453 Remove invalid sanity check.
In the presence of setUp() it is possible for stuff to be scheduled
by the time integration() is called.

Review URL: https://codereview.chromium.org//12090075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17870 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 19:47:16 +00:00
nweiz@google.com
8be520740e Roll back Pub stream changes.
These changes are still breaking the Windows bots, so I'm rolling them back
until we figure out what's going on.

TBR

Review URL: https://codereview.chromium.org//12095050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17867 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 19:26:03 +00:00
rnystrom@google.com
f73ee270b7 Fix issue where failing pub tests confused unittest.
Review URL: https://codereview.chromium.org//12086052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17861 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 17:45:50 +00:00
nweiz@google.com
d56994eb18 Use the dart:async Stream API thoroughly in Pub.
Review URL: https://codereview.chromium.org//12021008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17821 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 01:06:39 +00:00
sigmund@google.com
aeca565ae9 Fix build for throwsStateError: remove duplicate definitions in other tests.
Review URL: https://codereview.chromium.org//12088056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17812 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 21:47:05 +00:00
rnystrom@google.com
63eac3fe8b Handle parsing the "version" file better.
Review URL: https://codereview.chromium.org//12087008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17740 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 00:56:07 +00:00
jmesserly@google.com
61c97e7325 Restructure YAML package suitable for pub lish
After this I can use tools/publish_pkg.py upload script to fix dartbug.com/4126

Review URL: https://codereview.chromium.org//11622011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17685 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-26 02:25:43 +00:00
rnystrom@google.com
079402c3ae Get rid of RootSource.
This was a sort of hackish source only used internally during
version solving. But it causes a couple of subtle bugs because it
never gets registered with the SourceRegistry. That in turn makes
toString() fail on any PackageId with that source since it relies
on the Source being registered.

The simplest fix is to just remove the hacked source and have a
null source in PackageId/Ref mean "root" and handle it specially.

Review URL: https://codereview.chromium.org//12047096

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17646 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 18:22:29 +00:00
lrn@google.com
1f05296600 Change singleSubscription/multiSubscription to normal/broadcast.
Also make StreamController not a Stream.

Review URL: https://codereview.chromium.org//12049013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17563 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 13:30:27 +00:00
floitsch@google.com
ed938af868 Rename new Uri.fromString to Uri.parse.
Review URL: https://codereview.chromium.org//12052038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17562 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 13:26:18 +00:00
floitsch@google.com
fb7b9e3c5c Rename Date to DateTime.
BUG=http://dartbug.com/1424

Review URL: https://codereview.chromium.org//11770004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17549 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 12:16:37 +00:00
rnystrom@google.com
344249b02f Get rid of unneeded Future.immediate() calls.
Future.then() will now implicitly wrap the callback result in a
future if it isn't one, so this manual wrapping can be removed.

Also take advantage of the fact that Future.immediate() is always
async now and remove some workarounds.

Finally, noticed there were two copies of the git-related code
floating around so killed the old one.

Review URL: https://codereview.chromium.org//12042053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17519 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 01:13:36 +00:00
rnystrom@google.com
7ec5b82507 Make pub use the SDK's "version" file for its version.
This includes pub's own version and the implied version of SDK
packages. I also added a little test that verifies that pub can
parse the actual version file generated with the SDK.
BUG=5906,6173,7837

Review URL: https://codereview.chromium.org//12036065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17512 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 23:20:09 +00:00
rnystrom@google.com
edf7ca2927 Add support for specifying SDK version constraints in pubspecs.
These constraints don't currently do anything, but these patch
gets them being parsed by pub.

Review URL: https://codereview.chromium.org//12038038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17477 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 17:41:40 +00:00
rnystrom@google.com
f053f356ee Clean up code that locates SDK and SDK version.
This is prep work for SDK constraints. It moves the SDK
version-related code out of SdkSource (which will go away at some
point) into its own library.

I also removed the need for the DART_SDK env variable. It will
still be used if set (which the tests need), but if not set, Pub
will locate the SDK.
Clean up a few static warnings.

Review URL: https://codereview.chromium.org//11871028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17433 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 23:52:37 +00:00
hausner@google.com
a885f8638b Fix map literals from change 17410
Remove any type arguments from map literals
that had one type argument before change 17410.
Review URL: https://codereview.chromium.org//12045024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17412 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 17:31:29 +00:00
hausner@google.com
dc3bf6646a Stop supporting map literals with 1 type argument
To be checked in next week Tue (Jan 22)

Review URL: https://codereview.chromium.org//12021022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17410 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 16:48:00 +00:00
floitsch@google.com
1febeb689a Move some core classes to collection library.
Review URL: https://codereview.chromium.org//11867024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17352 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 13:34:02 +00:00
rnystrom@google.com
d160b37a92 Clean up a few static warnings.
Review URL: https://codereview.chromium.org//11867029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17331 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 23:54:38 +00:00
rnystrom@google.com
4573dcd11d Create a unit test config for the pub tests that's prettier.
In particular, it:

- Shows test results incrementally.
- Cleans up the stack traces.
- Doesn't show the failures and their stack traces twice.

Right now, it's opt in. You need to:
- Add initConfig() to the top of a test suite.
- Pass "--human" when you run the test.

At some point, I can add the initConfig() calls to every test suite but I figured we could just add them manually for now.

Review URL: https://codereview.chromium.org//11867012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17313 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 21:11:43 +00:00
rnystrom@google.com
97af32b4d3 Make integration tests a bit cleaner.
Review URL: https://codereview.chromium.org//11943005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17300 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 18:06:22 +00:00
nweiz@google.com
03244ffee1 Stop treating StreamController as a Stream.
Apparently StreamController will soon stop extending Stream, so this gets rid of
all uses of it as a Stream in pkg/http and pub.

Review URL: https://codereview.chromium.org//11975017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17163 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 21:35:45 +00:00
nweiz@google.com
e0867a91d1 Mark pub tests as flaky.
BUG=7905,7920

Review URL: https://codereview.chromium.org//11944003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17107 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 00:15:29 +00:00
nweiz@google.com
013b0104f5 Add an ErrorGroup class to Pub.
Review URL: https://codereview.chromium.org//11941003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17106 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 00:12:30 +00:00
nweiz@google.com
59cbc77eaf Increase the step timeout in scheduled pub tests.
Also un-mark the uploaders test as flaky.

BUG=7879

Review URL: https://codereview.chromium.org//11881033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17039 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 00:44:31 +00:00
nweiz@google.com
30d2e78687 Stop working around issue 7781 in Pub.
Review URL: https://codereview.chromium.org//11881032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17038 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 00:15:23 +00:00
ricow@google.com
e5b51f0196 Mark pub/pub_uploader_test as flaky.
Filed http://dartbug.com/7879
Review URL: https://codereview.chromium.org//11881016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17010 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-14 07:07:29 +00:00
lrn@google.com
4868ee2110 Remove Futures class, move methods to Future.
Optimize Future.forEach, Future.delay.

Review URL: https://codereview.chromium.org//11865005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16954 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-11 09:46:45 +00:00
nweiz@google.com
4774c5b7cf Un-mark pub_lish_test as flaky now that socket issues are resolved.
BUG=7819

Review URL: https://codereview.chromium.org//11826067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16944 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-11 00:06:25 +00:00
ricow@google.com
2f128089e7 Mark pub/pub_lish_test as flaky on linux.
This has been flaking a lot recently.

Filed high priority bug 7819
Review URL: https://codereview.chromium.org//11778090

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16902 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-10 08:23:57 +00:00
nweiz@google.com
fcff2fb2d9 Fix ALL the pub tests.
Review URL: https://codereview.chromium.org//11830017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16888 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 21:37:40 +00:00
rnystrom@google.com
907f515718 Fix chainToCompleter.
Review URL: https://codereview.chromium.org//11783052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16833 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 02:26:49 +00:00
rnystrom@google.com
b60575a0fb Get more pub tests working.
Review URL: https://codereview.chromium.org//11821012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16830 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 01:32:55 +00:00
rnystrom@google.com
c324f5f050 Get validator tests working on lib_v2.
Review URL: https://codereview.chromium.org//11784031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16776 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 01:39:25 +00:00
rnystrom@google.com
021b6438c5 Commit Martin's patch for pub + lib_v2.
Pub is still all kinds of broken with this, but it's slightly
less broken. Some tests pass, and at least the code *parses*
after this.

Review URL: https://codereview.chromium.org//11785028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16763 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 23:11:55 +00:00
floitsch@google.com
4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
rnystrom@google.com
0f99a4b070 Convert pub tests to line doc comments.
Review URL: https://codereview.chromium.org//11785008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16667 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-05 01:19:42 +00:00
nweiz@google.com
cab2a027ce Add a validator for top-level directory names.
BUG=7045

Review URL: https://codereview.chromium.org//11741026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16621 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-04 00:25:22 +00:00
rnystrom@google.com
ac04fc6c18 Convert pkg/http to use "package:" imports.
Review URL: https://codereview.chromium.org//11746009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16620 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-04 00:10:47 +00:00
nweiz@google.com
09afa8f485 Validate that a package doesn't depend on itself.
BUG=7045

Review URL: https://codereview.chromium.org//11737013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16614 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-03 22:18:46 +00:00
sgjesse@google.com
7e293aa077 Reapply "Fix URI encoding/decoding of + and space""
Updated test expectations for some tests for pkg/http, pkg/oauth2 and
pub to match the change.

TBR=lrn@google.com

Review URL: https://codereview.chromium.org//11659009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16426 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:50:05 +00:00
floitsch@google.com
f020a7d270 Add 'timeout' for io_test.
This reintroduces the change from https://codereview.chromium.org/11648033/
which was reverted in https://codereview.chromium.org/11570065/.

Review URL: https://codereview.chromium.org//11660003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16425 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:48:33 +00:00
floitsch@google.com
5271b558c2 Close receivePort when tests are failing.
Review URL: https://codereview.chromium.org//11570065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16422 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:37:48 +00:00
nweiz@google.com
5168d9bafd Add a validator for dependency version constraints.
BUG=7045

Review URL: https://codereview.chromium.org//11635060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16415 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 01:59:58 +00:00
nweiz@google.com
88af0578b6 Add a timeout to scheduled pub tests.
This ensures that at least we'll know which test is timing out.

Review URL: https://codereview.chromium.org//11649047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16410 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 00:24:44 +00:00
floitsch@google.com
bef5bcf8b4 Update status file.
Review URL: https://codereview.chromium.org//11648033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16395 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 20:09:26 +00:00
ager@google.com
87a38c4546 Fix pub suppression
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//11648008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16310 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 10:24:14 +00:00
ricow@google.com
e652efe397 Suppress flake for pub/io_test on windows
Review URL: https://codereview.chromium.org//11637013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16307 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 08:49:10 +00:00
nweiz@google.com
71e2fc2bf4 Fix analyzer errors/warnings for Pub.
Review URL: https://codereview.chromium.org//11609005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16299 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 01:08:42 +00:00
rnystrom@google.com
747a3f83f5 Move path ("pathos") to pkg/.
Review URL: https://codereview.chromium.org//11647003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16297 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 00:04:37 +00:00
nweiz@google.com
14c52ba5f1 Make listDir always emit paths within the given directory.
BUG=7346

Review URL: https://codereview.chromium.org//11553043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16275 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:00:12 +00:00
nweiz@google.com
e2036dea9c Add a pub command for managing uploaders for packages.
BUG=7363

Review URL: https://codereview.chromium.org//11569046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16230 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 21:47:37 +00:00
nweiz@google.com
3ea1942248 Validate that a single library has the same name as the package.
BUG=7045

Review URL: https://codereview.chromium.org//11519049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16139 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 20:57:30 +00:00
nweiz@google.com
899b1a7d1f A few small changes to the "pub lish" confirmation UI.
* Don't collapse the root directory of a directory tree, since this is usually
  going to be a very heterogeneous set of files and directories.

* Indent "(N more...)" two fewer spaces. This makes it clearer at what level
  things are collapsed when it comes immediately after a directory. E.g.

      |-- dir
      |   '-- file
      | (6 more...)
      |-- other-dir

  vs

      |-- dir
      |   '-- file
      |   (6 more...)
      |-- other-dir

Review URL: https://codereview.chromium.org//11442068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16085 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 01:11:47 +00:00
rnystrom@google.com
0f9bed70a5 Make pub publish more user friendly:
- Show the contents of their package.
- Let the confirm the upload even if there are no warnings.
- Make the error/warning text less scary.
- Validate that the pubspec has a version client-side.

Addresses #7175 and #7219.

Review URL: https://codereview.chromium.org//11557008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16068 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 22:22:38 +00:00
nweiz@google.com
7a2155fd65 Move path-manipulation code from io.dart into path.dart.
Review URL: https://codereview.chromium.org//11553005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16063 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 21:24:09 +00:00
rnystrom@google.com
f0154d3b5a Fix #7330.
Review URL: https://codereview.chromium.org//11558022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16056 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 19:49:26 +00:00
nweiz@google.com
8c3148b8b8 Mark the Pub validator test as failing on mac.
Review URL: https://codereview.chromium.org//11552004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16013 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 01:47:38 +00:00
nweiz@google.com
6e4bb05e59 Add a validator that checks that the lib directory is not empty.
BUG=7045

Review URL: https://codereview.chromium.org//11543006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16010 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 00:54:17 +00:00
sgjesse@google.com
93514a3b28 Reapply "Stop working around issue 6984."
Originally committted in r15804 and reverted in r15825.

Issue 6984 should be fixed by r15951.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11528005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15961 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 10:03:21 +00:00
rnystrom@google.com
67367bf7df Handle relative paths where the trailing directory has an extension.
Review URL: https://codereview.chromium.org//11512011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15946 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 03:22:15 +00:00
rnystrom@google.com
9125bd4591 Clean up command help.
It was missing a newline before which made it look busted:

some command helpUsage: pub foo

Review URL: https://codereview.chromium.org//11485012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15944 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 02:15:05 +00:00
rnystrom@google.com
e025df43ea Revise path library.
BUG=

Review URL: https://codereview.chromium.org//11471048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15937 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 23:56:19 +00:00
rnystrom@google.com
10f914c414 Get pub_lish tests running on Windows.
There were two issues:

1. We were printing 7zip's stderr to pub's stderr which confuses the tests that look for certain errors.
2. Sometimes deleting the sandbox fails because the spawned pub process hasn't shut down yet. To handle that, we just retry the delete a few times. <sigh>

Review URL: https://codereview.chromium.org//11522006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15935 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 23:11:21 +00:00
rnystrom@google.com
c9bacbbdb4 Fix path tests on windows.
BUG=

Review URL: https://codereview.chromium.org//11472045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15883 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 05:11:32 +00:00
nweiz@google.com
f813520a0a Add Bob's path library to pub.
BUG=7215

Review URL: https://codereview.chromium.org//11475046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15881 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:47:03 +00:00
nweiz@google.com
3b8e03576e Validate that an uploaded package has a LICENSE file.
BUG=7045

Review URL: https://codereview.chromium.org//11474047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15879 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:24:44 +00:00
nweiz@google.com
55ad513b3b Work around issue 7218 in Pub.
Review URL: https://codereview.chromium.org//11470030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15878 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:21:15 +00:00
rnystrom@google.com
30d0a0356d Fix type annotation and comment.
Review URL: https://codereview.chromium.org//11464040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15875 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:46:07 +00:00
rnystrom@google.com
015bb89346 Make sure to drain stderr in tests so that spawned process doesn't hang.
Review URL: https://codereview.chromium.org//11474046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15874 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:18:06 +00:00
rnystrom@google.com
2b9281fe14 Add in basic logging system.
Review URL: https://codereview.chromium.org//11470023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15870 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 22:13:47 +00:00
nweiz@google.com
97f425b7de Add a validator that checks package names.
BUG=7045

Review URL: https://codereview.chromium.org//11444018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15857 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 19:30:51 +00:00
nweiz@google.com
e15d4788ce Require a description field in pubspecs.
BUG=7045

Review URL: https://codereview.chromium.org//11466020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15856 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 19:27:03 +00:00
rnystrom@google.com
cf5ab6030e Revert "By default use current code page on Windows for decoding string"
This reverts commit c247cd299958d0ee713dcfef8aaf44d230a3a7e0.

Revert "Fix memory leaks in system string patch"

This reverts commit 5e533a0c383518fc1851fbdc01a796f7d6b077f8.

Review URL: https://codereview.chromium.org//11446067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15854 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 18:49:52 +00:00
rnystrom@google.com
e3bc775e68 Revert "Add logging system to pub and sprinkle some logging in."
This reverts commit 60468a1a0854389bb3f460cf2368f22013f1af31.

BUG=

Review URL: https://codereview.chromium.org//11472016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15830 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:48:12 +00:00
rnystrom@google.com
578c415134 Add logging system to pub and sprinkle some logging in.
We'll have to tune which things we log over time, but this covers
most IO operations which is where almost all of our problems come
from.

This patch also means that going forward you should no longer call
print() or printError() (which is gone) directly. Instead:

print() -> log.message()
printError() -> log.error()

That ensures all messages will correctly get added to the log's
transcript.

Review URL: https://codereview.chromium.org//11437019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15827 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:29:23 +00:00
nweiz@google.com
83fa5c203c Stop working around issue 7044.
Review URL: https://codereview.chromium.org//11478004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15826 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:11:35 +00:00
nweiz@google.com
29318c2f5c Revert "Stop working around issue 6984."
Review URL: https://codereview.chromium.org//11464015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15825 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:09:19 +00:00
nweiz@google.com
01dd8fcb4e Stop working around issue 6984.
Review URL: https://codereview.chromium.org//11464006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15804 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 20:50:21 +00:00
rnystrom@google.com
39dc1b5323 Better error messages for dependency conflicts.
BUG=

Review URL: https://codereview.chromium.org//11445034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15768 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 02:04:30 +00:00
nweiz@google.com
0e9b2ef0bd Add validation infrastructure for "pub lish".
This also adds a simple validator.

BUG=7045

Review URL: https://codereview.chromium.org//11434118

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15765 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 00:25:41 +00:00
nweiz@google.com
4ba4e92937 Handle OAuth2 AuthorizationExceptions in pub.
BUG=6950

Review URL: https://codereview.chromium.org//11416352

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15747 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 19:47:32 +00:00
rnystrom@google.com
2b3c4cd639 Make directory renaming more resilient on Windows.
BUG=

Review URL: https://codereview.chromium.org//11348332

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15608 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 22:39:45 +00:00
rnystrom@google.com
0c0d8d9dc7 Get curl uploads working on Mac.
Review URL: https://codereview.chromium.org//11411273

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15592 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 18:21:41 +00:00
nweiz@google.com
6a6c381b91 Use pkg/http pervasively in pub.
Review URL: https://codereview.chromium.org//11280246

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15559 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 01:15:23 +00:00
nweiz@google.com
f7f4e8c458 Give all async exceptions in pub some sort of stack trace.
Review URL: https://codereview.chromium.org//11421159

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15547 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 22:45:51 +00:00
nweiz@google.com
806e8a5432 Mark pub oauth2 and curl_client tests as skip on Windows.
Review URL: https://codereview.chromium.org//11308262

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15488 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:52:00 +00:00
nweiz@google.com
ff3ab9a439 Mark the pub oauth2_test as failing on Windows.
Review URL: https://codereview.chromium.org//11418227

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15483 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:39:07 +00:00
rnystrom@google.com
e7382431ba Get archive creation working on Windows.
Review URL: https://codereview.chromium.org//11348288

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15482 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:20:28 +00:00
nweiz@google.com
2df3fd15b2 The macos pub tests are working again.
BUG=

Review URL: https://codereview.chromium.org//11421136

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15479 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 23:34:34 +00:00
nweiz@google.com
558ffd19bf Work around issue 6984.
This ensures that before an HTTP response is closed, its corresponding
request is drained of input.

Review URL: https://codereview.chromium.org//11348285

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15476 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 22:43:10 +00:00
nweiz@google.com
a964e37605 Don't require users to copy-paste authorization codes when authorizing pub.
BUG=6951

Review URL: https://codereview.chromium.org//11348268

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15468 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 19:45:06 +00:00
nweiz@google.com
3b5ab2e81e Add support for pub command aliases.
BUG=6949

Review URL: https://codereview.chromium.org//11416222

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15434 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:57:30 +00:00