Commit graph

423 commits

Author SHA1 Message Date
gram@google.com 9b40e6b13e Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.
Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Review URL: https://codereview.chromium.org//12393017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19339 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:49:15 +00:00
ricow@google.com 85b572e7d7 Mark flaky pub tests
Review URL: https://codereview.chromium.org//12377042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19284 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:08:20 +00:00
gram@google.com 621650b0e8 Disable breaking tests while I investigate the issue. I don't really want to revert;
I want to understand this as it may indicate some other problem.
Review URL: https://codereview.chromium.org//12387033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19271 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 01:38:57 +00:00
nweiz@google.com a903dfd3a4 Remove the wrapStream workaround for issue 8310.
Review URL: https://codereview.chromium.org//12374033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19266 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:24:21 +00:00
nweiz@google.com 2a0c74a18d Make pub warning-clean.
Review URL: https://codereview.chromium.org//12382031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19265 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:21:58 +00:00
gram@google.com 017d21bdc0 Unit test changes:
- add back KevMoo's assertions now that the bugs they exposed ar efixed
- remove onTestResult methods from a couple of configs; these did nothing other
  than prevent the base class implementation from being called which is wrong.
- fix the TestFunction signature
- change from ExpectException, which is deprecated, to TestFailure.
Review URL: https://codereview.chromium.org//12335113

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19166 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 19:57:40 +00:00
amouravski@google.com edee0d7e8e Updated an error message to inform users that their packages were not installed
when their SDK version does not match.

Review URL: https://codereview.chromium.org//12315059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19026 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 03:12:02 +00:00
rnystrom@google.com 1d62e0a077 Disable test on Windows for now.
Review URL: https://codereview.chromium.org//12313114

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19016 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:20:47 +00:00
rnystrom@google.com b88ebea7c3 Handle shared path dependencies.
BUG=https://code.google.com/p/dart/issues/detail?id=8775

Review URL: https://codereview.chromium.org//12335076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19012 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:00:16 +00:00
lrn@google.com 3c0ac360e7 Remove deprecated string features.
Make String.codeUnits return a List.

Review URL: https://codereview.chromium.org//12282038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
nweiz@google.com c8f6014ae7 Move pkg/path to pkg/pathos.
Review URL: https://codereview.chromium.org//12316056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18906 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:45:55 +00:00
rnystrom@google.com df8647c43f Allow whitespace in version constraints.
BUG=http://code.google.com/p/dart/issues/detail?id=7140

Review URL: https://codereview.chromium.org//12310029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18851 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 19:47:44 +00:00
rnystrom@google.com e3e5d46f32 Make sure package names are URL encoded.
If you happen to have a weird package name like "/* blah *?" you
would get a nasty HTTP error when it tried to jam that in a URL.
Instead, this will give you a friendlier 'package "/* blah */" not found error."
BUG=http://code.google.com/p/dart/issues/detail?id=7466

Review URL: https://codereview.chromium.org//12328021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18849 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 18:59:48 +00:00
sgjesse@google.com 488b016a2f Merge IO v2 branch to bleeding edge
R=ager@google.com, ajohnsen@google.com, whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12316036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
rnystrom@google.com 8b37852e8a Use relative symlinks for self links and secondary "packages" dirs.
This lets you move a package directory without breaking all of those links.
BUG=http://code.google.com/p/dart/issues/detail?id=8342

Review URL: https://codereview.chromium.org//12321020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18785 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:17:16 +00:00
rnystrom@google.com e28a669679 Make some name validation errors warnings.
BUG=http://code.google.com/p/dart/issues/detail?id=8632

Review URL: https://codereview.chromium.org//12313014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18783 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:11:47 +00:00
nweiz@google.com d64b7d392a Use the correct set of reserved identifiers in pub validations.
We had been using the set listed in the spec as "BUILT_IN_IDENTIFIER", but
apparently those are the built-in identifiers that are valid for user use. Now
we're using the set listed in the spec as "reserved words".

BUG=8628

Review URL: https://codereview.chromium.org//12301032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18716 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:55:40 +00:00
rnystrom@google.com a1702c3578 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010


Review URL: https://codereview.chromium.org//12294039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18715 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:49:46 +00:00
rnystrom@google.com 5ed85458d1 Revert "Support relative paths in path dependencies."
This reverts commit 0b0da0d44dde213647e7281bf0914c59fc552b27.

BUG=

Review URL: https://codereview.chromium.org//12280019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18606 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 02:00:45 +00:00
rnystrom@google.com 8514e448b7 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18605 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 01:45:39 +00:00
rnystrom@google.com b12e27a4d2 Get rid of join() and encapsulate File and Directory in io.dart.
Review URL: https://codereview.chromium.org//12253054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18551 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:13:07 +00:00
rnystrom@google.com 10f7ad94ae Clean up some warnings and deprecated calls.
Review URL: https://codereview.chromium.org//12262056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18550 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:10:07 +00:00
rnystrom@google.com ba326cd770 Get rid of old redundant methods in io.dart.
Now that we have pkg/path, we can ditch the old methods in io.dart
that do the same thing.

Review URL: https://codereview.chromium.org//12255016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18500 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 01:14:31 +00:00
rnystrom@google.com 96697d6ecc Fix path tests on windows.
Review URL: https://codereview.chromium.org//12263018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18488 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 22:18:55 +00:00
rnystrom@google.com 76ec804170 Auto-reinstall broken packages in the system cache.
BUG=http://code.google.com/p/dart/issues/detail?id=5939

Review URL: https://codereview.chromium.org//12225149

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18480 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 21:11:12 +00:00
rnystrom@google.com bd0d874a53 Take Sam Elkhateeb's path for "path" dependencies and clean it up some.
BUG=http://code.google.com/p/dart/issues/detail?id=3732

Review URL: https://codereview.chromium.org//12208138

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18465 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 18:47:19 +00:00
whesse@google.com acd03abf83 dart:io: Use PathBuffer class for Directory.list on Windows platform.
BUG=https://code.google.com/p/dart/issues/detail?id=7505

Review URL: https://codereview.chromium.org//12252006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18448 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 15:00:55 +00:00
rnystrom@google.com 7c2e379f89 Add --force to pub lish.
BUG=http://code.google.com/p/dart/issues/detail?id=8487

Review URL: https://codereview.chromium.org//12217156

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18423 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 01:06:29 +00:00
rnystrom@google.com 1b15bef29f Mark oauth2 and pub_uploader as flaky. :(
Review URL: https://codereview.chromium.org//12251008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18416 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 23:46:56 +00:00
keertip@google.com ea861b9bdd add --preview flag to publish command
Review URL: https://codereview.chromium.org//12226077

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18397 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 19:52:01 +00:00
floitsch@google.com 3f7146707d Rework Timer interface.
Review URL: https://codereview.chromium.org//12213092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18326 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 19:22:16 +00:00
amouravski@google.com c6e2418c89 Added support for 'description' in pubspec.yaml.
Also standardized the way of validating a url.

Also, one test was working, but was not actually testing what it was supposed to be testing.

Review URL: https://codereview.chromium.org//12211097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18290 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-09 00:16:15 +00:00
pquitslund@google.com 90fd9e9c78 Call init test config for generating human-friendly test results.
Review URL: https://codereview.chromium.org//12218062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18234 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 22:11:34 +00:00
rnystrom@google.com 9f21b5324b Make createTempDir() synchronous.
Review URL: https://codereview.chromium.org//12225085

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18231 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 20:46:45 +00:00
rnystrom@google.com ec020bbd99 Handle circular dependencies on the root package when checking SDK constraints.
BUG=dartbug.com/8364

Review URL: https://codereview.chromium.org//12211061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18198 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 00:40:09 +00:00
rnystrom@google.com 12dd25f65b Drain HTTP request input streams before responding.
Review URL: https://codereview.chromium.org//12211052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18185 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 20:50:53 +00:00
rnystrom@google.com fcab5f5adb Fix hosted tests on Windows.
BUG=http://dartbug.com/8264

Review URL: https://codereview.chromium.org//12208006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18113 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 04:32:40 +00:00
rnystrom@google.com cf697141d9 Get most pub IO tests passing on Windows.
The remaining issue now is a hang in dart:io.

BUG=

Review URL: https://codereview.chromium.org//12211004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 04:18:34 +00:00
nweiz@google.com 193eac0d3c Un-mark {pub_{uploader,lish},oauth2}_test as flaky.
We need to see when these go red so they stop bit rotting.

Review URL: https://codereview.chromium.org//12195006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18105 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 01:09:57 +00:00
nweiz@google.com dbb72ee35d Get the pub oauth2 test passing locally.
Review URL: https://codereview.chromium.org//12191008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18103 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 00:57:25 +00:00
rnystrom@google.com 57c9b64975 Wait until file list is available before printing it.
Review URL: https://codereview.chromium.org//12193014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18081 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 22:18:08 +00:00
nweiz@google.com dfb2a2f23d Mark pub hosted tests as flaky on Windows.
BUG=8264

Review URL: https://codereview.chromium.org//12184019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18077 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 20:52:31 +00:00
rnystrom@google.com b6d5dc7f5a Make a bunch of stuff in pub synchronous.
Review URL: https://codereview.chromium.org//12079112

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18019 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-02 00:30:16 +00:00
nweiz@google.com 31c93eeceb Fix a few breakages with Pub's oauth2 test.
Review URL: https://codereview.chromium.org//12150006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18017 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-02 00:11:56 +00:00
rnystrom@google.com 4a9cc0f619 Validate packages against their SDK constraints.
After running pub install or update, it will look at all of the
selected packages and see if their SDK constraints match the
current SDK. If not, it will show a (hopefully) helpful error
message.
BUG=dartbug.com/6285

Review URL: https://codereview.chromium.org//12092080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18014 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 23:45:26 +00:00
nweiz@google.com 342e7a4c1a Don't mark the few passing hosted pub tests as failing.
Review URL: https://codereview.chromium.org//12082127

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18008 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 22:43:23 +00:00
nweiz@google.com 6565bb80ef Stop using cURL in Pub.
BUG=7395

Review URL: https://codereview.chromium.org//12090104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18007 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 22:35:33 +00:00
nweiz@google.com 6c3535dceb Fix the Pub status file.
Review URL: https://codereview.chromium.org//12149006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18006 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 21:55:44 +00:00
nweiz@google.com aac9fcda5a Mark pub hosted tests as failing.
Review URL: https://codereview.chromium.org//12082124

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17997 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 19:55:11 +00:00
nweiz@google.com 18d274df07 Use the dart:async Stream API thoroughly in Pub.
This was originally submitted as r17822, and rolled back in r17867. There are no
changes, but in preparation for the dart:io Stream changes we're applying this
with the intent to mark Windows tests as failing.

BUG=7807

Review URL: https://codereview.chromium.org//12086110

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17996 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 19:42:09 +00:00