Commit graph

12514 commits

Author SHA1 Message Date
gram@google.com
9b40e6b13e Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.
Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Review URL: https://codereview.chromium.org//12393017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19339 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:49:15 +00:00
ngeoffray@google.com
e83ac2ecf9 Now that we recognize "'undefined' is not an object" tests pass on safari.
Review URL: https://codereview.chromium.org//12381049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19338 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:41:35 +00:00
ngeoffray@google.com
9853a49a41 Fix safari error by matching the "undefined is not an object" TypeError to a NSME.
Review URL: https://codereview.chromium.org//12380072

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19337 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:23:35 +00:00
devoncarew@google.com
1600f30a14 Cleanup two warning messages when running apidoc, and update the apidoc.gyp file to rerun the tool
when any of its dart source changes.
Review URL: https://codereview.chromium.org//12388048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19336 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 20:01:03 +00:00
sigmund@google.com
5a1ee934cb pkg/unittest: Types, deprecations, docs
Add return types to a number of top-level members
deprecate callbackDone
guardAsync: added types, fixed documentation
- Shouldn't refer to private field in docs

Review URL: https://codereview.chromium.org//12381016
Patch from Kevin Moore <kevmoo@j832.com>.

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19335 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 18:49:35 +00:00
tball@google.com
ca8b23183b Added Socket::SetBlocking() and Socket::SetNonBlocking().
Review URL: https://codereview.chromium.org//12380032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19334 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 18:33:17 +00:00
antonm@google.com
5e96e05745 Support DateTime conversions.
R=ager@google.com,blois@google.com,podivilov@chromium.org
BUG=8836

Review URL: https://codereview.chromium.org//12378043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19333 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 18:23:58 +00:00
antonm@google.com
b3d61988af Implement necessary support.
R=ager@google.com,blois@google.com,podivilov@chromium.org

Review URL: https://codereview.chromium.org//12383053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19329 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 17:50:12 +00:00
blois@google.com
edb2b3c697 Revert "Revert "Converting dart:html to use DateTime rather than Date.""
Re-submitting change to use DateTime rather than Date.

I'm just disabling the new tests I added since they're failing on Dartium. Opened a bug tracking the Dartium and tests changes.

This means that dates are broken on Dartium, but they were broken everywhere before this change.

BUG=

Review URL: https://codereview.chromium.org//12330174

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19325 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 17:34:40 +00:00
ngeoffray@google.com
51a5d903ec Test fails on safari.
Review URL: https://codereview.chromium.org//12387042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19323 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 16:59:00 +00:00
vegorov@google.com
1fd357d38a CompileType::ToNullableCid must check whether type is implemented
This should be done in addition to checking whether type
has subclasses as subtyping relation is defined in terms of interfaces.

Otherwise type propagation infers that result of a mint
operation has a kIntegerCid because IntType has no subclasses.

It is only appropriate to not take subinterfaces into
account when inferring cid of the receiver.

No regression test included because currently it is not possible
to write one: fact that we inferred kIntegerCid for result
of mint operations is not observable and for other IR
instructions nullability prevents us from infering
anything but kDynamicCid.

R=kmillikin@google.com
BUG=

Review URL: https://codereview.chromium.org//12385044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19322 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 16:31:26 +00:00
whesse@google.com
360da64f5e dart:io | Add suppression for raw_secure_server_socket_intense_test on Windows.
BUG=dartbug.com/8798

Review URL: https://codereview.chromium.org//12379046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19320 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 16:30:32 +00:00
kasperl@google.com
823b384b6d Try to fix redness on the build by treating type masks on malformed types as not containing any types.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//12385047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19317 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 14:33:22 +00:00
ajohnsen@google.com
ba01a8ecfc Fix socket so we stop the consumer before we close the socket - this makes sure we socket-close future don't result in a socket write.
BUG=https://code.google.com/p/dart/issues/detail?id=8874

Review URL: https://codereview.chromium.org//12393010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19316 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 14:20:38 +00:00
ngeoffray@google.com
39504f19f7 Remove debugging code.
Review URL: https://codereview.chromium.org//12380061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19315 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 14:17:47 +00:00
kasperl@google.com
81ef254599 Get rid of HBoundedPotentialPrimitiveString.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//12381039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19314 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:56:28 +00:00
ngeoffray@google.com
ff6894c1e3 Fix csp failure and dartc failure.
Review URL: https://codereview.chromium.org//12374047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19313 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:56:24 +00:00
whesse@google.com
1b2e0aeeaf dart:io | Port secure_server_client_certificate_test to IO v2.
BUG=

Review URL: https://codereview.chromium.org//12383049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19312 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:47:18 +00:00
ajohnsen@google.com
b675e47aa0 Remane io_stream_consumer.dart to io_sink and move out all implementation from IOSink to _IOSinkImpl.
BUG=https://code.google.com/p/dart/issues/detail?id=8873

Review URL: https://codereview.chromium.org//12389050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19311 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:33:19 +00:00
ngeoffray@google.com
581bc6f0e4 Make instance methods whose names collide with intercepted methods have the interceptor calling convention (that is take the receiver as the first argument).
Review URL: https://codereview.chromium.org//12330135

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19310 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:28:14 +00:00
ngeoffray@google.com
0c10218886 Re-apply: Inside a generative constructor, "this" is created at the very end. So we have to use the type variables provided in the parameters.
Review URL: https://codereview.chromium.org//12389046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19309 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:18:10 +00:00
kasperl@google.com
db7d683bf4 Revert "Update FF status."
This reverts commit r19279.

TBR'ed.

R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//12391032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19308 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:13:51 +00:00
sgjesse@google.com
7b796611ad Update status file
TBR=ajohnsen@google.com

BUG=

Review URL: https://codereview.chromium.org//12389051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19307 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:11:04 +00:00
sgjesse@google.com
7aee440498 Enable most dart:io tests on Windows
The recent flaky logs show no failures.

R=ajohnsen@google.com

BUG=numerous

Review URL: https://codereview.chromium.org//12387040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19306 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:48:26 +00:00
kasperl@google.com
1c2dac901e Fix --host-checked mode and add proper canBePrimitive method to HBoundedType.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//12389049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19305 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:46:15 +00:00
ager@google.com
496f6edec3 Fix type warnings and remove unimplemented stuff from HttpClient interface.
R=whesse@google.com,sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//12380059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19304 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:34:45 +00:00
sgjesse@google.com
9021945997 Improve support for HTTP 1.0 clients
Fixed a number of issues related to HTTP 1.0 clients.

Added more HTTP 1.0 tests.

R=ajohnsen@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8866

Review URL: https://codereview.chromium.org//12383048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19303 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:34:27 +00:00
ager@google.com
7b5e766190 Add missing certificate getter on HttpClientResponse and add a regression test.
Also cleaned up some internal type annotations to avoid type warnings.

R=whesse@google.com,sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//12378040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19302 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:32:49 +00:00
ajohnsen@google.com
5a6f4f68f3 When the socket is closed, we can end up trying to send a close packet, before we get the async 'socket closed' event.
BUG=https://code.google.com/p/dart/issues/detail?id=8824

Review URL: https://codereview.chromium.org//12393005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19301 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:31:13 +00:00
kasperl@google.com
5681773c19 Remove HBoundedPotentialPrimitiveArray type.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//12380058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19300 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:30:39 +00:00
ajohnsen@google.com
9a01a09e4c Don't close the server until we have received the error.
This avoids a scenerio where server.close would destroy the socket before we would receive the error, if the validator stream is paused from the socket.

BUG=https://code.google.com/p/dart/issues/detail?id=8865

Review URL: https://codereview.chromium.org//12385041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19299 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:29:12 +00:00
whesse@google.com
ea9b57d9ff dart:io | Skip raw_secure_server_socket_intense_test on macos, due to limit on number of open sockets on Mac.
BUG=

Review URL: https://codereview.chromium.org//12389048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19298 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:23:15 +00:00
floitsch@google.com
9722e27876 Remove deprecated IllegalJSRegExpException class.
Review URL: https://codereview.chromium.org//12317130

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19297 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 12:14:45 +00:00
whesse@google.com
100ac91618 dart:io | Remove web_socket_no_secure_test, since issue 7157 is fixed.
BUG=

Review URL: https://codereview.chromium.org//12393006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19296 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 11:59:46 +00:00
whesse@google.com
aef6498465 dart:io | Add new test to try and reproduce issue 8798.
BUG=dartbug.com/8798
TEST=standalone/io/raw_secure_server_socket_intense_test

Review URL: https://codereview.chromium.org//12389047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19295 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 11:59:19 +00:00
ajohnsen@google.com
acbc829a06 Add test for setting content-length through 'headers.set'.
BUG=https://code.google.com/p/dart/issues/detail?id=5666

Review URL: https://codereview.chromium.org//12377044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19294 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 11:34:37 +00:00
kustermann@google.com
6109ccf605 Quote all arguments when printing test.py command
Review URL: https://codereview.chromium.org//12386047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19293 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 11:31:41 +00:00
karlklose@google.com
cfc26e6310 Check if the element is a typedef and add a comment.
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//12387039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19292 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 11:31:31 +00:00
kustermann@google.com
c7857e7c0b Quote all arguments when printing a Command
Review URL: https://codereview.chromium.org//12379041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19291 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 10:33:59 +00:00
ricow@google.com
fe7e6586ea Revert revision 19289
Review URL: https://codereview.chromium.org//12391030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19290 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 10:06:12 +00:00
ricow@google.com
923a9e72d9 Build the Editor from GYP/build.py.
The Editor is only rebuilt if it changes, not if the SDK changes.
Review URL: https://codereview.chromium.org//12090092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19289 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 10:02:39 +00:00
karlklose@google.com
8fe2fcc39e Check if enclosingElement is null.
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//12393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19287 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:47:32 +00:00
karlklose@google.com
367b526cd5 Do not register typechecks against type variables of typedefs.
Review URL: https://codereview.chromium.org//12389025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19286 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:09:33 +00:00
ricow@google.com
85b572e7d7 Mark flaky pub tests
Review URL: https://codereview.chromium.org//12377042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19284 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:08:20 +00:00
ngeoffray@google.com
5dc05a1ddb Revert revision 19282. Some tests fail.
Review URL: https://codereview.chromium.org//12388043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19283 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:05:41 +00:00
fschneider@google.com
7ea9189805 Fix null-termination bug in Stacktrace::ToCString.
Under certain conditions Stacktrace::ToCString can return
a not null-terminated string.

This is the case when ToCStringInternal is invoked with a stacktrace
of length 0.

BUG=dart:8850
TEST=tests/language/stacktrace_test.dart
Review URL: https://codereview.chromium.org//12387019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19282 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:03:45 +00:00
ngeoffray@google.com
ae33319464 Inside a generative constructor, this is created at the very end. So we have to use the type variables provided in the parameters.
Review URL: https://codereview.chromium.org//12379012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19281 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 08:52:22 +00:00
kasperl@google.com
4fba6e2b43 Mark --disallow-unsafe-eval as a supported feature in usage description.
R=ahe@google.com
BUG=

Review URL: https://codereview.chromium.org//12378038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19280 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 08:40:14 +00:00
kasperl@google.com
fc7f63ec54 Update FF status.
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//12377041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19279 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 08:39:09 +00:00
sgjesse@google.com
474fd10deb Update status file
Remove flaky marker for test io/http_content_length_test on Windows to
get the actual error message in the log file

TBR=ajohnsen@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8865

Review URL: https://codereview.chromium.org//12390030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19278 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 08:19:07 +00:00