Commit graph

41596 commits

Author SHA1 Message Date
John Messerly aa85651820 fix #27403, use AST summaries in DDC
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2353133004 .
2016-09-20 17:55:09 -07:00
Matthias Hausner 7e82552124 Make local var assignments debuggable in checked mode
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2352993003 .
2016-09-20 17:31:22 -07:00
Stephen Adams 3d9bbdaa9a dart2js load elimination: Look through refinements for locations
We have to look through the refinements (via .nonCheck()) for locations in order to avoid mistaking two different refinements for two separate locations.

R=het@google.com

Review URL: https://codereview.chromium.org/1459273002 .
2016-09-20 16:12:55 -07:00
James Robinson 8a53ba91de Stop using deprecated (names of) magenta syscalls.
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/2355953004 .
2016-09-20 15:55:51 -07:00
Vijay Menon e825d6d63e Update ddc pubspec.yaml
Fixing build ... should we be doing something differently?  E.g., not check in the lock file?

TBR=jmesserly@google.com,rnystrom@google.com

Review URL: https://codereview.chromium.org/2353193002 .
2016-09-20 15:08:05 -07:00
Matthias Hausner 631a48600b Fix debug break on assignment to global variable
Make sure a debug break is also inserted in checked mode.

BUG=#27287

Review URL: https://codereview.chromium.org/2351373002 .
2016-09-20 14:57:05 -07:00
Ryan Macnak fb127ddf4a Standalone: Add missing tree-shaker root.
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2356953002 .
2016-09-20 14:44:05 -07:00
Matthias Hausner 0dd760092d Add debugger safe point on assignment to global variables
Just like we do for local variables, add a debug step check (and
thus a breakpoint location) to global variable assignment if
the right side of the assignment has no possible breakpoint locations.

BUG=#27287
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2354773002 .
2016-09-20 14:05:45 -07:00
Konstantin Shcheglov ff22a0fe89 Fix 'new KnownClass.unresolvedConstructor()' type computation.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2356843002 .
2016-09-20 14:00:51 -07:00
Paul Berry 36a0807331 Test summary resynthesis of unresolved annotations.
Unresolved annotations were being summarized properly, but this was
untested, and testing them required some bug fixes to the test
infrastructure (mostly due to quirks introduced by dartbug.com/25706).

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2357513004 .
2016-09-20 13:43:41 -07:00
Regis Crelier b91d74172a Make sure unresolved function type parameter bounds do not end up in snapshot.
Read and write parent_level field of function type parameters in snapshots.
Update TypeParameter::ToCString() to handle function type parameters.
Address Siva's comments in previous cl.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2359543003 .
2016-09-20 13:18:01 -07:00
William Hesse d07d1148d2 Roll Dartium browser deps
This removes the package_build step, which has been removed from dart.  There is no longer a package root built, but a checked-in package spec.

BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2353133002 .
2016-09-20 21:54:24 +02:00
Ryan Macnak 8610536da7 Misc Observatory tweaks.
- Fix profiler mode descriptions.
 - Add count for ports and class hierarchy.
 - Group 'heap snapshot' and 'heap map' together.

R=johnmccutchan@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org/2359553002 .
2016-09-20 12:44:36 -07:00
Konstantin Shcheglov 1401a38d59 We do and test only AST based summaries.
There are 3 tests failing.

According to the Spec 'void' and 'dynamic' cannot be prefixes.
"It is a compile-time error if a built-in identifier is used as the declared name of a prefix, class, type parameter or type alias."
So, most probably these tests should be changed to test that the prefix is null.

I will look into "fail_invalid_prefix_type_parameter" in a separate CL.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2353993002 .
2016-09-20 10:48:56 -07:00
Harry Terkelsen 636084afa2 kernel->ssa: implement top-level getters and setters
See https://github.com/dart-lang/sdk/issues/27394

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2353793002 .
2016-09-20 10:18:08 -07:00
Paul Berry 2839653161 Fix generation of analysis results in analyzer_cli "build mode".
This was inadvertently broken in 1b10de1a86.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2350963005 .
2016-09-20 10:07:11 -07:00
John Messerly 8c25a41acc ignore dynamic when doing inference
R=leafp@google.com

Review URL: https://codereview.chromium.org/2343863004 .
2016-09-20 09:59:08 -07:00
Zachary Anderson 43231d9ff4 Pull boringssl generated source from boringssl_gen
Dart and Flutter engine both need to have the code generated for
boringssl under //third_party/boringssl. To avoid having two
copies of this code, this CL removes it from the Dart repo and
instead pulls it from a github repo that Flutter engine can
share.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2354623003 .
2016-09-20 08:46:44 -07:00
Brian Wilkerson c369a8449e More clean-up in server
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2350143004 .
2016-09-20 08:39:43 -07:00
Konstantin Shcheglov 3355612e13 We don't compute propagated types of non-local variables.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2351623005 .
2016-09-20 08:37:29 -07:00
Brian Wilkerson 3c865fa6b5 Remove use of shared messages
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2346803005 .
2016-09-20 08:25:55 -07:00
Brian Wilkerson d0245ea2b9 Finish removing MethodTrampoline
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2356653003 .
2016-09-20 08:20:56 -07:00
William Hesse 80572c4038 Update status for browser tests
BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2358583002 .
2016-09-20 16:36:01 +02:00
William Hesse 0695b1db3a Remove package root target and support scripts
BUG=https://github.com/dart-lang/sdk/issues/23565
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2346163005 .
2016-09-20 13:32:50 +02:00
William Hesse 3bdc62bfe3 Add package_resolver to dartium DEPS, update both DEPS files.
BUG=https://github.com/dart-lang/sdk/issues/21949
BUG=https://github.com/dart-lang/sdk/issues/27065
R=eernst@google.com

Review URL: https://codereview.chromium.org/2354863002 .
2016-09-20 11:54:37 +02:00
Konstantin Shcheglov d13a887292 Remove 'serializeLibrary(LibraryElement)' and its tests.
Switch PrelinkerTest to AST based unlinked summaries.

The *_common.dart files in tests might be not actually 'common', and
we could pull them into corresponding only subclasses.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2353773002 .
2016-09-19 20:28:46 -07:00
Florian Schneider cd05ee0c81 VM: Fix canonicalization of old-space allocated instances
Instances of objects allocated in old-space would not get canonicalized properly,
resulting in duplicates of these instances on the heap.

This can be e.g. argument descriptors allocated in the background compiler thread.

This also fixes the same issue occurring with isolate reload.

Also, add a NoSafepointScope for consistency.

BUG=#27364
R=asiva@google.com

Review URL: https://codereview.chromium.org/2351613005 .
2016-09-19 17:27:05 -07:00
John McCutchan d78cbce63d Fix Observatory recompiles on fresh build
- [x] GYPI: Remove buggy dependency on the sdk's packages.stamp which shouldn't have been a dependency in the first place.
- [x] GN: Switch output names to match new non-polymer based build

BUG=

Review URL: https://codereview.chromium.org/2351933002 .
2016-09-19 16:41:42 -07:00
John McCutchan 500f4e4e7d Fix VM test Service_IsolateStickyError
BUG=

Review URL: https://codereview.chromium.org/2356613002 .
2016-09-19 15:26:25 -07:00
Regis Crelier 11562f6874 Support generic method syntax (fixes #25869).
Function type parameters are parsed and resolved, but mapped to malformed types
(i.e. dynamic) until full support is implemented.

R=hausner@google.com

Review URL: https://codereview.chromium.org/2349593003 .
2016-09-19 15:17:33 -07:00
Konstantin Shcheglov 979a9bd6da Remove incremental session from analyzer_cli.
This should have been done together with 1310dc801a.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2348283004 .
2016-09-19 15:06:03 -07:00
Jacob Richman bad7f76374 Fix crashes due to attempts to create an identifier name containing the word <bottom>. Likely there is a better fix but this appears to work for now.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2354603003 .
2016-09-19 14:52:12 -07:00
Konstantin Shcheglov 1310dc801a Remove incremental analysis cache.
It could cache more than what we cache currently with pub summaries.
But pub and internal summaries seem to be a good level of granularity.

This also makes one user less for element based summarizer.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2353693002 .
2016-09-19 14:17:30 -07:00
Ryan Macnak 7432d20eaa Fix IsCompiletimeErrorObject for precompiled.
R=hausner@google.com

Review URL: https://codereview.chromium.org/2350973002 .
2016-09-19 14:11:29 -07:00
Konstantin Shcheglov 1387e8ec5c Remove fallback mode and corresponding cli flag.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2356523002 .
2016-09-19 14:02:14 -07:00
Konstantin Shcheglov 1b10de1a86 Generate only AST based summaries in build mode.
Should we also remove fallback mode?

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2355613003 .
2016-09-19 13:47:38 -07:00
John McCutchan 632c76942c Add Dart_GetStickyError
- [x] Add Dart_GetStickyError.
- [x] Change Dart_SetStickyError to allow for null and also not set the pause on exit bit.

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org/2350633003 .
2016-09-19 13:31:09 -07:00
Ryan Macnak 38a68ec544 Update status file for tests newly dependent on dart:mirrors.
Remove skip of removed tests.

TBR=whesse@google.com

Review URL: https://codereview.chromium.org/2350173004 .
2016-09-19 13:21:06 -07:00
Konstantin Shcheglov 8010f3ac99 Use MockSdk.getLinkedBundle(), and implement it using SummaryBuilder.
This is a step to removing generating summaries from elements,
as we decided last week.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2352573003 .
2016-09-19 12:58:36 -07:00
Paul Berry f7a12f9c83 Allow input summaries to be specified when running analyzer_cli in non-build mode.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2347133004 .
2016-09-19 12:39:24 -07:00
Konstantin Shcheglov 2fa34661d4 Generate SDK summaries using ASTs.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2351863002 .
2016-09-19 12:20:36 -07:00
Konstantin Shcheglov dd5a6c2265 Issue 27390. Visit 'ExecutableElement.typeParameters'.
Otherwise incremental updaters fail to update type parameters' offsets,
which causes failures later in DeclarationResolver when apply elements
to re-created AST.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27390

Review URL: https://codereview.chromium.org/2355543002 .
2016-09-19 12:17:27 -07:00
Paul Berry e77187ff6d Fix pkg/analyzer/tool/task_dependency_graph/check_test.
This was broken by the move to ".packages" files.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2351833002 .
2016-09-19 12:07:54 -07:00
William Hesse 66b5248bf9 standalone/addlatexhash test is passing, update status
TBR=eernst@google.com
BUG=

Review URL: https://codereview.chromium.org/2353583002 .
2016-09-19 19:10:31 +02:00
John Messerly 865e808f15 support @virtual fields, fix #27384
R=leafp@google.com

Review URL: https://codereview.chromium.org/2352433002 .
2016-09-19 09:45:24 -07:00
William Hesse 88a64b77bf Add support for package spec to testing HttpServer.
BUG=https://github.com/dart-lang/sdk/issues/27065
R=terry@google.com

Review URL: https://codereview.chromium.org/2347423003 .
2016-09-19 18:43:16 +02:00
Brian Wilkerson 57f1193c01 First steps toward removing MethodTrampoline
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2348353002 .
2016-09-19 08:24:29 -07:00
John McCutchan 699e328105 Fix VM connect element test
BUG=

Review URL: https://codereview.chromium.org/2348313002 .
2016-09-19 07:33:44 -07:00
Johnni Winther e24939f8d6 Handle generic factory constructors in kernel_impact
R=het@google.com

Review URL: https://codereview.chromium.org/2341263002 .
2016-09-19 11:35:56 +02:00
William Hesse 9f3b5d8680 Update observatory_tool.py to remove package-root
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2346483007 .
2016-09-19 10:11:31 +02:00