languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 21:31:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make local var assignments debuggable in checked mode

Browse source 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2352993003 .
This commit is contained in:
Matthias Hausner 2016-09-20 17:31:22 -07:00
parent 3d9bbdaa9a
commit 7e82552124
1 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
runtime/vm/flow_graph_builder.cc
View file

@ -3586,10 +3586,14 @@ void EffectGraphVisitor::VisitStoreLocalNode(StoreLocalNode* node) {
// call. Exception: don't do this when assigning to or from internal
// variables, or for generated code that has no source position.
if (FLAG_support_debugger) {
if ((node->value()->IsLiteralNode() ||
(node->value()->IsLoadLocalNode() &&
!node->value()->AsLoadLocalNode()->local().IsInternal()) ||
node->value()->IsClosureNode()) &&
AstNode* rhs = node->value();
if (rhs->IsAssignableNode()) {
rhs = rhs->AsAssignableNode()->expr();
}
if ((rhs->IsLiteralNode() ||
(rhs->IsLoadLocalNode() &&
!rhs->AsLoadLocalNode()->local().IsInternal()) ||
rhs->IsClosureNode()) &&
!node->local().IsInternal() &&
node->token_pos().IsDebugPause()) {
AddInstruction(new(Z) DebugStepCheckInstr(
@ -3708,13 +3712,13 @@ Definition* EffectGraphVisitor::BuildStoreStaticField(
// If the right hand side is an expression that does not contain
// a safe point for the debugger to stop, add an explicit stub
// call.
AstNode* val = node->value();
if (val->IsAssignableNode()) {
val = val->AsAssignableNode()->expr();
AstNode* rhs = node->value();
if (rhs->IsAssignableNode()) {
rhs = rhs->AsAssignableNode()->expr();
}
if ((val->IsLiteralNode() ||
val->IsLoadLocalNode() ||
val->IsClosureNode()) &&
if ((rhs->IsLiteralNode() ||
rhs->IsLoadLocalNode() ||
rhs->IsClosureNode()) &&
node->token_pos().IsDebugPause()) {
AddInstruction(new(Z) DebugStepCheckInstr(
node->token_pos(), RawPcDescriptors::kRuntimeCall));