languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity
41596 commits 11 branches 6011 tags 1.4 GiB
Commit graph

41596 commits

This branch
This branch
All branches
Author SHA1 Message Date
Konstantin Shcheglov
92ee0b2488 Fix for the new hint in super_mixin_example.dart in analyzer_cli. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2364763002 .
 2016-09-22 15:03:06 -07:00
Ryan Macnak
b80dedeb27 AOT: When expanding the cid range of a single target call, only check the new portion of the range. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2367533002 .
 2016-09-22 14:30:29 -07:00
Konstantin Shcheglov
77ba5fd087 Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. 
There are no positives in analyzer/server, dev_compiler or dart2js.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27300

Review URL: https://codereview.chromium.org/2364733002 .
 2016-09-22 14:27:47 -07:00
Matthias Hausner
74e779d4fe Fix stepping over await statements 
When async-stepping over an await statement that follows a previous
async-step command, ensure that the synthetic breakpoint at the
beginning of the async closure is not accidentally deleted.

Removing a test that depends on minute details of the internal
implementation of async-step commands.

Adding new test that checks for multiple consecutive async-step
commands.

Note that debugger.cc seems to contain a memory leak. Breakpoint
objects are not deleted (deallocated) when RemoveBreakpoint()
is called. Will address this in a separate CL.

BUG=#27238
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2366463002 .
 2016-09-22 14:06:24 -07:00
Brian Wilkerson
fd7bb76a4b Add some errors related to nnbd 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2362873002 .
 2016-09-22 13:43:37 -07:00
John McCutchan
decac71b70 Address Siva's DBCs on https://codereview.chromium.org/2350633003/ 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2359283002 .
 2016-09-22 13:27:50 -07:00
Ryan Macnak
326af5e9d7 Move Zone's destructor out of a header file. 
This unburdens users of StackZone from needing to include handles_impl.h. A new use of StackZone was recently added to heap.cc without a include of handles_impl.h, and this caused link-time errors on some versions of gcc.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2362573002 .
 2016-09-22 13:16:36 -07:00
Konstantin Shcheglov
65d2a2ce82 Issue 27392. Fix for invoking objects with function-bounds type parameter types. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27392

Review URL: https://codereview.chromium.org/2360303003 .
 2016-09-22 11:50:24 -07:00
Stephen Adams
5cafe42577 Use indexing for type variable access when the receiver type constrains the substitution(s) 
Often we are accessing Iterable.E from a precisely known class.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2352913003 .
 2016-09-22 11:32:26 -07:00
Stephen Adams
127b419fc1 Add WhereIterable.map 
This makes some nice code improvements for dart2js. dart2js can't
inline the MappedIterable factory constructor and specialize by
optimization, so specializing by hand removes the test "is
EfficientLength" for code like "x.where(f).map(g)".

R=lrn@google.com

Review URL: https://codereview.chromium.org/2354093002 .
 2016-09-22 10:36:16 -07:00
Brian Wilkerson
74686371b3 Add support for getting the sessionId from instrumentation and sending it to the client 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2359233002 .
 2016-09-22 10:26:13 -07:00
Konstantin Shcheglov
1e744f3dc2 Skip dev_compiler/gen while testing analyzer. 
There are about 400 failures in them.

R=brianwilkerson@google.com, jmesserly@google.com
BUG=

Review URL: https://codereview.chromium.org/2358393003 .
 2016-09-22 10:19:03 -07:00
Konstantin Shcheglov
5703f5adb1 Replace using reprecated 'package:analyzer/src/generated/error.dart'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2364643002 .
 2016-09-22 10:10:53 -07:00
Konstantin Shcheglov
163931ffdd Fix couple hints. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2362753002 .
 2016-09-22 09:59:40 -07:00
Stephen Adams
3291ecfbc9 Add another test for initializing dispatchPropertyName that runs outside the browser 
R=johnniwinther@google.com

BUG=

Review URL: https://codereview.chromium.org/2359023002 .
 2016-09-22 09:45:19 -07:00
William Hesse
8dc3811050 Check in runtime/observatory/.packages 
We won't remove it from the .gitignore file until we remove the
build steps that overwrite it.

BUG=https://github.com/dart-lang/sdk/issues/27412

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2359213002 .
 2016-09-22 18:38:20 +02:00
William Hesse
92cd3e10f5 Fix test.py and tests to use an explicit --packages flag. 
BUG=https://github.com/dart-lang/sdk/issues/27412
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2361813003 .
 2016-09-22 17:51:09 +02:00
Johnni Winther
7a570f1b80 Roll kernel to latest and add baseline test. 
The added visitor_test tests that the IR generated by the KernelVisitor
in dart2js matches the spec-mode IR.

R=asgerf@google.com, het@google.com

Review URL: https://codereview.chromium.org/2360603002 .
 2016-09-22 10:16:11 +02:00
Zachary Anderson
94c96ac42c Added a target for a host version of the dart executable. 
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2351743004 .
 2016-09-21 19:05:06 -07:00
Konstantin Shcheglov
5a668422ff Fix for test of linking with unused type parameter. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2354383002 .
 2016-09-21 18:04:34 -07:00
Vijay Menon
aae63b7e21 Regenerate DDC SDK 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2358323002 .
 2016-09-21 16:39:24 -07:00
Harry Terkelsen
3a01cbd31c kernel->ssa: Implement for-loops and while-loops 
This involved splitting out the loop handling logic from the
original SSA builder and sharing it with the kernel builder.
This was just the easiest way to do this for now, but in the future
we should write the loop handler for kernel to take into account
the simplified structure that kernel provides.

R=sra@google.com

Review URL: https://codereview.chromium.org/2360673003 .
 2016-09-21 16:38:10 -07:00
John Messerly
738b481052 fix #27411, avoid capture for instance creation 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2363503003 .
 2016-09-21 16:19:36 -07:00
Vijay Menon
a22b3b6205 Runtime fixes on DDC tests 
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2354383003 .
 2016-09-21 16:12:30 -07:00
Stephen Adams
160238d0af Fix type in dart2js_native/foreign_test.dart 
R=het@google.com
BUG=

Review URL: https://codereview.chromium.org/2364463002 .
 2016-09-21 15:53:08 -07:00
Stephen Adams
8aba13e471 Add test for initialization of the native interceptor dispatch property. 
R=het@google.com

Review URL: https://codereview.chromium.org/2360093002 .
 2016-09-21 15:14:07 -07:00
Vijay Menon
8e943b8c59 Fix tests 
This fixed the original 5 static errors from this morning.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2356413002 .
 2016-09-21 13:59:55 -07:00
Konstantin Shcheglov
3325004461 Include referenced declared variables and their values into the linked bundle hash. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2358213002 .
 2016-09-21 13:34:58 -07:00
Konstantin Shcheglov
e0150c45b1 Fix 'compareTypeParameterElements' to use TypeParameterElement, not Impl. 
TBR

This fixes the problem exposed by 5eea83396e.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2359953002 .
 2016-09-21 11:27:41 -07:00
Paul Berry
dac96d0584 Add SyntacticEntity, an interface shared by AstNode and Token. 
This allows types to be tightened up for AstNode.childEntities.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2357803002 .
 2016-09-21 11:23:46 -07:00
Harry Terkelsen
b114cfc724 kernel->ssa: support string concatenations/interpolations 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2357513005 .
 2016-09-21 10:42:46 -07:00
Stephen Adams
2a1ae8a3ce Revert "Move towards using WorldImpact for codegen" 
-36% on DromeaoDRT Benchmark?benchmark=dom-query-getElementsByTagName(div)

TBR=johnniwinther@google.com
BUG=

Review URL: https://codereview.chromium.org/2359923002 .
 2016-09-21 10:41:16 -07:00
Konstantin Shcheglov
5eea83396e Fix for out of scope type parameters in members. 
...by always using the substituted type in members.

This might increase memory usage. However members are mosly used in
method bodies, and we now aggressively flush resolved ASTs from cache.

I don't see any noticeable increase on analyzer + analysis_server code.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2351133004 .
 2016-09-21 10:19:26 -07:00
William Hesse
c0a714552a Add dartium buildbot step to clear temp directory on Windows 
BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=645681
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2355383002 .
 2016-09-21 19:08:07 +02:00
William Hesse
1c413993d9 Roll pub in DEPS to pick up test status change 
Does not roll dartium DEPS because it and other packages are at
much earlier versions.
Dartium DEPS should be updated all at once, in a different CL

BUG=https://github.com/dart-lang/pub/issues/1446
TBR=rnystrom@google.com

Review URL: https://codereview.chromium.org/2358083002 .
 2016-09-21 19:07:42 +02:00
Konstantin Shcheglov
e82cbea8fe Issue 27386. Fix for 'use similar' Quick Fix for import-prefixed identifiers. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27386

Review URL: https://codereview.chromium.org/2361483002 .
 2016-09-21 10:02:20 -07:00
Brian Wilkerson
454289dbe3 (TBR) Fix test failure 
Review URL: https://codereview.chromium.org/2357303002 .
 2016-09-21 09:10:40 -07:00
Konstantin Shcheglov
bdc024a303 Move PackageIndexAssembler into analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2357283002 .
 2016-09-21 08:54:46 -07:00
Brian Wilkerson
d947a7ba89 Async is no longer optional 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2361433002 .
 2016-09-21 08:29:34 -07:00
Brian Wilkerson
6062d5d6bd Fix mustCallSuper to ignore methods from interfaces 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2348383006 .
 2016-09-21 08:03:09 -07:00
Brian Wilkerson
2d9e690e6c Fix newly introduced errors and warnings 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2357553003 .
 2016-09-21 08:01:04 -07:00
William Hesse
92bfd566e5 Roll dartium's blink with layout test expectation changes. 
BUG=https://github.com/dart-lang/sdk/issues/19433
TBR=terry@google.com

Review URL: https://codereview.chromium.org/2356173002 .
 2016-09-21 13:44:55 +02:00
Johnni Winther
0a79576ed0 Move towards using WorldImpact for codegen 
CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.

R=het@google.com

Review URL: https://codereview.chromium.org/2349163003 .
 2016-09-21 12:31:38 +02:00
Johnni Winther
aafbaf15c3 Undo dartfmt in multitest. 
Review URL: https://codereview.chromium.org/2352343002 .
 2016-09-21 11:49:47 +02:00
Johnni Winther
ca3c2882ae Introduce OpenWorld. 
R=het@google.com

Review URL: https://codereview.chromium.org/2320583002 .
 2016-09-21 11:48:10 +02:00
Johnni Winther
012229ec83 Split Universe into ResolutionUniverse and CodegenUniverse 
Main changes in universe.dart

R=het@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2318593003 .
 2016-09-21 11:24:26 +02:00
Johnni Winther
b7d424f6fd Handle local functions in kernel_impact. 
R=het@google.com

Review URL: https://codereview.chromium.org/2359453002 .
 2016-09-21 11:18:03 +02:00
Johnni Winther
614cde5b1c Split World usage into open, inference, and closed world. 
This is a step towards separating the backend element model from the frontend model.

Main changes in world.dart.

R=het@google.com

Review URL: https://codereview.chromium.org/2314703002 .
 2016-09-21 10:54:34 +02:00
Johnni Winther
7ea9f8b8bc Handle string interpolation/juxtaposition in kernel_impact. 
R=het@google.com

Review URL: https://codereview.chromium.org/2357433003 .
 2016-09-21 10:44:57 +02:00
Zachary Anderson
2873e87a6e Roll boringssl_gen for small fixes 
This pulls in small fixes that are only needed for the standalone GN
build.

Review URL: https://codereview.chromium.org/2357043002 .
 2016-09-20 19:44:07 -07:00