languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 08:07:11 +00:00
Code Issues Projects Releases Packages Wiki Activity
87637 commits 11 branches 6011 tags 1.4 GiB
Commit graph

87637 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jens Johansen
97cdb043da [parser] Parse record type return type for operators 
Change-Id: I23b5ef38a9bfd58c327303198e59d9b50ace323b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262681
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-07 08:59:39 +00:00
Jens Johansen
575ae24207 [parser] Parse record type question after modifier 
Change-Id: If2dd018a79719bd0f5a9a44f46fb102c3595d08e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261644
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-07 08:52:04 +00:00
Sergey G. Grekhov
6524b31967 [co19] Roll co19_2 to 17f2b4079f55bb5beb8f8301970089c290590ae4 
2022-10-04 sgrekhov22@gmail.com Fixes dart-lang/co19#1483. Removed static analysis warnings for different parameter override value (dart-lang/co19#1484)
2022-10-03 sgrekhov22@gmail.com dart-lang/co19#195. Don't use nnbd syntax in pre-nnbd tests (dart-lang/co19#1482)

Change-Id: I1dd7734649dc545cc92e5c3edb000466cb211082
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263100
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2022-10-07 08:23:04 +00:00
Jens Johansen
af2f4e2d29 [parser] Parse record type used in optional and named parameters 
Fixes https://github.com/dart-lang/sdk/issues/50136

Change-Id: If02c0d86244ef9cd3685256e583b987d438307d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-10-07 06:39:08 +00:00
Jens Johansen
eb80f37103 [parser] Parse record type in for in 
Change-Id: I96773ecf597685bd6cdfe7da9971b42aea1488e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262940
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-07 06:37:42 +00:00
Jackson Gardner
47dd60fed0 Refactor run_wasm.js into an ESM module that is reusable in the browser. 
Change-Id: I1566febad2b4e1399f50bb923ad0596f04aa1a40
Cq-Include-Trybots: luci.dart.try:dart2wasm-linux-x64-d8-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262268
Reviewed-by: Joshua Litt <joshualitt@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Jackson Gardner <jacksongardner@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-10-07 03:09:39 +00:00
Konstantin Shcheglov
5ef329cf74 Report CompileTimeErrorCode.DUPLICATE_VARIABLE_PATTERN 
Change-Id: I07cb697c9c517f0d4eb67100f0ae134aa821d25d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263002
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-07 00:16:27 +00:00
Nate Bosch
79b66e79ba Mention tools/manage_deps in DEPS file 
Improve discoverability of the tool, since it's an easier way to change
DEPS and it automates a useful CL description.

Change-Id: I0402126d11764bb56f9cef0cb2ec6fd54378b1e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262848
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2022-10-07 00:04:56 +00:00
Nate Biggs
1e6aa3fcbe [dart2js] Migrate inferrer/types.dart to null safety. 
Change-Id: I39774c2a0875be6519c8bc95808a0fc76a27421b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263060
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2022-10-06 22:58:48 +00:00
Devon Carew
0c7df00e5a [deps] rev convert, dartdoc, markdown, and webkit_inspection_protocol 
convert (11d191e..f0acc6b):
  f0acc6b  2022-10-06  Devon Carew  update the CI configuration (#67)

dartdoc (9908cf8..c2f66ec):
  c2f66ecf  2022-10-06  dependabot[bot]  Bump ossf/scorecard-action from 2.0.3 to 2.0.4 (#3205)
  479f27ba  2022-10-06  Sam Rawlins  Deprecate src/model/model.dart as public API (#3208)

markdown (e7915ed..f387340):
  f387340  2022-10-06  Zhiguang Chen  Fix unicode case folding (#465)

webkit_inspection_protocol (4e5eb8d..b825c8f):
  b825c8f  2022-10-05  Devon Carew  Ci updates (#93)

Change-Id: Ia68ad07c0046603ea17485db7ddb9744cfa970e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263043
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
 2022-10-06 22:11:58 +00:00
Ahmed Ashour
a1eec6be31 [analysis_server] RemoveLeadingUnderscore to handle conflicting names 
Fixes #50142

Change-Id: I68c225e0528c643a29f2454607464d3896f25d36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262606
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-06 19:29:24 +00:00
Ryan Macnak
5b119191a5 [test] Add missing architectures when skipping tests using FFI on simulators. 
Bug: https://github.com/dart-lang/sdk/issues/37299
Change-Id: If4553d20ca13bdc3191cad19a987c875c1c88d73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262849
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2022-10-06 19:24:08 +00:00
Ryan Macnak
904c6fd6fa [vm] Add Dart_NotifyDetach. 
TEST=ci
Change-Id: I86776f93f5b1aedb205a62822a25d7a4697f73cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262520
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2022-10-06 19:00:37 +00:00
Kallen Tu
b3e57bd2f7 Remove dynamic call in _JsonMap. 
Change-Id: I73297a65a59aeefee9f170aa640b9d5d20e7bf9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262271
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2022-10-06 18:12:02 +00:00
Konstantin Shcheglov
e664ee9bb7 Test for resolving empty record literals. 
Change-Id: I776a8ccb30e7b83cae79f7d6975ea8932a9363c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263001
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-06 17:41:32 +00:00
Konstantin Shcheglov
975f25ba39 Account for class Record in constraint gathering. 
Change-Id: Iae20d430dec385dd42cd37617c2abebf7b841087
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263000
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-10-06 17:40:37 +00:00
Konstantin Shcheglov
57a619bcb7 Report diagnostics for relational patterns. 
Change-Id: I1a3e02e36679599e0240f74108a5e91db6269b1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-10-06 16:33:41 +00:00
Danny Tuppeny
ad334d85e1 [analysis_server] Don't allow Extract Method on directives 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4202.

Change-Id: I273d88f3dc5cfd76f01f268485c06916bbd74e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262430
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-06 15:39:15 +00:00
Erik Ernst
d2911decfb Adjust rules recordLiteralNoConst and recordType to include () 
This change is needed as a consequence of
https://github.com/dart-lang/language/pull/2422
where `()` was introduced as the syntax for the empty record as well
as the empty record type.

Change-Id: Ia8b3f590361343ca14355043c5898e7bd084c04e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261645
Reviewed-by: William Hesse <whesse@google.com>
Auto-Submit: Erik Ernst <eernst@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2022-10-06 15:10:57 +00:00
Chloe Stefantsova
fb0b4a80e6 [cfe] Allow records on the RHS of typedefs 
Part of https://github.com/dart-lang/sdk/issues/49713

Closes https://github.com/dart-lang/sdk/issues/50133

Change-Id: I482280599487a3539f88c715e5a92e78f810b264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262962
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2022-10-06 15:03:00 +00:00
Sam Rawlins
682567fe14 Bump dart_style to support unnamed-libraries 
Change-Id: I982b0f8db7609fce737db79524802b11c886af9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262847
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-10-06 14:40:10 +00:00
Ömer Sinan Ağacan
113f249e06 [dart2wasm] Implement null instance tear-offs 
Fixes https://github.com/dart-lang/sdk/issues/50111

These tests now pass:

corelib/null_closurized_method_tostring_test
corelib/null_test
language/nnbd/static_errors/unchecked_use_of_nullable_cascaded_test/10
language/nnbd/static_errors/unchecked_use_of_nullable_test/14
language/nnbd/static_errors/unchecked_use_of_nullable_test/15
language/null/to_string2_test
language/null/to_string_test

Change-Id: Iba5152aa986df24cc96ee81854d9a538aa839e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262601
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
 2022-10-06 12:54:53 +00:00
Michael Thomsen
64add14a45 Roll pub semver pkg 
Change-Id: I376e14f83738c8979a76cc29c316122801095f51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262428
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
 2022-10-06 12:53:49 +00:00
Johnni Winther
c3de385658 [cfe] Unify handling of 'resolveTypeParameterType'. 
We had multiple implementations of this logic and with the introduction
of IntersectionType some where not updated. Instead, this is now added
as a property of `DartType`.

Closes #50112

Change-Id: I2d7a3943b0577d905a1861aa35b0552578766993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262960
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
 2022-10-06 10:38:39 +00:00
Tess Strickland
3b2c41d789 [vm] Make symbol names more user-readable. 
Instead of trying to make names assembler-friendly, instead just
quote the symbols names in the assembly output and use user visible
names for function and object symbols.

More specifically:

* This CL changes the symbol name from an assembler-safe version of the
  scrubbed name to an assembler-unsafe version of the user visible name
  that is then quoted when used in assembly output.

* For code symbols, regular stubs are prefixed with `stub`, allocation
  stubs are prefixed with `new` and type testing stubs are prefixed with
  `assert type is` (e.g., `stub Await`, `new RegExp`,
  `assert type is List<Int>`). Function symbols have no prefix.

* Readonly data symbols begin with the type of the readonly data. If
  there's any additional information (e.g., the function name for
  objects like `PcDescriptors` when `SNAPSHOT_BACKTRACE` is defined),
  that follows the type in parentheses.

* For direct-to-ELF snapshots, we allow symbols to have duplicate names.
  Thus, internally we create unique ids for all created symbols and
  refactor the ELF and DWARF subsystems to pass and store these ids
  instead of the symbol names.

* For assembly output, symbols must have unique names. The namer now
  has a `CStringIntMap` that keeps counts of the number of times a
  given symbol name has been generated for assembly output. If the
  symbol name is in the `CStringIntMap`, then the new count in the map
  is added as a suffix to ensure uniqueness.

  For example, the first symbol created using the name `_StringBase.[]`
  has no suffix. If a second symbol is created using the same name,
  the second symbol is instead named `_StringBase.[] (#2)`.

  This also happens for read-only objects with additional information if
  that additional information is not sufficient to make it unique, and
  is added separately from that additional information.

* A further restriction for assembly output is that symbols that begin
  with 'L' have special meaning to the assembler. Thus, we keep the
  old system of prepending such symbol names with an underscore to
  avoid this behavior.

TEST=vm/dart{,_2}/use_add_readonly_data_symbol_flag

Bug: b/248012965
Change-Id: I1b6e876f4fb4f42f4a3b90e03110a34a87a03a7c
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try,vm-kernel-precomp-mac-product-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262242
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-10-06 10:33:09 +00:00
Chloe Stefantsova
e77f2ee5ff [cfe] Account for class Record in constraint gathering 
Part of https://github.com/dart-lang/sdk/issues/49713

Change-Id: Idfcc304c8da8bb1a6cd887de707ddfd060934543
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262427
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2022-10-06 08:21:38 +00:00
Jens Johansen
e860cf241b [parser] Empty record 
https://github.com/dart-lang/language/pull/2535

Change-Id: I8241119ee858ce39673472056b88c9393799e1a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262600
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2022-10-06 06:34:58 +00:00
Jens Johansen
4d9bbde5ce [kernel] AST-to-Text for records works as expected 
For whatever reason https://dart-review.googlesource.com/c/sdk/+/257203
didn't follow normal textual output and would for instance output

constants  {
  #C1 = 1
  #C2 = 2
const (#C1, #C2)
const ({a:#C1, b:#C2})
const ({a:#C3, b:#C4})
const (#C5, #C3)
}

instead of something like

constants  {
  #C1 = 1
  #C2 = 2
  #C3 = (#C1, #C2)
  #C4 = ({a:#C1, b:#C2})
  #C5 = ({a:#C3, b:#C4})
  #C6 = (#C5, #C3)
}

Change-Id: I9a8d515694d3486ffbb38fdc0d1986d41d053103
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262800
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2022-10-06 06:32:31 +00:00
Konstantin Shcheglov
341a4ab8e5 Resolve ListPattern. 
Change-Id: Ic54996113a73facecc2481d2b6677d11d38dc84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262880
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-06 01:05:37 +00:00
Ryan Macnak
28c4d87b34 [vm, gc] Extend alignment helpers to work with alignment offsets. 
TEST=ci
Change-Id: I02bad1feba3a16360aa52414c94cdef81b158ed6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262000
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2022-10-06 00:50:45 +00:00
Konstantin Shcheglov
7de6c03e57 Update a few pattern tests that can resolve now. 
Change-Id: I7d19dfde6a5d15e88f0d72f032734fc0686395f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-10-05 22:25:42 +00:00
Sam Rawlins
641110ec38 Remove unused TopLevelInferenceErrorKinds 
These fields were not used.

One field was verified in the element model, but no error was ever
derived from it. The error that maybe once was reported from it is now
reported as `INVALID_OVERRIDE`.

Change-Id: I19c57310d39142333cd3c3af9780f28789d56ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262846
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-10-05 22:21:00 +00:00
Stephen Adams
aaed0ce048 [dart2js] Add subtyping of record types against Record interface 
- Fix bug with nullable record type, e.g. `(int,int)?`.

Change-Id: Ie8006e8ec3a9ffd675519df2ab7b4d101d8d5dcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262843
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-10-05 21:56:07 +00:00
Konstantin Shcheglov
ca709d09db Resolve RelationalPattern. 
Change-Id: Ic390c0c760fbcfb91384bf4c9d5a0981483b0f27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262844
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-05 21:51:38 +00:00
Konstantin Shcheglov
b704bbad7c Use AstNodeImpl for a few NodeList(s). 
Change-Id: I2a078c35458ffc509e93108bd189aa29de7a6b7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-10-05 21:10:07 +00:00
Danny Tuppeny
d485d1a3aa [analysis_server] Allow clients to tell server which refactor field kinds they support prompting for 
Change-Id: Idcd79cb36344b95904184ca8c61be15cf1d2e3a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-05 21:08:42 +00:00
Stephen Adams
a07a0333c3 [kernel] Create Source.sourceCode as view of the binary bytes 
This saves about 400MB heap when loading a 900MB .dill file.

Change-Id: I5a09b06764cb493aab8dade2afb4665e12688133
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255802
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-10-05 20:27:59 +00:00
Devon Carew
7b704a727c [deps] rev http_parser, logging, markdown, pub_semver, and watcher 
http_parser (b968f7d..c739675):
  c739675  2022-10-05  Devon Carew  Merge pull request #60 from dart-lang/prep_publish
  a9247c2  2022-10-04  Devon Carew  update CI; prep for publishing

logging (f5d6442..f322480):
  f322480  2022-10-05  Devon Carew  update CI config (#121)

markdown (5713b50..e7915ed):
  e7915ed  2022-10-04  Zhiguang Chen  Improve the match pattern of inline html (#464)

pub_semver (9fd2875..eadf516):
  eadf516  2022-10-04  dependabot[bot]  Bump actions/checkout from 3.0.2 to 3.1.0 (#70)
  edd9d82  2022-10-04  Devon Carew  update the CI; update readme (#69)

watcher (e00c0ea..3259107):
  3259107  2022-10-04  Devon Carew  Merge pull request #127 from devoncarew/update_ci
  e70781d  2022-10-04  Devon Carew  add markdown badges
  ff9d1f2  2022-10-04  Devon Carew  update CI; add markdown badges

Change-Id: I81da3d3ba774b16dc0441b7ed371765c7b86d28c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262860
Reviewed-by: Nate Bosch <nbosch@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2022-10-05 19:43:35 +00:00
Paul Berry
afa257f53d Patterns parsing: fix the name of one more test. 
Change-Id: I106f3eaed7cc15badb8594188f272778a1036bbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262560
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-10-05 19:31:16 +00:00
Konstantin Shcheglov
6136a0dd92 Verify parent of child in ResolvedAstPrinter. 
Fix found issues.

Change-Id: I72f3eed470f0cb474ae9db75ec7ee4f0fd805563
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262841
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-05 19:06:28 +00:00
Alexander Markov
6d27517848 [vm] Fix subtyping for public Record class 
TEST=co19/LanguageFeatures/Records/record_class_A01_t01

Issue: https://github.com/dart-lang/sdk/issues/49719
Change-Id: Ic57de7f1ee59fdd9334b3463ec8b9a6e5e6af06c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262840
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2022-10-05 18:23:07 +00:00
Ryan Macnak
1bff4bead9 [vm, gc] Implement the incremental marking barrier for IA32. 
Enable concurrent marking for IA32.

This removes the last write barrier relying on different alignment offsets for old and new space.

TEST=ci
Change-Id: Ib1c13124002392cf1c3ec264643325ec471a6918
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262280
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2022-10-05 18:08:32 +00:00
Devon Carew
c515938ee4 Bump convert to 11d191e4cc517595f53f86dd193a7c01a7601228 
Changes:
```
> git log --format="%C(auto) %h %s" 7145da1..11d191e
 https://dart.googlesource.com/convert.git/+/11d191e Merge pull request #66 from dart-lang/introduce_date_parser
 https://dart.googlesource.com/convert.git/+/a9f92fc Fix test
 https://dart.googlesource.com/convert.git/+/43d7820 Add changelog entry
 https://dart.googlesource.com/convert.git/+/1f54201 Changes as per review
 https://dart.googlesource.com/convert.git/+/40b2b59 Fix typo
 https://dart.googlesource.com/convert.git/+/6252dd6 Add larger changes as per review
 https://dart.googlesource.com/convert.git/+/a4d6cb5 Apply simple changes as per review
 https://dart.googlesource.com/convert.git/+/a8dbfbf add documentation
 https://dart.googlesource.com/convert.git/+/cd1d2ed skip microsecond tests on web
 https://dart.googlesource.com/convert.git/+/e357b34 Add test to check for microseconds
 https://dart.googlesource.com/convert.git/+/e9e1e1c Duration to DateTime
 https://dart.googlesource.com/convert.git/+/0f301ca changes as per review
 https://dart.googlesource.com/convert.git/+/8a6384b changes as per review
 https://dart.googlesource.com/convert.git/+/d80d096 Remove unused variable
 https://dart.googlesource.com/convert.git/+/86483cd renaming
 https://dart.googlesource.com/convert.git/+/1d53e04 even faster
 https://dart.googlesource.com/convert.git/+/002a140 fix some stuff
 https://dart.googlesource.com/convert.git/+/46ba967 apply changes as per review, convert to SOA
 https://dart.googlesource.com/convert.git/+/ab083d3 rename files
 https://dart.googlesource.com/convert.git/+/6c072dd small name change
 https://dart.googlesource.com/convert.git/+/1309ceb add more changes as per review
 https://dart.googlesource.com/convert.git/+/df5b7aa add licenses
 https://dart.googlesource.com/convert.git/+/5e63874 rename
 https://dart.googlesource.com/convert.git/+/4bec055 Add fixed datetime parser/formatter
 https://dart.googlesource.com/convert.git/+/e9745f3 add license

```

Diff: https://dart.googlesource.com/convert.git/+/7145da14f9cd730e80fb4c6a10108fcfd205e8e7~..11d191e4cc517595f53f86dd193a7c01a7601228/
Change-Id: I23996b7fa090ed2fc8b06c88c129b4764453c942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262820
Commit-Queue: Moritz Sümmermann <mosum@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Moritz Sümmermann <mosum@google.com>
 2022-10-05 17:07:21 +00:00
Ahmed Ashour
615252b4e7 [analysis_server] enabled AddKeyToConstructors for bulk fix 
Fixes #50056

Change-Id: Ib6bff33a79860425027ac7b6ee3fc394b8d1200a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-10-05 17:03:52 +00:00
Konstantin Shcheglov
b90b86492b Use named parameters for few AST nodes. 
Change-Id: I11afd971778232cb0205aeb506e01e8e1051b263
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262744
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-05 16:58:53 +00:00
Stephen Adams
edf0da2df4 [dart2js,js_runtime] Record type recipes and runtime subtype test 
Change-Id: I54adb8b6184a19667a296a670fecb37d7ce9dce7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262126
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-10-05 16:48:01 +00:00
Joshua Litt
16d06dac06 [dart2wasm] Restore caller's zone when returning from await. 
Change-Id: Ifd0013eb130ff98bf2127991b685258ced115824
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262480
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2022-10-05 16:37:59 +00:00
Konstantin Shcheglov
683e2419da Deprecate 'DartType.element2' use 'element' instead. 
Change-Id: I6986a058616db489987789cfab09d53a450e3ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262666
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-10-05 16:30:09 +00:00
Konstantin Shcheglov
76b6db19a1 Remove many patterns resolution tests. 
Paul convinced me that adding them was a mistake, most of these tests
are about how it is parsed in various contexts, not necessary doing
anything differently for resolution.

Change-Id: I6e1336d96ce1fa2cff4f94ada35005c9aa804374
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262665
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-10-05 16:29:57 +00:00
Alexander Markov
6de81be8d1 [vm/aot/tfa] Fix optimization of 'is' tests for FutureOr of nullable types 
TEST=language/nnbd/normalization/future_or_never_normalization_test
Fixes https://github.com/dart-lang/sdk/issues/50121

Change-Id: Ifc0cb9b0524f3afbadcf0ba61e3e714681c503c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262622
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2022-10-05 14:56:09 +00:00