languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[kernel] Create Source.sourceCode as view of the binary bytes

Browse source 
This saves about 400MB heap when loading a 900MB .dill file.

Change-Id: I5a09b06764cb493aab8dade2afb4665e12688133
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255802
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This commit is contained in:
Stephen Adams 2022-10-05 20:27:59 +00:00 committed by Commit Queue
parent 7b704a727c
commit a07a0333c3
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
pkg/kernel/lib/binary/ast_from_binary.dart
View file

@ -244,6 +244,18 @@ class BinaryBuilder {
return readBytes(readUInt30());
}
Uint8List readOrViewByteList() {
int length = readUInt30();
List<int> source = _bytes;
if (source is Uint8List) {
Uint8List view =
source.buffer.asUint8List(source.offsetInBytes + _byteOffset, length);
_byteOffset += length;
return view;
}
return readBytes(length);
}
String readString() {
return readStringEntry(readUInt30());
}
@ -927,7 +939,7 @@ class BinaryBuilder {
String uriString = readString();
Uri uri = Uri.parse(uriString);
_sourceUriTable[i] = uri;
Uint8List sourceCode = readByteList();
Uint8List sourceCode = readOrViewByteList();
int lineCount = readUInt30();
List<int> lineStarts = new List<int>.filled(
lineCount,