Commit graph

115 commits

Author SHA1 Message Date
Sigmund Cherem bab152a0a9 Fix default in gardening tools
test.py was changed, this makes the gardening scripts use the same default for
strong-mode/no-preview-dart-2

Change-Id: I974e288a95811ed8980f0ffbe2d8a9135fbfb5f0
Reviewed-on: https://dart-review.googlesource.com/63987
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-09 17:42:38 +00:00
Devon Carew 3e33c3d0fc Eliminate analysis warnings in pkg/ code.
Change-Id: I571581bf16502c1698932c03313777aa8a9ee081
Reviewed-on: https://dart-review.googlesource.com/63983
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-07-06 21:28:07 +00:00
Leaf Petersen 93b9c06566 Dart 2 fixes in the gardening tools
Change-Id: Ib6339d20a15eb340aedb242f2c228dc2aeaac8b3
Reviewed-on: https://dart-review.googlesource.com/63341
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
2018-06-30 01:15:39 +00:00
Alexander Thomas 2c780c4b1d [gardening] Make gardening tools accept more swarming URLs & Dart 2 fixes
Change-Id: I9101020f3a32da130e26c53391477dc5501ef6ff
Reviewed-on: https://dart-review.googlesource.com/59080
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-06-07 14:57:26 +00:00
Alexander Thomas 8baa82413b [infra] Remove --no-preview-dart-2 flag from gardening tools
Fixes a regression caused by https://dart-review.googlesource.com/c/sdk/+/52461

Change-Id: I59ba32c2f31e70620bea58466935ed47ed61c1dc
Reviewed-on: https://dart-review.googlesource.com/53361
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-05-02 08:09:10 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code.
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-04-16 16:11:57 +00:00
Alexander Thomas a60d803913 [infra] Add --no-preview-dart-2 support for the analyzer to test.py
https://github.com/dart-lang/sdk/issues/32609

Change-Id: I5a7009a55a26452eae6e6465aeb78cecab91b476
Reviewed-on: https://dart-review.googlesource.com/50725
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-04-11 15:16:36 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files.
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-04-10 19:03:21 +00:00
Johnni Winther 23c59bd819 Fix compare_failures
+ and --force flag to always analysis past results (slower)

Change-Id: I9df760b61cfb71ecdf9a4b69d256895812f2eff1
Reviewed-on: https://dart-review.googlesource.com/50500
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-10 13:38:41 +00:00
Alexander Thomas cb08bf287d [infra] Expect certain errors to pass when runtime is "none"
test.py ignores RuntimeError, MissingRuntimeError, and Timeout when the
runtime is "none". Previously, the status update tool would attempt to fix
these "unexpected passes".

Change-Id: I73c15fdc7e18aa29d5553e58b6b4e65ec07c1246
Reviewed-on: https://dart-review.googlesource.com/49461
Reviewed-by: William Hesse <whesse@google.com>
2018-04-04 11:51:25 +00:00
Alexander Thomas 4c6379eaff [infra] Support preview_dart_2 in status update tool
Change-Id: Ib48afe47d22f4c2672139d3ac9946471b41ef89e
Reviewed-on: https://dart-review.googlesource.com/49440
Reviewed-by: William Hesse <whesse@google.com>
2018-04-04 09:42:58 +00:00
Alexander Thomas 1b696eb6f5 [infra] Print variable name for unknown variables
Change-Id: Ib6c21278a0f07c7cdd1ee07532242d7f64cc57bd
Reviewed-on: https://dart-review.googlesource.com/49400
Reviewed-by: William Hesse <whesse@google.com>
2018-04-04 09:42:46 +00:00
Sigmund Cherem 21c9372d8d Add dart2js-old-frontend option to test.py
Change-Id: I4e762bd5e50b2ff8a91b29e8067e47351ace94f7
Reviewed-on: https://dart-review.googlesource.com/44380
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-02-28 23:21:24 +00:00
Erik Ernst 4676ba866f Updated data for bot.dart command find-shard.
Change-Id: I5ef8018c477c581647efa8c6b3ea95702abe337c
Reviewed-on: https://dart-review.googlesource.com/42747
Reviewed-by: Erik Ernst <eernst@google.com>
2018-02-21 15:18:43 +00:00
William Hesse ffc478f6fa Improve status file update tool "fix similar tests" option
R=athom@google.com

Change-Id: I0a26e929b06b7c737b0f233839aca4551ec1d0dc
Reviewed-on: https://dart-review.googlesource.com/39020
Reviewed-by: Alexander Thomas <athom@google.com>
2018-02-06 12:51:07 +00:00
Alexander Thomas 59f272827e [infra] Remove unnecessary prefix 't' from section toggle option
Change-Id: Iacfea3435c813c1d74a64f09df1802610636ef4e
Reviewed-on: https://dart-review.googlesource.com/37460
Reviewed-by: William Hesse <whesse@google.com>
2018-02-06 11:35:52 +00:00
Alexander Thomas bc0156ee44 [infra] Only add custom sections once
* Prevent autofixing tests across suites.
* Handle invalid input when selecting files.
* Only display sections in files that apply to the failing test.

Change-Id: Ia7f22bdf29901af05742e461ca009f2e3a4a3e37
Reviewed-on: https://dart-review.googlesource.com/37400
Reviewed-by: William Hesse <whesse@google.com>
2018-02-06 11:35:52 +00:00
William Hesse 8e7174b210 Fix gardening status update tool to fix all similar tests in one step
Change-Id: Ie93900b32e86d67c2928b38030434509ab2fc5ec
Reviewed-on: https://dart-review.googlesource.com/38121
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-02-02 12:12:47 +00:00
William Hesse 0f67c89474 Update status for Chrome 64 and Firefox 59 on all operating systems
This reverts commit c5306595f4, which updated
the status for linux only, and updates it for all operating systems instead.
It also fixes a minor error in the status update tools.

Change-Id: I556dff775f221b872c5cea27b7ed5a0088d378a5
Reviewed-on: https://dart-review.googlesource.com/37261
Reviewed-by: Alexander Thomas <athom@google.com>
2018-01-29 18:11:06 +00:00
Alexander Thomas 0546d85ef3 [infra] Skip selection step when there is only one possible outcome
Change-Id: I5fc5677cbc52d998c24a6e2cefef519ec0178c2a
Reviewed-on: https://dart-review.googlesource.com/37200
Reviewed-by: William Hesse <whesse@google.com>
2018-01-29 16:12:51 +00:00
Alexander Thomas eff50ffc43 [infra] Ensure that <Enter> doesn't auto-fix
Change-Id: I6134eb2abc1b23d5aada43cf4666def67a580900
Reviewed-on: https://dart-review.googlesource.com/37180
Reviewed-by: William Hesse <whesse@google.com>
2018-01-29 16:12:51 +00:00
Alexander Thomas 2d84ed2297 [infra] Allow passing status command inputs to the tool directly
Change-Id: I20ee77aa8fe2102ddaed785d085d9e0c1806471d
Reviewed-on: https://dart-review.googlesource.com/37000
Reviewed-by: William Hesse <whesse@google.com>
2018-01-26 20:31:16 +00:00
Alexander Thomas c508eb6f29 [infra] Add support for to status.dart results
Change-Id: I17294da087152d7c9d5bc04c9146d05bfac1e6a9
Reviewed-on: https://dart-review.googlesource.com/36843
Reviewed-by: William Hesse <whesse@google.com>
2018-01-26 00:15:11 +00:00
Erik Corry 5ed2f25f40 There is no longer a safarimobilesim test runtime.
And so there is no need to maintain status files for this platform.

R=whesse@google.com

Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-01-17 13:13:17 +00:00
Alexander Thomas 616d02ef65 Search runtime directory for status summaries
Change-Id: Id1b4010cb07883193ea3ef5726c3cb651c2e061b
Reviewed-on: https://dart-review.googlesource.com/33882
Reviewed-by: William Hesse <whesse@google.com>
2018-01-10 16:13:57 +00:00
Morten Krogh-Jespersen d68cdbf099 Tool for updating status files from result logs.
Queries the user for input and performs updates to status files.

Bug:
Change-Id: Iac90d713fcff952b4f0d27044cbbcdc02456de4e
Reviewed-on: https://dart-review.googlesource.com/27540
Reviewed-by: William Hesse <whesse@google.com>
2017-12-08 14:58:55 +00:00
Morten Krogh-Jespersen 88662aafb1 Update workflow, printer and configurations for status tool.
The configuration is directly copied from test.py

Bug:
Change-Id: I221de5b6047289044f30fcbe270eca83c8f660d3
Reviewed-on: https://dart-review.googlesource.com/27521
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-08 14:58:55 +00:00
Morten Krogh-Jespersen 1022bd1ebb Refactor status expectations into a class.
This helps that status expectations are only loaded once. Ensure that we only
load a suite of status files once.

Finally, this also updates the regular expression for finding multitest
expectations without wildcard entries in the path.

Bug:
Change-Id: I9bee07cb0845cfe341fb731aa5772aba8b3060b1
Reviewed-on: https://dart-review.googlesource.com/27520
Reviewed-by: Jonas Termansen <sortie@google.com>
2017-12-08 14:58:55 +00:00
Morten Krogh-Jespersen 20da198715 Updating gardening tools readme with info about overlapping sections.
This updates the information in the README.md file regarding overlapping
sections, how it is invoke and the result from running it.

Bug:
Change-Id: I7c8c057ad73d5893c3ff69e4588e0f234f2d5832
Reviewed-on: https://dart-review.googlesource.com/27620
Reviewed-by: Jonas Termansen <sortie@google.com>
2017-12-08 13:21:09 +00:00
Morten Krogh-Jespersen 8765d5e529 Rewrite tool to find overlapping sections.
The rewrite removes the need to search for configurations from running tests by
using the disjunctive normal form.

Bug:
Change-Id: I66bbbbb9b0eb1e1ae9f8dc02e7ef6a8498850b26
Reviewed-on: https://dart-review.googlesource.com/24106
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-12-08 12:42:16 +00:00
Morten Krogh-Jespersen 6cbb00a889 Refactor results failures tool to allow sharing of code.
Combines the two util.dart files and moves getting result logs from arguments to
a helper file.

Adding spec-parser as compiler to environment.

Bug:
Change-Id: Ifc3b9aacaf98a2976d25ef594bac5c5823bed208
Reviewed-on: https://dart-review.googlesource.com/25260
Reviewed-by: Jonas Termansen <sortie@google.com>
2017-12-08 01:06:28 +00:00
Morten Krogh-Jespersen 3021c0d75f Clean up code to remove add-hoc test matrix.
Bug:
Change-Id: I739880778ded42af1998e34744dbae4ed2d5f128
Reviewed-on: https://dart-review.googlesource.com/24900
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-04 08:28:13 +00:00
Erik Ernst d7b4d12a1e Bug fix: avoid range error
Change-Id: I4fb2f132df38516c21f76b4589aa4896d7e213bc
Reviewed-on: https://dart-review.googlesource.com/24462
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
2017-11-29 15:45:40 +00:00
Morten Krogh-Jespersen ab6c900a39 Logdog rpc should not split incoming logs by new line.
Bug:
Change-Id: I1e4f33ab7856bdcd98a3ab7b5ec30db61e566ec3
Reviewed-on: https://dart-review.googlesource.com/19680
Reviewed-by: William Hesse <whesse@google.com>
2017-11-10 15:18:43 +00:00
Morten Krogh-Jespersen 0c53270b53 Small changes to compare_failures tool.
Remaining comments from previous CL implemented:
https://dart-review.googlesource.com/c/sdk/+/17222
Bug:
Change-Id: I5be455dfd92b0117f29185bf7b02bd83cac6a34d
Reviewed-on: https://dart-review.googlesource.com/17420
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-31 11:16:29 +00:00
Morten Krogh-Jespersen 7f875c6e01 Make compare failures work with logdog instead of build bot data.
Build bot data is no longer maintained and all logs are moving over to logdog.

Bug:
Change-Id: If3526bde1c950b936d9bf1e67bb53d19bffe7177
Reviewed-on: https://dart-review.googlesource.com/17222
Reviewed-by: William Hesse <whesse@google.com>
2017-10-31 07:22:57 +00:00
Morten Krogh-Jespersen 359eddc256 Make logdog rpc the primary way to interact with logdog.
Additionally, combine all stream chunks into a single buffer, separated by new
line.

Bug:
Change-Id: I0c56aa1e99e76ee7ff578c84dc9e3ef534f5e63f
Reviewed-on: https://dart-review.googlesource.com/17221
Reviewed-by: William Hesse <whesse@google.com>
2017-10-31 07:22:57 +00:00
Johnni Winther d4a6eec5f5 Fix 'results.dart get failures' for Windows.
Change-Id: I7bb88e57399acd33af369dcb4c78445608290b31
Reviewed-on: https://dart-review.googlesource.com/16960
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-30 08:29:34 +00:00
Morten Krogh-Jespersen 6365369a39 Refactoring failures tool
Refactoring of failures tool with:

Reducing the time it takes for looking up status files by dividing entries in
the status file by wildcard and none-wildcard. Speciel attention is needed for
multitests.

Not report an error when Skip or SkipByDesign is added to the status files.

Report which status files expectations are taken from.

Bug:
Change-Id: I56a05a9bd79a5206ef5287a58d341165d98aaefc
Reviewed-on: https://dart-review.googlesource.com/16441
Reviewed-by: William Hesse <whesse@google.com>
2017-10-27 09:12:06 +00:00
Morten Krogh-Jespersen 9f4da5c90a Update readme for result failures tool.
Updating the readme to better give a quick overview of how to use the results failures tool.
Bug:
Change-Id: Id6d4492e6a55e651886e9ccbbc88965248e1ac88
Reviewed-on: https://dart-review.googlesource.com/16740
Reviewed-by: William Hesse <whesse@google.com>
2017-10-26 09:41:50 +00:00
Morten Krogh-Jespersen 65656ca8e3 Improve the description of the failures gardening tool.
Bug:
Change-Id: I02d0612c81d214af2c9c2701bb6ae3312473cabd
Reviewed-on: https://dart-review.googlesource.com/16500
Reviewed-by: William Hesse <whesse@google.com>
2017-10-25 16:01:55 +00:00
Morten Krogh-Jespersen 0a075daaa1 Status files class for finding expectations.
Bug:
Change-Id: I231507facb448d327a68b987b1763524ae6b1541
Reviewed-on: https://dart-review.googlesource.com/16180
Reviewed-by: William Hesse <whesse@google.com>
2017-10-25 07:14:52 +00:00
Morten Krogh-Jespersen a95fef2a21 Remove dependendy on archive in gardening tools.
Bug:
Change-Id: I259f9446242c425dae62ecb23cdaa669e13f49a4
Reviewed-on: https://dart-review.googlesource.com/16160
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-25 07:14:23 +00:00
Morten Krogh-Jespersen ccd835ddb1 Wrapper around status files and expectations.
Bug:
Change-Id: I5cb9efcc915d4106f35516702109d35d4c12e604
Reviewed-on: https://dart-review.googlesource.com/13744
Reviewed-by: William Hesse <whesse@google.com>
2017-10-24 07:42:42 +00:00
Morten Krogh-Jespersen b679bf0818 Tool for finding duplicate entries for tests in status files.
Bug:
Change-Id: Ia1c1110b7b5f71465763bd3042ae459008293971
Reviewed-on: https://dart-review.googlesource.com/13745
Reviewed-by: William Hesse <whesse@google.com>
2017-10-20 11:44:09 +00:00
Morten Krogh-Jespersen f458bda37f Get builders and latest builds from CQ.
Change-Id: Ic8a53a688b82cb39061e5f6f4a1dc6beb685bc8c
Reviewed-on: https://dart-review.googlesource.com/12560
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-18 06:15:08 +00:00
Morten Krogh-Jespersen 613393b3ff Refactoring of testpy_wrapper.
Bug:
Change-Id: I136862fe693bc3e82bc37ca1b839633f12509b9a
Reviewed-on: https://dart-review.googlesource.com/13743
Reviewed-by: William Hesse <whesse@google.com>
2017-10-16 14:22:13 +00:00
Morten Krogh-Jespersen bb0687e6f5 Add utility methods to gardening.
Bug:
Change-Id: I4b9365a34b211d2885d32a8683a3128b82832a77
Reviewed-on: https://dart-review.googlesource.com/13742
Reviewed-by: William Hesse <whesse@google.com>
2017-10-16 13:48:25 +00:00
Morten Krogh-Jespersen 16fd76c481 Allow logging of all types of failures.
Bug:
Change-Id: I9f37f77815eda65085fa3b303d8197d480db8d66
Reviewed-on: https://dart-review.googlesource.com/13740
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-13 13:06:47 +00:00
Morten Krogh-Jespersen a409e4ddb8 Add spec-parser to configuration for result tool.
Bug:
Change-Id: I8697fa9516bb0c43863340d4e8beb87df8b46678
Reviewed-on: https://dart-review.googlesource.com/13520
Reviewed-by: William Hesse <whesse@google.com>
2017-10-12 11:38:24 +00:00