languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 12:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Remove --no-preview-dart-2 flag from gardening tools

Browse source 
Fixes a regression caused by https://dart-review.googlesource.com/c/sdk/+/52461

Change-Id: I59ba32c2f31e70620bea58466935ed47ed61c1dc
Reviewed-on: https://dart-review.googlesource.com/53361
Reviewed-by: Johnni Winther <johnniwinther@google.com>
This commit is contained in:
Alexander Thomas 2018-05-02 08:09:10 +00:00
parent 47e9039512
commit 8baa82413b
3 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
tools/gardening/bin/results_list.dart
View file

@ -59,7 +59,6 @@ models.Configuration getConfigurationFromArguments(ArgResults argResults) {
argResults["enable-asserts"],
argResults["hot-reload"],
argResults["hot-reload-rollback"],
argResults["no-preview-dart-2"],
argResults["preview-dart-2"],
argResults.rest);
}

1
tools/gardening/lib/src/results/configuration_environment.dart
View file

@ -46,7 +46,6 @@ final _variables = {
}),
"minified": new _Variable.bool((c) => c.minified),
"mode": new _Variable((c) => c.mode, Mode.names),
"no_preview_dart_2": new _Variable.bool((c) => c.noPreviewDart2),
"preview_dart_2": new _Variable.bool((c) => c.previewDart2),
"runtime": new _Variable(_runtimeName, Runtime.names),
"spec_parser": new _Variable.bool((c) => c.compiler == Compiler.specParser),

6
tools/gardening/lib/src/results/result_json_models.dart
View file

@ -28,7 +28,6 @@ class Configuration {
final bool enableAsserts;
final bool hotReload;
final bool hotReloadRollback;
final bool noPreviewDart2;
final bool previewDart2;
final List<String> selectors;
@ -54,7 +53,6 @@ class Configuration {
this.enableAsserts,
this.hotReload,
this.hotReloadRollback,
this.noPreviewDart2,
this.previewDart2,
this.selectors);
@ -81,7 +79,6 @@ class Configuration {
json["enable_asserts"] ?? false,
json["hot_reload"] ?? false,
json["hot_reload_rollback"] ?? false,
json["no_preview_dart_2"] ?? false,
json["preview_dart_2"] ?? false,
json["selectors"] ?? []);
}
@ -110,7 +107,6 @@ class Configuration {
_boolToArg("enable-asserts", enableAsserts),
_boolToArg("hot-reload", hotReload),
_boolToArg("hot-reload-rollback", hotReloadRollback),
_boolToArg("no-preview-dart-2", noPreviewDart2),
_boolToArg("preview-dart-2", previewDart2)
].where((x) => x != null).toList();
if (includeSelectors && selectors != null && selectors.length > 0) {
@ -123,7 +119,7 @@ class Configuration {
return "$mode;$arch;$compiler;$runtime;$checked;$strong;$hostChecked;"
"$minified;$csp;$fasta;$system;$vmOptions;$useSdk;$builderTag;$fastStartup;"
"$dart2JsWithKernel;$dart2JsOldFrontend;$enableAsserts;$hotReload;"
"$hotReloadRollback;$noPreviewDart2;$previewDart2;$selectors";
"$hotReloadRollback;$previewDart2;$selectors";
}
String _stringToArg(String name, String value) {