languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-05 18:22:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve status file update tool "fix similar tests" option

Browse source 
R=athom@google.com

Change-Id: I0a26e929b06b7c737b0f233839aca4551ec1d0dc
Reviewed-on: https://dart-review.googlesource.com/39020
Reviewed-by: Alexander Thomas <athom@google.com>
This commit is contained in:
William Hesse 2018-02-06 12:51:07 +00:00
parent 59f272827e
commit ffc478f6fa
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tools/gardening/lib/src/results_workflow/fix_failing_test.dart
View file

@ -113,6 +113,7 @@ class FixFailingTest extends WorkflowStep<List<FailingTest>> {
}
Future<WorkflowAction> _fixAllSimilarTests() async {
var unhandledTests = <FailingTest>[];
for (FailingTest similarTest in _remainingTests) {
_currentWorkingItem = new FixWorkingItem(similarTest.result.name,
similarTest, _statusExpectations, _lastComment, this._customSections);
@ -141,9 +142,11 @@ class FixFailingTest extends WorkflowStep<List<FailingTest>> {
var realLast = _lastWorkingItem;
await fixFailingTest(); // Sets _lastWorkingItem to _currentWorkingItem
_lastWorkingItem = realLast; // Might not be needed
} else {
unhandledTests.add(similarTest);
}
}
return new NavigateStepWorkflowAction(this, const <FailingTest>[]);
return new NavigateStepWorkflowAction(this, unhandledTests);
}
@override