languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-19 21:11:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
41522 commits 11 branches 6011 tags 1.4 GiB
Commit graph

41522 commits

This branch
This branch
All branches
Author SHA1 Message Date
Martin Kustermann 9195014572 Fix off-by-one issue in clustered snapshot implementation and api impl 
R=rmacnak@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org/2381573002 .
 2016-09-28 18:46:26 +02:00
pq b681fc5a44 Add ABSTRACT_SUPER_MEMBER_REFERENCE to error code enum. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2376623003 .
 2016-09-28 09:26:05 -07:00
Lasse R.H. Nielsen b98484fbc1 Fix spec reference to non-existing mirrors method. 
Fixes #25549
BUG= https://dartbug.com/25549
R=eernst@google.com

Review URL: https://codereview.chromium.org/2381483002 .
 2016-09-28 13:38:14 +02:00
Lasse R.H. Nielsen 9487e107bb Address shortcomings in documentation on Isolate class. 
Addresses issued #26597 and #26627.

BUG= http://dartbug.com/26597 http://dartbug.com/26627
R=eernst@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org/2062683002 .
 2016-09-28 10:42:06 +02:00
Lasse R.H. Nielsen debbf68223 Fix bug effectively stating that 1e8 is an integer literal, not a double. 
Fix typo in spec - uses `/` when intending division by zero error.

Fixes issues #26053, #27279

BUG= http://dartbug.com/26053, http://dartbug.com/27279
R=eernst@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org/2370853004 .
 2016-09-28 09:51:10 +02:00
Konstantin Shcheglov 536f53f0ef Initial version of Bazel SummaryProvider. 
Only request for a single consistent unlinked package is implemented.

Searching for consistent set of linked packages is to be implemented yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2376833002 .
 2016-09-27 17:33:26 -07:00
Chinmay Garde b29788329b Update vm/BUILD.gn to account for stricter GN warnings. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2369143005 .
 2016-09-27 16:16:11 -07:00
Siva Annamalai e8a9a06528 Fix status file for debugger_location_test. 
BUG=

Review URL: https://codereview.chromium.org/2371283002 .
 2016-09-27 15:51:58 -07:00
Konstantin Shcheglov 3647e7bac0 Order suggested Quick Fix imports: direct, export, non-API. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2377803002 .
 2016-09-27 15:03:26 -07:00
Florian Schneider add88f4ee3 Fix too strict debug assertion in disassembler. 
When printing function objects to JSON, we still allocate
temporary strings on the Dart heap.

BUG=

Review URL: https://codereview.chromium.org/2372973003 .
 2016-09-27 14:19:35 -07:00
Siva Annamalai 8e92c5e6da Skip failing test under asan (see issue 27441) 
BUG=

Review URL: https://codereview.chromium.org/2372713006 .
 2016-09-27 13:26:43 -07:00
John McCutchan 2ed4f4725a Status file tweak 
BUG=

Review URL: https://codereview.chromium.org/2377743002 .
 2016-09-27 13:02:39 -07:00
Florian Schneider 4bd534191a VM: Avoid allocating strings when disassembling code. 
For code objects, don't allocate symbol strings when printing the disassembly.

Don't try to make disassembling work with background compilation -- instead make sure that we don't allocate on the Dart heap while disassembling.

Add NoSafepointScope around disassemble functions to assert that no allocation happens.

Also, remove some dead code from object.cc.

BUG=#27430
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2363413004 .
 2016-09-27 12:43:05 -07:00
Ryan Macnak d9311af50b Appease TSAN regarding data race in profiler debug counters. 
BUG=b/31767249
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2376753002 .
 2016-09-27 12:27:37 -07:00
John McCutchan a7fe93b62c Also dump a stack trace on a pthread assertion failure 
Recently on the build bots we hit a pthread_error (https://build.chromium.org/p/client.dart/builders/vm-linux-debug-x64-reload-be/builds/337/steps/vm%20tests/logs/stdio)
 but that code uses a different ASSERT macro so we don't get to see the stack trace.

BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2372703006 .
 2016-09-27 11:16:28 -07:00
John McCutchan 52f9fac257 Split debugger_location_test into two separate tests 
Fixes #27434

R=asiva@google.com

Review URL: https://codereview.chromium.org/2376433003 .
 2016-09-27 10:59:46 -07:00
William Hesse 0f0bd64ca4 Commit observatory's pubspec.lock to the repo 
It is no longer generated, since we have checked in .packages rather
than generating it.  Pub build requires it to be there.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2371933004 .
 2016-09-27 14:04:47 +02:00
Johnni Winther 06d7fb2fc5 Replace ClosedWorld.backend with ClosedWorld.backendClasses 
R=het@google.com

Review URL: https://codereview.chromium.org/2370833002 .
 2016-09-27 10:33:51 +02:00
Johnni Winther a1cd695612 Move remaining functionality from ClassWorld to ClosedWorld 
... and rename ClassWorld to World.

R=het@google.com

Review URL: https://codereview.chromium.org/2366363002 .
 2016-09-27 10:23:03 +02:00
Siva Annamalai ce596133ad Skip service/debugger_location_test see Issue 27434. 
BUG=

Review URL: https://codereview.chromium.org/2370193002 .
 2016-09-26 21:15:45 -07:00
Siva Annamalai bb02e814dc Skip string_literals_test (see Issue 27433) 
BUG=

Review URL: https://codereview.chromium.org/2377563002 .
 2016-09-26 21:03:27 -07:00
Florian Schneider 7ca3da1a3a Fix lazy deoptimization in the presence of exceptions 
Catch block entries need to be considered when doing lazy deoptimization.

In addition to the return, also patch all catch entry blocks in a function scheduled for lazy deoptimization.

Also, move restoring the pool pointer to the jump-to-handler stub to simplify patching the catch entry.

BUG=#27419
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2357343003 .
 2016-09-26 16:24:23 -07:00
Ryan Macnak f2a5c7157c Prefer loading Smi 0 instead of null into a runtime call result slot. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2371983002 .
 2016-09-26 15:40:45 -07:00
Brian Wilkerson 9b882521e2 Move error codes and clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2370813003 .
 2016-09-26 13:26:26 -07:00
Konstantin Shcheglov ef015221b1 Catch exceptions while preparing analysis.implemented notification. 
This notification is sent often, and uses index and search engine. We
have several exceptions in internal logs, and all there exceptions are
fatal by default. It seems too harsh to shutdown the server because of
a missing notification.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2376493002 .
 2016-09-26 12:54:33 -07:00
Paul Berry e9e6b331c3 Update DEPS to pull in cli_util version 0.0.1+3. 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2371863002 .
 2016-09-26 11:40:24 -07:00
Konstantin Shcheglov 85d3aff259 Issue 25706. Fix for resolving '@prefix.ClassName.staticVariable.'. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/25706

Review URL: https://codereview.chromium.org/2376463002 .
 2016-09-26 10:59:40 -07:00
Ryan Macnak 2bc6e0a71d AOT: Add a separate switchable call state for unlinked calls. 
Flutter gallery
Isolate(CodeSize): 2213525 =>
Isolate(CodeSize): 2070395 (-6.4%)

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2357313003 .
 2016-09-26 10:34:36 -07:00
William Hesse 934b3718c8 Remove observatory GYP dependence on removed timestamp. 
BUG=https://github.com/dart-lang/sdk/issues/27412

TBR=cutch

Review URL: https://codereview.chromium.org/2372643002 .
 2016-09-26 18:49:03 +02:00
William Hesse 1f97819b25 Add --packages flag when compiling dart2js snapshot 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2368073004 .
 2016-09-26 18:48:26 +02:00
William Hesse 9941b665bf Tools not running from snapshots should use /.packages 
Stray .package files in their source can otherwise cause errors.

BUG=
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2374453002 .
 2016-09-26 18:47:32 +02:00
Ryan Macnak bace87bc00 AOT: Enable optimizing native functions. Removes some initialization of unused split slots. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2359393003 .
 2016-09-26 09:01:58 -07:00
William Hesse 79b682b885 Add explicit package spec to snapshot build steps 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2372573002 .
 2016-09-26 15:52:31 +02:00
William Hesse 7dbda3eaee Remove pub get from GYP observatory build. 
BUG=https://github.com/dart-lang/sdk/issues/27412
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2370773002 .
 2016-09-26 15:50:43 +02:00
Lasse R.H. Nielsen 3ba0e98020 Allow surrogates in string literals. 
Fixes issue #26620
BUG: http://dartbug.com/26620

R=asiva@google.com, brianwilkerson@google.com, floitsch@google.com, hausner@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2304923002 .

Committed: 574ae435f3
 2016-09-26 14:32:21 +02:00
Lasse R.H. Nielsen 574ae435f3 Allow surrogates in string literals. 
Fixes issue #26620
BUG: http://dartbug.com/26620

R=asiva@google.com, brianwilkerson@google.com, floitsch@google.com, hausner@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2304923002 .
 2016-09-26 13:23:41 +02:00
Roman Vanesyan 3a4b32d957 Update STRONG_MODE.md (#27391) 
Correct quotes.
 2016-09-26 11:57:22 +02:00
Johnni Winther 8820b8046b Move closed world reasoning methods from ClassWorld to ClosedWorld. 
Main changes in world.dart

R=het@google.com

Review URL: https://codereview.chromium.org/2363773005 .
 2016-09-26 11:14:57 +02:00
Johnni Winther 62f6c08959 Perform MixinFullResolution before baseline test. 
R=asgerf@google.com, het@google.com

Review URL: https://codereview.chromium.org/2367793002 .
 2016-09-26 10:54:31 +02:00
Lasse R.H. Nielsen caf208a543 Make StreamIterator not delay pausing between requests. 
The current implementation of StreamIterator has a one-element buffer which
allows it listen for the next even eagerly, and only pause if consumption
doesn't keep up with production.
However, StreamIterator is also used by both VM and dart2js implementations
of "await for", and according to the specification, the iterated stream
must be paused between loop iterations.

The CL removes the one-element buffer and forces a pause after each event.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2149893002 .
 2016-09-26 09:35:46 +02:00
Siva Annamalai 0d7c631a20 Adjust EvaluateGarbageCollection to account for some unit test case scenarios. 
BUG=

Review URL: https://codereview.chromium.org/2368003002 .
 2016-09-23 17:15:53 -07:00
John Messerly 1129d3d121 fix #27421, DDC did not generate implicit super calls in some cases 
this would happen when there was a chain of implicit super calls, leading to an implicit super with field initializers

R=vsm@google.com

Review URL: https://codereview.chromium.org/2365053003 .
 2016-09-23 17:06:10 -07:00
John Messerly 361cd4c61c fix #27408, reverts "ignore dynamic in inference" 
this reverts 8c25a41acc

R=vsm@google.com

Review URL: https://codereview.chromium.org/2360973004 .
 2016-09-23 17:01:33 -07:00
Siva Annamalai 2a957c1fd9 Fix product build break. 
BUG=

Review URL: https://codereview.chromium.org/2364843003 .
 2016-09-23 15:43:39 -07:00
Stephen Adams a2945cb281 Rewrite HStringify(a) to a.toString() when guaranteed to return a String 
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2365493002 .
 2016-09-23 15:29:54 -07:00
Zachary Anderson 27784381b2 Add tcmalloc to GN build 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2367723004 .
 2016-09-23 15:24:54 -07:00
Siva Annamalai 12f86594ec Add --parse-all option in order to benchmark and measure the scanner/parser performance. 
R=hausner@google.com

Review URL: https://codereview.chromium.org/2327693002 .
 2016-09-23 15:20:39 -07:00
Siva Annamalai 85cb1b3bd8 Fix for issue 25954 (Adjust heap growth amount for the case when the amount of garbage collected in the previous round is 0). 
out/ReleaseX64/dart ~/tmp/gc2.dart 1
permanent = 44739242  ephemeral = 671088620  21.875s

out/ReleaseX64/dart ~/tmp/gc2.dart 2
permanent = 89478485  ephemeral = 1342177280  45.3s

out/ReleaseX64/dart ~/tmp/gc2.dart 3
permanent = 134217728  ephemeral = 2013265920  79.41s

out/ReleaseX64/dart ~/tmp/gc2.dart 4
permanent = 178956970  ephemeral = 2684354540  101.525s

BUG=25954
R=zra@google.com

Review URL: https://codereview.chromium.org/2217833003 .
 2016-09-23 14:37:38 -07:00
John McCutchan 74ee4ea047 Fix handling of co19 syntax error tests using the @compile-error tag and reload bots 
BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2369633002 .
 2016-09-23 14:26:22 -07:00
pq bb4e0798df Pull linter 0.1.27 into the SDK. 
* Fixed cast exception in `dart_type_utilities` (dart-lang/sdk#27405).
* New `parameter_assignments` lint.
* New `prefer_final_fields` lint.
* New `prefer_final_locals` lint.
* Markdown link fixes in docs (#306).
* Miscellaneous solo test running fixes and introduction of `solo_debug` (#304).

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2369463003 .
 2016-09-23 14:00:01 -07:00