languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-19 23:41:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Catch exceptions while preparing analysis.implemented notification.

Browse source 
This notification is sent often, and uses index and search engine. We
have several exceptions in internal logs, and all there exceptions are
fatal by default. It seems too harsh to shutdown the server because of
a missing notification.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2376493002 .
This commit is contained in:
Konstantin Shcheglov 2016-09-26 12:54:33 -07:00
parent e9e6b331c3
commit ef015221b1
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
pkg/analysis_server/lib/src/operation/operation_analysis.dart
View file

@ -48,12 +48,19 @@ scheduleImplementedNotification(
for (String file in files) {
CompilationUnitElement unitElement = server.getCompilationUnitElement(file);
if (unitElement != null) {
ImplementedComputer computer =
new ImplementedComputer(searchEngine, unitElement);
await computer.compute();
var params = new protocol.AnalysisImplementedParams(
file, computer.classes, computer.members);
server.sendNotification(params.toNotification());
try {
ImplementedComputer computer =
new ImplementedComputer(searchEngine, unitElement);
await computer.compute();
var params = new protocol.AnalysisImplementedParams(
file, computer.classes, computer.members);
server.sendNotification(params.toNotification());
} catch (exception, stackTrace) {
server.sendServerErrorNotification(
'Failed to send analysis.implemented notification.',
exception,
stackTrace);
}
}
}
}