The `$builder_tag == strong` annotations were added before test.py
supported `$strong`. Now that `$strong` is supported, it's better to
use it directly to avoid confusion.
Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This follows Leaf's simplified suggestion. As a temporary hack it
assumes that the mixin passes its type parameters through to its
superclass constraint unchanged.
Change-Id: I091b44005d6364a91e20578f2ff6340334b1fab6
Reviewed-on: https://dart-review.googlesource.com/38040
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Change-Id: Ia6ee8f86d53376ed30c783dc54f3a5f4633e17b1
Reviewed-on: https://dart-review.googlesource.com/39521
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.
Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
This reverts commit d78a41e0ee.
Revert "Fix length for WideToUTF8 conversion in UriToPath"
This reverts commit 011e1cc1c5.
Change-Id: I36140426a474962f77605e1aed6ddfd158bd064a
Reviewed-on: https://dart-review.googlesource.com/39480
Reviewed-by: Alexander Aprelev <aam@google.com>
The Pixel is pickier about this than the other CPUs we've encountered so far.
Change-Id: I253e9e97d110112816fc9052a2e9c497cff0c01c
Reviewed-on: https://dart-review.googlesource.com/39360
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This change shifts logic for invoking Dart scripts during the build
from a couple of python scripts to a new template called dart_action().
Change-Id: Ic0818122cd7317cbd22a7255d880fe8f87271b7e
Reviewed-on: https://dart-review.googlesource.com/39260
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This allows the original loadId to be determined when the original ends in a digit.
Change-Id: I37231229c538c66fd54c79dffbfded3aa9e3973b
Reviewed-on: https://dart-review.googlesource.com/36490
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
This CL finishes the process of removing findMemberName from parsing
class members and sets the stage for improved recovery.
In addition, this CL:
* Revises the `endMethod` event to include a beforeParam token
so that the parser can revise the token stream before the parameters
during recovery.
* Reworks insertSyntheticIdentifer for use in more places
Change-Id: If5bcd6f554053f72429e938b5cd5e7021e03d5b3
Reviewed-on: https://dart-review.googlesource.com/39320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Rename a method that clashes with the new update method being added to
Map.
Change-Id: I7717e055ddd2734ee3dfc9b0d20f69c415775b28
Reviewed-on: https://dart-review.googlesource.com/39240
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Change-Id: Idcdadb0b26c2fc187a90dd60f11b634a84c12b9f
Reviewed-on: https://dart-review.googlesource.com/38920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
This reverts commit 9356382e6b.
Reason for revert: Landed incomplete change.
Original change's description:
> Wrap any Flutter widget expressions, not just instance creations.
>
> So, we can wrap references to widgets, e.g. variables.
>
> R=brianwilkerson@google.com, devoncarew@google.com
>
> Change-Id: Idc233251a3f5a62e47a0899c27f524537a3497d3
> Reviewed-on: https://dart-review.googlesource.com/38922
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com
Change-Id: I0b7c75802e328bc3ae7fdc4c2be6fab663bac570
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This separates and cleans up externally called fasta parser methods
such as parseTopLevelMember and parseMember from internal callers.
* Split external and internal calls to parseTopLevelMember
so that external callers use parseTopLevelMember
and internal callers use parseTopLevelMemberImpl.
* Rename the externally called parseMember --> parseClassMember
and the internally called parseClassMember --> parseClassMemberImpl
* Revise the insertSyntheticIdentifier method and cleanup some
exiting recovery code to use it.
Change-Id: Ic66ddcbbe761937bb917c679590fc7de2fdd0396
Reviewed-on: https://dart-review.googlesource.com/39080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
By default super method invocations look for dispatch target.
However super-mixins semantics permits super invocations to
target interface members too.
Fixes https://github.com/dart-lang/sdk/issues/31994
Change-Id: I950abb3f0fea4a9611e3dd3b90dd05415a6d2979
Reviewed-on: https://dart-review.googlesource.com/38800
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Change-Id: I4c7f7c7b39e07eee42b4dd5375fb855d3348ac49
Reviewed-on: https://dart-review.googlesource.com/39121
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit 0b59f24f97.
Reason for revert: Creates crashes in dart2js with kernel, see
https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751
Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
>
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Leaf Petersen <leafp@google.com>
TBR=lrn@google.com,leafp@google.com
Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com>
Change-Id: I71d675a694f74b274bfbf8ae8470541c8398e7ac
Reviewed-on: https://dart-review.googlesource.com/38801
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
* Prevent autofixing tests across suites.
* Handle invalid input when selecting files.
* Only display sections in files that apply to the failing test.
Change-Id: Ia7f22bdf29901af05742e461ca009f2e3a4a3e37
Reviewed-on: https://dart-review.googlesource.com/37400
Reviewed-by: William Hesse <whesse@google.com>
Bug:
Change-Id: Ifb3a6cf2bff45ce12bb69135a9f2c172dcd8191d
Reviewed-on: https://dart-review.googlesource.com/37781
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.
Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>