languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 18:05:01 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Replace $builder_tag == strong with $strong in status files

Browse source 
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`.  Now that `$strong` is supported, it's better to
use it directly to avoid confusion.

Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This commit is contained in:
Paul Berry 2018-02-07 11:50:10 +00:00 committed by commit-bot@chromium.org
parent dc35b04a18
commit cca7b4419d
15 changed files with 26 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/pkg.status
View file

@ -153,7 +153,7 @@ analyzer/test/*: Skip # Issue 26813
analyzer/tool/*: Skip # Issue 26813
# Don't analyze tests in strong mode yet
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
# Analyze dev_compiler but only run its tests on the vm

2
pkg/status_file/test/data/vm.status
View file

@ -129,7 +129,7 @@ dart/data_uri*test: Skip # Data uri's not supported by dart2js or the analyzer.
dart/optimized_stacktrace_line_test: StaticWarning
dart/optimized_stacktrace_line_and_column_test: StaticWarning
[ $compiler == dart2analyzer && $builder_tag == strong ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == app_jit ]

3
runtime/observatory/tests/service/service.status
View file

@ -69,7 +69,7 @@ get_cpu_profile_timeline_rpc_test: Pass, RuntimeError # http://dartbug.com/31794
[ $arch == simdbc64 && $compiler == dartk && $mode == debug ]
eval_test: Pass, Slow
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
# Enabling of dartk for sim{arm,arm64,dbc64} revelaed these test failures, which
@ -124,3 +124,4 @@ step_through_getter_test: RuntimeError # Debugging StringConcatenation doesn't w
# Skip all service tests because random reloads interfere.
[ $hot_reload || $hot_reload_rollback ]
*: SkipByDesign # The service tests should run without being reloaded.

2
runtime/tests/vm/vm.status
View file

@ -155,7 +155,7 @@ cc/Profiler_TypedArrayAllocation: Pass, Fail # Issue 31137
[ $builder_tag == asan && $mode == debug && ($runtime == dart_precompiled || $runtime == vm) ]
cc/Dart2JSCompileAll: SkipSlow # Timeout.
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == dartk && $mode == debug && $runtime == vm ]

2
samples/samples.status
View file

@ -22,7 +22,7 @@ build_dart: Skip
build_dart_simple: Skip
sample_extension: Skip
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == dart2js && $runtime == none ]

5
tests/co19/co19-analyzer.status
View file

@ -55,7 +55,7 @@ Language/Expressions/Identifier_Reference/built_in_not_dynamic_t32: MissingCompi
Language/Expressions/Identifier_Reference/evaluation_type_parameter_t02: MissingCompileTimeError # Please triage this failure.
Language/Expressions/Instance_Creation/Const/abstract_class_t01/01: MissingCompileTimeError # Please triage this failure.
Language/Expressions/Instance_Creation/Const/abstract_class_t03/01: MissingCompileTimeError # Please triage this failure.
Language/Expressions/Instance_Creation/Const/arguments_t03: MissingCompileTimeError# Please triage this failure.
Language/Expressions/Instance_Creation/Const/arguments_t03: MissingCompileTimeError # Please triage this failure.
Language/Expressions/Lookup/Method_Lookup/superclass_t07: StaticWarning # Please triage this failure.
Language/Expressions/Lookup/Method_Lookup/superclass_t08: StaticWarning # Please triage this failure.
Language/Expressions/Maps/constant_map_t02: MissingCompileTimeError # Please triage this failure.
@ -503,5 +503,6 @@ WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/test-007_t0
WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/test-009_t01: StaticWarning # Please triage this failure.
WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/test-011_t01: StaticWarning # Please triage this failure.
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649

2
tests/compiler/dart2js_extra/dart2js_extra.status
View file

@ -23,7 +23,7 @@ timer_test: Fail # Issue 7728.
[ $runtime == none ]
timer_negative_test: Fail, OK # A negative runtime test.
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $strong && $compiler == dart2analyzer ]
dummy_compiler_test: Skip # Issue 28649
recursive_import_test: Skip # Issue 28649

6
tests/corelib/corelib.status
View file

@ -119,9 +119,6 @@ int_parse_radix_test/*: Pass, Slow
[ $arch == x64 && $system == windows ]
stopwatch_test: Skip # Flaky test due to expected performance behaviour.
[ $builder_tag == strong && $compiler == dart2analyzer ]
*: Skip # Issue 28649
# Analyzer's implementation of fromEnvironment assumes that undefined
# environment variables have an unspecified value (rather than being
# null) because it is expected that the user will supply a value when
@ -135,6 +132,9 @@ from_environment_const_type_undefined_test/13: CompileTimeError
from_environment_const_type_undefined_test/14: CompileTimeError
from_environment_const_type_undefined_test/16: CompileTimeError
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler != dart2analyzer && $runtime != dart_precompiled && $runtime != vm ]
data_resource_test: RuntimeError # Issue 23825 (not implemented yet).
file_resource_test: Skip, OK # VM specific test, uses dart:io.

2
tests/html/html.status
View file

@ -159,7 +159,7 @@ worker_api_test: Skip # Issue 13221
[ $strong ]
*: SkipByDesign
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == dart2js && $runtime == chrome ]

2
tests/isolate/isolate.status
View file

@ -48,7 +48,7 @@ spawn_uri_multi_test/none: RuntimeError # Issue 13544
[ $strong ]
*: SkipByDesign
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == dart2js && $runtime == chrome ]

6
tests/kernel/kernel.status
View file

@ -12,15 +12,15 @@ unsorted/super_mixin_test: CompileTimeError
[ !$strong ]
unsorted/invocation_errors_test: RuntimeError
[ $builder_tag == strong && $compiler == dart2analyzer ]
*: Skip # Issue 28649
[ $compiler == dart2analyzer && $runtime == none ]
unsorted/invocation_errors_test: StaticWarning
unsorted/loop_test: CompileTimeError # int64
unsorted/simple_literal_test: CompileTimeError # int64
unsorted/super_mixin_test: CompileTimeError
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == dartk && $strong ]
unsorted/invocation_errors_test: CompileTimeError
unsorted/loop_test: RuntimeError

6
tests/language/language_analyzer2.status
View file

@ -398,9 +398,6 @@ vm/type_cast_vm_test: StaticWarning
vm/type_vm_test: StaticWarning
void_type_test: StaticWarning
[ $builder_tag == strong && $compiler == dart2analyzer ]
*: Skip # Issue 28649
[ $compiler == dart2analyzer && $runtime == none ]
arithmetic_test: CompileTimeError # int64
bit_operations_test/01: CompileTimeError # int64
@ -424,3 +421,6 @@ assertion_initializer_const_error2_test/none: Pass
[ $compiler == dart2analyzer && $runtime == none && !$checked ]
assertion_initializer_const_function_error_test/01: MissingCompileTimeError
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649

2
tests/lib/analyzer/analyze_library.status
View file

@ -25,7 +25,7 @@ lib/web_gl/dartium/web_gl_dartium: Skip # TODO: Remove Dartium
lib/web_sql/dart2js/web_sql_dart2js: CompileTimeError # Issue 16522
lib/web_sql/dartium/web_sql_dartium: Skip # TODO: Remove Dartium
[ $builder_tag == strong && $compiler == dart2analyzer ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == dart2analyzer && $use_sdk ]

6
tests/lib/lib.status
View file

@ -207,12 +207,12 @@ typed_data/setRange_2_test: Fail # Safari doesn't fully implement spec for Typed
typed_data/setRange_3_test: Fail # Safari doesn't fully implement spec for TypedArray.set
typed_data/setRange_4_test: Fail # Safari doesn't fully implement spec for TypedArray.set
[ $builder_tag == strong && $compiler == dart2analyzer ]
*: Skip # Issue 28649
[ $compiler == dart2analyzer && $checked ]
mirrors/regress_16321_test/01: MissingCompileTimeError # Issue 16391
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == dart2js && $mode == debug ]
mirrors/native_class_test: Pass, Slow

2
tests/standalone/standalone.status
View file

@ -30,7 +30,7 @@ verbose_gc_to_bmu_test: Skip
[ $builder_tag == swarming && $system == macos ]
io/*: Skip # Issue 30618
[ $compiler == dart2analyzer && ($builder_tag == strong || $strong) ]
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == dartk && $strong ]