srdjan@google.com
6a524865a1
Remove public int.is64Bit.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//1105453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45407 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 18:53:05 +00:00
rmacnak@google.com
327b85d956
Move symbol demangling to dart:_internal to remove dart:core dependency on dart:mirrors.
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1107613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45405 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 17:49:58 +00:00
pquitslund@google.com
a565470b1f
Bump analysis_server dep on args to >=0.13.0.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1108553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45402 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 17:09:07 +00:00
hausner@google.com
1890e567fe
Simplification in resolving classes
...
The helper functions in Parser to resolve classes in the library
and prefix scope created an unnecessary handlescope. With libraries
caching previous lookups, and with namespaces now using dictionaries,
there are just a handful (so to speak) of handles allocated for the
lookup. That does not warrant a handlescope. Removed the helper
functions.
R=asiva@google.com
Review URL: https://codereview.chromium.org//1087463005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45399 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 15:45:54 +00:00
danrubel@google.com
6237c8909f
add dart: and package: import uri suggestions
...
BUG=dartbug.com/23073
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1100393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45398 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 12:51:52 +00:00
kmillikin@google.com
f44f9c78ac
Support rethrow in the dart2js JS backend.
...
The approach is simple: translate rethrow to a throw of the enclosing
catch block's JS exception. There is already an assert that the JS
backend does not see rethrow at code generation time.
R=karlklose@google.com , floitsch@google.com
BUG=
Review URL: https://codereview.chromium.org//1094453006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45397 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 11:23:09 +00:00
scheglov@google.com
0cb3816eea
Fix for linked position offsets when insert directly before.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//1086273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45394 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 04:51:12 +00:00
scheglov@google.com
1fb5410c07
Issue 23271. Check target.staticElement for null.
...
Unable to reproduce and provide a test.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23271
Review URL: https://codereview.chromium.org//1098423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45393 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 04:47:06 +00:00
johnmccutchan@google.com
50ec92f8f2
Fix service rpc parameter validation
...
BUG=
Review URL: https://codereview.chromium.org//1052373010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45391 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 00:36:24 +00:00
johnmccutchan@google.com
583f48a132
Add crash dumps to service protocol and Observatory
...
- Add _getCrashDump RPC
- crash dump service response is map of request uris to responses, includes:
-- getVM
-- getFlagList
-- for each isolate:
-- getIsolate
-- _getAllocationProfile
-- getStack
- Add FakeVM to service library
- Add load crash dump to Observatory connect page
- Removes old chromium target support from connect page
- Make debugger page display stack even if libraries can't be loaded
- Fix reload of vm-connect page
- Fix polymer initialization calls
R=turnidge@google.com
Review URL: https://codereview.chromium.org//1100583006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45390 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 00:08:07 +00:00
nweiz@google.com
127f7e2a0b
Update args to 0.13.0.
...
See also https://codereview.chromium.org/1094793005 .
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//1103803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45389 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 23:42:54 +00:00
danrubel@google.com
b5e86ba441
switch -package-root to use PackageMapUriResolver
...
This change allows future code completion mods to consistently use the
SourceFactory.packageMap method to build a list of package uri import
suggestions.
BUG=dartbug.com/23073
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1107583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45387 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 23:06:13 +00:00
brianwilkerson@google.com
20a2f86f6b
Re-add missed files
...
Review URL: https://codereview.chromium.org//1102473006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45386 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 22:29:37 +00:00
regis@google.com
98ae5ba15a
Implement bigint shift intrinsics on arm.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//1087983009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45385 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 22:20:54 +00:00
brianwilkerson@google.com
3d536efcfe
Revert breaking change
...
Review URL: https://codereview.chromium.org//1101213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45384 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 22:12:20 +00:00
asiva@google.com
49d1dc7252
Address issue 13719, cleanup the status file to reflect reality.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//1085363005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45383 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:42:28 +00:00
brianwilkerson@google.com
24c853446a
Convert analyzer and analysis_server to use the plugin package
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1063153004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45382 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:32:35 +00:00
srdjan@google.com
70774b53fa
Fix flag —no-propagate-ic-data.
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//1107583003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45381 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:32:43 +00:00
pquitslund@google.com
2e544388e0
Changelog fixes.
...
R=brianwilkerson@google.com , nweiz@google.com
Review URL: https://codereview.chromium.org//1099563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45380 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:31:10 +00:00
turnidge@google.com
aa1363c2af
Update hack in test_helper.dart to handle new error message.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1063853006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45379 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 18:32:54 +00:00
turnidge@google.com
d9f65329c3
Do not JSON encode the 'result' of a service rpc.
...
Before a response looked like this...
{ result:<string> id:* }
...where result was always a json encoded string. This meant that
users of the service protocol had to json decode both the outer
message and the result, which was silly.
Now a response looks like this:
{ result:<map> id:* }
This means that users of the service protocol only need to decode once.
We have changed event formats as well. Previously, an event looked like this:
{ result:<string> }
(Essentially a result without an id.) The result was json encoded,
requiring the user to double-decode.
Now an event looks like this:
{ event:<map> }
This allows us to distinguish events from rpc results and avoids
double-decoding. It also avoids having an id-less rpc result mistaken
for an event.
------------
Some details and associated changes:
- Unify GCEvent and ServiceEvent in the VM.
- Move sequence number handling out of dart code and into JSONStream
in the VM. Plumbing. I needed to do this to avoid double-encoding.
Some of the dart code gets a bit simpler.
- Update C++ tests to have a sequence number.
- Change format of method/params used in Error responses to be more json-y.
- Strip out double decoding in the service lib.
- Improvements to tests. I was running into some races and other issues.
- Fail fast when we run into a message decoding problem. Instead of
returning a service exception, we now disconnect from the vm.
- VMDisconnected => ConnectionClosed.
- Add some support for a reason string when disconnecting from the vm
in the service library.
Review URL: https://codereview.chromium.org//1093043004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45378 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 17:55:08 +00:00
danrubel@google.com
1330c1f1ee
provide importUri for packages and include those suggestions
...
BUG=dartbug.com/23175
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1100213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45377 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 16:24:57 +00:00
pquitslund@google.com
6753963a1a
Analyzer version bump.
...
R=brianwilkerson@google.com , kevmoo@google.com
Review URL: https://codereview.chromium.org//1066003005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45375 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 15:47:37 +00:00
johnniwinther@google.com
1eea9e39d1
Deprecate ResolvedVisitor.visitOperatorSend.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1097943006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45374 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 13:52:50 +00:00
karlklose@google.com
adcdabdfd9
Update test expectations for native tests on dart2js-cps_ir.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1093893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45373 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 10:32:36 +00:00
lrn@google.com
b3ee3a85bf
Improve return type of markUnmodifiableList to JSArray instead of List.
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1076013006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45372 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 10:20:53 +00:00
karlklose@google.com
e8fa15c30a
Update dart2js-cps_ir test expectations.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1091143003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45371 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 08:40:49 +00:00
ajohnsen@google.com
ab6f8cc118
Make all of stdout/stderr/stdin pipes close-on-exec when spawing child processes.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1076093004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45370 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 07:37:53 +00:00
scheglov@google.com
a713fc0e01
Use package:test_reflective_loader instead of reflective_tests.
...
R=brianwilkerson@google.com
BUG=
Committed: https://code.google.com/p/dart/source/detail?r=45367
Review URL: https://codereview.chromium.org//1101003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45368 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 21:16:38 +00:00
scheglov@google.com
ab423fe70e
Use package:test_reflective_loader instead of reflective_tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1101003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45367 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 21:12:55 +00:00
regis@google.com
f40270798e
Add reference to existing issue in status file.
...
This test has to be skipped on dartium because the VMOptions line is ignored.
Review URL: https://codereview.chromium.org//1098343003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45366 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:58:52 +00:00
scheglov@google.com
9efb25fa50
Use package:test_reflective_loader instead of reflective_tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1101003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:54:29 +00:00
rmacnak@google.com
948e638dd8
Fix script-view. Hide annotations except the current position when debugging.
...
Review URL: https://codereview.chromium.org//1079163009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45364 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:49:33 +00:00
regis@google.com
2e2bcf6149
Use a breakpoint instruction for a stop message on arm instead of
...
a svc instruction (or hlt instruction on arm64).
The instructions svc and hlt are used in conjunction with a simulator only.
At least, gdb now stops on armv5te when hitting a stop message (no prompt).
Add support for printing stop message in disassembly on mips and arm64.
Clean up various bkpt codes on arm (now similar to arm64 and mips).
R=zra@google.com
Review URL: https://codereview.chromium.org//1097413004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45363 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:45:52 +00:00
pquitslund@google.com
49d0f16a2a
Analyzer CLI removal.
...
CLI now lives in dedicated `analyzer_cli` package.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1102613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45362 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:32:05 +00:00
pquitslund@google.com
434ba369f9
Driver fix to decouple from analyzer front-end deps.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1100943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45361 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:31:52 +00:00
danrubel@google.com
8f7079de3d
fix NSM in suggestions with importUri
...
BUG=dartbug.com/23302
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1088973008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45359 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:15:16 +00:00
brianwilkerson@google.com
b63a2e1d78
Add API for contributing to the index
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1060063008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45358 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:11:20 +00:00
hausner@google.com
ec56ffcc1d
Minor refactoring of local name resolution
...
Not much to see here, move along please.
R=asiva@google.com
Review URL: https://codereview.chromium.org//1096383005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45357 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 19:45:19 +00:00
brianwilkerson@google.com
8e6ccb391a
Rename IndexStore to avoid confusion with the new public API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1100673005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45356 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 19:40:45 +00:00
brianwilkerson@google.com
cb7e001db8
Add file missed in previous CL and comment clean-up
...
R=danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1084793006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45355 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 19:23:07 +00:00
koda@google.com
db58faa53e
Fix array allocation overflow check on arm/arm64/mips.
...
When adding an object size in bytes to the allocation top address,
we must check for *unsigned* overflow, not signed overflow. 32-bit example:
if top is 0xfffff000 and size is 0x1008, then top + size is an unsigned,
but not a signed, overflow.
Add similar unit test for typed data (same issue).
BUG=23254
R=regis@google.com
Review URL: https://codereview.chromium.org//1096063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45354 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 18:32:37 +00:00
alanknight@google.com
25c6f198f5
"Reverting 45351"
...
BUG=
Review URL: https://codereview.chromium.org//1097053006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45353 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 17:51:58 +00:00
rmacnak@google.com
e2c41789ee
Mirrors memory usage tweaks.
...
- Don't build and cache vestigial members/constructors maps.
- Avoid creating multiple LibraryMirrors for the same library.
- Store infrequently used method flags as a bitfield.
- Don't cache MethodMirror source.
mirrors_reader_test final heap size: 10.8 -> 8.9 MB (-17.5%)
mirrors_reader_test time: 1.55 -> 1.33 seconds (-14.2%)
R=asiva@google.com
Review URL: https://codereview.chromium.org//1080393006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45352 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 17:51:49 +00:00
alanknight@google.com
7431beaec2
appendHtml and insertAdjacentHtml should be consistently sanitized
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1081973003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45351 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 17:16:01 +00:00
floitsch@google.com
17ecf6b954
dart2js: Fix new emitter.
...
Review URL: https://codereview.chromium.org//1103523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45350 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 14:33:41 +00:00
danrubel@google.com
b0886e8c98
include importUri in out of scope suggestions
...
BUG=dartbug.com/23175
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1095113004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45349 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 14:31:46 +00:00
johnmccutchan@google.com
73fe0259ff
CPU profile displayed in three tables with a tree
...
Table #1 :
All functions sortable on inclusive or exclusive.
Table #2 :
Callers of focused function.
Table #3 :
Callees of focused function.
Tree:
Inclusive or Exclusive rooted profile tree filtered by focused function.
Also includes:
- Kill LinkLocationManager.
- Merge HashLocationManager into LocationManager.
- Kill nav-control element.
- Add goParameter to navigate based on page parameters (e.g. ?isolateId=...).
R=turnidge@google.com
Review URL: https://codereview.chromium.org//1013563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45348 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 14:05:20 +00:00
floitsch@google.com
eb20073478
dart2js: add compiler builtins to the core-runtime.
...
WIP.
R=johnniwinther@google.com , sra@google.com
Committed: https://code.google.com/p/dart/source/detail?r=45176
Reverted: https://code.google.com/p/dart/source/detail?r=45177
Review URL: https://codereview.chromium.org//954253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45347 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 13:44:39 +00:00
johnniwinther@google.com
19c838f3eb
Fix dart2dart new backend status.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1083093005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45346 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 13:20:48 +00:00