fschneider@google.com
3ec3e1bec2
VM: Fix potential bug in x64 inline cache stub.
...
A frame entered with EnterStubFrame, must be left with
LeaveStubFrame. It did not cause a crash since the inline cache stubs
don't load a new pool pointer, but leave PP unchanged and use the callers pp.
I checked other platforms - they already use LeaveStubFrame in the right places.
R=vegorov@google.com
Review URL: https://codereview.chromium.org//1089953004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45345 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 13:11:07 +00:00
johnniwinther@google.com
3fbdff8783
Add structural equality to ConstantExpression.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1050133006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45344 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 13:03:57 +00:00
lrn@google.com
a8036defab
Ensure that native function throws on bad argument instead of aborting.
...
Review URL: https://codereview.chromium.org//1072193006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45343 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 12:40:45 +00:00
johnniwinther@google.com
15b752f93f
Avoid use of deprecated in end2end_test.
...
BUG=
Review URL: https://codereview.chromium.org//1050133007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45342 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 12:26:09 +00:00
johnniwinther@google.com
cfc2e8017c
Deprecate ResolvedVisitor.visitTypeLiteralSend.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1097933004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45341 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 11:57:54 +00:00
kmillikin@google.com
7b8684f0a3
Change analyzer2dart's end2end test to match the backend's current behavior.
...
This current behavior is almost certainly not what we really want.
I've filed issue 23301 to track fixing it.
R=johnniwinther@google.com
BUG=23301
Review URL: https://codereview.chromium.org//1089853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45340 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 11:55:11 +00:00
johnniwinther@google.com
c467b33a6e
Refactor SourceMapBuilder to allow for post-processing.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1084573006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45339 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 11:23:11 +00:00
sgjesse@google.com
4d85e2a2aa
Revert "Fix warnings and hints in the SDK"
...
This reverts r45331.
TBR=lrn@google.com
BUG=
Review URL: https://codereview.chromium.org//1097353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45338 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 11:08:38 +00:00
kmillikin@google.com
ed699ec05d
Mark a dart2js test that fails in --use-cps-ir mode.
...
R=karlklose@google.com
BUG=
Review URL: https://codereview.chromium.org//1085913004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45337 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 11:08:39 +00:00
lrn@google.com
d44257439c
Don't rely on Function being callable in static analysis.
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1099233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45336 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 11:07:15 +00:00
kmillikin@google.com
4f7c1d3d54
Clean up handling of constants in the CPS backend.
...
Before: constant-valued expressions were usually compiled by the JS constant
compiler task, which surprisingly produces a Dart (not JS) constant.
After: use the already computed constant value of a constant-valued
expression. This is looked up in one of two ways depending on whether the
expression is an identifier or not. For primitive constants (Booleans,
doubles, integers, strings, and null) simply construct them as they have not
had a value computed.
Also, fix a variety of small bugs. In some case the fix is disabling an
incorrect code path and bailing out of the compiler.
BUG=
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1057483004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45335 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:59:03 +00:00
lrn@google.com
f139d0e93b
Add List.unmodifiable constructor.
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1056353004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45334 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:48:22 +00:00
fschneider@google.com
99f775103e
VM: Fix dissassembly output of stub code.
...
Make --disassemble-stubs works with multiple isolates.
Review URL: https://codereview.chromium.org//1098253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45333 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:45:17 +00:00
lrn@google.com
45718dff8b
Avoid checking Uint8List for non-Latin-1 characters.
...
Optimize checking code as well.
Remove some unused code.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1100873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45332 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:43:32 +00:00
sgjesse@google.com
f8eaff5b69
Fix warnings and hints in the SDK
...
BUG=
R=paulberry@google.com , sgjesse@google.com , whesse@google.com
Review URL: https://codereview.chromium.org//996683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45331 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:35:49 +00:00
floitsch@google.com
6594a922d5
Mark dart2js/exit_code_test as slow.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//1090273007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45330 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:09:29 +00:00
johnniwinther@google.com
bd10ba7f11
Refactor visitOperatorSend to used SemanticSendVisitor methods.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1095113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45329 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 09:23:17 +00:00
karlklose@google.com
9e154bc62a
Allow access to type variables as expressions in factory constructors.
...
BUG= http://dartbug.com/22700
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1100073002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45328 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 09:11:14 +00:00
ricow@google.com
7ac466315e
Add utility function for getting increasing numbers in a git only world.
...
The numbers will be used for archiving purposes, so that we have a standard way of calculating a location, that will sort in increasing order of commits.
For dev/stable channel builds we will move to use the version number instead.
R=sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1050823006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45327 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 04:01:44 +00:00
rmacnak@google.com
529993214f
Fix missing annotations in script inset when first annotation is outside the subset of lines being displayed.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1057793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45326 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 00:42:55 +00:00
sigmund@google.com
e770481ab8
Fix also analyzer2dart
...
TBR=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1100853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45325 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 00:23:00 +00:00
sra@google.com
00dde387ab
Improve CssClassSet add / remove
...
Allow the 'contains' call to be removed if the result is unused.
DivElement bars = new DivElement()
..classes.add('pipeline-bars');
-->
t3 = document.createElement("div", null);
list = t3.classList;
list.contains("pipeline-bars");
list.add("pipeline-bars");
-->
t3 = document.createElement("div", null);
t3.classList.add("pipeline-bars");
R=sigmund@google.com
Review URL: https://codereview.chromium.org//1092553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45324 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 22:48:12 +00:00
sigmund@google.com
41a675b771
Fix other tests in 'try' after elementvisitor changes
...
TBR=sra@google.com ,johnniwinther@google.com
Review URL: https://codereview.chromium.org//1056133008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45323 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 22:23:39 +00:00
pquitslund@google.com
4c03f25626
Analyzer build updates to use analyzer_cli.
...
The associated change to add analyzer_cli to DEPS is here:
https://codereview.chromium.org/1093173004/
R=brianwilkerson@google.com , paulberry@google.com , ricow@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//1100553003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45321 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 20:59:31 +00:00
johnmccutchan@google.com
0afab79fde
Skip coverage test on Windows
...
BUG=
Review URL: https://codereview.chromium.org//1099953003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45319 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 20:10:13 +00:00
sigmund@google.com
3b57a3d8b7
Fix test in try affected by refactor
...
TBR=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1079523004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45317 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 17:40:46 +00:00
hausner@google.com
21ca62f8bc
Properly resolve top-level setters
...
Fixes issue 4386.
When converting a getter to a setter (converting a right-hand
side expression to a left-hand side, assignable entity),
we need to know where to look for the setter function.
Top-level setters need to be resolved in the library or prefix
scope in which the getter was found.
R=regis@google.com
Review URL: https://codereview.chromium.org//1090373006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45316 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 17:36:34 +00:00
sigmund@google.com
667173800b
Visit arguments of invalid TypeLiteralSends during inference
...
BUG= http://dartbug.com/23264
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1081873005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45315 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 15:36:22 +00:00
johnniwinther@google.com
1ef811ab2b
Refactor DartTypeVisitor and ElementVisitor.
...
This enables more patterns of use.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1093363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45314 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 13:46:58 +00:00
sgjesse@google.com
170be8d7d1
Process outstanding events before making a new HTTP client request
...
This re-applies r45127, which was reverted in r45129. The revert was due
to a failing test which is re-written here to perform the separate steps
in a deterministic order.
Original change description:
This fixes the issue of using a HTTP client connection from the
connection pool which was closed and where the close indication has
already been received by the event handler.
This specifically fixes the 'pub get' issue where a long running
constraint resolver would end with the error "Connection closed before
full header was received"
Retrying GET methods when the connection is closed after succesfuly
sending (parts of) the request is still missing.
R=lrn@google.com
BUG=http://dartbug.com/21798
Review URL: https://codereview.chromium.org//1055943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45313 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 12:14:55 +00:00
johnniwinther@google.com
af8a0dcdca
Add SourceInformationFactory.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1100723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45312 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 12:07:51 +00:00
sra@google.com
b840a38c69
CHANGELOG entry for CssClassSet
...
BUG=
Review URL: https://codereview.chromium.org//1096223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45310 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 05:09:53 +00:00
sra@google.com
f1ab388015
Rewrite for-in loop on JavaScript indexable arrays as indexing loop
...
for (E variable in a) <body>
is generated as:
_end = a.length;
for (_i = 0; _i < a.length; a.length == _end || (0, H.throwConcurrentModificatiionError)(a), ++_i) {
variable = a[_i];
<body>;
}
or, when the list is known to be fixed length:
for (_i = 0; _i < a.length; ++_i) {
variable = a[_i];
<body>;
}
R=floitsch@google.com
Committed: https://code.google.com/p/dart/source/detail?r=45270
Reverted: https://code.google.com/p/dart/source/detail?r=45271
Review URL: https://codereview.chromium.org//1087973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45309 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 03:13:36 +00:00
regis@google.com
2b3abd61d8
Make build green by skipping debug break test on Dartium and friends (will
...
investigate later).
Review URL: https://codereview.chromium.org//1092373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45308 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 01:42:52 +00:00
sra@google.com
904c18efcc
Enforce token syntax for CssClassSet arguments
...
Committed: https://code.google.com/p/dart/source/detail?r=45265
Reverted: https://code.google.com/p/dart/source/detail?r=45266
R=terry@google.com
Committed: https://code.google.com/p/dart/source/detail?r=45301
Committed: https://code.google.com/p/dart/source/detail?r=45303
Reverted: https://codereview.chromium.org/1096433006/
Review URL: https://codereview.chromium.org//1077203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45307 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 01:32:49 +00:00
sra@google.com
736007062a
Revert "Enforce token syntax for CssClassSet arguments"
...
TBR=terry@google.com
BUG=
Review URL: https://codereview.chromium.org//1096433006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45306 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 01:14:32 +00:00
rmacnak@google.com
11d54fd84f
Reapply "Add tests for evalutating against activation records."
...
Also kill the testee if the tester has an exceptions running its tests.
BUG=http://dartbug.com/20047
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1099663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45305 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 01:13:59 +00:00
johnmccutchan@google.com
52022c23fd
Do not register service isolate descendants for debugging
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1096173005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45304 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 01:10:54 +00:00
sra@google.com
a1850bb69a
Enforce token syntax for CssClassSet arguments
...
Committed: https://code.google.com/p/dart/source/detail?r=45265
Reverted: https://code.google.com/p/dart/source/detail?r=45266
R=terry@google.com
Committed: https://code.google.com/p/dart/source/detail?r=45301
Review URL: https://codereview.chromium.org//1077203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45303 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 00:37:10 +00:00
sra@google.com
ec484da9f6
Revert "Enforce token syntax for CssClassSet arguments"
...
Review URL: https://codereview.chromium.org//1098073003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45302 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 00:25:54 +00:00
sra@google.com
01d3e99f18
Enforce token syntax for CssClassSet arguments
...
Committed: https://code.google.com/p/dart/source/detail?r=45265
Reverted: https://code.google.com/p/dart/source/detail?r=45266
R=terry@google.com
Review URL: https://codereview.chromium.org//1077203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45301 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 23:44:11 +00:00
regis@google.com
240c208462
Add a separate test verifying that the optimizer does not trip over debug break.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//1091133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45300 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 23:19:58 +00:00
sra@google.com
1b2296c2be
getElementsByName returns HtmlCollection on IE
...
Review URL: https://codereview.chromium.org//1093243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45299 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 22:23:08 +00:00
sra@google.com
55372e4678
t # Enter a description of the change.
...
Revert "getElementsByName returns HtmlCollection on IE"
TBR=terry@google.com
BUG=
Review URL: https://codereview.chromium.org//1098953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45298 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 21:48:30 +00:00
brianwilkerson@google.com
4e0bb57118
Update specification version number
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1096693006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45297 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 21:07:29 +00:00
brianwilkerson@google.com
4422b7c01e
Fix error handling for formatting and update the spec
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1099633004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45296 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 20:57:33 +00:00
sra@google.com
44ea26b4fb
getElementsByName returns HtmlCollection on IE
...
This CL will be committed and reverted to sniff out test status changes (some very small tests will start passing)
TBR=terry@google.com
Review URL: https://codereview.chromium.org//1093243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45295 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 20:16:24 +00:00
keertip@google.com
aff5c67bda
add the api_readme file to the sdk build
...
Review URL: https://codereview.chromium.org//1085103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45294 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 19:28:38 +00:00
brianwilkerson@google.com
1fa696f64d
Initial version of completion plugin API
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1095143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45293 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 17:44:41 +00:00
asiva@google.com
ec55c135c5
Fix check for return of error before calling SyncDirectoryListing.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//1096803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45292 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 17:23:10 +00:00