Commit graph

31263 commits

Author SHA1 Message Date
ricow@google.com 7c0a00cf0c Remove gyp entries for editor and java based analyzer
Also, remove some editor specific tools and remove support from annotated steps

R=kustermann@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1130963003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45630 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 06:44:51 +00:00
ricow@google.com a29715af79 Add --dry option to the promote script.
This makes it easier to validate against our archive

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//1132533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45627 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 05:44:55 +00:00
sra@google.com 6ab9b2ceb2 Optimize DateTime properties
Several small pieces fit together to improve calendar arithmetic code in a customer's app.

1. Mark DateTime primitives that return small integers as returning uint31.

2. uint31 + uint31 -> uint32 in type inference.

3. uint32 / N can be generated as (uint32 / N) | 0 when N >= 2.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45621

Review URL: https://codereview.chromium.org//1106443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45625 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 00:52:29 +00:00
paulberry@google.com 728e9b3a9e Create a task in the new task model to compute constant dependencies.
This is the first of several planned tasks for constant evaluation.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1131953004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45624 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 00:36:45 +00:00
brianwilkerson@google.com ed28cd5969 Progress toward new AnalysisContextImpl
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1136673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45623 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 23:19:46 +00:00
nweiz@google.com d3bff0054f Fix an invalid variable name in DependencyQueue.
Also fix an analysis hint.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1126263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45622 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 21:51:54 +00:00
sra@google.com 532a7948d8 Optimize DateTime properties
Several small pieces fit together to improve calendar arithmetic code in a customer's app.

1. Mark DateTime primitives that return small integers as returning uint31.

2. uint31 + uint31 -> uint32 in type inference.

3. uint32 / N can be generated as (uint32 / N) | 0 when N >= 2.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1106443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45621 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 21:39:17 +00:00
scheglov@google.com 194d48f9da Set CacheEntry.target in the contructor.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1135613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45619 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 21:04:51 +00:00
scheglov@google.com 47df8674d1 Remove unused AnalysisContextImpl.findElementById().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1132623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45618 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 21:02:23 +00:00
scheglov@google.com 61a371476b Remove unused InternalAnalysisContext.addSourceInfo().
The analysis cache is now accessible, if we will ever need this feature again.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1131063004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45616 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 20:17:13 +00:00
scheglov@google.com 1ccf10f617 Some clean ups for cache partitions.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1130263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45615 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 20:15:49 +00:00
floitsch@google.com 90759b7299 pub: don't start the admin server if no --admin-port flag was given.
`pub serve` used to bind its admin port to the port below the main port. For example `pub serve --port=8081` would automatically bind its admin port to 8080.
With this change the admin server is only started if an --admin-port flag was provided.

BUG= http://dartbug.com/20922
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1126403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45614 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 20:01:51 +00:00
brianwilkerson@google.com 9414515ba7 Remove CompositeResultDescriptor
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1136603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45613 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 20:00:49 +00:00
nweiz@google.com 05e6d1cf78 Convert a bunch of version solver code to use async/await.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1125373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45612 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:50:38 +00:00
paulberry@google.com 7040257579 Store elements in the constant eval dependency graph rather than AST nodes.
This paves the way for constant evaluation to be integrated into the
new task model, since the new tasks for constants will use elements as
their targets.

Since the element model makes a distinction between constructor
members and constructor elements, we have to be careful to be
consistent about what kinds of elements are stored in the dependency
graph.  We always store constructor elements in the dependency graph.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1129143003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45611 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:38:37 +00:00
scheglov@google.com 1bc667b086 Flush memento objects.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1129173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45610 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:36:04 +00:00
scheglov@google.com 9aeccc0d2f Get AnalysisCache from InternalAnalysisContext.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1124113004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45609 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:12:42 +00:00
scheglov@google.com 11f96844dc When invalidate because of the ERROR state, propagate its exception.
I have to move invalidation implementation into CacheEntry, because we need to set the "exception" field value.
Should we also move "setDependedOnResults" and make ResultData a dumb data container?

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1126793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45608 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:10:27 +00:00
brianwilkerson@google.com 965ac274f6 Clean-up result descriptors
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1131983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45607 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:10:14 +00:00
srdjan@google.com e47ecf48c0 Eagerly create local var descriptors for artificially created methods (they cannot be regularly parsed).
R=hausner@google.com

Review URL: https://codereview.chromium.org//1133633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45606 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 19:04:28 +00:00
scheglov@google.com 4f04a6cf2e Don't update offsets for elements of 'part' and 'part of' directives.
These elements are not defined in the source that references it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1131053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45605 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 18:34:19 +00:00
brianwilkerson@google.com e8c5b87478 Get computeError working
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1130763003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45604 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 18:30:40 +00:00
johnmccutchan@google.com 655545c881 Only add -lrt on Linux, not on Mac
BUG=

Review URL: https://codereview.chromium.org//1127273008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45603 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 17:40:01 +00:00
asiva@google.com b5336c5726 Unify processing of Keywords and predefined symbols in the same loop and add accessors for keyword symbol handles.
R=hausner@google.com

Review URL: https://codereview.chromium.org//1130843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45602 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 17:28:02 +00:00
sigmund@google.com d0002db5ed Avoid reparsing metadata expressions
BUG= http://dartbug.com/23404
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1126423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45600 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 17:07:04 +00:00
scheglov@google.com 8152e8c970 Use AbstractContextTest for AnalysisContextImplTest.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1124053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45599 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 16:58:14 +00:00
regis@google.com 52b19e2b14 Make sure the bound of a mixin type parameter is finalized before instantiating
it during finalization (fix issue 23385).
Print more info in ToCString() for an unresolved type.

Review URL: https://codereview.chromium.org//1124253004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45598 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 16:08:11 +00:00
scheglov@google.com a3366361de Cache flushing implementation for the task model.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1133513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45597 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 15:50:13 +00:00
brianwilkerson@google.com 2a1657d467 Fix methods for getting source kind
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1131853003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45596 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 15:32:41 +00:00
het@google.com b362e51596 Update angular deps to e30ad2ec2c7cf75c3bfc8823a305c967a1a507a4
BUG=

Review URL: https://codereview.chromium.org//1133643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45595 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 15:29:31 +00:00
paulberry@google.com 4bbe16a115 Ensure that nulls aren't added to constant eval dependency graph.
In r45541, I accidentally left out a null check causing nulls to get
inserted into the constant evaluation dependency graph.  This caused a
log message to be printed when running the command-line analyzer, but
no test failures.

I've inserted the proper null check and added an assert statement so
that if the bug recurs it will be caught during testing.

BUG=dartbug.com/23407
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1133623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45594 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 14:41:56 +00:00
johnniwinther@google.com f238761664 Improve resolution/codegen separation invariant.
BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1126163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45593 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 13:30:05 +00:00
brianwilkerson@google.com 654c4b4675 More renames
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1126353004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45592 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 13:19:04 +00:00
johnniwinther@google.com 065b2163e3 Differentiate between unresolved class and constructor.
BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1130773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45591 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 13:02:49 +00:00
ricow@google.com 568a551386 Fix test_suite.dart
Missing semicolon

TBR=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//1127423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45590 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 12:50:05 +00:00
johnmccutchan@google.com 95064c2d0d Fix Observatory rebuild
BUG=

Review URL: https://codereview.chromium.org//1133603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45589 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 12:45:33 +00:00
ricow@google.com e92f697236 Remove dart2dart support from testing scripts and status files
I will leave it to the dart2js people to remove the support from the dart2js tools (there is also a bunch of comments still in code, do a git grep)

R=kustermann@google.com, floitsch@google.com, kmillikin@google.com
BUG=

Review URL: https://codereview.chromium.org//1126363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45588 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 11:29:55 +00:00
ricow@google.com fb7f171a0e Remove promote script from editor/build and put it under tools (where it really belongs)
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//1133573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45587 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 10:52:01 +00:00
lrn@google.com 4d539e4975 Fix typo in EfficientLengthIterable documentation, and improve it slightly.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//1132503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45586 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 10:18:36 +00:00
herhut@google.com 38af8ac50a Improve documentation for MirrorsUsed.
BUG= http://dartbug.com/15656
R=floitsch@google.com, kathyw@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//1122983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45585 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 09:08:11 +00:00
srdjan@google.com ba038822fb Reenable eager local var descriptors until issue with one test resolved.
Review URL: https://codereview.chromium.org//1130133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45584 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 06:33:56 +00:00
srdjan@google.com ace53da9b7 FIxed 'typo', enabled lazy var descriptors generation again.
Review URL: https://codereview.chromium.org//1130963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45583 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 05:34:44 +00:00
srdjan@google.com fef4e08b75 Fix breakage by disabling lazy local var descriptors.
Review URL: https://codereview.chromium.org//1133523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45582 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 04:31:31 +00:00
srdjan@google.com 3744661bc4 Lazily generate local var descriptors.
R=hausner@google.com

Review URL: https://codereview.chromium.org//1128803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45581 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 04:16:50 +00:00
het@google.com acfd54f53a Report malformed URIs in library dependencies as errors.
For instance: "import '../../Udyn[mic ils/expect.dart';" used to cause an internal compiler error. The error is now caught and the compiler reports the invalid import.

BUG=http://dartbug.com/23228
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1131593006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45580 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 00:11:47 +00:00
brianwilkerson@google.com 1124eaacd8 Rename EMPTY_ARRAY to EMPTY_LIST
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1127183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45579 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-06 23:47:59 +00:00
alanknight@google.com dd9150542d Keep dart:debugger comments in sync
BUG=
R=johnmccutchan@google.com, skybrian@google.com

Review URL: https://codereview.chromium.org//1130043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45578 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-06 23:14:38 +00:00
alanknight@google.com 6fe25b0578 Provide a dart2js implementation of dart:debugger
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1121293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45577 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-06 22:36:01 +00:00
johnmccutchan@google.com 37feb0c855 Add embedded_dart_io source_set for Sky
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1124193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45576 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-06 21:36:15 +00:00
sra@google.com ac0f1ade9e Recognize unmodifiable lists
Add a new type, JSUnmodifiableArray, that is the type returned by
List.unmodifiable and the type of const list literals.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1126063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45575 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-06 21:25:25 +00:00