languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity
41547 commits 11 branches 6011 tags 1.4 GiB
Commit graph

41547 commits

This branch
This branch
All branches
Author SHA1 Message Date
Konstantin Shcheglov
36d737008f Don't use actual dependency walker in pub summaries. 
We already pre-check transitive dependencies, so we know which nodes
can be linked, and can use just a single link() invocation.

The code is slightly worse, because I stuffed several more operations
into getLinkedBundles(), but either this, or passing several parameters
around :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2375383004 .
 2016-09-29 10:30:35 -07:00
Konstantin Shcheglov
9a44ee9b41 Clean up Bazel provider, still only unlinked. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2379563004 .
 2016-09-29 08:39:02 -07:00
John McCutchan
1937854112 Only collect 1 stack trace when a test timeouts on mac 
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2383553002 .
 2016-09-29 08:30:48 -07:00
Lasse R.H. Nielsen
9bd4406d4b Fix bug in _SimpleUri.resolve. 
In some cases it didn't follow our non-RFC behavior for resolving a relative
path on top of another relative path.

Fixes issue #27447
BUG= http://dartbug.com/27447
R=eernst@google.com

Review URL: https://codereview.chromium.org/2374253004 .
 2016-09-29 15:00:42 +02:00
William Hesse
2ca7ae5e0e Update webkit in Dartium to fix build problem 
BUG=https://github.com/dart-lang/sdk/issues/27442
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2381923002 .
 2016-09-29 14:15:20 +02:00
William Hesse
c20e2a0883 Update pub, making --packages-dir false by default 
BUG=https://github.com/dart-lang/sdk/issues/27399
BUG=https://github.com/dart-lang/pub/issues/1450
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2374143005 .
 2016-09-29 14:01:13 +02:00
Lasse R.H. Nielsen
9e032f493d Add documentation to the mixin superclass requirement description. 
Fixes issue #25312
BUG= http://dartbug.com/25312
R=eernst@google.com

Review URL: https://codereview.chromium.org/2375913002 .
 2016-09-29 10:24:35 +02:00
John Messerly
5c9e12497e fix #27135 and fix #27449 strong mode does not use propagated types 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2380863003 .
 2016-09-29 00:14:07 -07:00
John Messerly
d614c8dcd4 fix #27410, subtype should not use DartType.== 
This should improve performance of subtype tests & simplify things, as we are not recursing structurally over the types multiple times.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2381773002 .
 2016-09-29 00:11:33 -07:00
Ryan Macnak
e1a252a017 Fix a throw returning to a frame marked for lazy deopt that captures the stacktrace. 
A lazy deopt via a return needs to preserve one value (the result), but via a throw needs to preserve two values (the exception and stacktrace).

Fixes #27446.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2374273002 .
 2016-09-28 16:51:45 -07:00
Ryan Macnak
82ec8d6c9e Omit unreachable fall through code for graph intrinsics, e.g. Array.length. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2371133004 .
 2016-09-28 16:38:03 -07:00
Florian Schneider
fc50f7ad01 VM: Fix NoSuchMethod invocation interrupted by shutdown. 
When shut down while processing a NoSuchMethod invocation in the runtime,
we forgot to check for an error result after allocating the invocation mirror.

BUG=#26588
R=zra@google.com

Review URL: https://codereview.chromium.org/2380583003 .
 2016-09-28 14:52:15 -07:00
Konstantin Shcheglov
99d88531f3 Rename _LinkedNode to _LinkNode in pub summary manager. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2381673002 .
 2016-09-28 13:46:55 -07:00
Konstantin Shcheglov
82fc169e7e Fix FunctionTypeAliasElementForLink.enclosingUnit type. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2378873002 .
 2016-09-28 13:45:22 -07:00
John McCutchan
e434d3daab Attempt to print the stack traces of hung test processes on MacOS. 
/usr/bin/sample is a standard tool installed on all MacOS machines.

BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2371383005 .
 2016-09-28 13:39:54 -07:00
Konstantin Shcheglov
3f6afd8cf5 Add tests for resolveRelativeUri() and a workaround. 
The actual problem should be fixed in SDKs Uri implementation.
https://github.com/dart-lang/sdk/issues/27447

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2376073003 .
 2016-09-28 13:20:26 -07:00
Zachary Anderson
3b6f3f3969 Roll buildtools forward and fix GN build for it. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2378223002 .
 2016-09-28 13:03:47 -07:00
Ryan Macnak
e3420eab29 Revert "Pass new pool pointer to the JumpToException stub instead of reloading in through the frame's Code object." 
This reverts commit 3413e052b3.

Review URL: https://codereview.chromium.org/2374173002 .
 2016-09-28 13:00:00 -07:00
John McCutchan
1b5533fe8f Use a larger sleep time in get_allocation_profile_rpc_test so that the test doesn't flake on Windows 
Fixes #27444

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2378813002 .
 2016-09-28 12:45:02 -07:00
Harry Terkelsen
a56cf2cac4 Some kernel->ssa cleanups. 
* add --disable-inlining flag to top-level command for testing
* merge pushCheckNull into GraphBuilder now that compiler is in there
* fix typo

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2378113004 .
 2016-09-28 12:39:59 -07:00
Kevin Moore
f7e6c02e22 Document thrown errors during function parsing 
Other cleanup
Closes https://github.com/dart-lang/sdk/issues/27376

R=whesse@google.com

Review URL: https://codereview.chromium.org/2368413003 .
 2016-09-28 11:35:45 -07:00
Vijay Menon
6144c10409 Fix analyzer error 
Analyzer was complaining that final field was not set.  The other constructor
does set, so doing so here as well.  We may be able to remove this flag soon,
but I see downstream uses.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2382463002 .
 2016-09-28 10:21:15 -07:00
Harry Terkelsen
71613d72a8 kernel->ssa: implement for-in loops 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2377813002 .
 2016-09-28 10:20:26 -07:00
Ryan Macnak
3413e052b3 Pass new pool pointer to the JumpToException stub instead of reloading in through the frame's Code object. 
This is prep work for lazy deopt without code patching.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2376843002 .
 2016-09-28 10:15:09 -07:00
Vijay Menon
68d2121fd0 Use .packages instead of pubspec.yaml 
This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204

R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2371113004 .
 2016-09-28 09:49:31 -07:00
Martin Kustermann
9195014572 Fix off-by-one issue in clustered snapshot implementation and api impl 
R=rmacnak@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org/2381573002 .
 2016-09-28 18:46:26 +02:00
pq
b681fc5a44 Add ABSTRACT_SUPER_MEMBER_REFERENCE to error code enum. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2376623003 .
 2016-09-28 09:26:05 -07:00
Lasse R.H. Nielsen
b98484fbc1 Fix spec reference to non-existing mirrors method. 
Fixes #25549
BUG= https://dartbug.com/25549
R=eernst@google.com

Review URL: https://codereview.chromium.org/2381483002 .
 2016-09-28 13:38:14 +02:00
Lasse R.H. Nielsen
9487e107bb Address shortcomings in documentation on Isolate class. 
Addresses issued #26597 and #26627.

BUG= http://dartbug.com/26597 http://dartbug.com/26627
R=eernst@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org/2062683002 .
 2016-09-28 10:42:06 +02:00
Lasse R.H. Nielsen
debbf68223 Fix bug effectively stating that 1e8 is an integer literal, not a double. 
Fix typo in spec - uses `/` when intending division by zero error.

Fixes issues #26053, #27279

BUG= http://dartbug.com/26053, http://dartbug.com/27279
R=eernst@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org/2370853004 .
 2016-09-28 09:51:10 +02:00
Konstantin Shcheglov
536f53f0ef Initial version of Bazel SummaryProvider. 
Only request for a single consistent unlinked package is implemented.

Searching for consistent set of linked packages is to be implemented yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2376833002 .
 2016-09-27 17:33:26 -07:00
Chinmay Garde
b29788329b Update vm/BUILD.gn to account for stricter GN warnings. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2369143005 .
 2016-09-27 16:16:11 -07:00
Siva Annamalai
e8a9a06528 Fix status file for debugger_location_test. 
BUG=

Review URL: https://codereview.chromium.org/2371283002 .
 2016-09-27 15:51:58 -07:00
Konstantin Shcheglov
3647e7bac0 Order suggested Quick Fix imports: direct, export, non-API. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2377803002 .
 2016-09-27 15:03:26 -07:00
Florian Schneider
add88f4ee3 Fix too strict debug assertion in disassembler. 
When printing function objects to JSON, we still allocate
temporary strings on the Dart heap.

BUG=

Review URL: https://codereview.chromium.org/2372973003 .
 2016-09-27 14:19:35 -07:00
Siva Annamalai
8e92c5e6da Skip failing test under asan (see issue 27441) 
BUG=

Review URL: https://codereview.chromium.org/2372713006 .
 2016-09-27 13:26:43 -07:00
John McCutchan
2ed4f4725a Status file tweak 
BUG=

Review URL: https://codereview.chromium.org/2377743002 .
 2016-09-27 13:02:39 -07:00
Florian Schneider
4bd534191a VM: Avoid allocating strings when disassembling code. 
For code objects, don't allocate symbol strings when printing the disassembly.

Don't try to make disassembling work with background compilation -- instead make sure that we don't allocate on the Dart heap while disassembling.

Add NoSafepointScope around disassemble functions to assert that no allocation happens.

Also, remove some dead code from object.cc.

BUG=#27430
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2363413004 .
 2016-09-27 12:43:05 -07:00
Ryan Macnak
d9311af50b Appease TSAN regarding data race in profiler debug counters. 
BUG=b/31767249
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2376753002 .
 2016-09-27 12:27:37 -07:00
John McCutchan
a7fe93b62c Also dump a stack trace on a pthread assertion failure 
Recently on the build bots we hit a pthread_error (https://build.chromium.org/p/client.dart/builders/vm-linux-debug-x64-reload-be/builds/337/steps/vm%20tests/logs/stdio)
 but that code uses a different ASSERT macro so we don't get to see the stack trace.

BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2372703006 .
 2016-09-27 11:16:28 -07:00
John McCutchan
52f9fac257 Split debugger_location_test into two separate tests 
Fixes #27434

R=asiva@google.com

Review URL: https://codereview.chromium.org/2376433003 .
 2016-09-27 10:59:46 -07:00
William Hesse
0f0bd64ca4 Commit observatory's pubspec.lock to the repo 
It is no longer generated, since we have checked in .packages rather
than generating it.  Pub build requires it to be there.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2371933004 .
 2016-09-27 14:04:47 +02:00
Johnni Winther
06d7fb2fc5 Replace ClosedWorld.backend with ClosedWorld.backendClasses 
R=het@google.com

Review URL: https://codereview.chromium.org/2370833002 .
 2016-09-27 10:33:51 +02:00
Johnni Winther
a1cd695612 Move remaining functionality from ClassWorld to ClosedWorld 
... and rename ClassWorld to World.

R=het@google.com

Review URL: https://codereview.chromium.org/2366363002 .
 2016-09-27 10:23:03 +02:00
Siva Annamalai
ce596133ad Skip service/debugger_location_test see Issue 27434. 
BUG=

Review URL: https://codereview.chromium.org/2370193002 .
 2016-09-26 21:15:45 -07:00
Siva Annamalai
bb02e814dc Skip string_literals_test (see Issue 27433) 
BUG=

Review URL: https://codereview.chromium.org/2377563002 .
 2016-09-26 21:03:27 -07:00
Florian Schneider
7ca3da1a3a Fix lazy deoptimization in the presence of exceptions 
Catch block entries need to be considered when doing lazy deoptimization.

In addition to the return, also patch all catch entry blocks in a function scheduled for lazy deoptimization.

Also, move restoring the pool pointer to the jump-to-handler stub to simplify patching the catch entry.

BUG=#27419
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2357343003 .
 2016-09-26 16:24:23 -07:00
Ryan Macnak
f2a5c7157c Prefer loading Smi 0 instead of null into a runtime call result slot. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2371983002 .
 2016-09-26 15:40:45 -07:00
Brian Wilkerson
9b882521e2 Move error codes and clean-up 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2370813003 .
 2016-09-26 13:26:26 -07:00
Konstantin Shcheglov
ef015221b1 Catch exceptions while preparing analysis.implemented notification. 
This notification is sent often, and uses index and search engine. We
have several exceptions in internal logs, and all there exceptions are
fatal by default. It seems too harsh to shutdown the server because of
a missing notification.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2376493002 .
 2016-09-26 12:54:33 -07:00