languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 04:06:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
84645 commits 11 branches 6011 tags 1.4 GiB
Commit graph

84645 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ryan Macnak 2d530c1556 [infra] Upload RISCV64 SDK. 
gclient sync will need a prebuilt SDK on RISCV64 hosts.

Bug: https://github.com/dart-lang/sdk/issues/48545
Change-Id: I90358d27c66e1ec8228419ae0fa463c98e2cb5e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237627
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2022-03-30 22:18:50 +00:00
Ben Konyi d087f0334d [ DDS ] Fix devtools_server tests on Windows 
Fixes https://github.com/dart-lang/sdk/issues/48528

Change-Id: Iaa08d6ee409354eadc37d3beb98ea79b75575758
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239464
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-30 20:45:20 +00:00
Chloe Stefantsova d5c9f086e3 [cfe] Add DillConstructorBuilder to super parameters inference 
Part of https://github.com/dart-lang/sdk/issues/47525

Change-Id: If88bf24dffa79e214e49b5133ee8314bbdb53716
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239426
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2022-03-30 20:35:20 +00:00
Nicholas Shahan ba4e18b531 [ddc] Remove more diffs with pkg/js_ast 
- Remove lint ignores and cleanup violations when they are either
  in code that doesn't exist in or are already fixed in the pkg/js_ast
  version.
- Migrate the builder_test.dart (the small test file).

Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I1083235de93f028e5f338180b97308f52a45f17f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239363
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2022-03-30 19:53:30 +00:00
Sam Rawlins 31dbdd4acf Allow excluding pubspec.yaml and analysis_options.yaml 
Bug: https://github.com/dart-lang/sdk/issues/48683
Change-Id: Icb4ac24c37bfa91b4dd8612d2783c6fdcc663106
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-30 19:17:30 +00:00
Ryan Macnak f2d3051598 [vm] Some pieces for Windows ARM support. 
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/47824
Change-Id: Iaf401f4d25fc5bf171170728d4a5d3ae6ef17527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239369
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2022-03-30 19:01:33 +00:00
Alexander Markov b55dc762fa [benchmarks] Add micro-benchmark for async/await with live variables 
Issue: https://github.com/dart-lang/sdk/issues/48594
Issue: https://github.com/dart-lang/sdk/issues/48378
Change-Id: Ib5bd65c149342bb5d9bb2b5176a4a3b968a08a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238980
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2022-03-30 18:25:00 +00:00
Konstantin Shcheglov 5234076fbe Tweaks for MessageGrouper. 
Change-Id: I1be1d7e998ee28414a455816383e5d0810d4ad9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239403
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-30 17:42:10 +00:00
Ryan Macnak 8a280c90f9 [build] -fno-strict-vtable-pointers is a Clang-only flag. 
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/48703
Change-Id: I76dc6abe2ad709b5ae6c9df31db5174774b8ae9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239324
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2022-03-30 17:34:20 +00:00
Paul Berry 05f50c7d44 Add a piece of analyzer/CFE shared infractructure for language issue 731. 
This algorithm will form a piece of the solution to
https://github.com/dart-lang/language/issues/731 (improved inference
for fold etc.).  In particular, when performing generic type inference
on an invocation where more than one argument is a closure, it will
determine the order in which type inference should visit the closures
to maximize the chances of producing meaningful assignments of types
to type parameters.

Change-Id: Ifc2202cb713965373981574f276dffbf1b3f48c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239364
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-03-30 17:28:34 +00:00
Konstantin Shcheglov 9ab676b6d0 Migrate analysis domain tests to PubPackageAnalysisServerTest. 
Change-Id: I684d027906b118d2c0fddd8f64930ae291ed8827
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-30 17:01:00 +00:00
Joshua Litt 856fcb9c8c [dart2wasm] Add experimental JS interop API for dart2wasm. 
This is a fork of `js_util` to support the needs of Wasm. It is very
much a WIP. We're landing this now to facilitate prototyping, and so we
can get a sense of what the right JS interop API might look like for
Wasm.

Change-Id: I8b2ddda07e906f1938d4cd5fe0e63203e9cdd6d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230120
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-03-30 17:00:20 +00:00
Konstantin Shcheglov 25b99575df Issue 48697. Fix for inferring super-formal parameters when generic base class. 
Bug: https://github.com/dart-lang/sdk/issues/48697
Change-Id: I2762e326024f672dc616f784b3f925dfd0c3ffcc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-30 16:15:36 +00:00
Brian Wilkerson 6207471a83 Convert two sync handlers from the edit domain 
Change-Id: I61e741530cb7702b2e0961464e6d13cf82043387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239366
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-30 16:08:00 +00:00
Danny Tuppeny 224d2768af [analysis_server] Fix LSP typeDefinition test on Windows 
Fixes https://github.com/dart-lang/sdk/issues/48701.

Change-Id: I39b9eead0adda9d9f016d7bb6f73679edd9839ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239314
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-30 15:43:50 +00:00
Martin Kustermann 46e7d54050 [vm] Be more lenient when assumptions about _StreamIterator._stateData field is not a Future 
Issue https://github.com/flutter/flutter/issues/100441
Issue https://github.com/dart-lang/sdk/issues/48695

TEST=vm/dart{,_2}/flutter_regress_100441_test

Change-Id: Ifdd331dc3b0a2b825a938132808b4021c0af5f71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239311
Reviewed-by: Slava Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2022-03-30 15:35:22 +00:00
Joshua Litt cfde2d406a [dart2js] Fix bug with trimming component. 
Also fully unifies all of our phases in `runSequentialPhases` for
simplicity.

Change-Id: I51dc8993070fe20de3d10fd98edd07adda5e790f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239361
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-03-30 15:35:20 +00:00
Jens Johansen 706fa83de6 [CFE] Expression suite fuzzing with no-nnbd too 
Previously the expression suite was testing in non-nnbd mode.
It was recently converted to testing in nnbd mode.
In doing so, fuzzing found some bugs.

This CL lets fuzzing work in both modes, potentially catching more bugs.

Change-Id: I69760078ffe8ed7a5a33216a09378da3e4dd1903
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238340
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-03-30 14:23:00 +00:00
Johnni Winther 88846ca4b4 [kernel] Remove unused Typedef fields 
The fields typeParametersOfFunctionType, positionalParameters,
and namedParameters were never used.

TEST=existing

Change-Id: I0ca1c546fdf94df9c3248164a56ed88cd2468b18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239310
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2022-03-30 13:01:40 +00:00
Sigurd Meldgaard cd22f8ca32 Allow depot_tools to update in tools/manage_deps.dart 
This became a problem with: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3556588 .

Change-Id: I00d16291112d63dff190a5553805f6185ea470b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239316
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2022-03-30 12:00:50 +00:00
Clement Skau ba341d740a [vm] Avoid spills for most FFI leaf calls. 
Adds an additional `contains_call` mode specifying that the
register allocator should block all non-callee-save ABI registers.
As opposed to `kCall`, this frees the use of callee-save registers
across FfiCallInstr, meaning that live values do not always have
to be spilled.
For architectures with sufficient free callee-save registers
this should result in less overhead for each FfiCall.

This change also removes RequiresStackSlot as it was only being
used for FfiCall's TypedData, and wasn't implemented in the
Register Allocator.
Since FfiCall no longer blocks all registers TypedData can now
live in a register, so the previous assumptions about it always
being on stack have to be relaxed.

This change also works around an issue where the register allocator
might allocate an FPU register that does not have an associated S
register. This causes problems when FFI tries to pass 32 bit floats
in said register.
As a work around we block all FPU regs. above the 8 that have S regs.
for FFI calls in VFPv3-D32 mode.

This change also adds an additional temp registers which was previous
used but not being reserved in FfiCall IL on Arm64.

Some additional prereq. fixes were branched out into:
https://dart-review.googlesource.com/c/sdk/+/237690

TEST=Adds IRTest_FfiCallInstrLeafDoesntSpill.

Bug: https://github.com/dart-lang/sdk/issues/45468
Change-Id: Icdeccb0de77e46f5bc34dd5bd4e308d27bc1ef99
Cq-Do-Not-Cancel-Tryjobs: true
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-win-release-x64-try, vm-precomp-ffi-qemu-linux-release-arm-try, vm-kernel-mac-release-arm64-try, vm-kernel-nnbd-mac-debug-arm64-try, vm-kernel-nnbd-mac-release-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221624
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2022-03-30 10:57:26 +00:00
Sigurd Meldgaard c78ef90124 Bump pub to a3a102a549388a6dbfecc9252fabb618f9a2f5f7 
Changes:
```
> git log --format="%C(auto) %h %s" 8f5ab7b..a3a102a
 https://dart.googlesource.com/pub.git/+/a3a102a5 Fix equality and hashcode for the sdk descriptors (#3367)
 https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212)
 https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346)
 https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361)
 https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305)
 https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358)
 https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215)
 https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356)
 https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757)" (#3357)
 https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359)
 https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354)
 https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352)
 https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349)
 https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347)
 https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341)
 https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340)
 https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335)
 https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332)
 https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331)
 https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330)
 https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313)
 https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320)
 https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311)
 https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304)
 https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297)
 https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295)
 https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757)

```

Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..a3a102a549388a6dbfecc9252fabb618f9a2f5f7/
Change-Id: I8d0ea375039ea450d397871d9fac35d590ea8869
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239315
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2022-03-30 09:34:50 +00:00
Ahmed Ashour d2d83df1f2 CreateConstructorForFinalFields to handle NNBD and super_parameters 
Fixes #45812

Change-Id: I8d0f9677cbc9c7628dc9068c83409a1145638e0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-30 04:06:30 +00:00
Sam Rawlins 06e0672dc7 ConvertToExpressionFunctionBody: no fix if comments are present 
Bug: https://github.com/dart-lang/sdk/issues/29313
Change-Id: I1548ee3db0b8a00ba42c419c0748daeaab118d61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-29 22:54:29 +00:00
Paul Berry a79291167e Extract getFreeParameters method from TypeSystemImpl.instantiateTypeFormalsToBounds. 
I'm going to need to use this logic for
https://github.com/dart-lang/language/issues/731 (improved inference
for fold etc.)

Change-Id: I9232e42ccfd29b028fb393af06541a9a51f57579
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239161
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-03-29 21:33:02 +00:00
Keerti Parthasarathy a3505a1209 Add a check for validating method name 
Change-Id: Ia312b8c64c01a809b4ae98d0469b755e959dbd16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2022-03-29 21:31:10 +00:00
Nate Biggs 0993ee0811 [CFE] Fix clone not copying futureValueType onto cloned FunctionNodes. 
Happened upon this and noticed it was missing. Might not cause correctness bugs but my exclude the cloned function from some optimizations.

Change-Id: I2481c66a5f277556ac652954f03f09983d68480a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239320
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
 2022-03-29 21:24:59 +00:00
Ryan Macnak 9166b3eb9d [vm] Avoid vtable loads being hoisted above vtable stores. 
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/48659
Bug: https://github.com/dart-lang/sdk/issues/48681
Change-Id: I23c4900862a534864790b0c587f61cdd7b9e4bfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239242
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2022-03-29 20:54:29 +00:00
Konstantin Shcheglov 16fadd69a6 Switch to protocol version 1.33.0, enable new completion protocol. 
Change-Id: Ib7de4d616cba91bfe3b014199b6aacaa01c9c052
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239322
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-29 20:53:39 +00:00
Paul Berry 4b47910994 Change DependencyWalker.walk to avoid walking already-evaluated nodes. 
Previously this was the responsibility of the client, but not all
clients of `DependencyWalker` were doing this, causing potentially
duplicate work in the analyzer.

Change-Id: Ice68b371a75c290fbd6b144fc927b48a5dd87620
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239261
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-03-29 20:34:49 +00:00
Konstantin Shcheglov 0d408f6316 Add missing @override to addTestFile(). 
Change-Id: Ib7d83946f80461420bf4645982415d22ae99fff3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-29 19:51:39 +00:00
Nicholas Shahan 4193c18160 [ddc] Migrate js_ast libraries to null safety 
- builder.dart
- template.dart

Change-Id: Ie399e7e5ba3261dea36d5139239ddc3d014981f9
Issue: https://github.com/dart-lang/sdk/issues/46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239222
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2022-03-29 19:23:29 +00:00
Mark Zhou 10c5c79aa5 [dart2js] Plumbing the kernel component to and restructuring dumpInfo 
- Pulls dumpInfo out from the Linking phase.
- Forks dumpInfo into ElementInfoCollector and KernelInfoCollector.
- Introduces a temporary compiler variable that will be more cleanly integrated later.

Change-Id: I5f0970d9dbd5b1f215063ac161468b2774fb28a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239005
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
 2022-03-29 18:41:49 +00:00
Danny Tuppeny 8e90d6ac15 [dds] Fix deserialisation of env vars in DAP 
Change-Id: Ia3da6d4abdfd41b4b4f6631fd82d8680ee1727b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239309
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-29 18:39:29 +00:00
Konstantin Shcheglov 0640f6e1e3 Move navigation tests to PubPackageAnalysisServerTest. 
Change-Id: I7c98b5621bca9b204a253faec5e45488e1ef1bc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-29 18:09:51 +00:00
Danny Tuppeny e7adcb6ba3 [anlaysis_server] Add support for LSP's Go-to-Type Definition 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3833.

Change-Id: Ieb459ded5af3e074566b69c7df40f1bf6b5d6c25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239306
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-29 18:06:39 +00:00
Nate Biggs a1bf2b1b0e [CFE] Pass fasta folder.options flags to dart2js target CompilerOptions. 
This allows us to parse FeatureOptions from the folder.options file.

Change-Id: I185d8d1de11db846e8a6777c15be0dddfffc98c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239181
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
 2022-03-29 17:54:21 +00:00
Sam Rawlins 248b27c37f Bump dartdoc to ~5.1.0 
Change-Id: Iee217a3cab8653828b7437cf89c68d31c41dd284
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239241
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-29 17:10:49 +00:00
Ilya Yanok 6e501511b2 Revert "update package:async" 
This reverts commit f90456b75c.

Reason for revert: breaks one test and blocks the SDK roll, see b/227329107

Original change's description:
> update package:async
>
> Bug:b/227194243
> Change-Id: I53a3cc569d3c5c0484fd488417bfdca633080461
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239140
> Auto-Submit: Jake Macdonald <jakemac@google.com>
> Commit-Queue: Jake Macdonald <jakemac@google.com>
> Reviewed-by: Nate Bosch <nbosch@google.com>
> Commit-Queue: Nate Bosch <nbosch@google.com>

TBR=jakemac@google.com,nbosch@google.com

Change-Id: I892b7c8005872575e9bc4a2259a3977614faa1b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/227194243
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239308
Reviewed-by: Ilya Yanok <yanok@google.com>
Reviewed-by: Emmanuel Pellereau <emmanuelp@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2022-03-29 16:31:19 +00:00
Johnni Winther 5f853eb0a5 [cfe] Use correct version number for 'super-parameters' message 
Closes https://github.com/dart-lang/sdk/issues/48690

Change-Id: If2a335147bbb6f64bdb8e991c6b3923019dbbed7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239303
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2022-03-29 14:30:45 +00:00
Sigurd Meldgaard afe5e06381 Revert "Bump pub to 94ae66a660cc187cc46ceaf1ab96bdcf8d48a313" 
This reverts commit 6e00bb17b8.

Reason for revert: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-engine-linux/16089/overview

Original change's description:
> Bump pub to 94ae66a660cc187cc46ceaf1ab96bdcf8d48a313
>
> Changes:
> ```
> > git log --format="%C(auto) %h %s" 8f5ab7b..94ae66a
>  https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212)
>  https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346)
>  https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361)
>  https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305)
>  https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358)
>  https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215)
>  https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356)
>  https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757)" (#3357)
>  https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359)
>  https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354)
>  https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352)
>  https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349)
>  https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347)
>  https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341)
>  https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340)
>  https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335)
>  https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332)
>  https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331)
>  https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330)
>  https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313)
>  https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320)
>  https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311)
>  https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304)
>  https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297)
>  https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295)
>  https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757)
>
> ```
>
> Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..94ae66a660cc187cc46ceaf1ab96bdcf8d48a313/
> Change-Id: I121fa281ad77991ef10938a3c228ce1d62e748db
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238901
> Reviewed-by: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>

TBR=sigurdm@google.com,jonasfj@google.com

Change-Id: I2402e8647ad79a613d8be55a85a7f05f511a4081
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239301
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2022-03-29 13:12:47 +00:00
Aske Simon Christensen 0797fe6dbc [dart2wasm] Add unsafeCast function that is opaque to the TFA 
This is necessary to cast to and from the special Wasm types.

Change-Id: I1d672c4ccf417901e70dd9af7534ad78f56c18b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239029
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2022-03-29 09:29:05 +00:00
Aske Simon Christensen 2b1be5d6f6 [dart2wasm] Remove unneeded patch file for native finalizers 
This unbreaks dart2wasm after it broke as a result of
https://dart-review.googlesource.com/c/sdk/+/236320

Change-Id: Icc5e8ab7fa16e36009b0a2cf53bc503f101b8c95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239028
Reviewed-by: Joshua Litt <joshualitt@google.com>
 2022-03-29 09:29:05 +00:00
Sigurd Meldgaard 6e00bb17b8 Bump pub to 94ae66a660cc187cc46ceaf1ab96bdcf8d48a313 
Changes:
```
> git log --format="%C(auto) %h %s" 8f5ab7b..94ae66a
 https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212)
 https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346)
 https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361)
 https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305)
 https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358)
 https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215)
 https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356)
 https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757)" (#3357)
 https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359)
 https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354)
 https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352)
 https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349)
 https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347)
 https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341)
 https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340)
 https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335)
 https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332)
 https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331)
 https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330)
 https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313)
 https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320)
 https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311)
 https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304)
 https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297)
 https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295)
 https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757)

```

Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..94ae66a660cc187cc46ceaf1ab96bdcf8d48a313/
Change-Id: I121fa281ad77991ef10938a3c228ce1d62e748db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238901
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2022-03-29 09:14:45 +00:00
Chloe Stefantsova 61465fb08b [cfe] Remove coercions for super parameters 
Part of https://github.com/dart-lang/sdk/issues/47525

Change-Id: Iadb2f0125318edd73ab84e5b1a9cafae098ec618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239081
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2022-03-29 09:06:26 +00:00
Tess Strickland 95d1ae911d [vm] Reduce class id reloads in TTSes when possible. 
Now GenerateCidRangesCheck in the flow graph compiler returns
whether the class id register was clobbered, so users that
make multiple calls to it for the same cid know whether the cid
needs reloading after the generated check.

Also unifies FlowGraphCompiler::EmitTestAndCheckCid across
architectures, since the non-Intel versions would have
always forced reloading.

TEST=vm/cc/TTS

Change-Id: I08835dc97ba457b7dc8dfa51206b4741a607db22
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-mac-release-arm64-try,vm-kernel-precomp-linux-release-simarm_x64-try,vm-kernel-nnbd-mac-release-arm64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-precomp-nnbd-linux-release-simarm_x64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-linux-debug-simriscv64-try,vm-kernel-precomp-linux-debug-simriscv64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238583
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
 2022-03-29 08:03:35 +00:00
Tess Strickland 6bec28da38 [vm] Only check for Smi once when reloading cid for TTS cid checks. 
When generating a type testing stub (TTS) for implemented classes,
multiple cid range check blocks may be generated, each of which
requires reloading the cid. This CL makes it so that only a single
Smi check will be generated the first time the cid is loaded, so
later checks can just load the cid directly without the Smi case.

TEST=vm/cc/TTS

Change-Id: I4d76ee34a03cf4a0def268e9f74a096e3c0deb58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238702
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
 2022-03-29 07:48:45 +00:00
Konstantin Shcheglov 38a0305768 Inline 'testFilePathPlatform' as 'testFile.path'. 
Change-Id: I6b27af152f91a639e1dfc09a2b1a4da286692a38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239124
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-29 05:55:45 +00:00
Sam Rawlins ba7921a84a Add dynamic return type when creating noSuchMethod 
Fixes https://github.com/dart-lang/sdk/issues/47142

Change-Id: I9fe504c91bff2486774285ce1b147eefefe7e2b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239125
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-29 04:51:30 +00:00
Sam Rawlins c895971315 Test that mixins and typedefs are included in added show directive 
Fixes https://github.com/dart-lang/sdk/issues/43338

Change-Id: Ib6b66f71dd5fc87f252cd60772713fd2c541eecd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-29 04:15:40 +00:00