languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 22:19:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
83888 commits 11 branches 6011 tags 1.4 GiB
Commit graph

1687 commits

Author SHA1 Message Date
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Terry Lucas dd8988c9b2 - Moved all WebGL rendering/drawing constants to synthesized class WebGL. 
- Removed obsolete Dartium/_blink code.

R=kevmoo@google.com

Change-Id: I81a6f0d5bfe33592ff8ae9c85db9266e898c2861
Reviewed-on: https://dart-review.googlesource.com/60380
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-15 17:08:54 +00:00
Terry Lucas f479435bca - Removed custom handling of fill - it was wrong the method is now overloaded. 
- Associate the JS class SpeechSyntesisVoice with the correct Dart class (DDC).
- Top-level querySelectorAll wasn't generic.
- Handle "static" for attributes in the IDLs.

Fixes #33147
Fixes #33178
Fixes #31886
Fixes #20585

R=vsm@google.com

Change-Id: Ic75a2bfc66670b72342269be259408b610547dab
Reviewed-on: https://dart-review.googlesource.com/59240
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-15 02:25:13 +00:00
Terry Lucas eea2dff20d Added support for members of type Promise. 
Fixes #31046

R=sra@google.com

Change-Id: Id1e8d415b91a842bd8e2f50c6064c24aaaed9d98
Reviewed-on: https://dart-review.googlesource.com/59460
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-06-13 18:20:53 +00:00
Lasse R.H. Nielsen 0b91676362 Remove the retype method. 
See #33075.

Bug: http://dartbug.com/33075
Change-Id: I1ee2f587afbc672dd08ac61ac003bbdc85bb95e2
Reviewed-on: https://dart-review.googlesource.com/59091
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-12 14:36:09 +00:00
Terry Lucas f4386ed488 Fix type error in MultiElementCssClassSet constructor. 
Fixes #29901

R=sra@google.com

Change-Id: Idfa1dee3d243ed34c3ca8d1225404143a28746e8
Reviewed-on: https://dart-review.googlesource.com/59340
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-06-08 17:47:32 +00:00
Terry Lucas 5ec940a2e0 Updated to expose APIs promiseToFuture calls for users. 
Fixes #33226

R=kevmoo@google.com, sra@google.com

Change-Id: I04995b33e9445d0fcef8d874315f14fd272018d1
Reviewed-on: https://dart-review.googlesource.com/57482
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-06-07 01:40:22 +00:00
Terry Lucas cf87b84f7d Support Promise to Future for both DDC and dart2js. 
APIs in the newer Chrome IDLs support more JS style promises. The Dart web libraries now hookup those promises and return a Dart Future.
Additionally, a new type maplike is exposed in the IDL this is exposed too.

Change-Id: I44175877eb95f4d910586d42c0139fb182483f82
Reviewed-on: https://dart-review.googlesource.com/49800
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-23 04:08:14 +00:00
Lasse Reichstein Holst Nielsen 862a894de6 Make cast do the same things as retype. 
Deprecate `retype` and forward it to `cast`.

Change-Id: Ie17ffdd1eef0d3f19582bf638c5349927c7b5ebd
Reviewed-on: https://dart-review.googlesource.com/53802
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-05-09 08:00:08 +00:00
Terry Lucas 6ab6d1eda9 Suppress fromRect its only available in DOMRect and not in ClientRect - will open bug to fix this issue. 
R=sra@google.com

Change-Id: I09b653c7f3987dcf7ce5b235593e4f3140561d5c
Reviewed-on: https://dart-review.googlesource.com/50581
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-04-10 23:25:12 +00:00
Terry Lucas 34be5de0c7 Fixed _DomRect class to map to both ClientRect and DOMRect for browser backward compat. 
R=sra@google.com,sigmund@google.com

Change-Id: I2f5ccae15bcd993ab1e15ab556a25d6e0cd1d450
Reviewed-on: https://dart-review.googlesource.com/50504
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-04-10 21:18:45 +00:00
Sigmund Cherem 133cd9d182 Use JavaScriptFunction for _registerCustomElement 
"=Object" was inacurate and contradicted the inferred type <Function> in strong mode.

Change-Id: Ibee4351357dde4aaacf95ff7265cd335fc5d06ea
Reviewed-on: https://dart-review.googlesource.com/49832
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-04-06 23:14:13 +00:00
Terry Lucas 3e6b8717fe Fixed GamePadList not working in DDC and hide MessagePort.start operation. 
Fixes https://github.com/dart-lang/sdk/issues/31029

R=vsm@google.com

Change-Id: I757538eec1ebcf42204e7de0807a48a4757f3faf
Reviewed-on: https://dart-review.googlesource.com/49740
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-04-05 15:13:17 +00:00
Terry Lucas 49558b9c4c Fixed MessageChannel receiveing messages on ports. 
Removed pkg browser from tests.

Fixes https://github.com/dart-lang/sdk/issues/26351
Fixes https://github.com/dart-lang/sdk/issues/32631

R=kevmoo@google.com

Change-Id: Ib0ef5f933d38b2f748cca1f82de8bcf01702df4d
Reviewed-on: https://dart-review.googlesource.com/48742
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-30 17:16:15 +00:00
Jenny Messerly c9e9c1d8e9 Remove dart:isolate runtime support in DDC 
This disables most runtime features of dart:isolate, similar to dart:io.

For now, this supports `new ReceivePort()` and `ReceivePort.close` as
those are used by async tests to keep the Dart VM alive. Those are
no-ops in DDC. Also removes most of dart:_isolate_helper, except for
the JS API that's used to bootstrap DDC `main()`.

Change-Id: I84eab6cd39d05a70a6afe982e952076ddaaa8c0f
Reviewed-on: https://dart-review.googlesource.com/45754
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-28 19:42:08 +00:00
Terry Lucas 8e02ff92db Added @category annotation for Web libraries and removed createCustomUpgrader. 
TBR=jcollins@google.com

Change-Id: I151e8d8af4bc647bdf47399c11f83b1625dabcf6
Reviewed-on: https://dart-review.googlesource.com/48523
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-27 23:53:14 +00:00
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json, 
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-03-27 20:45:33 +00:00
Terry Lucas 17a778c9cb Changed AudioScheduledSourceNode.start to start2. 
Fixes https://github.com/dart-lang/sdk/issues/32624

TBR=kevmoo@google.com

Change-Id: Ied9494a4b9695ae08ff2ef63c43759ea7951e9fa
Reviewed-on: https://dart-review.googlesource.com/47760
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-22 13:18:37 +00:00
Terry Lucas 581c512345 Fixed DOMRectList not having a prototype field. 
TBR=vsm@google.com

Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-03-20 01:08:47 +00:00
Terry Lucas 60469482f1 Move ClientRect members to DOMRect. 
TBR=sigmund@google.com,sra@google.com

Change-Id: I424b087830954329f4399f6b169f572196a4f658
Reviewed-on: https://dart-review.googlesource.com/46948
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 13:27:46 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs. 
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 09:41:04 +00:00
Stephen Adams 109316c484 Force inlining to match AST version 
These are a couple of cases where inlining differs from the previous
version and makes a difference in angular code.

Change-Id: Ibc8ba0d720b8bb49481c41e1332fc6a4a0292d9d
Reviewed-on: https://dart-review.googlesource.com/44701
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-03-02 20:10:49 +00:00
Jenny Messerly 8bce74bc05 Remove dart:html import of dart:isolate 
dart:isolate was used for the `Future<Isolate>` return type of
spawnDomUri, which is an unimplemented experimental method. This method
now returns `Future`.

This change helps dart4web disable support for dart:isolate (#30538)

Change-Id: Ida87c2a27ac33d1b9a14feb7dd6d306a546a0aaf
Reviewed-on: https://dart-review.googlesource.com/43860
Reviewed-by: Terry Lucas <terry@google.com>
 2018-02-28 07:25:00 +00:00
Terry Lucas 9f09ef0af3 - Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and 
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used).  The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.

Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter.  The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:

     Uncaught TypeError: t1.get$target is not a function


R=vsm@google.com,gabrielchow@google.com,sra@google.com

Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-02-23 14:29:45 +00:00
Lasse R.H. Nielsen 6f78471687 New methods on Iterable, List, Set, Queue, Map. 
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-02-07 06:12:53 +00:00
William Hesse 9c35cff5cd Revert "New methods on Iterable, List, Set, Queue, Map." 
This reverts commit 0b59f24f97.

Reason for revert: Creates crashes in dart2js with kernel, see
https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751

Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
> 
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Leaf Petersen <leafp@google.com>

TBR=lrn@google.com,leafp@google.com

Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-06 13:32:19 +00:00
Lasse R.H. Nielsen 0b59f24f97 New methods on Iterable, List, Set, Queue, Map. 
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-02-06 11:17:46 +00:00
Terry Lucas d7a8aa155f Fixed a number of File API methods in DDC. 
R=vsm@google.com

Change-Id: I77881201f1e89f731476655476eb865e10d581a1
Reviewed-on: https://dart-review.googlesource.com/38164
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-02-05 22:29:00 +00:00
Terry Lucas 0a02050867 Fixed DirectoryReader returned from createReader to exist in DDC. 
R=vsm@google.com

Change-Id: I6761da70b2f51f235534ee10fa0b7cb7a7a98659
Reviewed-on: https://dart-review.googlesource.com/36020
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-01-19 18:14:05 +00:00
Terry Lucas 476b1e02a9 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test. 
Also, updated status files to correctly fix failures in FF, IE and removed other spurious status entries.

R=alanknight@google.com,vsm@google.com

Change-Id: Ic965103d892ff4d5d119712e3187e829f57cd022
Reviewed-on: https://dart-review.googlesource.com/31800
Reviewed-by: Terry Lucas <terry@google.com>
 2017-12-29 23:51:02 +00:00
Terry Lucas 0af98266ab Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test." 
This reverts commit 0c8294e4a0.

Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-12-23 01:59:38 +00:00
Terry Lucas 0c8294e4a0 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test. 
R=alanknight@google.com,vsm@google.com

Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
 2017-12-22 22:57:34 +00:00
Terry Lucas bfea069823 Test possible keyevent fix. 
Change-Id: I3f90979fad2681775cae56d499f3ff5968ea6485
Reviewed-on: https://dart-review.googlesource.com/29545
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-12-14 21:22:39 +00:00
Terry Lucas 642b768e87 Fixed default parameter messagePorts for MessageEvent factory. 
R=vsm@google.com

Change-Id: Ic94ccbe4c29302e44c58791658ce75dff86d9ac2
Reviewed-on: https://dart-review.googlesource.com/29544
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-12-14 18:21:25 +00:00
Terry Lucas 529add3834 DDC fix to expose classes which are only created inside of the browser. 
R=vsm@google.com

Change-Id: I27ede73ac84a72ee9b5e8b3b0a706ade82b2aa59
Reviewed-on: https://dart-review.googlesource.com/25500
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-12-13 03:03:09 +00:00
Vijay Menon b8cd835bb9 Workaround CFE instantiate-to-bounds bug 
This avoids #31566 for now.

Change-Id: I5f2ea0cf0ad15a534c1c62182bdca36fc3b0b103
Reviewed-on: https://dart-review.googlesource.com/26760
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-12-06 21:34:11 +00:00
Leaf Petersen 8f199377fa Remove generic method comment syntax from dart:html. 
This removes the last uses of the generic method comment syntax from
the SDK.  There are no additional explicit casts or reified generics
(other than those implied by reifying generic methods) in this CL.

Bug:
Change-Id: Icae23cac60869243cb3ba441f86d70422f68178f
Reviewed-on: https://dart-review.googlesource.com/26081
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2017-12-06 21:26:04 +00:00
Paul Berry 316f2b429f Strong mode fixes to DDC SDK 
Change-Id: I40508c686014f28772109fdfd10c68b986b40be6
Reviewed-on: https://dart-review.googlesource.com/25140
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-12-01 19:58:07 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase. 
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase." 
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase. 
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-11-14 11:13:04 +00:00
Stephen Adams 7686dce346 Replace _downcast and _cast with local downcasts (dart:html) 
Change-Id: I4282b20aac07da125805a2654da072742dbbdd0b
Reviewed-on: https://dart-review.googlesource.com/20300
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-11 00:09:38 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Terry Lucas 352f9fd859 Fixed bad indent not flushing emitted files. 
Removed Dartium code emission.

TBR: alanknight@google.com,vsm@google.com
Change-Id: Ib027f542b238c90311f6838e67b4b8d27815374c
Reviewed-on: https://dart-review.googlesource.com/3280
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-05 14:43:08 +00:00
Florian Loitsch ee46026671 Don't use LinkedList in the core libraries anymore. 
R=lrn@google.com

Committed: fe17b5b2bc
Reverted: 5d4a786f44
Review-Url: https://codereview.chromium.org/2975443002 .
 2017-07-28 21:14:11 +02:00
Bob Nystrom 012774c78e Remove Dartium support from test.dart. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2981223002 .
 2017-07-20 12:46:50 -07:00
Vijay Menon 12e32e230d Add hook to register global object 
DDC will use this in a later CL.

R=alanknight@google.com, sra@google.com

Stephen: I assume this will get compiled out be dart2js.
Review-Url: https://codereview.chromium.org/2983813002 .
 2017-07-19 05:46:07 -07:00
Alan Knight 0700adc633 Fix the go.sh script for a completely new repo. 
BUG=

Review-Url: https://codereview.chromium.org/2981193002 .
 2017-07-18 13:44:08 -07:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium) 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
 2017-07-18 11:02:02 -07:00
Terry Lucas 657daa96a8 First step in removing dartium from IDL generation in TIP of master. 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2982143002 .
 2017-07-18 08:40:39 -07:00
Alan Knight 789de57cdf Allow setting unknown CSS properties, e.g. CSS variables 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2976213002 .
 2017-07-17 14:56:31 -07:00
Stephen Adams 8623950864 Change imports to clean up irritating warning 
This gets rid of the following messages in the build:

patched_dart2js_sdk/lib/_internal/js_runtime/lib/native_typed_data.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/svg/dart2js/svg_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_audio/dart2js/web_audio_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_gl/dart2js/web_gl_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_sql/dart2js/web_sql_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.

BUG=
R=ahe@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2982503002 .
 2017-07-12 14:37:40 -07:00
Terry Lucas 1265b4c674 Fixed readPixels not working in Dartium. 
BUG=11614
R=alanknight@google.com, jacobr@google.com

Review-Url: https://codereview.chromium.org/2975953002 .
 2017-07-11 13:12:51 -07:00
Stephen Adams b0803e1dd7 _ChildrenElementList implements removeRange 
This is to avoid inheriting an implementation that works incorrectly for the underlying NodeList.

TBR=lrn@google.com

BUG=

Review-Url: https://codereview.chromium.org/2977453002 .
 2017-07-07 15:55:19 -07:00
Stephen Adams fc7d880c60 Implement _ChildNodeListLazy.removeRange as throwing UnsupportedError 
_ChildNodeListLazy.removeRange used to throw UnsupportedError because ListMixin.removeRange calls setRange.
Make throwing UnsupportedError explicit to avoid relying on the implementation of ListMixin.removeRange
This will unblock the '_closeGap' change.

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2955103003 .
 2017-06-28 09:42:55 -07:00
Florian Loitsch 978213d427 Revert "Make Zone API strong mode clean." 
This reverts commit 0b35711d48.

BUG=

Review-Url: https://codereview.chromium.org/2963743002 .
 2017-06-28 13:31:32 +02:00
Florian Loitsch 0b35711d48 Make Zone API strong mode clean. 
Review-Url: https://codereview.chromium.org/2959163002 .
 2017-06-28 13:16:39 +02:00
Erik Corry 029b1cb948 Spelling fixes e to i. 
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
 2017-06-24 13:41:39 +02:00
Terry Lucas 8ab1a87aba Typedefs and IDL file order between platforms could generated different files. 
TBR=alanknight@google.com,vsm@google.com

Review-Url: https://codereview.chromium.org/2948493002 .
 2017-06-18 11:54:29 -07:00
Alan Knight 6042ae4bd8 Get the name and message from DOMException correctly 
BUG=
R=jacobr@google.com, terry@google.com

Review-Url: https://codereview.chromium.org/2931903003 .
 2017-06-13 08:59:33 -07:00
Terry Lucas b3a90540f1 Fix sound not playing in Dartium checked mode. 
Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls.
Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations
with optional arguments that are Promises.

https://github.com/dart-lang/sdk/issues/29810

TBR=alanknight@google.com,kevmoo@google.com

Review-Url: https://codereview.chromium.org/2940543002 .
 2017-06-12 22:50:12 -07:00
Terry Lucas 3cbacefbe3 Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation. 
R=alanknight@google.com,sigmund@google.com

Review-Url: https://codereview.chromium.org/2932793002 .
 2017-06-08 20:44:30 -07:00
Alan Knight 75a1eaef7e Fix dataTransfer getter 
BUG=

Review-Url: https://codereview.chromium.org/2907273003 .
 2017-05-30 15:14:40 -07:00
Alan Knight d21cc80a54 Add a dataTransfer member to MouseEvent 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2899393004 .
 2017-05-25 14:05:10 -07:00
Terry Lucas 20dc749844 Suppress Scale interface - unused. 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2901213006 .
 2017-05-25 12:54:38 -07:00
Alan Knight 6f71f9c80b Revert "[Experiment] Stop suppressing DragEvent" 
This reverts commit fbbb974670.

Also updates the cached_patches.dart file.

BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2907563003 .
 2017-05-25 11:16:10 -07:00
Alan Knight b4b02daade Include DDC fixes to dart:html in the main version 
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2899173002 .
 2017-05-24 12:49:13 -07:00
Alan Knight e6c38ea30f Remove JS_CONST from CssStyleDeclaration, causes DDC problems 
BUG=
R=sra@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2896393002 .
 2017-05-23 14:48:08 -07:00
Alan Knight fbbb974670 [Experiment] Stop suppressing DragEvent 
BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2898673003 .
 2017-05-22 14:10:05 -07:00
Alan Knight 9e0297f49e Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIEvent 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2896653003 .
 2017-05-22 10:29:24 -07:00
Sigmund Cherem cd2ebf70a2 Add dart:html and friends to patched_dart2js_sdk/platform.dill, also fix up 
warnings on these libraries.

R=sra@google.com

Review-Url: https://codereview.chromium.org/2885103005 .
 2017-05-17 10:58:30 -07:00
Stephen Adams 9c3d439b1e dart2js + html: getBoundingClientRect() returns a ClientRect 
Gives better code since the general Rectangle requires getInterceptor
dispatch.

BUG= https://github.com/dart-lang/sdk/issues/29602
R=jacobr@google.com, terry@google.com

Review-Url: https://codereview.chromium.org/2879403002 .
 2017-05-16 13:48:04 -07:00
Stephen Adams 89b9c7c8dd html: AudoTrackList is a List 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2884813002 .
 2017-05-15 14:44:35 -07:00
Stephen Adams 35979c3205 Add keyLocation to KeyboardEvent constructor for backwards compatibility 
BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2884713002 .
 2017-05-15 10:58:24 -07:00
Stephen Adams 01ba5f8d74 fix KeyEvent and KeyboardEvent 
Some keyboard specific properties moved in the IDL from UIEvent to
KeyboardEvent.  We has done work to hide them on UIEvent; this needed
to be updated.

TBR=terry@google.com

BUG=

Review-Url: https://codereview.chromium.org/2883623004 .
 2017-05-12 16:03:01 -07:00
Stephen Adams ca3d90c4cd Prevent ExtendableMessageEvent.data from thwarting DOM tree-shaking 
We can't have the [data] and [source] getters typed as Object.
This causes it to appear that all DOM types are instantiated.

I have modelled the annotations after the same getters from
MessageEvent.

TBR=jacobr@google.com

BUG=

Review-Url: https://codereview.chromium.org/2879763002 .
 2017-05-11 19:31:20 -07:00
Stephen Adams 0879884d80 web_audio: rename OfflineAudioContext.suspend 
Rename member to avoid warning due to incompatible signature of base class method of same name.

TBR=terry@google.com

BUG=

Review-Url: https://codereview.chromium.org/2872023006 .
 2017-05-11 18:05:09 -07:00
Stephen Adams 91f9ce3f71 Better type for _match argument in AttributeMatch 
This fixes two warnings in analyze_api_test:

R=jacobr@google.com

sdk/lib/html/dart2js/html_dart2js.dart:41478:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == null;
                              ^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:41514:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == _namespace;
                              ^^^^^^^^^^^^^^^^^^
Review-Url: https://codereview.chromium.org/2875183002 .
 2017-05-11 16:59:17 -07:00
Stephen Adams f3734a9fc5 dom: Recognize __getter__ indexers 
BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2879663002 .
 2017-05-11 13:59:41 -07:00
Terry Lucas f27144d7b5 Roll 50: Updated for push to origin/master. 
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2875773003 .
 2017-05-10 18:16:51 -07:00
Alan Knight 95930806c9 Add dynamic declaration to CssRectangle width/height setters 
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2868483002 .
 2017-05-05 13:34:23 -07:00
Nate Bosch bbc65073fa Clarify units for timeout 
This is indicated in the linked MDN doc, but we should not make readers
go looking.

Also fix a typo.

BUG=https://github.com/dart-lang/sdk/issues/29428
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2832353003 .
 2017-05-05 10:11:03 -07:00
Alan Knight cedd8a6854 Format dart:html and related generated files on output 
BUG=
R=jacobr@google.com, terry@google.com

Review URL: https://codereview.chromium.org/2858323003 .
 2017-05-05 10:09:00 -07:00
Stephen Adams ea2c9cba39 dart2js_html: Fix for issue 29538 - some returned lists may be null 
Annotate querySelectorAll as not-null to recover code quality.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2857143003 .
 2017-05-03 14:26:38 -07:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
Erik Corry 4b9bba55b4 Stoppp using trippple consonants 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2833073002 .
 2017-04-21 17:50:13 +02:00
Jacob Richman 119b2d58ce Format all files under tools and utils directory. 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2827793002 .
 2017-04-20 09:08:31 -07:00
Stephen Adams 14c7c3c556 Redo "Refined types for most HtmlElement factory constructors" 
Fix: ShadowElement is not always present.

Original:
Committed: b7b12b564a
Reverted:  963df1e3e1

BUG=

Review-Url: https://codereview.chromium.org/2718713003 .
 2017-02-24 14:28:58 -08:00
Stephen Adams 963df1e3e1 Revert "Refined types for most HtmlElement factory constructors" 
Need to fix ShadowElement

TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2710323004 .
 2017-02-24 14:15:37 -08:00
Stephen Adams b7b12b564a Refined types for most HtmlElement factory constructors 
The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element.
The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined.

This tends to improve the code generated for idioms like

    new DivElement()..classes.add('foo')

    var e1 = new DivElement();
    e1.children.add(e2);

BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2705213003 .
 2017-02-24 11:23:06 -08:00
Alan Knight de05077537 Revert "Add Selection.toString() calling the native method" 
This reverts commit 01e6e00499.

BUG=

Review URL: https://codereview.chromium.org/2678593002 .
 2017-02-03 17:02:06 -08:00
Alan Knight b1552f9ef9 Revert "Re-submit Range.toString() and test status changes" 
This reverts commit 95d409e3ed.

BUG=

Review URL: https://codereview.chromium.org/2678543002 .
 2017-02-03 13:05:18 -08:00
Alan Knight 01e6e00499 Add Selection.toString() calling the native method 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2669103003 .
 2017-02-03 10:24:18 -08:00
Alan Knight 95d409e3ed Re-submit Range.toString() and test status changes 
https://codereview.chromium.org/2632363002
https://github.com/dart-lang/sdk/pull/28376

R=whesse@google.com

Review URL: https://codereview.chromium.org/2672843003 .
 2017-02-03 09:55:59 -08:00
Alan Knight 05e80e9cfc Regenerate html files after b42dbe524c 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2670203002 .
 2017-02-02 12:54:56 -08:00
Asger Feldthaus 8701dbf147 Revert "added Range.toString() to dart:html (#28376)" +1 more 
Revert "dart2js status updates after Range.toString was added to dart:html"

This reverts commit 226a7e7177.
This reverts commit c279a951f4.

The test

  co19/LayoutTests/fast/filesystem/file-writer-abort-continue_t01

broke after the inital commit. The second commit being reverted
is one that updated the status files for tests that now pass.

BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2635033004 .
 2017-01-17 17:21:46 +01:00
Kulshekhar Kabra b42dbe524c Add documentation for a method (#28209) 
* Add documentation for a method

Adds docs for the `getPropertyValue` method of the `CssStyleDeclaration` class in the `html` package

* Remove unneeded extra line
 2017-01-16 09:18:27 +01:00
Lex Berezhny 226a7e7177 added Range.toString() to dart:html (#28376) 
* added Range.toString() to dart:html

* added Range.toString to impl_range.darttemplate as well
 2017-01-13 14:13:07 -08:00
Terry Lucas 4b497fb319 Fixed checked mode error for resolvePackageUri. 
TBR=asiva@google.com

Review-Url: https://codereview.chromium.org/2626643003 .
 2017-01-10 09:00:16 -08:00
Terry Lucas 559ae993d1 Added VMLibraryHooks setup for Dartium to support resolvePackageUri. 
BUG=25594
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2611353002 .
 2017-01-10 07:25:10 -08:00
Leaf Petersen 7ab0daeedf Make EventStreamSubscription DDC safe. 
EventStreamSubscription.listen does a cast which is only working in
DDC because we're ignoring the failure.  This wraps the listener to
check the argument rather than casting the function.  Also picks up a
few misc changes to the main SDK that hadn't been merged into DDC.

BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2609633002 .
 2017-01-09 04:13:36 -08:00
Stephen Adams 20a9824605 Force inlining for _ElementCssClassSet.add() / .remove() 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2614593002 .
 2017-01-03 17:23:00 -08:00
Jacob Richman 3659aaf181 Fix bug in Blob creation from workers. 
Fixes https://github.com/dart-lang/sdk/issues/28155

BUG=

Review-Url: https://codereview.chromium.org/2592813003 .
 2016-12-21 08:45:48 -08:00
Jacob Richman 7f26211c26 Correct handling of cross-frame functions in ddc. 
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
 2016-12-19 15:00:55 -08:00
Sigmund Cherem d89dab56b5 Fix IE11 issue: this complements the CL I sent last week. It turns out that 
there are two places where we do this check. This is why the test that I added
appears to be failing in the bots.

BUG=
R=jakemac@google.com

Review URL: https://codereview.chromium.org/2504883002 .
 2016-11-16 08:38:24 -08:00
Sigmund Cherem 008da86c03 Support extending TemplateElement in IE11 + webcomponents-lite.js 
Addresses issue reported in the polymer repo: https://github.com/dart-lang/polymer-dart/issues/682

R=jakemac@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2493703004 .
 2016-11-14 07:32:09 -08:00
Jan-Hendrik Dolling 89560c68a0 change "the the" to the 2016-10-28 21:47:50 +02:00
Stephen Adams c9c3c203c1 Minor tweaks to dart:html for better dart2js codegen 
- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.

BUG=
R=alanknight@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2422293002 .
 2016-10-17 13:35:17 -07:00
Alan Knight 42f8ab2d6a Fix dataTransferItemList indexing 
BUG=

Review URL: https://codereview.chromium.org/2326113002 .
 2016-09-09 12:28:59 -07:00
Alan Knight 43cb6a4c59 Replace Maps library tour link in Storage template with current URL. 
BUG=#27150
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2277103002 .
 2016-08-26 12:34:53 -07:00
Harry Terkelsen 1d749a2fec record that Gamepad.buttons creates GamepadButtons 
This also extends the html generator to be able to generate List implementations with nullable element types

Fixes https://github.com/dart-lang/sdk/issues/27073

R=sra@google.com, terry@google.com

Review URL: https://codereview.chromium.org/2242203002 .
 2016-08-16 13:56:32 -07:00
Jacob Richman 36c9514f04 Use Point<num> in dart:html for strong mode 
Strong mode is (as of recently) inferring a stricter type (e.g., Point<double>) and causing breaking changes.

patch from issue 2211493003 at patchset 1 (http://crrev.com/2211493003#ps1)

BUG=

Review URL: https://codereview.chromium.org/2211563002 .
 2016-08-03 14:09:10 -07:00
Harry Terkelsen faaff39aa9 Record that MediaStream creates MediaStreamTracks 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2168473002 .
 2016-07-19 17:00:04 -07:00
William Hesse bde8d3efc6 Revert "Don't call _ensureRequestAnimationFrame in Dartium." 
This reverts commit bf8eeef6a0.

Revert "Fix animationFrameRequest for dartium."

This reverts commit 3daaf3849f.

BUG=https://github.com/dart-lang/sdk/issues/26906

Review URL: https://codereview.chromium.org/2159183003 .
 2016-07-19 13:56:36 +02:00
Alan Knight 30b489578d Revert "Reapply zone tasks." 
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
 2016-07-18 13:12:36 -07:00
Terry Lucas 2b1816c869 Added switch to disable generating cached_patches.dart file (Dartium only). 
The switch --no-cached-patches to be used by Dart enlistment (non-Dartium) and need to
re-gen the sdk/lib files using:

    ./go.sh --no-cached-patches

R=alanknight@google.com

Review URL: https://codereview.chromium.org/2154863002 .
 2016-07-18 05:45:33 -07:00
Alan Knight e610d803b1 Update test status for webgl extension tests, fix one typo in extension name 
BUG=

Review URL: https://codereview.chromium.org/2152393002 .
 2016-07-15 15:00:15 -07:00
Alan Knight b9316f9882 Recognize WEBGL extensions on Firefox (copy with regenerated files) 
Both of the following objects need to map to Dart type 'AngleInstancedArrays'

    [object ANGLEInstancedArrays]
    [object ANGLE_instanced_arrays]

Fixes https://github.com/dart-lang/sdk/issues/26850

BUG=

patch from issue 2147093002 at patchset 1 (http://crrev.com/2147093002#ps1)

R=sra@google.com

Review URL: https://codereview.chromium.org/2150003002 .
 2016-07-15 12:48:22 -07:00
Florian Loitsch badabcc53a Don't use => on void functions. 
Fixes #26740
BUG= http://dartbug.com/26740
R=sra@google.com

Review URL: https://codereview.chromium.org/2118633002 .
 2016-07-11 14:20:12 +02:00
Florian Loitsch bf8eeef6a0 Don't call _ensureRequestAnimationFrame in Dartium. 
Review URL: https://codereview.chromium.org/2117103004 .
 2016-07-05 19:50:49 +02:00
Florian Loitsch 3daaf3849f Fix animationFrameRequest for dartium. 
Review URL: https://codereview.chromium.org/2124863002 .
 2016-07-05 19:22:27 +02:00
Florian Loitsch 6a7c037aa6 Reapply zone tasks. 
This reverts commit 34d3c37233.

Committed: f746f8f77e

R=lrn@google.com

Review URL: https://codereview.chromium.org/2119243002 .

Reverted: dae3922915
 2016-07-05 17:33:09 +02:00
Florian Loitsch dae3922915 Revert "Reapply zone tasks." 
This reverts commit f746f8f77e.

Review URL: https://codereview.chromium.org/2123593002 .
 2016-07-04 21:58:15 +02:00
Florian Loitsch f746f8f77e Reapply zone tasks. 
This reverts commit 34d3c37233.

Review URL: https://codereview.chromium.org/2119243002 .
 2016-07-04 19:55:58 +02:00
Florian Loitsch 34d3c37233 Revert zone tasks. 
Revert "Add tasks to zones."

This reverts commit 85cccde717.

Revert "Make Dom events run through zone tasks."

This reverts commit 6d1f6b2af6.

Revert "Add zone task support for request-anim."

This reverts commit 726b9f8dc7.

Revert "Add zone task support to http-requests."

This reverts commit b40cfcb57f.

Revert "Update status file for jsshell."

This reverts commit 5e05ee9b5f.

Review URL: https://codereview.chromium.org/2120063002 .
 2016-07-01 22:36:52 -07:00
Florian Loitsch b40cfcb57f Add zone task support to http-requests. 
R=alanknight@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2042033002 .
 2016-07-01 19:44:19 -07:00
Florian Loitsch 726b9f8dc7 Add zone task support for request-anim. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2039963003 .
 2016-07-01 19:43:36 -07:00
Florian Loitsch 6d1f6b2af6 Make Dom events run through zone tasks. 
R=jacobr@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2022263002 .
 2016-07-01 19:43:06 -07:00
Jacob Richman fd58be1816 Add back in pure_interfaces list that turned out to still be needed. The checked in generated code matches this cl. 
BUG=

Review URL: https://codereview.chromium.org/2005143004 .
 2016-05-24 10:25:31 -07:00
Jacob Richman f26e522f84 Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1987073002 .
 2016-05-18 12:49:09 -07:00
Harry Terkelsen 1745ba77f5 fix all instances of "the the" 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1980573003 .
 2016-05-13 12:38:25 -07:00
Alan Knight c5acca2ff0 Check for the case where previousNode fails in sanitization. Can happen with object tags 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1825373004 .
 2016-04-28 12:51:40 -07:00
Jacob Richman 6ef4eae35f Remove as checks bloating sample dart apps by 4K 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1923143002 .
 2016-04-27 08:53:48 -07:00
Alan Knight dad1a74d2e Oops, movementX/Y are private. Fix template 
BUG=

Review URL: https://codereview.chromium.org/1916203002 .
 2016-04-25 13:26:14 -07:00
Alan Knight 5542568adc Fix MouseEvent.movement to not use old webkit prefix 
BUG=

Review URL: https://codereview.chromium.org/1921823002 .
 2016-04-25 12:35:03 -07:00
Terry Lucas 8f7b8a9d87 Update to new Webkit additions for custom elements 
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1914643002 .
 2016-04-22 12:53:36 -07:00
Jacob Richman 7fdce7a2f0 Use _downcast and _cast instead of "as" to reduce dart2js output size. 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1914583002 .
 2016-04-22 11:09:01 -07:00
Jacob Richman 819ed4bb60 Fix strong mode errors in SVG 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903893003 .
 2016-04-21 12:45:08 -07:00
Jacob Richman 25b88eabe5 Fix indexed_db strong mode warnings. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903973002 .
 2016-04-21 10:03:53 -07:00
Jacob Richman 9ffe1c2450 Make querySelectorAll a generic method so that checked mode behavior is consistent with existing behavior and strong mode behavior is strong for the case of List<InputElement> elems = document.querySelector("input"); 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1904903003 .
 2016-04-21 09:54:18 -07:00
Jacob Richman 777e1a386e Revert "Remove the generics from _FrozenElementList: causes checked mode failures" 
This reverts commit 7824ac771b.

BUG=

Review URL: https://codereview.chromium.org/1909613003 .
 2016-04-20 18:50:11 -07:00
Jacob Richman b546d05362 TBR. Add back fix to the misleading types for onError. Otherwise, html/worker_test/functional fails due to the browser itself throwing an event of type Error that is not an ErrorEvent. 
BUG=

Review URL: https://codereview.chromium.org/1908603002 .
 2016-04-20 10:41:56 -07:00
Jacob Richman 068252e721 Revert changes to event signatures as they broke one co19 test and this change isn't required due to relaxation in types in EventStreamProvider.dart 
BUG=

Review URL: https://codereview.chromium.org/1903033002 .
 2016-04-19 16:42:16 -07:00
Jacob Richman 864b64fd5e Strong html 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
 2016-04-19 15:08:45 -07:00
Alan Knight 810faa31b9 Don't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D) 
BUG=

Review URL: https://codereview.chromium.org/1885943002 .
 2016-04-16 16:26:14 -07:00
Alan Knight 7824ac771b Remove the generics from _FrozenElementList: causes checked mode failures 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1891543005 .
 2016-04-14 15:14:40 -07:00
Terry Lucas 74ddf84ffd Remove MutationEvent bad entries in both removed list and renamed list 
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1890983002 .
 2016-04-14 13:49:42 -07:00
Alan Knight 48d73a66e0 Fix MutationEvent class name 
BUG=

Review URL: https://codereview.chromium.org/1888693004 .
 2016-04-14 09:56:07 -07:00
Alan Knight a718c8dac9 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Committed: 65fe0a5383

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 15:13:31 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html" 
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
 2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 14:41:10 -07:00
Jacob Richman 08c171d3e5 Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects."" 
Fix missing case that was breaking co19 tests.
This reverts commit 688eeb555c.

BUG=

Review URL: https://codereview.chromium.org/1883513004 .
 2016-04-12 17:16:06 -07:00
Jacob Richman 688eeb555c Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects." 
This reverts commit f382890e1a.
Reverting while tests are fixed.

BUG=

Review URL: https://codereview.chromium.org/1879093002 .
 2016-04-12 11:28:05 -07:00
Jacob Richman f382890e1a Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1873933002 .
 2016-04-12 10:23:32 -07:00
Jacob Richman 1536c671f5 Add support for switching library from the chrome devtools console. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1865803004 .
 2016-04-07 11:14:47 -07:00
Terry Lucas c95b9875ef Fix registerElement for HTMLElement prototype should not change it's m_type 
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1857343002 .
 2016-04-05 11:59:28 -07:00
Alan Knight 0f5c249f22 Fix webgl methods, properly this time 
BUG=

Review URL: https://codereview.chromium.org/1846803002 .
 2016-03-31 09:45:32 -07:00
Jacob Richman 3cb280c5e1 Fast path Location.hash as some apps call it 10000+ times a frame. 
BUG=

Review URL: https://codereview.chromium.org/1847543003 .
 2016-03-31 09:04:10 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X. 
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
 2016-03-29 18:32:52 -07:00
Terry Lucas 10e70db01c Speed up interop patch file creation. 
Made a number of optimizations to reduce load time from 8 secs to 1 sec.  The changes involved:

- No longer dynamically generate patch files on startup for dart:* libraries (created from WebKits IDL e.g., html, svg, web_audio, web_gl, indexed_db, web_sql).  Instead create a cache of patch files.

- Comparison of @JS refelctedType not by library and symbol name comparison.

- In addition, a VM mirror change see CL https://codereview.chromium.org/1834673003/ gives us the remaining speedup.

This cache of interop patch files, for Dartium only, requires a manual re-gen after go.sh run is:

> cd tools/dom/scripts
> run go.sh

The steps after (for Dartium) are:

1.  build Dartium
2.  cd tools/dartium
3.  run generate_patches.sh
4.  build Dartium

R=jacobr@google.com, alanknight@google.com

Review URL: https://codereview.chromium.org/1833373002 .
 2016-03-28 08:20:13 -07:00
Alan Knight ab55f22334 Fix WebGL tex[Sub]Image2D/buffer[Sub]Data, restored Typed/Untyped aliases 
BUG=

Review URL: https://codereview.chromium.org/1831033002 .
 2016-03-24 10:20:11 -07:00
Alan Knight 4fe809c211 Add @creates annotation to VttCue members 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1811213002 .
 2016-03-18 07:35:35 -07:00
Alan Knight 051451d7e6 Trying to fix SQLResultSetRowList's subscript operator to do type conversion 
BUG=

Review URL: https://codereview.chromium.org/1779023002 .
 2016-03-09 14:02:30 -08:00
Alan Knight 1f9395fb30 Add back CssCharsetRule for Safari support 
BUG=

Review URL: https://codereview.chromium.org/1777683002 .
 2016-03-08 14:40:57 -08:00
Terry Lucas af562187bc Chrome moved clipboardData from Event to ClipboardEvent for security clipboard can only be accessed during a onCut/onCopy/onPaste event. 
The polyfill class KeyEvent can no longer access clipboardData without listening for the cut, copy or paste event.

TBR=alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1775923002 .
 2016-03-08 05:24:02 -08:00
Terry Lucas 5d77c0e83c More UIEvent attribute movement in 45 roll. 
TBR=alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1771113002 .
 2016-03-07 16:12:28 -08:00
Terry Lucas 5c3728b067 Fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45 
TBR=jacobr@google.com,alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1754523006 .
 2016-03-07 07:51:50 -08:00
Terry Lucas a552c24089 Match version of idl_parser and WebCore so go.sh can be run from a Dart only enlistment. 
Needed to pull in the tools/idl_parser code for a Dart enlistment populated during a gclient sync.

Added .gitingore to not ignore tools/idl_parse

TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1768853002 .
 2016-03-06 15:10:36 -08:00
Terry Lucas c510dc9831 Fixed typedef used globally in IDLs 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1763063003 .
 2016-03-05 07:34:51 -08:00
Alan Knight 83e2e2dbb2 Change scripts to avoid generating things that bloat the compiled code 
BUG=

Review URL: https://codereview.chromium.org/1763213002 .
 2016-03-04 15:08:48 -08:00
Kasper Lund 96be0c49fb Revert "Change scripts to avoid generating things that bloat the compiled code" 
This reverts commit 4f3abbd5ef.
 2016-03-04 10:06:07 +01:00
Alan Knight 4f3abbd5ef Change scripts to avoid generating things that bloat the compiled code 
BUG=

Review URL: https://codereview.chromium.org/1759303003 .
 2016-03-03 17:39:50 -08:00
Jacob Richman c66635cc9f Basline of dart2js w/ regen'd sdk/libs 
BUG=

Review URL: https://codereview.chromium.org/1762063002 .
 2016-03-03 13:42:10 -08:00
Terry Lucas 4f3b4097fd Fixed dart2js compilation problem 
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1762763002 .
 2016-03-03 11:08:24 -08:00
Terry Lucas 3f0bb621a8 Revert "Changes to tests and status file for the 45 roll w/ regenderated sdk/libs" 
This reverts commit 8d12df1e77.

TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1763753002 .
 2016-03-03 09:41:01 -08:00
Terry Lucas 23d5f671ae Revert "Fixed dart2js compilation and udpate obsolete analyzer for co19" 
This reverts commit 439b59b1fc.

TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1753903005 .
 2016-03-03 09:37:53 -08:00
Terry Lucas 439b59b1fc Fixed dart2js compilation and udpate obsolete analyzer for co19 
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1757293002 .
 2016-03-03 06:23:31 -08:00
Terry Lucas 8d12df1e77 Changes to tests and status file for the 45 roll w/ regenderated sdk/libs 
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1746623002 .
 2016-03-03 05:33:46 -08:00
Terry Lucas d094857c12 Fixed createImageData and added RequestAnimationFrameCallback for compat 
TBR=jacobr@google.com

Committed: b524161f8f

Review URL: https://codereview.chromium.org/1753813005 .
 2016-03-02 13:23:22 -08:00
Terry Lucas e1a33e9981 Moved ChromiumSubscribeUniform to web_gl 
Fixed to return null if dictionary returned form blink is null
Cleanup up logging/error reporting

TBR=alanknight@google.com,jacobr@google.com

Committed: 01f6e4ed0f

Review URL: https://codereview.chromium.org/1752983003 .
 2016-03-02 08:15:45 -08:00
Terry Lucas f22c1f6e83 Revert "test of dart2js w/ regen'd sdk/libs" 
This reverts commit 083280b171.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1747283005 .
 2016-03-02 04:34:19 -08:00
Terry Lucas 083280b171 test of dart2js w/ regen'd sdk/libs 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1756653003 .
 2016-03-02 03:39:14 -08:00
Terry Lucas 6aff6fb1ba Fixed Dictionary emitted as interface and dictionary conversion with a null map 
TBR=alanknight@google.com,jacobr@google.com

Committed: a61bd2f7b2

Review URL: https://codereview.chromium.org/1752153002 .
 2016-03-01 15:55:13 -08:00
Terry Lucas d2e1a2ce3c client* no longer handle manipulated the properties are back to ints 
TBR=alanknight@google.com,jacobr@google.com

Committed: 637ed1e3e1

Review URL: https://codereview.chromium.org/1754593004 .
 2016-03-01 04:50:40 -08:00
Terry Lucas 8cb5ef741f Fix more things with webgl so it works 
- dart.idl emitted currently supported operations in Chrome 45 so there were 9 duplicates.
- Support mapping a bunch of webgl types to Dart types.

TBR=jacobr@google.com,alanknight@google.com

Committed: 3a6e6cafea

Review URL: https://codereview.chromium.org/1748383002 .
 2016-03-01 03:34:19 -08:00
Terry Lucas 81d0e0f94f Revert "Test sdk/lib regen for dart2js" 
This reverts commit 733c996535.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1750283002 .
 2016-02-29 23:49:58 -08:00
Terry Lucas 733c996535 Test sdk/lib regen for dart2js 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1755523002 .
 2016-02-29 23:37:21 -08:00
Terry Lucas c7c12c7756 Migrated changed for sdk/lib genernation from integration branch to master. 
-  client* not properly exposed.
  -  Expose createImageDataFromImageData for backward compat
  -  Chrome now allow typedefs defined in and IDL to be used and other IDL files (even though the IDL has no include).

TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1744093002 .
 2016-02-28 11:59:20 -08:00
Terry Lucas e4b800845b Fixed more sdk/lib issues 
- SpeechRecognition calling blink constructor needs name prefixed with WebKit
  - Enumerator types as arguments must be String (all enums in IDL are string values).
  - Removed methods in IDBStorage that caused overloaded operations.

TBR=alanknight@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org/1744613003 .
 2016-02-27 10:44:45 -08:00
Terry Lucas 6dce8ce573 Needed to handling calling static attributes/operations in blink 
TBR=alanknigt@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1738913003 .
 2016-02-25 13:40:07 -08:00
Terry Lucas 2a20f47782 Add MessageEvent.data template for dart2js, remove duplicate claims on ClipboardEvent and PointerEvent 
BUG=

Review URL: https://codereview.chromium.org/1725083002 .
 2016-02-24 07:51:50 -08:00
Terry Lucas 0aad46c4c6 Fixed handle of multi-inheritance 
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1727233003 .
 2016-02-24 06:55:08 -08:00
Alan Knight 78b0f6f353 Replace the now missing ContextAttributes with our previously Firefox-only _TypedContextAttributes 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1727003002 .
 2016-02-23 16:33:31 -08:00
Alan Knight cc142b92a4 Treat Element.clientTop/Left/etc same as scrollTop/etc., avoid duplicate members 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1726173002 .
 2016-02-23 16:29:40 -08:00
Alan Knight ce744f6222 Some dart2js fixes with new IDL. RequestCallback name and web_sql import 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1729813002 .
 2016-02-23 16:27:59 -08:00
Alan Knight 14b2dfd8dd Add wrap/unwrap_jso calls in native_DOMImplementation, remove unused _DOMStringMap 
BUG=

Review URL: https://codereview.chromium.org/1724853002 .
 2016-02-23 11:21:01 -08:00
Alan Knight e67b4c9161 Fix generator to use SerializedScriptValue for all postMessages 
BUG=

Review URL: https://codereview.chromium.org/1723703002 .
 2016-02-23 09:28:55 -08:00
Terry Lucas 97861e3f22 Fixed a few problems with 45 roll merge 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1720823003 .
 2016-02-22 12:02:43 -08:00
Terry Lucas a3350d9b06 Generation of sdk/lib files from 45 roll 
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1720743005 .
 2016-02-22 10:59:12 -08:00
William Hesse 2573093c50 Switch to downloaded SDK executable, drop executables in testing/bin. 
BUG=https://github.com/dart-lang/sdk/issues/24311
R=ricow@google.com

Review URL: https://codereview.chromium.org/1697203002 .
 2016-02-15 17:10:59 +01:00