languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 03:36:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better type for _match argument in AttributeMatch

Browse source 
This fixes two warnings in analyze_api_test:

R=jacobr@google.com

sdk/lib/html/dart2js/html_dart2js.dart:41478:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == null;
                              ^^^^^^^^^^^^^^^^^^
sdk/lib/html/dart2js/html_dart2js.dart:41514:31:
Warning: The getter '_namespaceUri' is not defined for the class 'Node'.
  bool _matches(Node node) => node._namespaceUri == _namespace;
                              ^^^^^^^^^^^^^^^^^^
Review-Url: https://codereview.chromium.org/2875183002 .
This commit is contained in:
Stephen Adams 2017-05-11 16:59:16 -07:00
parent db331244d0
commit 91f9ce3f71
3 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sdk/lib/html/dart2js/html_dart2js.dart
View file

@ -41453,7 +41453,7 @@ abstract class _AttributeMap implements Map<String, String> {
/**
* Checks to see if the node should be included in this map.
*/
bool _matches(Node node);
bool _matches(_Attr node);
}
/**
@ -41487,7 +41487,7 @@ class _ElementAttributeMap extends _AttributeMap {
return keys.length;
}
bool _matches(Node node) => node._namespaceUri == null;
bool _matches(_Attr node) => node._namespaceUri == null;
}
/**
@ -41523,7 +41523,7 @@ class _NamespacedAttributeMap extends _AttributeMap {
return keys.length;
}
bool _matches(Node node) => node._namespaceUri == _namespace;
bool _matches(_Attr node) => node._namespaceUri == _namespace;
}
/**

10
sdk/lib/html/dartium/html_dartium.dart
View file

@ -41262,11 +41262,11 @@ class Url extends DartHtmlDomObject implements UrlUtils {
return _blink.BlinkURL.instance
.createObjectURL_Callback_1_(blob_OR_source_OR_stream);
}
if ((blob_OR_source_OR_stream is MediaStream)) {
if ((blob_OR_source_OR_stream is MediaSource)) {
return _blink.BlinkURL.instance
.createObjectURL_Callback_1_(blob_OR_source_OR_stream);
}
if ((blob_OR_source_OR_stream is MediaSource)) {
if ((blob_OR_source_OR_stream is MediaStream)) {
return _blink.BlinkURL.instance
.createObjectURL_Callback_1_(blob_OR_source_OR_stream);
}
@ -47774,7 +47774,7 @@ abstract class _AttributeMap implements Map<String, String> {
/**
* Checks to see if the node should be included in this map.
*/
bool _matches(Node node);
bool _matches(_Attr node);
}
/**
@ -47808,7 +47808,7 @@ class _ElementAttributeMap extends _AttributeMap {
return keys.length;
}
bool _matches(Node node) => node._namespaceUri == null;
bool _matches(_Attr node) => node._namespaceUri == null;
}
/**
@ -47844,7 +47844,7 @@ class _NamespacedAttributeMap extends _AttributeMap {
return keys.length;
}
bool _matches(Node node) => node._namespaceUri == _namespace;
bool _matches(_Attr node) => node._namespaceUri == _namespace;
}
/**

6
tools/dom/src/AttributeMap.dart
View file

@ -85,7 +85,7 @@ abstract class _AttributeMap implements Map<String, String> {
/**
* Checks to see if the node should be included in this map.
*/
bool _matches(Node node);
bool _matches(_Attr node);
}
/**
@ -119,7 +119,7 @@ class _ElementAttributeMap extends _AttributeMap {
return keys.length;
}
bool _matches(Node node) => node._namespaceUri == null;
bool _matches(_Attr node) => node._namespaceUri == null;
}
/**
@ -155,7 +155,7 @@ class _NamespacedAttributeMap extends _AttributeMap {
return keys.length;
}
bool _matches(Node node) => node._namespaceUri == _namespace;
bool _matches(_Attr node) => node._namespaceUri == _namespace;
}
/**