languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-04 16:03:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update to new Webkit additions for custom elements

Browse source 
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1914643002 .
This commit is contained in:
Terry Lucas 2016-04-22 12:53:36 -07:00
parent 7fdce7a2f0
commit 8f7b8a9d87
6 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
sdk/lib/_blink/dartium/_blink_dartium.dart
View file

@ -23281,6 +23281,7 @@ class Blink_Utils {
static defineInterceptorCustomElement(jsObject, Type type) native "Utils_defineInterceptorCustomElement";
static defineInterceptor(jsObject, Type type) native "Utils_defineInterceptor";
static setInstanceInterceptor(o, Type type, {bool customElement: false}) native "Utils_setInstanceInterceptor";
static setInstanceInterceptorCustomUpgrade(o) native "Utils_setInstanceInterceptorCustomUpgrade";
// This method will throw if the element isn't actually a real Element.
static initializeCustomElement(element) native "Utils_initializeCustomElement";

4
sdk/lib/html/dartium/html_dartium.dart
View file

@ -20146,6 +20146,10 @@ class HtmlDocument extends Document {
js.JsNative.setProperty(elemProto, 'createdCallback', js.allowInteropCaptureThis(($this) {
// The created callback has already been called by the very act of passing a JS
// custom element from JS to Dart.
// Make element's interceptor a CustomElementClass.
_blink.Blink_Utils.setInstanceInterceptorCustomUpgrade($this);
if (oldCreatedCallback != null)
oldCreatedCallback.apply([], thisArg: $this);
}));

2
tests/co19/co19-dartium.status
View file

@ -1364,8 +1364,6 @@ LayoutTests/fast/dom/createElementNS_t01: RuntimeError # Issue 26134
LayoutTests/fast/dom/HTMLTemplateElement/cycles-in-shadow_t01: RuntimeError # Issue 26134
LayoutTests/fast/dom/HTMLTemplateElement/cycles_t01: RuntimeError # Issue 26134
LayoutTests/fast/dom/computed-style-set-property_t01: RuntimeError # Issue 26134
LayoutTests/fast/dom/custom/element-type_t01: RuntimeError # Issue 26134
LayoutTests/fast/dom/custom/element-upgrade_t01: RuntimeError # Issue 26134
LayoutTests/fast/dom/custom/document-register-type-extensions_t01: RuntimeError # Issue 26134
LayoutTests/fast/dom/custom/document-register-namespace_t01: RuntimeError # Issue 26134
LayoutTests/fast/dom/DOMException/prototype-object_t01: RuntimeError # Issue 26134

2
tools/deps/dartium.deps/DEPS
View file

@ -9,7 +9,7 @@ execfile(os.path.join(path, 'src', 'dart', 'tools', 'deps', 'dartium.deps', 'DEP
vars.update({
"dartium_chromium_commit": "c2d1ddba7a86ce11a8dcb77a4ac101872d6110bd",
"dartium_webkit_commit": "a0bee58b8a55333175dad90e31a9becd3f4447de",
"dartium_webkit_commit": "c1840828d0445beb8c0482f92cd6bec830813c1e",
"chromium_base_revision": "338390",
# We use mirrors of all github repos to guarantee reproducibility and

1
tools/dom/scripts/generate_blink_file.py
View file

@ -133,6 +133,7 @@ class Blink_Utils {
static defineInterceptorCustomElement(jsObject, Type type) native "Utils_defineInterceptorCustomElement";
static defineInterceptor(jsObject, Type type) native "Utils_defineInterceptor";
static setInstanceInterceptor(o, Type type, {bool customElement: false}) native "Utils_setInstanceInterceptor";
static setInstanceInterceptorCustomUpgrade(o) native "Utils_setInstanceInterceptorCustomUpgrade";
// This method will throw if the element isn't actually a real Element.
static initializeCustomElement(element) native "Utils_initializeCustomElement";

4
tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
View file

@ -380,6 +380,10 @@ $else
js.JsNative.setProperty(elemProto, 'createdCallback', js.allowInteropCaptureThis(($this) {
// The created callback has already been called by the very act of passing a JS
// custom element from JS to Dart.
// Make element's interceptor a CustomElementClass.
_blink.Blink_Utils.setInstanceInterceptorCustomUpgrade($this);
if (oldCreatedCallback != null)
oldCreatedCallback.apply([], thisArg: $this);
}));