Summary:
This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself.
The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior.
BUG: 307747
Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen.
{F3787651}
Test Plan:
1. Drag a folder.
2. Drop it onto itself.
Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure
Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure
Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D6281
Summary:
Two clicks renaming doesn't check if the user is actually allowed to rename a file/folder. With this patch, this get fixed.
Depends on D7647
Reviewers: rkflx, #dolphin, ngraham
Reviewed By: #dolphin, ngraham
Subscribers: elvisangelaccio, ngraham, #dolphin
Differential Revision: https://phabricator.kde.org/D8740
Summary:
This patch gives the status bar a little more vertical whitespace, prevents the status bar from "jumping up and down" when showing a progress bar, and adds a bit of padding on the sides so the labels are more clearly separated when using dual panes.
Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio
Differential Revision: https://phabricator.kde.org/D8540
Summary:
FEATURE: 269332
Make Dolphin's Saved Search feature discoverable by adding a button inside the search field. The button only becomes enabled when there is a valid search term. When pushed, it saves the search to the Places panel, providing a visible-by-default way to do this to complement the existing implementation that is only visible in the context menu.
Also harmonized the label text so that it's consistent no matter how you create a saved search (button or context menu)
Test Plan:
Tested in KDE Neon. Works great:
{F5449508}
Reviewers: #dolphin, broulik, dfaure, markg, emateli, elvisangelaccio
Reviewed By: #dolphin, markg, emateli, elvisangelaccio
Subscribers: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D8454
Summary:
Make renaming of files/folders faster by clicking a second time on the items text to start renaming.
BUG: 205157
Test Plan:
This feature works as follows:
1. select an item by single-click, or one is already selected
2. wait the "double-click-interval"
3. click on the items text
4. none of the cancellations (see below) happens within the double-click-interval
5. inline-renaming starts
Cancellations:
* open any file/folder
* select different item(s)
* start dragging items
* Dolphin loses focus
This feature is just enabled while "Double-click to open files and folders" in system-settings and "Rename inline" in Dolphin are enabled.
Reviewers: #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
Reviewed By: #dolphin, #kde_applications, elvisangelaccio, ngraham, rkflx
Subscribers: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
Differential Revision: https://phabricator.kde.org/D7647
When unmounting a removable media Dolphin checks if there are
some files open on the device before performing the unmount.
If the terminal window in dolphin is open and the to be unmounted path is open,
the unmount process will be blocked.
This patch sets the terminal window current path to the home directory upon unmount request
if the terminal directory is set to the mount path.
The unmount request could came from two sources:
The user could hit right click on the media in the dolphin's places panel and hit unmount.
The user could request an unmount from the indicator applet
This patch was originally written by Arjun AK for the kdelibs4 version
of Dolphin: https://git.reviewboard.kde.org/r/121613/
BUG: 158264
FIXED-IN: 17.11.80
Differential Revision: https://phabricator.kde.org/D7847
Summary:
Move Folders item closer to the top in Dolphin's find panel. This seems like a more natural placment than after the document types.
Also re-order variable placement to maintain consistency
Test Plan:
Tested in KDE Neon; works. Before:
{F4631565}
After:
{F4631532}
Reviewers: #dolphin, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D8132
This commit adds an option under "More options" at the search widget.
It allows to only search for folders and filter out everything else,
just like the other options (e.g. "Videos") above.
FEATURE: 269334
REVIEW: 130159
Summary: QStaticText's constructor with const QString & as argument is now explicit.
Test Plan:
Did not build before, now does.
Note that this might change the behaviour as the other properties of m_text are now
kept, which was not the case before. I'm not sure what the expected behaviour here
is supposed to be.
Reviewers: #dolphin, #kde_applications, cfeck
Reviewed By: cfeck
Subscribers: cfeck, #kde_applications, #dolphin
Differential Revision: https://phabricator.kde.org/D8075
Summary:
Adds Bitrate to Dolphin's Additional information columns.
BUG: 368418
Test Plan:
Tested in KDE Neon. A bitrate column can be added and shows the bitrate in kb/s:
{F3907210}
Works for audio as well as video files!
Reviewers: #dolphin, #kde_applications, broulik, aacid, dfaure, emmanuelp
Reviewed By: #dolphin, #kde_applications, emmanuelp
Subscribers: rkflx, alexeymin, anthonyfieroni
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D7763
Whenever the dolphin view is initialized to show the contents of a new URL
(e.g. "/home/x/test") it will be checked if the new URL is a parent of the
previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is
successful, then the common child (in this example: "/home/x/test/documents/")
folder item will be selected and scrolled into view.
REVIEW: 123253
BUG: 377392
CCBUG: 335616
When renaming a file, if its new name causes it to scroll out of view,
Dolphin will not scroll to the location of the new file.
This patch aims to address that. This affects all view modes.
CCBUG: 354330
Test Plan:
1. Have many files in a directory (or several files, just zoom in a lot)
2. Rename a file so that it will move out of view
Differential Revision: https://phabricator.kde.org/D6312
After commit 68bb0ec22a the shortcut for the Delete action is not
necessarily Shift+Del, but whatever the user set in System Setting.
However DolphinRemoveAction assumes/hardcodes Shift+Del, so we should
always make sure we have this shortcut around, for consistency.
We just need to add it (if necessary) to the list of shortcuts of the
action. However:
* for the actual Delete action, we need to append it (if we'd prepend it,
it would override a custom primary shortcut in the 'Configure Shortcuts' dialog).
* for DolphinRemoveAction, we need to prepend it in order to have
Shift+Del (rather than the custom primary shortcut) in the context menu.
Differential Revision: https://phabricator.kde.org/D7655
Summary:
BUG: 384352
Add an "Open in New Window" menu item to the context menu for Dolphin's places items.
Test Plan:
Tested in up-to-date KDE Neon. Works as expected:
{F3898707}
Reviewers: #dolphin, #kde_applications, dfaure, aacid, elvisangelaccio, emmanuelp, broulik
Reviewed By: #dolphin, emmanuelp, broulik
Subscribers: alexeymin, emmanuelp, broulik, sefaeyeoglu, #dolphin
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D7690
QGuiApplication::queryKeyboardModifiers() does not work on Wayland [1].
We don't need it in the first place, since we already know (thanks to
the key events) whether Shift has been pressed or released.
So we can just pass this information to DolphinRemoveAction::update().
BUG: 354301
[1]: https://bugreports.qt.io/browse/QTBUG-62786
Differential Revision: https://phabricator.kde.org/D7519
Summary:
Added the option to limit the displayed folders in the folder panel (F7) to the tree below the user's home directory if the current URL is inside the home directory.
This can be configured in the preferences General/Behaviour tab by checking the corresponding check box.
Reviewers: #dolphin, elvisangelaccio, emmanuelp
Reviewed By: #dolphin, elvisangelaccio, emmanuelp
Subscribers: emmanuelp, elvisangelaccio, #konqueror, #dolphin
Differential Revision: https://phabricator.kde.org/D7477
When inside a place, the address bar already gives it precedence over the actual folder name.
By doing this in the title bar also, we make it consistent and can mask ugly technical terminology
like "trash:/" and instead show the nice localized "Trash" place name as well as "Home" instead
of lowercase internal user name.
BUG: 211959
Differential Revision: https://phabricator.kde.org/D4826
Summary: I have just imitated the code that made this funcionality for artist and album additional information for audio files.
Reviewed By: #dolphin, emmanuelp
CCBUG: 374558
Differential Revision: https://phabricator.kde.org/D7215
You cannot do this from the menu but the option was there (but ignored) in the "View Properties" dialog.
BUG: 302622
Differential Revision: https://phabricator.kde.org/D7386
This comment (introduced in commit 39f89141b0) no longer seems to
apply, so drop the duplicate translations and just use the default
strings from kconfigwidgets.
Differential Revision: https://phabricator.kde.org/D6779
It was introduced in kconfig(widgets) 5.25. Using the standard action
results in less code and no need to hardcode the F2 shortcut.
Differential Revision: https://phabricator.kde.org/D6777
It was introduced in kconfig(widgets) 5.25. Using the standard action
results in less code and no need to hardcode the Del shortcut.
Test Plan:
- Change shortcut in System Settings -> Shortcuts -> Standard Shortcuts
- Make sure the new shortcut is used by dolphin.
Differential Revision: https://phabricator.kde.org/D6778
