kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-20 00:41:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
3245 commits 140 branches 325 tags 158 MiB
Commit graph

3245 commits

This branch
This branch
All branches
Author SHA1 Message Date
Peter Penz 4a9561e6b7 Fix regression that creating a sub-folder is not possible 
CCBUG: 265714
 2011-02-09 21:15:55 +01:00
Peter Penz d3496b1231 Coding style update for pointer comparison 
Most developers seem to prefer
  if (ptr) ...
  if (!ptr) ...
in comparison to
  if (ptr != 0) ...
  if (ptr == 0) ...

Adjusted the Dolphin-code to use the "most-prefered style" to make contributors happy.
 2011-02-09 19:24:27 +01:00
Peter Penz ceba0f6f6a Use capitalized includes of recently committed kdelibs headers 2011-02-09 18:42:04 +01:00
Aaron Reichman 6af0a792a2 Fixing krazy spelling errors 2011-02-07 12:58:14 -08:00
David Faure 3250510ba2 Add support for KAbstractFileItemActionPlugin. Requires kdelibs > 4.6.0. 
(cherry picked from commit 4caa285c06)
 2011-02-07 13:13:02 +01:00
Peter Penz 0b925e0231 Fix issue that filenamesearch: is used instead of nepmuksearch: 2011-02-06 13:44:30 +01:00
Peter Penz 27456a2f73 Provide a hook for externally triggered search queries 
In this case the "From Here"/"Everywhere" buttons and the "Filename"/"Content" buttons are useless. Currently they just get disabled but the plan is to provide a better visual indication of the current query and to remove them completely.
 2011-02-05 23:33:08 +01:00
Peter Penz 0a9cdfa4ed Fix compilation when Nepomuk is not available 
CCBUG: 265547
 2011-02-05 21:12:19 +01:00
Andreas Hartmetz c1e805adf6 dolphinsearchboxtest: link with gold 2011-02-05 06:19:02 +01:00
Peter Penz 17d217b862 Add unittest for DolphinSearchBox 
A minor API cleanup in DolphinSearchBox has been done related to the test.
 2011-02-04 22:13:50 +01:00
Peter Penz 236eac2ffa Don't clear the search-text when switching between tabs 
The clearing of the search-text should only be done when opening the search-box.
 2011-02-04 20:55:52 +01:00
Peter Penz fd74aa8e20 Update e-mail address from peter.penz@gmx.at to peter.penz19@gmail.com 2011-02-04 15:57:33 +01:00
Peter Penz 956ebf7115 Don't use the submodule-path for Qt-includes on application-level 
Also some KDE-includes have been capitalized
 2011-02-04 15:49:45 +01:00
Peter Penz 8eb9b508ca Use capitalized KDE includes 2011-02-04 15:43:21 +01:00
Peter Penz b184340286 Use KUrl::isParentOf() instead of doing custom QString-operations 
This fixes the issue that a directory might be declared as indexed/non-indexed although it just starts with a similar name like another directory.
 2011-02-03 17:23:45 +01:00
Peter Penz 687f40b545 Fix 3 issues reported by "krazy" 2011-02-03 16:51:08 +01:00
Script Kiddy d0ff8aea0b SVN_SILENT made messages (.desktop file) 2011-02-03 07:24:26 +01:00
Peter Penz 7045a25e3a Fix visibility- and enabled-issues for the filter-panel 
The filter-panel should be disabled if the current folder is not indexed at all. Also when triggering a "Find" the filter-panel should stay invisible per default when the current folder is not indexed.

CCBUG: 264969
 2011-02-02 19:36:08 +01:00
Peter Penz 28f00f36d7 Provide a default size-hint for all panels 
This fixes the issue that the initial size of the Filter Panel is too small.
 2011-02-02 17:30:25 +01:00
Script Kiddy 0981134987 SVN_SILENT made messages (.desktop file) 2011-02-02 08:24:54 +01:00
Peter Penz 4d2e4979c5 Show the pointing-hand cursor also when the selection-toggle is disabled 
CCBUG: 264791
 2011-01-31 22:35:14 +01:00
Peter Penz 6a8dde1793 Don't show the pointing-hand cursor when double-click is enabled 
CCBUG: 264796
 2011-01-31 21:29:10 +01:00
Peter Penz f491c6ff9b Updated copyright information 2011-01-30 18:49:38 +01:00
Sebastian Doerner aef40807d1 Fix crash when detaching a tab with "Split View Mode" setting enabled 
svn path=/trunk/KDE/kdebase/apps/; revision=1217560
 2011-01-27 21:30:45 +00:00
Frank Reininghaus a2ac570198 Some additions to DolphinDetailsViewTest_AllViewModes. 
In particular, tests for changing the zoom level and for saving and
restoring the view state.

svn path=/trunk/KDE/kdebase/apps/; revision=1217270
 2011-01-26 13:38:19 +00:00
Frank Reininghaus 72fb2ca0a8 Make dolphinviewtest_columns more stable. 
Up to now, some Columns View tests that need a folder to be displayed
in the view only passed if they were run first: The first test always
passed, and if a test name was passed on the command line, such that
only this test would be run, this test would work as well. In other
cases, the view was empty, not showing the items in the folder.

The problem is worked around by creating a new DolphinView before each
test in the case of the Columns View. Added a TODO comment to make me
remember to look into this again at some point.

svn path=/trunk/KDE/kdebase/apps/; revision=1217260
 2011-01-26 13:20:36 +00:00
Frank Reininghaus e85b2ef0ad Improve DolphinViewTest_AllViewModes::testKeyboardFocus(). 
The test assumes that the view does not have the keyboard focus
initially. However, this may not be the case if this is the only test
to be executed (i.e., if testKeyboardFocus is passed to the test
executable on the command line). This commit transfers the keyboard
focus explicitly to another widget.

svn path=/trunk/KDE/kdebase/apps/; revision=1217251
 2011-01-26 13:12:49 +00:00
Peter Penz 20664d8b72 Prevent that the view is forced to increase its width when the searching is enabled and not enough width is available for all options. 
svn path=/trunk/KDE/kdebase/apps/; revision=1216467
 2011-01-23 15:03:52 +00:00
Frank Reininghaus 8653fc7f87 Add a unit test that checks the DolphinView functionality that is 
related to the folder view properties.

svn path=/trunk/KDE/kdebase/apps/; revision=1216359
 2011-01-22 20:39:20 +00:00
Peter Penz 51a4c273a0 SVN_SILENT: Coding style updates 
svn path=/trunk/KDE/kdebase/apps/; revision=1216293
 2011-01-22 14:08:11 +00:00
Peter Penz c9f9132555 Stay consistent with the non-indexed searching and also return folders as search-result when searching in indexed folders. 
CCBUG: 263724

svn path=/trunk/KDE/kdebase/apps/; revision=1215987
 2011-01-20 16:55:53 +00:00
Script Kiddy 57af78b411 SVN_SILENT made messages (.desktop file) 
svn path=/trunk/KDE/kdebase/apps/; revision=1215655
 2011-01-19 06:32:58 +00:00
Peter Penz c341810400 Assure that a sorting by the Dolphin specific columns "Path" and "Link Destination" works correctly. 
svn path=/trunk/KDE/kdebase/apps/; revision=1215483
 2011-01-18 21:38:10 +00:00
Peter Penz 2fa1dce977 Assure that the enabled plugins for previews are set for the Information Panel and the tooltips. This fixes the issue that a disabled thumbnail-plugin might be chosen. For 4.7 it should be considered to move this code into KIO::filePreview() as default already (will provide a patch on the reviewboard). 
svn path=/trunk/KDE/kdebase/apps/; revision=1215459
 2011-01-18 19:56:18 +00:00
Peter Penz 4dd1ed179d Fix issue that the "From Here" search restriction does not work on subfolders when Nepomuk/Strigi has been activated. 
CCBUG: 262274


svn path=/trunk/KDE/kdebase/apps/; revision=1215428
 2011-01-18 18:27:49 +00:00
Frank Reininghaus 519c2d435f Improve DolphinTreeViewTest's stability. 
When running the test in the background while using the computer for
other things, it may happen that the test's widgets are not focused,
which led to an infinite loop before this commit. I've removed the
checks that caused this loop because the only thing that is important
for the test is that the view loses the keyboard focus at some point
(see bug 220898).

svn path=/trunk/KDE/kdebase/apps/; revision=1215139
 2011-01-17 19:36:00 +00:00
Peter Penz 75a6e8fb2a Fix regression introduced by SVN commit 1214916: The navigator should get the focus when "Replace Location" is invoked. 
CCMAIL: sebastian@sebastian-doerner.de

svn path=/trunk/KDE/kdebase/apps/; revision=1215110
 2011-01-17 17:39:36 +00:00
Peter Penz 4d3e52e92e Don't assure the visibility of the leaf, if another directory has been opened by the [+]-toggle. 
CCBUG: 263344

svn path=/trunk/KDE/kdebase/apps/; revision=1214979
 2011-01-17 06:46:33 +00:00
Sebastian Doerner fdcba0c01e Make toggleSplitView()'s documentation consistent with its behavior 
svn path=/trunk/KDE/kdebase/apps/; revision=1214927
 2011-01-16 22:05:54 +00:00
Sebastian Doerner f5f6c89c3f Simplify DolphinMainWindow::replaceLocation() 
svn path=/trunk/KDE/kdebase/apps/; revision=1214916
 2011-01-16 21:18:18 +00:00
Peter Penz 38719e5dfd Remember all iterated directories to prevent an endless recursion by links. Tested with search all files below / 
svn path=/trunk/KDE/kdebase/apps/; revision=1214895
 2011-01-16 19:51:48 +00:00
Frank Reininghaus e5a0ce83fd DolphinTreeView contains some code to update the selection after a 
keyboard search because QTreeView (unlike the other item views) does
not handle this internally.

This commit simplifies that code by performing the selection update in
the method keyboardSearch(). That way, we can get rid of the member
m_updateCurrentIndex and of 3 member functions. The unit tests still
pass, so I'm quite confident that this does not break anything.

svn path=/trunk/KDE/kdebase/apps/; revision=1214865
 2011-01-16 18:35:36 +00:00
Frank Reininghaus ae59d894c2 DolphinTreeViewTest: Add unit test for bug 220898 (rubberband 
selection failure after a keyboard focus change in between key press
and key release events)

svn path=/trunk/KDE/kdebase/apps/; revision=1214822
 2011-01-16 14:13:30 +00:00
Peter Penz d650a50d10 Assure that no endless searching is done if a link points to a parent directory 
CCBUG: 263262
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1214807
 2011-01-16 12:38:45 +00:00
Frank Reininghaus 732b46e39a Move the call "setUniformRowHeights(true)" from DolphinDetailsView's 
constructor to the one of its base class DolphinTreeView. The reason
is that DolphinTreeView::updateElasticBandSelection() contains
"Q_ASSERT(uniformRowHeights())", so it makes sense to ensure that
every DolphinTreeView has uniform row heights. This might be important
for unit tests which use DolphinTreeView directly.

svn path=/trunk/KDE/kdebase/apps/; revision=1214695
 2011-01-15 23:08:23 +00:00
Frank Reininghaus aefa8ce888 DolphinTreeViewTest: Add unit test for bug 259656 (multiple file 
deletion if Shift+Delete is pressed for some time and the confirmation
dialog is disabled).

svn path=/trunk/KDE/kdebase/apps/; revision=1214651
 2011-01-15 19:12:37 +00:00
Peter Penz 1b30368506 If the searching has been triggered by clicking on a facet and the facet gets reset again, assure that not all indexed files are shown. Instead return to the previous state before the searching has been started. 
svn path=/trunk/KDE/kdebase/apps/; revision=1214634
 2011-01-15 17:52:00 +00:00
Frank Reininghaus 8ac62cc953 Improve tests for DolphinTreeView's code that updates the selection 
when a key is pressed.

svn path=/trunk/KDE/kdebase/apps/; revision=1214565
 2011-01-15 11:43:59 +00:00
Peter Penz ce27e1a48d Move the FileMetaDataConfigurationDialog from "settings" to "panels/information", as it is not used anymore for the tooltips and only in the information panel. 
svn path=/trunk/KDE/kdebase/apps/; revision=1214480
 2011-01-14 19:55:55 +00:00
Script Kiddy 80d8222edb SVN_SILENT made messages (.desktop file) 
svn path=/trunk/KDE/kdebase/apps/; revision=1213663
 2011-01-11 09:07:40 +00:00