kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-20 00:41:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve DolphinTreeViewTest's stability.

Browse source 
When running the test in the background while using the computer for
other things, it may happen that the test's widgets are not focused,
which led to an infinite loop before this commit. I've removed the
checks that caused this loop because the only thing that is important
for the test is that the view loses the keyboard focus at some point
(see bug 220898).

svn path=/trunk/KDE/kdebase/apps/; revision=1215139
This commit is contained in:
Frank Reininghaus 2011-01-17 19:36:00 +00:00
parent 75a6e8fb2a
commit 519c2d435f
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/tests/dolphintreeviewtest.cpp
View file

@ -373,10 +373,9 @@ void DolphinTreeViewTest::bug220898_focusOut()
widget.setFocus();
// Wait until the widgets have received the focus events
while (view.viewport()->hasFocus() || !widget.hasFocus()) {
while (view.viewport()->hasFocus()) {
QTest::qWait(10);
}
QVERIFY(widget.hasFocus());
QVERIFY(!view.viewport()->hasFocus());
// Release the "Down" key
@ -387,11 +386,10 @@ void DolphinTreeViewTest::bug220898_focusOut()
view.viewport()->setFocus();
// Wait until the widgets have received the focus events
while (!view.viewport()->hasFocus() || widget.hasFocus()) {
while (widget.hasFocus()) {
QTest::qWait(10);
}
QVERIFY(!widget.hasFocus());
QVERIFY(view.viewport()->hasFocus());
// Press left mouse button below the last item
const int lastRowHeight = view.sizeHintForRow(4);