Commit graph

3098 commits

Author SHA1 Message Date
Frank Reininghaus 8ac62cc953 Improve tests for DolphinTreeView's code that updates the selection
when a key is pressed.

svn path=/trunk/KDE/kdebase/apps/; revision=1214565
2011-01-15 11:43:59 +00:00
Peter Penz ce27e1a48d Move the FileMetaDataConfigurationDialog from "settings" to "panels/information", as it is not used anymore for the tooltips and only in the information panel.
svn path=/trunk/KDE/kdebase/apps/; revision=1214480
2011-01-14 19:55:55 +00:00
Script Kiddy 80d8222edb SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=1213663
2011-01-11 09:07:40 +00:00
Peter Penz ac51281676 Don't trigger a slotDirListerCompleted() when the directory lister has been cancelled. Beside leading to a crash for the unit tests this is semantically wrong.
svn path=/trunk/KDE/kdebase/apps/; revision=1213203
2011-01-09 15:14:29 +00:00
Peter Penz a48679b36b Fix implementation of DolphinView::invertSelection() which assures that DolphinView::hasSelection() provides a valid return-value. This looks like an issue in Qt, but I did not have the time yet to provide a Qt-only example for a bug-report :-(
svn path=/trunk/KDE/kdebase/apps/; revision=1213199
2011-01-09 15:03:30 +00:00
Peter Penz fae8ba471b Encapsulate the creation and handling of the directory lister, the model and proxy model to DolphinView. By this it will be easier later to replace the traditional QAbstractItemViews by any kind of other implementation (e.g. based on QGraphicsView/QML).
svn path=/trunk/KDE/kdebase/apps/; revision=1213189
2011-01-09 13:58:35 +00:00
Peter Penz 58ea012256 Internal simplification: It is not necessary to keep the ViewModeController as member for the view-modes, as the URL is alredy known by the DolphinViewController.
svn path=/trunk/KDE/kdebase/apps/; revision=1213172
2011-01-09 12:28:43 +00:00
Peter Penz b3acdc75c4 Forward port: Fix memory leak in searchDirectory()
CCBUG: 262481


svn path=/trunk/KDE/kdebase/apps/; revision=1212998
2011-01-08 23:48:22 +00:00
Peter Penz eaf7c9ab2b SVN_SILENT: Remove unused method
svn path=/trunk/KDE/kdebase/apps/; revision=1212992
2011-01-08 23:11:34 +00:00
Sebastian Doerner 3b452fee2e SVN_SILENT: Fix typos in doxygen documentation
svn path=/trunk/KDE/kdebase/apps/; revision=1212955
2011-01-08 19:31:41 +00:00
Sebastian Doerner 6866686dd2 Fix sanity check in toggleViews()
svn path=/trunk/KDE/kdebase/apps/; revision=1212950
2011-01-08 19:08:49 +00:00
Peter Penz d257bcb21c Add the "Lock Panels"/"Unlock Panels"-action to the context-menu of the Places Panel.
svn path=/trunk/KDE/kdebase/apps/; revision=1211709
2011-01-04 17:54:58 +00:00
Peter Penz 420b696c7c SVN_SILENT: Use same comment-style as the other unit-tests
svn path=/trunk/KDE/kdebase/apps/; revision=1210710
2011-01-01 20:59:54 +00:00
Peter Penz f8a60e4d85 Add test for the keyboard-focus
svn path=/trunk/KDE/kdebase/apps/; revision=1210707
2011-01-01 20:46:51 +00:00
Peter Penz dfaff684d6 Forward-port: Restore keyboard-focus when changing the view-mode
svn path=/trunk/KDE/kdebase/apps/; revision=1210699
2011-01-01 20:18:43 +00:00
Peter Penz 91b99e9fd3 Increase version to 1.6.9
svn path=/trunk/KDE/kdebase/apps/; revision=1210665
2011-01-01 18:02:34 +00:00
Peter Penz 79a7412107 Forward port: Don't grab the focus if the view did not have the focus already.
CCBUG: 261147
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1210659
2011-01-01 17:54:23 +00:00
Peter Penz a5c75b52fe SVN_SILENT: Don't connect to non-existing signal/slot
svn path=/trunk/KDE/kdebase/apps/; revision=1210426
2010-12-31 11:06:49 +00:00
Peter Penz 9481509325 Lock panels per default and allow to unlock them like in Amarok.
BUG: 229811
FIXED-IN: 4.7.0

svn path=/trunk/KDE/kdebase/apps/; revision=1210424
2010-12-31 10:59:46 +00:00
Peter Penz f7bbe21b5b Fix regression introduced in 4.5 and allow to add the menu actions "Show Information Panel", "Show Folders Panel", "Show Terminal Panel", "Show Places Panel" and "Show Places Panel" to the toolbar like in KDE SC 4.4.
BUG: 250847
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1207728
2010-12-19 12:48:24 +00:00
Peter Penz 342954bb1f Select the whole text in the filterbar and searchbox if the widget has lost the focus and gets focused again by the shortcut (this behavior is consistent to e.g. the behavior in Kate).
CCBUG: 256160

svn path=/trunk/KDE/kdebase/apps/; revision=1207719
2010-12-19 12:03:46 +00:00
Peter Penz 366db15682 Remove the dynamic "Configure Tooltips..." button. The tooltip configuration is context specific anyhow and can be done inside the properties dialog.
svn path=/trunk/KDE/kdebase/apps/; revision=1207031
2010-12-16 16:44:15 +00:00
Peter Penz bf4689bb64 Keeping DolphinDirLister and DolphinModel as DolphinViewContainers members is not needed anymore, as all the handling is encapsulated inside DolphinView in the meantime. The moving of the dirlister- and model-construction will be done after the 4.6 release, as some internal API adjustments are necessary.
svn path=/trunk/KDE/kdebase/apps/; revision=1206754
2010-12-15 18:55:25 +00:00
Peter Penz adde3d4e3c Fix issue that the enabled state of the "Create New..." menu is not updated correctly in the column-view.
BUG: 258534
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1206749
2010-12-15 18:40:08 +00:00
Peter Penz 221059395c Fix issue that 2 files get deleted in the details-view instead of 1 when Shift+DEL is pressed for a longer time (and the confirmation dialog has been turned off).
BUG: 259656
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1206734
2010-12-15 17:10:59 +00:00
Peter Penz 8061c3fb90 If "Use common view properties for all folders" is checked, the optimized view-modes for trash and searching should be replaced by the common view properties too.
BUG: 259894
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1206728
2010-12-15 16:40:32 +00:00
Peter Penz e587aaa9c4 Show an undetermined progress indication within one second after changing an URL.
Update to SVN commit 1205329:
- Fix issue that an undetermined progress is shown when switching between columns of the column-view.
- Fix issue that no undetermined progress is shown when editing the URL directly in the URL navigator

BUG: 234894
BUG: 163004
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1205345
2010-12-10 22:54:37 +00:00
Peter Penz 0da54e5c1b Show an undetermined progress indication within one second after changing an URL.
svn path=/trunk/KDE/kdebase/apps/; revision=1205329
2010-12-10 21:54:53 +00:00
Script Kiddy 934c7bd12f SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=1204063
2010-12-06 06:05:38 +00:00
Frank Reininghaus 28c5cd8336 1. Also use a time out when waiting for the view's selectionChanged signal.
2. Reduce the time out for the finishedPathLoading signal.

svn path=/trunk/KDE/kdebase/apps/; revision=1202815
2010-12-02 11:56:47 +00:00
Script Kiddy 8255466548 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=1202489
2010-12-01 06:10:29 +00:00
Frank Reininghaus 05b6549e25 Use the correct libraries for the test in the CMake file.
svn path=/trunk/KDE/kdebase/apps/; revision=1202160
2010-11-29 21:27:18 +00:00
Frank Reininghaus f45966d9c3 Use kWaitForSignal to wait until the view has finished reloading. I've
also added a timeout such that the tests fail rather than hang if the
file kioslave dies (which happens sometimes according to some test
logs on cdash.org).

svn path=/trunk/KDE/kdebase/apps/; revision=1202159
2010-11-29 21:24:53 +00:00
Frank Reininghaus bdcca2b903 Add a unit test for the basic selection-related functionality of
DolphinView. The main testing code is inside an abstract base
class. Three classes inherit this base class and do the actual testing
in one view mode each.

svn path=/trunk/KDE/kdebase/apps/; revision=1202157
2010-11-29 21:15:35 +00:00
Script Kiddy b84afd8d05 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=1201667
2010-11-28 10:25:26 +00:00
Vishesh Handa c129ec928f Use KFileItem::targetUrl() instead of KFileItem::url().
This fixes previews for Nepomuk Search results.

svn path=/trunk/KDE/kdebase/apps/; revision=1201458
2010-11-27 20:06:44 +00:00
Peter Penz 55a9aa18d2 DragAndDropHelper::isMimeTypeSupported() returns always true in the meantime - remove it
svn path=/trunk/KDE/kdebase/apps/; revision=1201101
2010-11-26 18:51:04 +00:00
Peter Penz c520572f5d Assure that the directory lister gets updated when changing the URL
svn path=/trunk/KDE/kdebase/apps/; revision=1201096
2010-11-26 18:38:33 +00:00
Peter Penz 056bbd061d SVN_SILENT: Don't inline the setter/getters
svn path=/trunk/KDE/kdebase/apps/; revision=1201095
2010-11-26 18:37:37 +00:00
Peter Penz c227e8afe9 Also reconnect signals for the directory lister when changing the view or the URL, as the directory lister might change in the case of the column view (based on a patch from Frank Reininghaus)
svn path=/trunk/KDE/kdebase/apps/; revision=1201082
2010-11-26 17:54:49 +00:00
Peter Penz d63a5c26e2 Don't offer the "Search everywhere" option for non-local URLs.
svn path=/trunk/KDE/kdebase/apps/; revision=1200741
2010-11-25 15:42:15 +00:00
Peter Penz cbbadab33a Assure that the "From Here (...)" button contains always a useful content also for non-local URLs
svn path=/trunk/KDE/kdebase/apps/; revision=1200307
2010-11-24 16:03:10 +00:00
Peter Penz 32764c9696 Allow to search for filenames + textcontent also for non-local files.
svn path=/trunk/KDE/kdebase/apps/; revision=1200303
2010-11-24 15:51:58 +00:00
Frank Reininghaus cd1ced9158 Some minor changes in DolphinDetailsViewTest:
1. Remove unneeded includes
2. Fix typo
3. Add newline at end of file.

svn path=/trunk/KDE/kdebase/apps/; revision=1200027
2010-11-23 17:14:04 +00:00
Sebastian Trueg da32e987a5 Honor the from here/everywhere setting
svn path=/trunk/KDE/kdebase/apps/; revision=1199915
2010-11-23 08:06:22 +00:00
Frank Reininghaus 0fa3148780 Simplify dolphindetailsviewtest by moving code that is shared by all
test to init() and cleanup().

svn path=/trunk/KDE/kdebase/apps/; revision=1199721
2010-11-22 14:10:26 +00:00
Frank Reininghaus 0d63feed1b In the item view constructors, call setFocus() only after
m_extensionsFactory is initialised. This fixes a possible crash in
Konqueror when changing the settings or manipulating tabs.

CCBUG: 240374

svn path=/trunk/KDE/kdebase/apps/; revision=1199276
2010-11-21 12:36:45 +00:00
Friedrich W. H. Kossebau 6b2ee4933c removed: include of unused header
svn path=/trunk/KDE/kdebase/apps/; revision=1199157
2010-11-20 21:32:16 +00:00
Friedrich W. H. Kossebau 452fa54f4e changed: QImageBlitz is no longer used, so do not require and link to it (useful for built on MeeGo)
svn path=/trunk/KDE/kdebase/apps/; revision=1199156
2010-11-20 21:27:36 +00:00
Friedrich W. H. Kossebau e4551e5fe8 removed: include of unused header
svn path=/trunk/KDE/kdebase/apps/; revision=1199153
2010-11-20 21:23:15 +00:00