The configChanged() implementation could unnecessarily schedule a
reload due to a bug in a has-this-config-element-changed comparison,
which would result in icon position losses in scenarios such as
changing the wallpaper or the workspace theme, without having touched
any sorting-related options. Further, OK'ing the config dialog could
undo the unsorted state entered by moving an icon while the dialog
was open; this is now handled by updating the sorting mode combo box
in the dialog after the icon is dropped.
The later relies on a preceding fix in kde-workspace.git to make
Applet::isUserConfiguring() work for containments if Folder View is
used as desktop containment.
- move the title configuration UI to the Location page
- use one combobox + one lineedit
- use an enum instead of comparing strings
- clean up the code
BUG:313940
FIXED-IN:4.11
- int m_filterType -> ProxyModel::FilterType m_filterType
- ProxyModel::filterModeFromInt(int) -> static_cast<ProxyModel::FilterType>(int)
- int -> QVariant<ProxyModel::FilterType> in the config UI
- selectUnselectAll() -> two separate methods; eliminate sender() call
This also fixes filterChanged() and configAccepted() wrt this config key.
Use the actual filter mode value instead of the combobox index which is
error-prone in case the order of the items in the combobox changes.
BUG:317323
FIXED_IN:4.10.2
- int m_filterType -> ProxyModel::FilterType m_filterType
- ProxyModel::filterModeFromInt(int) -> static_cast<ProxyModel::FilterType>(int)
- int -> QVariant<ProxyModel::FilterType> in the config UI
- selectUnselectAll() -> two separate methods; eliminate sender() call
This also fixes filterChanged() and configAccepted() wrt this config key.
Use the actual filter mode value instead of the combobox index which is
error-prone in case the order of the items in the combobox changes.
BUG:317323
FIXED_IN:4.10.2
Both Konqueror and the folderview applet use X11 functions directly so
we need to make sure CMake is finding it. Right now, this works
because Qt4ConfigDependentSettings.cmake that is distributed with KDE
does an indirect find_package. The one in upstream CMake does not, so
it's a ticking time bomb and depends on installation configuration.
* Use networkAvailable() instead of networkStatusChanged()
* Enable the "network not reachable" error message
* Connect to the network status update notification in init()
The ListView object ownership is transferred to Dialog upon creation, so
not deleting the Dialog object in the applet dtor results in a leaked
ListView. However, when the leaked ListView receives a repaint signal on
plasma theme change, the model pointer in that view is already invalid,
which leads to the crash in m_model->rowCount().
BUG:299077
FIXED-IN:4.9.5
Ark's drag'n'drop D-Bus interface needs to be changed: so far, the object
path was always /DndExtract, but this does not work if Ark is being used as
an embedded KPart (in Konqueror or Rekonq, for example), as all tabs will
end up calling QDBusConnection::registerObject() with the same path. Only
the first call will work, and the result is that dragging and dropping from
any tab previewing an archive with Ark will extract from the first archive
being previewed.
To fix that, applications that accept the application/x-kde-dndextract
mimetype should now be adjusted to check the
application/x-kde-ark-dndextract-service and
application/x-kde-ark-dndextract-path ones instead; the former contains the
same service information that used to be passed, while the latter tells
which object path should be talked to.
This is the folderview part of the change, modeled after the changes made to
Dolphin.
CCBUG: 304860
QGraphicsView::underMouse() can fail if the mouseEnterEvent has not been
delivered. E.g. opening a context menu in a folder peek popup and then clicking
the desktop makes subsequent underMouse() calls return false.
This replaces underMouse() with the standard Plasma method based on using the
item's scene coordinates.
BUG:300386
FIXED-IN:4.8.4
1)Use setPreferredSize instead of setMinimumSize
2)Set the size policy to QSizePolicy::Minimum
Also, remove update() from constraintesEvent() as per the docs.
BUG:295531
FIXED-IN:4.8.2
Close all open popups on "Open With" selected to maintain consistency with activating an item in the folder peek popup and in order not to occlude the dialog with the popup
1)Expose the KFileItemActions object in KonqPopupMenu
2)Add a method hideThisAndParentPopup() to hide the open popups without deletion;actually delete the popups only after executing the context menu in order to avoid a crash in contextMenuRequest() after deleting the popups
BUG:240414
FIXED-IN:4.8.2
reviewed by fredrikh
1)Apply the text line count setting in updateListViewState() - removed an incorrect pointer check
2)Relayout the items in the list view on text line count change and recalculate the list view size
This correctly fixes bug 261207, as it allows the user to set the text line count to 1, thus saving vertical space.
BUG:261207
FIXED-IN:4.8.1
1)Keep the folderview panel icon size constant independent of the panel height / width.
2)Update icon size on panel icon size change using KGlobalSettings.
3)Check for m_iconWidget in the panle branch of constraintsEvent() to avoid creating duplicates / ghost entries on constraintEvent().
BUG:244557
FIXED-IN:4.8.1
REVIEW:103915
fix sorting by size
1)If the files have identical size, type or modification time, sort them by name for consistency - this fixes "random" sorting
2)Explicitly handle sorting by size (previously done by size_t->string, resulting in wrong sorting)
3)When sorting by size, put folders on top of the list and sort them by the number of child items
4)Introduce three-level fallback for file name comparison, as done in Dolphin. Thanks goes to Peter Penz
BUG:265774
FIXED-IN:4.8.1
CCMAIL:peter.penz19@gmail.com
REVIEW:103895
When comparing folders wth other file items in ProxyModel::lessThan(), take into account the current sorting order to allow folders to get to the start of the list. Note that the folders are still sorted according to the current sorting order.
CCBUG:180646
REVIEW:103884
